From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA49DC761A6 for ; Tue, 4 Apr 2023 10:36:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A24E6B007B; Tue, 4 Apr 2023 06:36:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 152CB6B007D; Tue, 4 Apr 2023 06:36:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01B65900002; Tue, 4 Apr 2023 06:36:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E3A2D6B007B for ; Tue, 4 Apr 2023 06:36:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BE9D5120900 for ; Tue, 4 Apr 2023 10:36:17 +0000 (UTC) X-FDA: 80643353994.25.ECD2FC1 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf01.hostedemail.com (Postfix) with ESMTP id D243B40019 for ; Tue, 4 Apr 2023 10:36:13 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680604575; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BppM7GftMObA2NSPlHnsHlni92IKzhtfwR96UZGSeZo=; b=WAY9/jb4wqKT3g/25rm1tSyYnob/WqGfVq2mP24Y4l6g+0JM9y51hu+MGQPcTPMEqCmIHH cwBfgQOi5Ric/5pQr1aoTCtL3s1ojczvLr8hhpDR/HPqduLAfRTG8/fRjoliMG4AlksQC8 RUz/g2vSsG3G+8I8jnE3RdaM738qJdw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf01.hostedemail.com: domain of xialonglong1@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=xialonglong1@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680604575; a=rsa-sha256; cv=none; b=1LcQ+UUpGFUBBALH4cLrk/+H88QBA+L4UQrLrZ3IM8mY2zr99qrhjrTiDs5RpwUFE1UAqp ZcqV+7SHTPAcH8DOiEtpPDvhflw6zBlBJNIc3dE9poB5ueQi/Pq3MRU+XG2VtPahWDhLSi QdOwbsMFQRNn5zuiCY6f0VuslPoRk+E= Received: from kwepemm600003.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PrPGG6Ll9zSn8d; Tue, 4 Apr 2023 18:32:22 +0800 (CST) Received: from [10.174.177.229] (10.174.177.229) by kwepemm600003.china.huawei.com (7.193.23.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 4 Apr 2023 18:36:06 +0800 Message-ID: <9cdeeacd-8a64-cf73-7054-fcb58c3705ac@huawei.com> Date: Tue, 4 Apr 2023 18:36:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/2] mm: memory-failure: Refactor add_to_kill() To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= CC: "akpm@linux-foundation.org" , "linmiaohe@huawei.com" , "wangkefeng.wang@huawei.com" , "sunnanyong@huawei.com" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" References: <20230330074501.205092-1-xialonglong1@huawei.com> <20230330074501.205092-2-xialonglong1@huawei.com> <20230331054142.GA1435482@hori.linux.bs1.fc.nec.co.jp> From: xialonglong In-Reply-To: <20230331054142.GA1435482@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.177.229] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600003.china.huawei.com (7.193.23.202) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: D243B40019 X-Stat-Signature: iac489y86zrok1c3kc9ppu9qqok6zdf6 X-Rspam-User: X-HE-Tag: 1680604573-570019 X-HE-Meta: U2FsdGVkX18zMe+qPYmlfIDMz77EoYV1yegtuVBIS9NFxSLt1BolLxssRkcAhiTJ6sRngss3xJCyI5UZg4p2PTvfiy3zeHwm2nkJhtmIvHw/gE1Bz9BMKgUb8JETKUw2+dqs59II998WT+J+pLFpx+AsPQtSh/Bwlfpn1DvvxI6ezHY554cZFrnmbZwTsGdw4jUvh4pWSqzlePfSYTqIpjU2bXLy/aOfrztnks3gq6hmye6I9zNNlF1zi+A54Pd7VKZoqPy6pIgAC297ktTuH0KDMULsiGHjV9exoYwjJ0VteT/pTUYEq8r+xm3CX/A4Mlni+I3ZS0TYDNAhPx4WVSmHLdRP+/2JN6mBEEwmAwCr248Rp27uGVCbDPUflG68EFRHEztpY6xDUf9gTp8pfkVaeVON88nfgTqs6Qxg/aSxU27AiSoDIJVlHigwIr35nTlhrG/iD/4IAR76FvVJ8s4ksUCBdVox8oGrpaaldnFU7jjM/o0sFguL9DVD5ScNitZVROk2/vjGR6Xyjqc39fKxwiGooFJFs8cDIjKKVvAxtdIh3ljM0V7yB7yz/jQKfvdl5M/r0Y4RRdQa0n8Grr0KzhaKQTKLfwR2/9rv9QId+AvoWo6/zcsuPg4HHi+wsfUoCHeHMPkS1WZL3lt4ScJiibnU40VbHx6TKF0d9Pdxo4KnV6pllujzQz9sp4TFf284Ar2ww4XCPpsrx2iCul6ZaCbQFgKwd0qZQZUZuJ1InSQS0rx0Bi9rWpNvcfANChw0Ziytwpi1vNdUylj6VtOM15OBeDfjrHnN7zlJ+EvhxuECbyBKz6GOFO/Lsn+QSItcY+qsHWlqYyp8HWn78L/b3a0BAxKlBTREbnUzn+YogkvXt8NL2KhXITvuhq3RHsj50SIYC4dU4Xic3CUILokDbSrzOm86yGiuH7Az++GUOpEBcDCKlL7bS8spGtBjRKfNoOqhL7BrkPWLdEJ RT3TCbzK RCXuPXj4DYqME7IuuW/RbW4IJv8RnX2VAJ5iLO+kFlbyFr4oil0MvKRhq/Q63+D9f1aS6HUnQKSmYN4M+phN/nRnGctP4y+yLNx83TK+5amKLiaaOT2pIImoIVpRz+Hi6nXko/vXZtGTvtoDXYnOqm/EKjYN4ZMGNlsq6javjuhCuIq0SaEJpimHZURqNDaviAsWz38Xr3XjghMeNDKgjbYJBle1smz33rcBVmey1ZzlZXrWQ6BjsbTpVKPiM4Zsrr8nn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thank you for your response. I will modify the name of this parameter to "ksm_addr" in the next version. Best regards, Longlong Xia 在 2023/3/31 13:41, HORIGUCHI NAOYA(堀口 直也) 写道: > On Thu, Mar 30, 2023 at 03:45:00PM +0800, Longlong Xia wrote: >> The page_address_in_vma() is used to find the user virtual address of page >> in add_to_kill(), but it doesn't support ksm due to the ksm page->index >> unusable, add an addr as parameter to add_to_kill(), let's the caller to >> pass it, also rename the function to __add_to_kill(), and adding >> add_to_kill_anon_file() for handling anonymous pages and file pages, >> adding add_to_kill_fsdax() for handling fsdax pages. >> >> Signed-off-by: Longlong Xia >> --- >> mm/memory-failure.c | 29 +++++++++++++++++++++-------- >> 1 file changed, 21 insertions(+), 8 deletions(-) >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index a1ede7bdce95e..9ca058f659121 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -405,9 +405,9 @@ static unsigned long dev_pagemap_mapping_shift(struct vm_area_struct *vma, >> * page->mapping are sufficient for mapping the page back to its >> * corresponding user virtual address. >> */ >> -static void add_to_kill(struct task_struct *tsk, struct page *p, >> - pgoff_t fsdax_pgoff, struct vm_area_struct *vma, >> - struct list_head *to_kill) >> +static void __add_to_kill(struct task_struct *tsk, struct page *p, >> + struct vm_area_struct *vma, struct list_head *to_kill, >> + unsigned long addr, pgoff_t fsdax_pgoff) > > Hi, Longlong, > > The new argument addr seems to be used only from add_to_kill_ksm(), > so you can name the argument as such (like ksm_addr), as we do > for fsdax_pgoff (which is clear to be used only for fsdax)? > > Thanks, > Naoya Horiguchi