From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B68B2C001B0 for ; Tue, 15 Aug 2023 14:27:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 525008D0006; Tue, 15 Aug 2023 10:27:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D5538D0001; Tue, 15 Aug 2023 10:27:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39CBB8D0006; Tue, 15 Aug 2023 10:27:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 283EA8D0001 for ; Tue, 15 Aug 2023 10:27:53 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id DCB67C0D33 for ; Tue, 15 Aug 2023 14:27:52 +0000 (UTC) X-FDA: 81126567984.16.261CC9D Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf21.hostedemail.com (Postfix) with ESMTP id B95871C0031 for ; Tue, 15 Aug 2023 14:27:50 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=bAfZgAoN; spf=pass (imf21.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692109670; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BYSzQl/k/Rf6bxTS583bK1exyptODxYufwKUOHcW4LE=; b=wmsmzvOY9+ByIZChboaNbHDZCLFaXOV70bg7GoRTpRcM66nHzl2Gq3fRrvps4pmjL70FT4 XKngHTWjFivXgBVdl7Wm6MCrIdktQ4nzc3BO0zIQf4cmFf/EX8JeDJnoejHSIlOYcy7s4p GDaKvwfW2uq4v3ow+CDy3CCKGbPp+t0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692109670; a=rsa-sha256; cv=none; b=fP4EvZUI7s+A9tsB7EPMbsPVUrq2bnVoAmDBeaHy5GCoatgnuWWUqbqVGRp47q0TACU0rg 6xSEe9nV4ygp7BvTxau99jhg+1JP0WIMkDtNv0V3r5LI3D4nLnzD3aI47aWcEDI9Jprd/4 /rET/P+Vpc/HvRqQKwjXa2eq3iEDSoo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=bAfZgAoN; spf=pass (imf21.hostedemail.com: domain of adobriyan@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=adobriyan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-99c93638322so1134101566b.1 for ; Tue, 15 Aug 2023 07:27:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692109669; x=1692714469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BYSzQl/k/Rf6bxTS583bK1exyptODxYufwKUOHcW4LE=; b=bAfZgAoNrNwS32o2NHhbFuiKgq1nfBTnjlnqm9JyQYqPR25XvVEjgvZ/aHnZoaKnXv 09JjgWn5IggP6k6wxTtj+p/UQzY6KlQTLy0J5MU+lHyCuXqxUtUUnmzHekB4NUeioStD dAEbTR88D8z3ZjJ/wIQJdi3GGknVRHh+ifSjhaQkMQS1sXkYEkblYfQEj9nAZ5nwSFjb Grzf2M9t4IaxTgSxSozYFhVvtvhGwYM1OEKDOcmyTOL9rrqYQ9E/mLZZgjL9POIHashE lM+g69ic9vFcEXqmAUOU0+feZizlAbpQj6Feemuf2wRzULZSQG/LgzUA1KSMf/PO8HCq E2ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692109669; x=1692714469; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BYSzQl/k/Rf6bxTS583bK1exyptODxYufwKUOHcW4LE=; b=Z1OQB7OzsHwpaZCb+UMbenQSaAL7b2K/MxM+hjn4d7Y+vtMKEZbaEs17sh73TApSvU YOShbizYnhC6G0kE9e61dpDuwR5q5jpuOxr95eb8l0SieqMocC9kEMw6U67ZdOfSsB4u tntotwM7q/elwPlXMB9VKHjiavQNqFX7O0LKtFVXwxv6ak36+2YUalREu1OMvvS5nf4u UBm2SN2HZISRPMzvR8yKxQ/UhmqcuRT2q3/iwBP2hChBECXhzw7YtvAkoIuVbp4bstI8 gP8Z82+RYyxUQyFsQ1jjbq/SjHHIbdH27tygPjBsCLvERT2jyMGfUG0K0Z39LQpKetYP 00/g== X-Gm-Message-State: AOJu0YyagrtzCiLKs1Lwz6l0Gkk1Z9i4x+fTK7A5P8u+cU2qpf7Tym7i 8iGnfwjzJBVH6UDMa6qhKw== X-Google-Smtp-Source: AGHT+IEX1EzhSCo/Qm/CUX5TXVBJqbPFUvPLcEN7UNzmZxv8NVl9Mb0CNcFB2nRqtoR1W44zudkuFQ== X-Received: by 2002:a17:906:cc46:b0:994:5407:9ac9 with SMTP id mm6-20020a170906cc4600b0099454079ac9mr2204877ejb.5.1692109668970; Tue, 15 Aug 2023 07:27:48 -0700 (PDT) Received: from p183 ([46.53.254.179]) by smtp.gmail.com with ESMTPSA id cd19-20020a170906b35300b0098e42bef732sm7034745ejb.183.2023.08.15.07.27.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 07:27:48 -0700 (PDT) Date: Tue, 15 Aug 2023 17:27:46 +0300 From: Alexey Dobriyan To: Hugh Dickins Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] mm,thp: fix smaps THPeligible output alignment Message-ID: <9cc6f150-6673-4fe1-a406-e04bc33a49e8@p183> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B95871C0031 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: nr7hj3qcroxgde496z46pk4nuf7qh1rg X-HE-Tag: 1692109670-890419 X-HE-Meta: U2FsdGVkX18TuiPkk7SDbaB8eYCOesxoJEcea+kPnxtGso9khdPFm4cQmbvHUGvMy6lnp4JCJ2pQP0TiaY7R8llDyaxYdJHdrTuYh/UIXPkvnGc2oi1oE41BzYe+4KUykMPgwlqb3LIQ1jJG1YWRXfNGtHrgvhWUYcmIyTVTIzyaMlH2BZCUaBCOb2WiRi2e4sTGzJZgNviHThjjEy56aoGMGETkr3KMKw1JKp6r4wmfzQ9pks+L2qvgtCKuD1ZW07G4VKK0NSm4u+gDcpk3tSjgwbRUKJ2bFjffT/cKIQQSmQcCyU7aIQRRnSDpUk8t6ueX+naC/ew+MHP4yz+zfme09QQBjf3Ry7q6J/+x2ZnUS4HmseTF0EkP4J/WJ+v7bnfwSCNWuCNPspiADdGj/CpBHAv3VXK/2jiFbLcPFgHEqUlx4kphZ5JLTkD+ZM5IsVMpr4rfRxTogiL3PVk8BTeEcqHqgvgs2PfSsl3W4nFmnIon/PJY85M1Bh1pRNBr9sjn+ydirlLoPk47lngVcO4FL6rURx5qv5TIVpkY5jWjnk/AIDbxBSQ2qXIyuFz/9xUm1nRKKjA5TeXV1I8wAYd16Ps8lih+xBmOEybeAlSSP7Zula1q/tfCQIL8z7G+/EW9vqtdhWG1hFPCyoZPe8H54rHXp1tSDsj5ER9JMRIdbOqHIPkogf1HevG8pbseqFlAxZkrYlJcEIsaCAzQnqJSQLlDhhCbu2ok9K7mwWfWmPTFZHQbagEjL5dE+vB0HG6kbhb18UDcdUnpdgobCYxYU+/Zh1zeCw8oCM06DaI1LOg22/mxSFIdzExJLf6SmEj0CJmSDYbtSsfK/Tk9QcLc08BExQF4FNXYb3LmAzJqiFCJmMvKN/WL4Rm7z8FKj45zEau6JPsYwLJg3JYtBs+1O82SdIe5z72yWmLltz2JL/nFDH1NtcNSWDXOoVyXXPbd0N7wjHQmIdCnJ0a vdRTSqGg 6+9Hqnj/YLbFsJXSeitZs+oOcmA2UDic0sVgPolZsIsZ18FVSr8HiZkUIcDhxyIIfNXC9maoWxRdX1oWxNx1Ycehm7nXxpM/91s0x465GvThdR7nBujOtRxOm9tbC7YFXB0/dmmYrbi6c7MFuyCRUw4JfDnkMRH1a2451XWfI9LXLRSGaaByRSJMNHgjI2tdV7J2xx+ViNj/rB+AaXuvesAu46GaGjabUxN8jWrr3Om9Rx27KoGjJuEYIezk/XUyp05PlmGHLM4tQZtd2C68gMRQ8vywsJX40NtCZBpg6RiqeoesZdYkaM3V2mivzcXJoy2DwbwvR+MIriFEfj1GIDaX2Nb0o0ROMdD+86DRh4c8fHJdfUfm1n1ZxrVlzjYL7ZYiedzDI/JvQttFwct4hXVDS985vpka/lZaUpKu+QocmWLDqeM66VCdPqYaKyowQKaZkeGSzWda5dKQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 14, 2023 at 01:02:08PM -0700, Hugh Dickins wrote: > Swap: 0 kB > SwapPss: 0 kB > Locked: 0 kB > THPeligible: 0 > ProtectionKey: 0 > - seq_printf(m, "THPeligible: %d\n", > + seq_printf(m, "THPeligible: %8u\n", > hugepage_vma_check(vma, vma->vm_flags, true, false, true)); Why format string change? It would only slow down printing. I'd print with "%u", +hugepage_vma_check() or just add whitespace.