From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 639BDC7EE30 for ; Wed, 25 Jun 2025 10:57:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07B648D0002; Wed, 25 Jun 2025 06:57:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 029978D0001; Wed, 25 Jun 2025 06:57:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E81FD8D0002; Wed, 25 Jun 2025 06:57:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D47918D0001 for ; Wed, 25 Jun 2025 06:57:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 535D8B6874 for ; Wed, 25 Jun 2025 10:57:36 +0000 (UTC) X-FDA: 83593622112.30.E8DE112 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf20.hostedemail.com (Postfix) with ESMTP id B658C1C000E for ; Wed, 25 Jun 2025 10:57:34 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1750849054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aE/pHIcq+J7yahftKLlbjX02zfDr0tucuYbmauN0PGo=; b=IdQOKMKg8wPxQ/XpraMS0htbYUjOO8yrJL166odhHPf0g/6uzzspa2sclmp6lljBdXnKfe uVYu2Ofd8nmK1LUCIPTKpChRUNhfdWpz0TdAbjzMb3xBssSN6fjqj+2lO5KyheFVh4qbKS 7ExaRtDH9S81h1biDp7GaymzwQ5prsg= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1750849054; a=rsa-sha256; cv=none; b=HNJTPhl1bxa9DhwGa1p2myfICoRSyEJxP8xZr1lsCXWE+xRd2HsqU7ZPi38/OVQ+Zq53iU i6L9QoziYFcs2yZTGvqg/z0FdUufs+TRq/6IDsLPF8dN0a1tsI8tVJoHs29kYoRXmeSZzX 4svSox2V+Kr85qGaYnl2Ho3TilYfITI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 527A5106F; Wed, 25 Jun 2025 03:57:15 -0700 (PDT) Received: from [10.57.84.221] (unknown [10.57.84.221]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4ED4E3F58B; Wed, 25 Jun 2025 03:57:30 -0700 (PDT) Message-ID: <9cc06930-2671-4534-ac30-6d3ae3e472d3@arm.com> Date: Wed, 25 Jun 2025 11:57:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] arm64: pageattr: Use pagewalk API to change memory permissions Content-Language: en-GB To: Mike Rapoport , Lorenzo Stoakes Cc: Dev Jain , akpm@linux-foundation.org, david@redhat.com, catalin.marinas@arm.com, will@kernel.org, Liam.Howlett@oracle.com, vbabka@suse.cz, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, suzuki.poulose@arm.com, steven.price@arm.com, gshan@redhat.com, linux-arm-kernel@lists.infradead.org, yang@os.amperecomputing.com, anshuman.khandual@arm.com References: <20250613134352.65994-1-dev.jain@arm.com> <20250613134352.65994-2-dev.jain@arm.com> <8077b321-8953-46aa-b06d-95c91823e6ce@lucifer.local> From: Ryan Roberts In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B658C1C000E X-Stat-Signature: 7xmrft1xghmtunmmqunrruzwtst7e6um X-HE-Tag: 1750849054-202996 X-HE-Meta: U2FsdGVkX1+xfoPH4iFFLAFlJ30AjEz+FXgAKypd1LxsvHbFlSOWyLyjCBbzhcuGq4qixe7LfeBkPwlfFgOEptSILYCFFrdfkqwoSMwYUWAzP5BnpG1W8dunyukpY0IWQbwQ6BYvo5+JCitZJQxougwxWGGIUULS+XGETnyWJ+lMspbEkGxt6MCuFAaGemSLcG0BaQtoyC2DY88aHnUk2jjs5OLDwf7+0hfRH5eW25K4ComjNfMFABV7IPEAmxaHBOd313TS/D1+D3+i9qAOJaFzGSQVfrlZ+HrCzj9Yn5v0rimU97MdK59cGl9AtNqhxLZSAruVQ/nV4sJlXX7D/vtJ4m70rNUnTaEgantLahxlu+4meuBSyzBj6bnWgwiFWjx4vOoIOLWpvKpyvVauhsC6+9heDgdTJ3/hgVgg9kB4hA3YHfC3OyBvu9hWdJiNcCDvCCLQpzI3TI4npdlyp2K2TI0da6ryRnkPVwyQ9YY9c/5/ALWmNneoyEB1NwVit3oePXuecKJUTEhqdWsjzmgjL1t7/Z0dSl/xQSlRFpJRr9JGjgfIcuIms5fpQ3hihUyMmWDZc2Z39zmXV6dtWZPYXCRA7KYcrgik1Ubp4wDEoOlkgsO3L/psJfOSpiR2vzPjqiesVVCzSfEwmzrNq3gZL4aY0bwJBMFxyVlj4cQfYya+XveG0JYgw6GKMsHIwegWlajbdM73aizXFDDV3+8tdoWBsD1cFbq2+k4PM8H4kHBD9CrfqQYiVv6tZEfv922/gVXxzAhcfQsCH5UhxAJWKO9sE6pDWxDvxVzpmGPsyCRLWueIKaZlo6ZALm/F+HGjM02y4iFWADXEs3iX3g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15/06/2025 08:25, Mike Rapoport wrote: > On Fri, Jun 13, 2025 at 05:27:27PM +0100, Lorenzo Stoakes wrote: >> On Fri, Jun 13, 2025 at 07:13:51PM +0530, Dev Jain wrote: >>> -/* >>> - * This function assumes that the range is mapped with PAGE_SIZE pages. >>> - */ >>> -static int __change_memory_common(unsigned long start, unsigned long size, >>> +static int ___change_memory_common(unsigned long start, unsigned long size, >>> pgprot_t set_mask, pgprot_t clear_mask) >> >> I wouldn't presume to comment on conventions in arm64 arch code, but that's >> a lot of underscores :P >> >> I wonder if this is the best name for it as you're not only invoking it >> from __change_memory_common()? > > Could update_range_pgport() work? Sounds good to me! > >> And yes this is a pedantic comment, I realise :) >> >