From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1867C77B75 for ; Mon, 22 May 2023 12:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B3366B0074; Mon, 22 May 2023 08:06:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 763736B0075; Mon, 22 May 2023 08:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 62AC7900002; Mon, 22 May 2023 08:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 52BE36B0074 for ; Mon, 22 May 2023 08:06:13 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 06A4A120DF5 for ; Mon, 22 May 2023 12:06:13 +0000 (UTC) X-FDA: 80817763026.16.1666F42 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf17.hostedemail.com (Postfix) with ESMTP id 8CF9E40016 for ; Mon, 22 May 2023 12:06:10 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hY4ned95; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684757170; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KuXWj6x5wwVD+5iQQsnKFnyHh9i2kfkjkc5BqJvFz/A=; b=Bnz4q+ZJJYukCUxLjIT+/hFA97sln81VlYbCVPmIoY+9DKtE+D38/0y3/s9Xpl0+b+/Z8M +i6Jd4RKukHeA8uvhFO3CxLdM0sUZ5RjN+6KPsSk8eDc0OdWdfv5+PLwvYlWvCmqZ1Fc62 J8nRv1CVVSY2ulGwbi0rJGHrjeETteo= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=hY4ned95; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf17.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684757170; a=rsa-sha256; cv=none; b=bIAasKh8Lv9+RyVtlGd4zpbXU4HoB5jFuFh+XjmjTJ8PkSPkKPYj2wVDufB/hH3u5yywCe gKy3AcT0oPeICV66uOJZk+stcNJIsKfxtMsO8YruuIMEiZfEKI4fFVAJbRTgbk6CadK35F ttY4R/AJ7uVwRHus7hH7t5fzzmQ8rtI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684757169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KuXWj6x5wwVD+5iQQsnKFnyHh9i2kfkjkc5BqJvFz/A=; b=hY4ned9571Hgj592D17a9OD8SpXNy33SNlk5rWYEVNZCb+cM0xlYlfGmJhKlqcOgYf94zS CZIwQkAh54iBYfXTJzEDIqgw/tdtzgvU+z2TWRyY6qxxUTcoxSx167kgA1C715xeQhOP8X PGpOdFtz6q8xLt4XHyWuMqWAjFDV2FY= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-144-D0-ow1ylONuGNmyETjdrGA-1; Mon, 22 May 2023 08:06:08 -0400 X-MC-Unique: D0-ow1ylONuGNmyETjdrGA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f60536450eso4342825e9.1 for ; Mon, 22 May 2023 05:06:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684757167; x=1687349167; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KuXWj6x5wwVD+5iQQsnKFnyHh9i2kfkjkc5BqJvFz/A=; b=Hz/QiPGd6khfbE5wwI9lSHw18+bhEMNUKLQORHC6hgjZsUydrdoKdi2tj7zDLDFSaG WDe4fJmk6TzaSmmfRwemdOdzQ1045CRfv+41+KkOsGWQkV8n9wnOWiVJhx3qW1jVhKiy nO8G4NNpdGFbwnwgbWgtxNWMH+fAyZAJQydxF7NGZiBxW+pVQlnDrQ6A+e5TJgy6+Ike FKn8rIi1yPabAy5QOhU4BzUor/xGdnUqsSxCl/H/S9aHUc0UKjMUd3E7lgPREFSPGB3o FoB/Zmw3p1008HdC/QGgdcSzG8VPOLPOH8vjnFmfDv+YC9M1RQO+EM9zRcYqiik+Q4fM erzg== X-Gm-Message-State: AC+VfDxWLOvppw1kEbUwolgyxAoMtvDKLIwK/ASG46j1Kki0PijPZOKf U8c3t5lViZjv7NcEfdYui+w9ClFM/vIT0mOOAP1KMuXDobAfpGgqSBk8aPUrUXpgWESNwz9PJJR hqcjT/yxE7ag/RkHXIdE= X-Received: by 2002:a5d:590c:0:b0:306:2c5b:9da6 with SMTP id v12-20020a5d590c000000b003062c5b9da6mr6347439wrd.56.1684757167252; Mon, 22 May 2023 05:06:07 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Ss4E8BoZe344FBKqcpTBeR0JGtUNN3AchR0PtaG/dWQhjUMQZUW7Jg3YDVmcSBsuE4mBbpg== X-Received: by 2002:a5d:590c:0:b0:306:2c5b:9da6 with SMTP id v12-20020a5d590c000000b003062c5b9da6mr6347422wrd.56.1684757166933; Mon, 22 May 2023 05:06:06 -0700 (PDT) Received: from ?IPV6:2003:cb:c742:c800:d74f:aec6:f8ac:558? (p200300cbc742c800d74faec6f8ac0558.dip0.t-ipconnect.de. [2003:cb:c742:c800:d74f:aec6:f8ac:558]) by smtp.gmail.com with ESMTPSA id w4-20020adfee44000000b0030785b864f1sm7529723wro.65.2023.05.22.05.06.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 May 2023 05:06:06 -0700 (PDT) Message-ID: <9cbd93e0-721a-01c2-14dd-87f89363a830@redhat.com> Date: Mon, 22 May 2023 14:06:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH -V2 4/5] swap: remove get/put_swap_device() in __swap_duplicate() To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , Minchan Kim , Tim Chen , Yang Shi , Yu Zhao References: <20230522070905.16773-1-ying.huang@intel.com> <20230522070905.16773-5-ying.huang@intel.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230522070905.16773-5-ying.huang@intel.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8CF9E40016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: wbf3m9so3tqs6oobcpxekz7c3jfmy75q X-HE-Tag: 1684757170-669597 X-HE-Meta: U2FsdGVkX1+gJ5i5dYwfRexDvycuMcD/bV3XOPwKDBVOSGp+HaObzoxdnMbamAZRmh0g7LiVdSTDWCndWw7/ikYcyAKwu5jaqm4fJUezgq1f0YU1qxCS+aGFCttf6KAkxPNPaSmrjS/hiUqd00PsVzs4Zy52k3x2XoPtNnmQQK25jwCg4ICFzXiFU4XBJZTA1htKobWszasz7tS7G957LNY7g51bgYAReWeUxfZXXhfXNb5gNQylLYUzxqu4XFl/Z0A8JLeeQUTEa4tra58tGoq6s2htCu1HkVEeyFmPXgTG7HRE0kP40qwMici7BD7YYKBBVSCVvQcYOClUmKhNbtwgkfpbXW4EVNXX2uPhfT8MWZVsW/fUKF54SeA9t/8mW7yTzL30nuouS25Y25NlQsATDjVaxJCYa0D+k4/grsGOpLojbrp53MKiQC5xQ195B2MzVU42MEdXDKccdT+MwKFv7p0CVoijSi6HPbZ9P23yXnUFSrP/4pXfw/YRrN5t9GCEnqEb+fekPeLBhJTUJd4PXj5D8CJdZ36qej2P7PY7RcJTRxMxabQ/AukvzpU7sC9Wxq4pYWPj8v0R8pIRJhAyqcBg/PJValSZyKLCvmDTUuskHfmV8al9E+QqAvq+wa15cIhR59GTFYzXl99mR7UaLga6HE4oy3QjjqFzZHtD7dzP/ks6CGGyc2AJKfh50TFCRD6kf2hyxE7fbyOE/6LfZx/VPYarVkkMEdughQUS1Y4Mrwy1EAfe/uLszcH+Mw8ukn5nbmygzNMFR7cbFK0w2ixVTYKx9KshXJJBe2l8Oyv9gEVLnNxCBf8oTSLfQiIPUmAgjxTBRJlUcp+ZQqoj0L11b1B/bBhWwQKQG+lfoPxiehKKtnxBTv03OLRD7q4ymSH2UBlo57BYmFkUjAWz4D9+YegETxGg2w6TF/UuLvfUYaoxyU24ACtUdSHhBsKHcAgTfTll2371y/u 4ArRVvZc 5ZvRNoWe/yQn0NbUyKpdvVbekhNWZEZLWi+/qoHAr6ts4SjTIBXF+2Ndtqxrs0/rHER7vRFloAI3flNIGQlqgmBbWLb2lu8AQ4YGUu9xrgKJhQS0ISwJgRb663ZVRJNkO9OI4NxIobJaQXBTY4EaoGTJ0PYgesrI3qR8q2xoo3Eovx6MM3ZLPtvjgIJzrRxSHTpIz5Hgvk1G1d9VDbtKguslK9WF50720qwp9QrEFgHxIzzxvaeM435ih8btrwF7aL8AH8FoePSSp7DNnA3kHEhj8ANSdi3wZkB6mfAr6e5mtCG0PEcywLoLmxL9EEdjUHt1abMSkb8wQLl9/GJyCr+kNaVgN9P5VJZht6hFsiyszLZOIVv+nOGFe0tm2odjMkRerl2ZqRRySVgw76HP4+y23vW+vHfeNTy/9sEgQvDgySvQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.05.23 09:09, Huang Ying wrote: > __swap_duplicate() is called by > > - swap_shmem_alloc(): the page lock of the swap cache is held. page lock of the swap cache? Did you really mean to say that or am I confused? "Page lock of the page that is in the swap cache?" > > - copy_nonpresent_pte() -> swap_duplicate() and try_to_unmap_one() -> > swap_duplicate(): the page table lock is held. > > - __read_swap_cache_async() -> swapcache_prepare(): enclosed with > get/put_swap_device() in __read_swap_cache_async() already. > > So, it's safe to remove get/put_swap_device() in __swap_duplicate(). -- Thanks, David / dhildenb