linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "John Hsu (許永翰)" <John.Hsu@mediatek.com>
To: "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"liam.howlett@oracle.com" <liam.howlett@oracle.com>
Cc: "Andrew Yang (楊智強)" <Andrew.Yang@mediatek.com>,
	"Qun-wei Lin (林群崴)" <Qun-wei.Lin@mediatek.com>,
	"Chinwen Chang (張錦文)" <chinwen.chang@mediatek.com>,
	"Casper Li (李中榮)" <casper.li@mediatek.com>,
	"Kuan-Ying Lee (李冠穎)" <Kuan-Ying.Lee@mediatek.com>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"yuzhao@google.com" <yuzhao@google.com>,
	"John Hsu (許永翰)" <John.Hsu@mediatek.com>
Subject: [BUG] trigger BUG_ON in mas_store_prealloc when low memory
Date: Fri, 9 Jun 2023 08:37:31 +0000	[thread overview]
Message-ID: <9cb8c599b1d7f9c1c300d1a334d5eb70ec4d7357.camel@mediatek.com> (raw)

Hi reviewers and author liam.howlett@oracle.com,
Kindly ping.

We met BUG_ON in mas_store_prealloc with kernel-6.1 stress testing
environment.
According to coredump, BUG_ON is triggered by mas->node with error
number -ENOMEM(0xffffffffffffffd2).
There are some mas_node_count functions in mas_wr_store_entry, and it
seems that mas->node may be set to error node with -ENOMEM if there was
no enough memory spcace for maple tree operations.
We think that return -ENOMEM instead of directly triggering BUG_ON when
memory is not available is suitable, because in reality the tree
operation shouldn't be performed in this situation.

following are the backtrace:
mas_store_prealloc+0x23c/0x484
vma_mas_store+0xe4/0x2d0
__vma_adjust+0xab0/0x1470
vma_merge+0x5b8/0x5d4
mprotect_fixup+0x1f4/0x478
__arm64_sys_mprotect+0x6b0/0x8f0
invoke_syscall+0x84/0x264
el0_svc_common+0x118/0x1f0
do_el0_svc+0x5c/0x184
el0_svc+0x38/0x98

Any suggestion is appreciated.

Thank you.
BRs,
John Hsu

             reply	other threads:[~2023-06-09  8:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-09  8:37 John Hsu (許永翰) [this message]
2023-06-13 14:11 ` Liam R. Howlett
2023-06-14  7:06   ` John Hsu (許永翰)
2023-06-14 15:58     ` Liam R. Howlett
2023-06-16  9:18       ` John Hsu (許永翰)
2023-07-06 18:54         ` Liam R. Howlett
2023-07-10 12:49           ` John Hsu (許永翰)
2023-07-10 14:24             ` Liam R. Howlett
2023-07-13  3:25               ` John Hsu (許永翰)
2023-07-13  3:29                 ` John Hsu (許永翰)
2023-07-19 18:51                 ` Liam R. Howlett
2023-07-19 19:22                   ` Liam R. Howlett
2023-08-07  9:54                   ` John Hsu (許永翰)
2023-08-08 20:00                     ` Liam R. Howlett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9cb8c599b1d7f9c1c300d1a334d5eb70ec4d7357.camel@mediatek.com \
    --to=john.hsu@mediatek.com \
    --cc=Andrew.Yang@mediatek.com \
    --cc=Kuan-Ying.Lee@mediatek.com \
    --cc=Qun-wei.Lin@mediatek.com \
    --cc=akpm@linux-foundation.org \
    --cc=casper.li@mediatek.com \
    --cc=chinwen.chang@mediatek.com \
    --cc=liam.howlett@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maple-tree@lists.infradead.org \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox