From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9231CC433EF for ; Mon, 14 Mar 2022 13:12:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F32128D0006; Mon, 14 Mar 2022 09:12:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE2418D0003; Mon, 14 Mar 2022 09:12:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA9278D0006; Mon, 14 Mar 2022 09:12:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0153.hostedemail.com [216.40.44.153]) by kanga.kvack.org (Postfix) with ESMTP id CB3BE8D0003 for ; Mon, 14 Mar 2022 09:12:16 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 78590A4A70 for ; Mon, 14 Mar 2022 13:12:16 +0000 (UTC) X-FDA: 79243030272.20.15A77F4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id F2FC9160024 for ; Mon, 14 Mar 2022 13:12:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1647263534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BfrmpYIpBAIQM1+Gt9Phq5AOoHKq7aRJ010EA06rYLU=; b=YkK2u4ua2ItTwZ+Oxu1jmK+LGAUZycZDqrVHiY+i5bUSUZPJA1VdeJGGOM6avXoUPkrbrT I2PfV1iwINea1rGqB8bNnDQJjHROQpZbNRI5Qh0jvv8vcDSc1ttY0gbL9eRPPbmLrovXCE Xu4tT24OOLk7EnKfpXDhBWtAzANjh9o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-610-4u2miUeMMhmUtNtu1uVNUA-1; Mon, 14 Mar 2022 09:12:12 -0400 X-MC-Unique: 4u2miUeMMhmUtNtu1uVNUA-1 Received: by mail-wm1-f72.google.com with SMTP id 84-20020a1c0257000000b00389a203e5adso5395593wmc.2 for ; Mon, 14 Mar 2022 06:12:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=BfrmpYIpBAIQM1+Gt9Phq5AOoHKq7aRJ010EA06rYLU=; b=eLAYO2a+813GxaO6JP2tcLiD0R5z9S1HYF8Vofc5Fr3ENLB4lsMCLCdkNi+tUK1Ji4 ijaLZ2XCZcc3pqK+jN4stwtc2US117NQbSFcqWaXLm/48xQFFfUDDZWBczViQep/BB0J UdHf0itE3JFxL+VHQrP9SbVG0j3UjdZkwioeRK4J1gKGjTVaxerrWnC8gojI9rK16M5k T7McCA357uom7PhAsKQQMRA6SnVFYk5WBJWWQ3jWfYODTv9v5tvUVpayiK2lxjrh09Yh e1rYu2clf+Sx3lCSYbtDvkRt6tWfSYV0qyURbP+OnfMYnhMmsDOSzNcI1qNhPouJHR5z kLww== X-Gm-Message-State: AOAM532LoJExCtiX4ofS962KCwu7VbepJsZFmvShQRIbPh3GVPZDmubS EoJbGkwg4HidWiaTjJGvLAnngCLbcI47qzWZsrljttR6G4Gosd0OPhD4FOSO9ocbSXPo3ikcJou h1H4PGlBdjRw= X-Received: by 2002:a5d:4992:0:b0:1f0:68bd:4c34 with SMTP id r18-20020a5d4992000000b001f068bd4c34mr17064597wrq.670.1647263531486; Mon, 14 Mar 2022 06:12:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy3mZ0+w8htNAo5t0qhYrTrRDOxGC7G6tNWZztZlmqcfmQXvFb0I4unRmYEI5Q5T6ypHhtxMQ== X-Received: by 2002:a5d:4992:0:b0:1f0:68bd:4c34 with SMTP id r18-20020a5d4992000000b001f068bd4c34mr17064584wrq.670.1647263531261; Mon, 14 Mar 2022 06:12:11 -0700 (PDT) Received: from ?IPV6:2003:cb:c704:9a00:b2c1:8682:b807:e870? (p200300cbc7049a00b2c18682b807e870.dip0.t-ipconnect.de. [2003:cb:c704:9a00:b2c1:8682:b807:e870]) by smtp.gmail.com with ESMTPSA id w9-20020a5d6089000000b001f0256761b9sm20912217wrt.45.2022.03.14.06.12.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Mar 2022 06:12:10 -0700 (PDT) Message-ID: <9cb7c909-eded-4933-c7a5-a7aa5a5221da@redhat.com> Date: Mon, 14 Mar 2022 14:12:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: [PATCH] mm/mremap:: Use vma_lookup() instead of find_vma() To: Miaohe Lin , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220312083118.48284-1-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220312083118.48284-1-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: F2FC9160024 X-Stat-Signature: zgcbpr7t3ye8enf4oqgn3m6sfhp8a1m3 Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=YkK2u4ua; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf08.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-HE-Tag: 1647263535-890182 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 12.03.22 09:31, Miaohe Lin wrote: > Using vma_lookup() verifies the address is contained in the found vma. > This results in easier to read the code. > > Signed-off-by: Miaohe Lin > --- > mm/mremap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/mremap.c b/mm/mremap.c > index 002eec83e91e..9d76da79594d 100644 > --- a/mm/mremap.c > +++ b/mm/mremap.c > @@ -942,8 +942,8 @@ SYSCALL_DEFINE5(mremap, unsigned long, addr, unsigned long, old_len, > > if (mmap_write_lock_killable(current->mm)) > return -EINTR; > - vma = find_vma(mm, addr); > - if (!vma || vma->vm_start > addr) { > + vma = vma_lookup(mm, addr); > + if (!vma) { > ret = EFAULT; > goto out; > } Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb