From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DADE7718B for ; Mon, 30 Dec 2024 03:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A69C06B007B; Sun, 29 Dec 2024 22:12:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A1A176B0083; Sun, 29 Dec 2024 22:12:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8BAC36B0085; Sun, 29 Dec 2024 22:12:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 716F76B007B for ; Sun, 29 Dec 2024 22:12:19 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E0A81B0390 for ; Mon, 30 Dec 2024 03:12:18 +0000 (UTC) X-FDA: 82950151074.16.82EFD27 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf14.hostedemail.com (Postfix) with ESMTP id 2B3F9100005 for ; Mon, 30 Dec 2024 03:11:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jRCagp2Q; spf=pass (imf14.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735528289; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=00MV44O/wLuPQ/RpQp8S/rpHXiOskq9DnLB00pReqmw=; b=z2cuy+cWjYbyO/JMrOGZW2o4u1Zx/hLx18kbOH7kNLO1zu0j9OR02+rYgvHJ9THCfPpW2c 2heTwBzolpWWTTQGJjf6aE3ziQQcNXaEXG8U5ilKc+TjcW1h70Tk4fJgtDX/XtsEjR9Ye+ DhA/W2e9eXsclXZlltNEwF8u1POO7/Y= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=jRCagp2Q; spf=pass (imf14.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735528289; a=rsa-sha256; cv=none; b=U2inkeKmXpNdXYoJ4arVHGIGLD3tdxMMiPY/bMFLqrd9KBmO2FUh7fFY6kKbr7CVTXy7K/ vwFmgws13duu2uXw29jriP7+QLfVCNBY+XEjKvTyHm7SeNJvZnBHejuSF1GFSMxl+eWubj ZtDDzGRPcZDxQgbkPwOQtA76lGeGg6U= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-216281bc30fso130773425ad.0 for ; Sun, 29 Dec 2024 19:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1735528335; x=1736133135; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=00MV44O/wLuPQ/RpQp8S/rpHXiOskq9DnLB00pReqmw=; b=jRCagp2Q1GaYAz9p3KUSIy6RCraRMH+oFUBN5pJUMe2Mk2CMATcxMyycogyx0w7Vca uWrJ59ZQAgV869ynFU7ZgvhrjLK1bJ3VQpXqHjc1jIzbHlY9J2yRWAc4IczfkQI0J/3z a0OKvH65GxXmpYMiT4OK7E3JKDkB9xpI7kxgE7XlEcqat/kroRKaxecgiUaCCWd8IjNb GfPExtGYpQ36ZzLNMQJL8EkAZzNN8NAZQ0zIx5+rzbPqLO6UF1hTMyF7jkMytCr9GsUp e7ANLCmCdnmFTdz7la5gXMdy9M9qR8Js8F/SmoF2+40aWLIQOg3XMMQVGla8kx8PBLtp flRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735528335; x=1736133135; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=00MV44O/wLuPQ/RpQp8S/rpHXiOskq9DnLB00pReqmw=; b=J0m3HfHSJM8wQ6dWCHA6gN1p2MJHHSvTRXpp7hOlJE0aTavHNkcqAIHm86OSpGHTcD N1fdlkgtl54RX573p9ZxqR2S30gsLEY+IKaUxxweLQJaEUZuh6+KwMwhpwAdRrYpZ7+a GuM9Ht/mmwocuVz1bCL3AvXXoWr5KT6FTAqwMzOT/EYWR//R++twr0YKUubV3uitUfem ZlkZ9gzCuuMNQXA+jRCUd+Q8Crbf+du6v80cUdVPzfljCSzumzvUmr/JJJTG7yavmVyF 0ZBraeeIi++qwsM1SswmbTbmD7mT27FQJvc+rSmdfRJ2MevZaOxT5M1bLjw7tZ0wluYG zXzw== X-Forwarded-Encrypted: i=1; AJvYcCXOfghj7JrH/QakRw8wrt4T33tA9l1DJUTwfzc6FlAJPpA3V62DJBOiyZn2Kak6DgkxOoVdQ62VgQ==@kvack.org X-Gm-Message-State: AOJu0Yw520hGbkTILWTSJHosPNaq0af/wm4h+oUNddPgfngJcHfLRKkQ XGtbcF1GUD5DSnOSixcPfwxRmZfvoSoiBiYgk4X+pm+5yQ2LdNexi+zoscq3FhQ= X-Gm-Gg: ASbGncuZ+/S+d1tMMMAQpwNtCTdxqS//VWwLoeGaFraLZIteXxeG06V+BbTVlrxYqK1 nRxz0Q7S1TO7raz/bkk1KjwcPuScWJ2mnaecIOyix9xZ7rdndC4k1Hh2wrOZqnO3RR1YaKDB93V C3vLqRnQ59IKucH7PnuJGyCzWR1uCchEqmWt7w5zNn9KdPDR/CVsCKyBwtF62cIn6nOzsLcK2/s 0SjqPI0kGEJvuvWG7aockxJJ3HzwnxuzVgE4WSNQS+i2aPKrVtmIszvZaZw7O0iAoRZRo9ZtTAx Eu098g== X-Google-Smtp-Source: AGHT+IHVtuGTDJKnXgo1JS5AtVrvj0I/cg1dyieo6seko5BYBtWvsXqnYPIAVAFKhaTndzKmWg8VgQ== X-Received: by 2002:a05:6a20:9185:b0:1e5:7db5:d6e7 with SMTP id adf61e73a8af0-1e5e083f019mr66304616637.46.1735528334820; Sun, 29 Dec 2024 19:12:14 -0800 (PST) Received: from [10.84.148.23] ([203.208.167.148]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72aad84eb45sm18191842b3a.88.2024.12.29.19.12.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Dec 2024 19:12:14 -0800 (PST) Message-ID: <9cac5690-c570-4d43-a6bc-2b59b85497ae@bytedance.com> Date: Mon, 30 Dec 2024 11:12:00 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 15/17] mm: pgtable: remove tlb_remove_page_ptdesc() Content-Language: en-US To: Mike Rapoport , akpm@linux-foundation.org, kevin.brodsky@arm.com, peterz@infradead.org Cc: agordeev@linux.ibm.com, tglx@linutronix.de, david@redhat.com, jannh@google.com, hughd@google.com, yuzhao@google.com, willy@infradead.org, muchun.song@linux.dev, vbabka@kernel.org, lorenzo.stoakes@oracle.com, rientjes@google.com, vishal.moola@gmail.com, arnd@arndb.de, will@kernel.org, aneesh.kumar@kernel.org, npiggin@gmail.com, dave.hansen@linux.intel.com, ryan.roberts@arm.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arch@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org References: From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2B3F9100005 X-Rspam-User: X-Stat-Signature: rbfwday83g3de3aztejspsjz1ihi59kr X-HE-Tag: 1735528284-439667 X-HE-Meta: U2FsdGVkX199CwOmHNMQPdr/o3Vpddw+JxxPyxkjZ3a5vJ/1NNF4UE0N2Tap6bkbs8TSXkwmQ/rkPMfKWiOM4OxnWubGBpUDMAs7C5Th+kX2o+Uhr8HaYbDxNhBE+LF2ulS3a+uYy49lhQWs/l5tckzXKJjT46481oXqVunwoLgG3QC//3JJH21yR7J4/XaeS4F0cixMzHmdQu0Z6h5Fel4aIf2y12WfsepQ8P1VVoLcH8HuTJN6w50Oj2lCfJTvz5Z9uT3CIw1HorJ2TfaulW9+7ZAfAfqk1ChiZoLqA5k0mPBYkq91VYP83vZBbpmCXhAmU7PYgZE5NMXUYkkk4dnqTx23j76Gc5KlbgNb1sG9Y8J2mASmZ661BjzWw49dbPK0P/zdUk0Tyuxms4CGTbQo++VgJqVYLoaOF167UozGjPqy3V5zyR/+a7Qfq6bJGRZv4eal4KDu8wX7I2Qdh5CDIj4MrzTzuzHg7aZ6ReMZ81yQMlF4BWcjWzcIAXOcKHVRrtkWpWEk89gpne41rzxDCWd2xbzl0O+ojFAP1ja/qkEQHMCZyfK+srdH5RxavhKER++Z3bKHqQCGyMXpjlENCVL5geHmT1dC2cNPTLBS1sw+BL2CQp5kRRZaknBz4YTPpjmBoaXHPLEsJZRX5wUAwT6g5z0GLXfTT0BHK5hHhvTmbjEkDZAo1mAtnGt+OSMmXn4gjvYWsvCjvRMgm4A3YkzZn5hxq/xZqvlTtxvZ+6FHMJ/hq4OGdEP3NHVUWKVaIbt9QDxLMADnRWkLwzN05wNQL9Xv03f1jyPXXIuZBdL+8vNLlutHNSC5iaCfB912vQkzrrTOvOyKseGutwpWSi7pdhN8+LsRGWc7Gu4M/VlsE6154QOziLk67VfeCbzN7RuY6XWdPSTZpWKyKc3mzSlXPXP6in5WuaNMl0U7GQgu0jreqr6Fc8lTSX5rPN6epnqGBPymDhs4nAv 3aywv5dF qAkMsXLiSWgqMp1I/Z7BQDGy9OEAPwGlZdjHrrCYUTSh7VmvzJL28fkBwtbIbKPExHycOixEHGFrO4kl04odlvAe95wgHEFkuYp7XOcnIv8uRCJzvTu/ceIC8E/nKK3wxwLpQyq8zlKPzxoa3NNRpt50naBVJqE7Q7BeorT4bexrf8svIRLb3Ka3V9sI+uhvEZGlDPzNsz6Yiw7NlBsAgqjR7ZaXszWOgyIO494EKQb/10nl0dgkk3y0U4F/2/UN8AZev6yejeitFCDLhOcwznbcchRW9pZmwQ9WDB+P+eOOPKSjKr3VGGx6vXLegx8ESGD2St0SnQP/PXmTlLxGhwWBGRtqv5HC015Q9deBLjJWYUiEHUbZZeFoz9k1kLevs0BHKPxmTTvfOvxu1V03MRensaKFe1Ja1CPCpIhf1hQYY0T4mHIPV5jLhiEwFRlbHz5fWHPOKDy6FT0U0EgvLiFmX8YxW7txafzyRcmr2IxRzOyT9rDRveUGhvqheGfXaawB5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Mike, On 2024/12/28 17:26, Mike Rapoport wrote: > On Mon, Dec 23, 2024 at 05:41:01PM +0800, Qi Zheng wrote: >> Here we are explicitly dealing with struct page, and the following logic >> semms strange: >> >> tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte))); >> >> tlb_remove_page_ptdesc >> --> tlb_remove_page(tlb, ptdesc_page(pt)); >> >> So remove tlb_remove_page_ptdesc() and make callers call tlb_remove_page() >> directly. > > Please don't. The ptdesc wrappers are there as a part of reducing the size > of struct page project [1]. > > For now struct ptdesc overlaps struct page, but the goal is to have them > separate and always operate on struct ptdesc when working with page tables. OK, so tlb_remove_page_ptdesc() and tlb_remove_ptdesc() are somewhat intermediate products of the project. Hi Andrew, can you help remove [PATCH v3 15/17], [PATCH v3 16/17] and [PATCH v3 17/17] from the mm-unstable branch? For [PATCH v3 17/17], I can send it separately later, or Kevin Brodsky can help do this in his patch series. ;) Thanks, Qi > > [1] https://kernelnewbies.org/MatthewWilcox/Memdescs >