From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3220FC25B7E for ; Tue, 4 Jun 2024 08:07:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79F8F6B0098; Tue, 4 Jun 2024 04:07:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7500D6B0099; Tue, 4 Jun 2024 04:07:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EFFD6B009A; Tue, 4 Jun 2024 04:07:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 40EA46B0098 for ; Tue, 4 Jun 2024 04:07:41 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BD8791C1592 for ; Tue, 4 Jun 2024 08:07:40 +0000 (UTC) X-FDA: 82192477080.04.D7F8BEE Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf09.hostedemail.com (Postfix) with ESMTP id 76BD2140014 for ; Tue, 4 Jun 2024 08:07:38 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WQqRq1vm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717488458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ly4p1bO5fTYf1D2HUojjOEVvzZSKtVu8aHZjMR200Kg=; b=z/X90g5ddIHKW8dLHFLEIryGNd6Ss+34pGNmpWy4GM7csX6YgKkmRhv2fOjnSW46S5X3qk F1qkE3DSjiUEn9WMiIRJRT48P9Iz+zi4erscQ0xdV+kHHdB1ilY14fopj+WY3AmSQBt7lb +ViP9vXNakWDBVDIPRG8NiAmla1VPSM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WQqRq1vm; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf09.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717488458; a=rsa-sha256; cv=none; b=DK0DmhcRgIK2lkJyK6U2CFqYcyZc7uXSd7bUqmrAg4rbX7hUINcMhPKCymzrvP6N2E15N8 4KZDtMqOhGl5SGGUOaHOLQ9wJe/0zuH8P0X4E5ENxY7nAXn292AC6IKDKTJHhSA2xCMPUl rYhO8cBr4NbTV5kwto8N8yWNX8F0xf8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717488457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ly4p1bO5fTYf1D2HUojjOEVvzZSKtVu8aHZjMR200Kg=; b=WQqRq1vm7HPVznQxffqTgTEtBRBR8ghAfG7yzKU9MrnnUbmY7Xvn7j+iYol77T0ymsV6Du 1QpA5tEjuNOWJzPvxDjzKBEOnK0o5Iho+AT+H8ntkLKdMaNYGurib9FJRBZx1B0HIXAQ7q KQNh1uFDAkki/HcLzhvYKPRv07vUXjI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-688-AyM0lqalNb-ON3iJx_B1kA-1; Tue, 04 Jun 2024 04:07:36 -0400 X-MC-Unique: AyM0lqalNb-ON3iJx_B1kA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42120e033e2so27814335e9.0 for ; Tue, 04 Jun 2024 01:07:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717488455; x=1718093255; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ly4p1bO5fTYf1D2HUojjOEVvzZSKtVu8aHZjMR200Kg=; b=P2ELZTUGh96S+wvj/gF6F66Bpm3J8EGQG/BlFLMKDkdHB7v9IbzrdH5RK0P3DvyscY HTcGl6nm7Nkg09ZeC9O98Z8BcGpGpFJEvGihkfLAQXVfGrZVosMZpxn9lF/RMg4oB+9b fB4pioPegqpVqtCPH4UxzynpwUL7SnMaoCjFTmvu0gN5hxit80cZN73C6JszEFH24f6Q 7+ZjJv1qEJ5wN5p0+6YvpyLc2Tn1Wm442eJ9l+EApRAe4cZXZRtlJoSkate0gHvR+sBu kwz2a/8Mrg0k8Qi3deWQv4medQa/IobWO6R9pKRGj97n8B/nA1Up+AND/W7B0s+NJdbw XB0w== X-Forwarded-Encrypted: i=1; AJvYcCUamWP3QtoYoGW3eWrIelN7xMkedGRu3NijfYT+UmLkEVzLtvVKJ/W1yfqnicq+Y8RPEU7FR+/I8QLUxT5ILzRTpuc= X-Gm-Message-State: AOJu0Yw++jEAJQFMh/5MP8Dw44JxJ+kKHt93OXllpBW0F5GxjBA+Lmc/ jU3CMofNxBr2ojIcmyvR/u8hj5KkpurCV6exk+Aa2JkzJ+Lmau+dMeUbYNwGj5IhcV95vGwtgcG FU7OBSQcELbSMc+hAwc1PRlnxL5AVB5psrizFpA2BXKGAcqme X-Received: by 2002:a05:600c:46d3:b0:41f:e4ad:9ae4 with SMTP id 5b1f17b1804b1-4212e076433mr84478885e9.23.1717488455236; Tue, 04 Jun 2024 01:07:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8AY7rYF071eqwcC1hb7vOUn9ZYOu95JNEbeh8n0ioDjWipBqkNwcT7kVAZipAt3JryuOr0Q== X-Received: by 2002:a05:600c:46d3:b0:41f:e4ad:9ae4 with SMTP id 5b1f17b1804b1-4212e076433mr84478705e9.23.1717488454812; Tue, 04 Jun 2024 01:07:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42135fea176sm106380295e9.24.2024.06.04.01.07.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 01:07:34 -0700 (PDT) Message-ID: <9ca730ce-2b2f-42d2-8c7a-78735a995c64@redhat.com> Date: Tue, 4 Jun 2024 10:07:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/10] mm/ksm: reduce the flush action for ksm merging page To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> <20240604042454.2012091-2-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240604042454.2012091-2-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 76BD2140014 X-Stat-Signature: n3qh9ifpqkawg5sq99165qgkadh485kr X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1717488458-450148 X-HE-Meta: U2FsdGVkX18p7zcfj/+dC5phcz2wv2t3oEh7wwugN+NkaJqgh7UUnLgq9HWaYvBU29Pe5qFbAhx6IDQ9FfXdmhumMtFxLOsfyopiTJqmvHqFV3tXupE6E5SzNXF6rrh/dJBmy8AbDnS0E6l46yZHp01bBqU73tvqzJ2myPi9g43xUI0Oi1/9gwc/MRN768tHycbfkqOF/OrHy8Gc7S0yEGX37pJMBM5fSKfXJytWtpD9F32Bx6xITRm5FvzXzvV9v6ldL6N3QRAlkvwleEoT23aY/SGQETeumYz43DjD6gFFZXrPt67e0Uz1Ser4Kv09GULOAp+KN7dYNLVTY0RzuxjW7FlbdEf522ANOr9OQGrN2kvif7BIWaLPrVXCfN8eWVF8ns2wtKoztbw4G0vJApPESyx1emhPl0dKs1sKQfKCLOYryO+QTirvLLbUQJvdthHsmvamzi5rX38HzeqsAGc/q1e+tT610dVpOwco5DTQ2Bjs/LJGQkNI5Ay9FYnRISvNtUqZBhfUrKiFRzkSK95A7XBWOeAQ/kDGUn2HmQa/bb6f/ZMZMeLO4U6rEifuZykeD0auNJjjZ1MHNchOt1sYV3n4tKsPM1Xi2Zf+w/7/s9kXoHHVW3GgIYuF02uX+A8OTqnhXddjtCpxYplK4Hi0lC3hfrZJMuLHFlgwcsLZJcIBRh3GTimc0hgN8XM342m8qveeN66/wIpTHFij7D8DyGK8MO2l1NJIEMQsfajM0cbLmKCX0TgV3I3fj4qf8t/7k1lV7AtNc1f2zf4flr0jKaIV1EEVDAKAIlpZ3rI+GTDyZZDaHrY5Z4aAcG6XZvTpBpFsOl46vgOSHrW8VRtQlBOqYAu1KBm61uL0mp5IjpcjU1S0l6dYdJ0FeYNUT7ufvyA6ToZ9aI4p3TXf7TTnEvjcen9KW430NJavK8qMT1aa8NvXqcFV+oC0qUY75N2R/ta6BZxvDZ4vqx0 OSo+DNvL ufzqUBRYxEImye6lm5I2N3MTrP6DoOoz5P/5/WOsNEru4uedrTkvn7cYyds4bnZPzBHKzaXlpXqi89mOxJMN0m0zEcK0EyFApsWw9VxW98RKl4w+guILeEZCERrnNMgIf7aAEfrzjVw9yTV1YKcy7Ex0W5bkidjYAQJj5Qw0v/tJ0KVSwa8Cgxh9DZ2snWv+1tlK1TC6zIQBCaRO+iCrrZZcVxZo2HAVYGGSfyxb+V8BtW1C4cyOMS62dZyOnYuQsRRyuI3ehZVT1plvel5zTRvnhUREjI7dIol6kQhfWbtrM9CPvzB140vP9aazhRjAkDiXolP5uH6ljG8FK7OIXIliqqrDpfmkETcdRwKnG0GaFx38j7SsaYaFfDKB1UIuc/1MoymanAFe4uEyQebTXSJBK+GQ/1mW0j4TbnDeNj7Hw+BuGOrJ03J9E6RmY0dyDeS8MACWZrxCtZn6fjLCUvXDsJe4bEJxBUDj7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001357, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 06:24, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > We can put off the flush action util a merging is realy coming. That > could reduce some unmerge page flushing. > BTW, flushing only do at arm, mips and few other archs. > I'm no expert on that flushing, but I thought we would have to do the flushing before accessing page content -- before calculating the checksum etc. Now you would only do it before the pages_identical() check, but not when calculating the checksum. -- Cheers, David / dhildenb