From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 614AECF6495 for ; Sun, 29 Sep 2024 19:45:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B6BD4900006; Sun, 29 Sep 2024 15:45:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1BC6900005; Sun, 29 Sep 2024 15:45:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0A28900006; Sun, 29 Sep 2024 15:45:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 82C29900005 for ; Sun, 29 Sep 2024 15:45:54 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EEBECAC0FB for ; Sun, 29 Sep 2024 19:45:53 +0000 (UTC) X-FDA: 82618806186.22.8EC5E1B Received: from bout3.ijzerbout.nl (bout3.ijzerbout.nl [136.144.140.114]) by imf18.hostedemail.com (Postfix) with ESMTP id 995FB1C0003 for ; Sun, 29 Sep 2024 19:45:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=ijzerbout.nl header.s=key header.b="Ww/MOM8R"; spf=pass (imf18.hostedemail.com: domain of kees@ijzerbout.nl designates 136.144.140.114 as permitted sender) smtp.mailfrom=kees@ijzerbout.nl; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727639114; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=K2c1JPr7TkQlxiBsiQVFWIbhJb3fC/HSB32Ss/2aCVE=; b=A9kWrDdtyEvcw4k9HeFm5jozShMK7+InlDjO+0OfcF6mc90msQQbuBHRUCJMhjJ8WBThWp QzvQfFsPEwxJ4EykA34q760FaAKxgF6hwBhqK6blR6IDqOmX40uUzkFPEo4dz8W1/OJJ8u bG7Qm2Yzv/5NLEPtAxbS4Me0sWgIgQI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=ijzerbout.nl header.s=key header.b="Ww/MOM8R"; spf=pass (imf18.hostedemail.com: domain of kees@ijzerbout.nl designates 136.144.140.114 as permitted sender) smtp.mailfrom=kees@ijzerbout.nl; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727639114; a=rsa-sha256; cv=none; b=Fr6ekKSvysyIay88gnA9UiZt9UjGOb20VKcesfLSyvwoBmRMv2Pd8ZSc/7ZgUQRrLLnttz a2MtJK8MvN1jI+dODWOvKItyple+GnqV52nlTLvzp20Y9g5JdcvxCJ2YWp0q0Nh9HwUwfa jssn9Eyyz6M/zMlvB54euJQ+/L2BpdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ijzerbout.nl; s=key; t=1727639150; bh=lLDXHndlLN2AGQyh1h7RqYpLTpU2JFoFieAtxm/FQDU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ww/MOM8RghUtJdB9kiePjL42q2jdeDwY9sOIcRyu8OwK6NQSZUmVvfjvZtiLA8OCC Au440KUtL0JGdnNJDJbhXTwXhgj7/tjqw0S1FiwqDAejLvJQXMadgTdbeMeHjYFGgh AxHo2nEDHA5dCdCNJ2oM9cFv83y4bsvc61Jn+736FyoLS4AcygZ0hkmTQnkUbF3vhN lT15Go1lsMPMZaKDsr4fs6Nys2rAqew3GI+XBF569aYtazVcQ+N+/0AcJaOALBwc17 NjhhzqoE9QWyDeS+iv641aqYSo3mRv/sScx49/9ARm3jxpcmCZgaCwVrgRf/3Ii/+l dwTHjbPBl2jWb1fsAMUFoPZ3r3yqK/RAlwRERq5d/NxQrfMk0BJwmWftmY6VYRKbFD kHQyKfe0X0kNyFn4xb6i3AtPy8SrcwnBX8EJUkRlrO7NR4Ly/ltnuDV0wvJaOQ7UOo 3H4IZMLfL589GVCHfRf212qZxBCN2CAjmAkOCPF6V+6liMlIAa5v6xzTaF6WO5CkmV 1szCAVMgOQtymc8UOp3z+NL8RKIc8YiFZVYpX/kQLIDXkmNwLVrLaT1c/FwtYsQhs6 DTd1yuLpa6Sd/xaQ03DIghI87JA0o3AhU1AXA0IbV5+HB1viggQwrzVShLnnk2Wj88 AwRHggGEt67O/LBpwAFvpBfc= Received: from [IPV6:2a10:3781:99:1:1ac0:4dff:fea7:ec3a] (racer.ijzerbout.nl [IPv6:2a10:3781:99:1:1ac0:4dff:fea7:ec3a]) by bout3.ijzerbout.nl (Postfix) with ESMTPSA id 26DCD168CCD; Sun, 29 Sep 2024 21:45:48 +0200 (CEST) Content-Type: multipart/alternative; boundary="------------Um12NfJEMqr5b966dxSv1c2n" Message-ID: <9c9586ab-0426-46c1-bcc6-6ee2927b7a86@ijzerbout.nl> Date: Sun, 29 Sep 2024 21:45:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH -v3 3/3] resource, kunit: Add test case for region_intersects() To: Huang Ying , Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Dan Williams , David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Andy Shevchenko , Bjorn Helgaas , Baoquan He References: <20240906030713.204292-1-ying.huang@intel.com> <20240906030713.204292-4-ying.huang@intel.com> Content-Language: en-US From: Kees Bakker In-Reply-To: <20240906030713.204292-4-ying.huang@intel.com> X-Rspam-User: X-Stat-Signature: q16b9qq3rigni3y4r88fkdyih5mcstkz X-Rspamd-Queue-Id: 995FB1C0003 X-Rspamd-Server: rspam11 X-HE-Tag: 1727639151-953931 X-HE-Meta: U2FsdGVkX18sM6U2LmYMqANcmUcpbmf6nI9FeZZj7FW/vfiotY6mWvvmJXjydDG9KBcAsbJnWPNpkMAXpM1kdFwIi+za4VqKq+pxfYq7de1i3dYEQwWzQx82p2dvwQwmASBrQ1CafUkNsOk9nB1v/8IlW1CdByJH/Eg3J3ONykfU5ClgxWD3e+cHdE7PTxOCxi2oWUJXHyn+WQhx91eoMkAVKNz53QbJ29wZQQEUFMKWMbqmB0B8REHLH6tXhe+urY/FS0UTVLI1rfJJIUpJUzN0ho4k9Rn+s3b6uArVCFlXt+aBoKjbIXLP63Yn7lbtmjDRJg7jkKTtk6H94xMS/pDJ06hyWh4sp88T9vroGkYuyRcCaOfqZPahryueuW+M+nDFyH+EbkzX9X9Ks9ATv/tzhVChYwDtbqrnK7myts2nY2fhKRiGhgUhLzO2FofS3s3PNtJgKBhgrdLr5P+GwswZi91MOdwIKZbCfj7nd4dEw2v7wgiPl5xf88G4+X8cuxdFHS3UjjV0hBIxrMoFBjpphOV450VBooGk6avbk0ZS7eu3YUQZZuaTTwVwMI4JQkUEtFfIHhBwacPPRjqppMGYcSIp8DSgjbs+YPsnV4KI1B2gLw969baxRIOv0sCbEXpBxHvEEtWSDBwtYfGp0OLYY3OjQovmHGzLS32d7DxrvSENVqSnKEcdV2PcBuWBZ8cOAOJXwSuspQqgq2I/qZd7+051TJWFtHMCAHnxoIZJYp9kaVOWHftEkl8nPrbkaqoja5Zk+Y1v3MoVjvHr+CCdUgSezcl9isMZLJty88R1u9RIveFd0KAiH6xXRUoL9swD323V6Ni2qDJgzWNg+GNUDb6qVLS+ahyDrjVMyxT7FTPZA3fxfNex4AE90+H0VgsW22G2AHqJbPrri5Kj7lYFWNwjULqnEPnf5xJy5pcDjFSrsZtTbmMdN98GzNycW/GaV+aKyEivox3RiNH xVdxrbxt PfpBQBZdwH5r3r10ASFOamT3tgfgKUen3N2E5zQ9c7jBe3g1DAmwLTcracjePD7T0nA5hnLc95lIV+829D0dx74rVzFDTNr3lzNtLSeKGzzAMFnYj9v9vQmzdUFRPaz7KE6Mpz+4ws8WZVwmnEf08ZYIyISVeqWUrYTbXQ8FtmdcDUXw/gemONomfnkSaRjbP6OWXmyqhG1IHgxa/0CctvnC4C4mST+oYyvfoyCrv/BR0gVuINsdsOdvsTX9tlSMqs/b9m3bZRzsIDenQvVVTxYlly/B9CJ0hJgd1IJyLBdZt+HrTIZ99JNDOVgUWI/OZQRMiDI8oCdkVvIOJm3Yb3OeK+BG9oYwW+++UYkqZVcMnOlTDVEqdKT26Z+DtSJ+JA4WFjgMhSmfYVM4xbvQDQ5WxaboCVNH1xDbehA7TBvrX8lUvBbp3T3desBp9/PGswxSy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: This is a multi-part message in MIME format. --------------Um12NfJEMqr5b966dxSv1c2n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Op 06-09-2024 om 05:07 schreef Huang Ying: > [...] > +static void resource_test_insert_resource(struct kunit *test, struct resource *parent, > + resource_size_t start, resource_size_t size, > + const char *name, unsigned long flags) > +{ > + struct resource *res; > + > + res = kzalloc(sizeof(*res), GFP_KERNEL); > + KUNIT_ASSERT_NOT_NULL(test, res); > + > + res->name = name; > + res->start = start; > + res->end = start + size - 1; > + res->flags = flags; > + if (insert_resource(parent, res)) { > + kfree(res); > + KUNIT_FAIL_AND_ABORT(test, "Fail to insert resource %pR\n", res); Isn't this a user-after-free? > + } > + > + kunit_add_action_or_reset(test, remove_free_resource, res); > +} > --------------Um12NfJEMqr5b966dxSv1c2n Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
Op 06-09-2024 om 05:07 schreef Huang Ying:
[...]
+static void resource_test_insert_resource(struct kunit *test, struct resource *parent,
+					  resource_size_t start, resource_size_t size,
+					  const char *name, unsigned long flags)
+{
+	struct resource *res;
+
+	res = kzalloc(sizeof(*res), GFP_KERNEL);
+	KUNIT_ASSERT_NOT_NULL(test, res);
+
+	res->name = name;
+	res->start = start;
+	res->end = start + size - 1;
+	res->flags = flags;
+	if (insert_resource(parent, res)) {
+		kfree(res);
+		KUNIT_FAIL_AND_ABORT(test, "Fail to insert resource %pR\n", res);
Isn't this a user-after-free?
+	}
+
+	kunit_add_action_or_reset(test, remove_free_resource, res);
+}
--------------Um12NfJEMqr5b966dxSv1c2n--