From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA26CC5321D for ; Tue, 27 Aug 2024 02:12:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 499746B0082; Mon, 26 Aug 2024 22:12:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 449686B0083; Mon, 26 Aug 2024 22:12:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 339326B0085; Mon, 26 Aug 2024 22:12:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 136B86B0082 for ; Mon, 26 Aug 2024 22:12:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B42A1C14C4 for ; Tue, 27 Aug 2024 02:12:10 +0000 (UTC) X-FDA: 82496400420.25.46F58F9 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf15.hostedemail.com (Postfix) with ESMTP id 1FBF8A0009 for ; Tue, 27 Aug 2024 02:12:07 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724724665; a=rsa-sha256; cv=none; b=UEvKcfpi+T8doX9/eaYKDcaT4llRntq/92xwQSNfFeuGmpTlUxiN/WbDqSBMOd6kBawl6q LXK41JZnZPfWmqCCfWehZJwg+2ubLODdfj8dx8g6/CQP8tK5dUpr4j61UIJKzmxAijbP85 h9mIzcGsVFyWeSBdv+IgMA+axYnLD20= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724724665; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Expt/tFyXYUXgXT2rgyqLT/J1m01vKaIYsVzu6vnFuU=; b=lwiBCiAYtc86xhVVr5Zy5tkKYGAOYUNIp+iRqK7Wxny7zu7AoOruWeD5/+/R3XYAJidC1Y HLSwq+IDWV+cLfZfEBvWG8YmIuqphrdWOBuRvRhMwBtxUXBDvChx6YWk1sysS1Gc4c9pth S78agEuhK38ZlEFzpHGiCdOXSRgmu7g= Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Wt9xC6GBYzpTj2; Tue, 27 Aug 2024 10:10:23 +0800 (CST) Received: from kwepemd200019.china.huawei.com (unknown [7.221.188.193]) by mail.maildlp.com (Postfix) with ESMTPS id CBC9C1800FF; Tue, 27 Aug 2024 10:12:03 +0800 (CST) Received: from [10.173.127.72] (10.173.127.72) by kwepemd200019.china.huawei.com (7.221.188.193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Tue, 27 Aug 2024 10:12:03 +0800 Subject: Re: [PATCH v2 3/5] mm: memory_hotplug: check hwpoisoned page firstly in do_migrate_range() To: Kefeng Wang , David Hildenbrand , Andrew Morton CC: Oscar Salvador , Naoya Horiguchi , References: <20240817084941.2375713-1-wangkefeng.wang@huawei.com> <20240817084941.2375713-4-wangkefeng.wang@huawei.com> <5a475005-e670-427c-b3a7-7e1fe7af1ec0@huawei.com> From: Miaohe Lin Message-ID: <9c930ecb-7d14-93ec-2fd1-270f935bb1be@huawei.com> Date: Tue, 27 Aug 2024 10:12:02 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <5a475005-e670-427c-b3a7-7e1fe7af1ec0@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.127.72] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemd200019.china.huawei.com (7.221.188.193) X-Rspamd-Queue-Id: 1FBF8A0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: ag98qbzma4rur1bhz7ub8145jwmrfwcx X-HE-Tag: 1724724727-9640 X-HE-Meta: U2FsdGVkX19wxei6pPMGv9hEyzHyGyxH/V0aeQGR7ePpAUNCUetqd9YWYMVl46FxOmrXWWDI7A92wx/Ks3EaIYaZgi1oTd3Ja4cz3MChXyUq1MA/4ZeGzGOGMMsZ8qJ+jYFuFqg2Jgwdf9A/6pi2wK2UPpBVlGuOQoi0zS2O8YlOHR51mMD+l73dXeAa1+7JKZOnIihF9E+5j1+BW35E8lMfpo/xo5Bvt6J/ZQe1ud/63upLFyVyBP61bZi1IoAbIXYyx8Hna8IoB9Nfe9dfA6iS1J4lb/yPSSCs1ZkMqPaOy1/4m6h5UQFNvFlTINFO9cf6ljo8RVH0Sj7BvWDbHSWCMgBTNsMZcJi/G/Mia1EQp8rYaTGJ9uqLi9Fu+V7Kk1TKbR5dLcIfsA2lfmGb3gUZYOKoLporJa14XmSZf0Q0PruOFVZdOv7zm8QKw8DBH+I3RbxlKwHQU889z77b4SkqKy69curdKzlMMHHm26SxxfTNGf6KuFJKz+6FclBGl1CkmWrhoOe8U/GBvELGKD2kqSfJxXDAlaSF4dRkzW5T5l7QwGuXxtn4C+CpyUeZmKtJTz9mUcMwcNPLO5o15b64mGG50re/gfp4DFP9LNw+VrIXPlBOtqGctJH1ufPLKPH6pnQlfK2nG5RFrCcq0Rf0xdWMvsvxvFOV/22HFNIa0lpgpoMHrofV7BEEjn1QwQixKjIvyiC0nxpollM0jWftETu0VN5GxiO9GRkps+mu8H3BxUAZRdOryYr4iZrvKLqWSMloSOl0IV1ucYWEPnfnpgtzKZIV/KSKQNxDha/SZYJ7aLGNjhFBSUr0J7dMQdD1+X8lI6MRTzbFrjU20zh3I4EqToEG6hgDdheqoSmAVaP3OY/rzdQqMWmnkSalEyESjrDo4njERO9bz1+9FK+LJ+l340zHf/Bo2wtOtZXOaiaYUbfc7AQ7mA9msheUMs+iqsz34nChQUCvbeN JaRpMgmZ 6xouleAkCt/sN/lG8dJLYJ6vI2NODVI5bjxaOjWD5zR4cL9AlGGiDGyW0N8+dIAahCmh/HLz6Lg2UC+UpLyqzmfOMVCz7dZTpoPHo97XR65SbkKYn3x6Y99+DqjtH0GjugneZ7ZC4uT7E1kd8Zty4D7H6R5nnyGI6kV9dd/+Ij9GmE7rmILf9Yg5cZg9njTZ3HS3aKFX5VKdp+HdbKfulRRCcp3IDjahBZakI6fILHmzNmTKoblIJ8O5ge6aH9DLr+CMyij0dUdH8fO3CkeWGBsb7NRjTUMOB2f9lxlpSCOsSxgU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/8/27 9:13, Kefeng Wang wrote: > > > On 2024/8/26 22:46, David Hildenbrand wrote: >> On 17.08.24 10:49, Kefeng Wang wrote: >>> The commit b15c87263a69 ("hwpoison, memory_hotplug: allow hwpoisoned >>> pages to be offlined") don't handle the hugetlb pages, the endless >>> loop still occur if offline a hwpoison hugetlb, luckly, with the >>> commit e591ef7d96d6 ("mm,hwpoison,hugetlb,memory_hotplug: hotremove >>> memory section with hwpoisoned hugepage") section with hwpoisoned >>> hugepage"), the HPageMigratable of hugetlb page will be clear, and >>> the hwpoison hugetlb page will be skipped in scan_movable_pages(), >>> so the endless loop issue is fixed. >>> >>> However if the HPageMigratable() check passed(without reference and >>> lock), the hugetlb page may be hwpoisoned, it won't cause issue since >>> the hwpoisoned page will be handled correctly in the next movable >>> pages scan loop, and it will be isolated in do_migrate_range() but >>> fails to migrate. In order to avoid the unnecessary isolation and >>> unify all hwpoisoned page handling, let's unconditionally check hwpoison >>> firstly, and if it is a hwpoisoned hugetlb page, try to unmap it as >>> the catch all safety net like normal page does. >>> >>> Signed-off-by: Kefeng Wang >>> --- >>>   mm/memory_hotplug.c | 17 +++++++++-------- >>>   1 file changed, 9 insertions(+), 8 deletions(-) >>> >>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c >>> index dc19b0e28fbc..02a0d4fbc3fe 100644 >>> --- a/mm/memory_hotplug.c >>> +++ b/mm/memory_hotplug.c >>> @@ -1793,13 +1793,8 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >>>            * but out loop could handle that as it revisits the split >>>            * folio later. >>>            */ >>> -        if (folio_test_large(folio)) { >>> +        if (folio_test_large(folio)) >>>               pfn = folio_pfn(folio) + folio_nr_pages(folio) - 1; >>> -            if (folio_test_hugetlb(folio)) { >>> -                isolate_hugetlb(folio, &source); >>> -                continue; >>> -            } >>> -        } >>>           /* >>>            * HWPoison pages have elevated reference counts so the migration would >>> @@ -1808,11 +1803,17 @@ static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) >>>            * (e.g. current hwpoison implementation doesn't unmap KSM pages but keep >>>            * the unmap as the catch all safety net). >>>            */ >>> -        if (PageHWPoison(page)) { >>> +        if (folio_test_hwpoison(folio) || >>> +            (folio_test_large(folio) && folio_test_has_hwpoisoned(folio))) { >> >> We have the exact same check already in mm/shmem.c now. >> >> Likely this should be factored out ... but no idea what function name we should use that won't add even more confusion :D > > Maybe folio_has_hwpoison(), and Miaohe may have some suggestion, > but leave it for later. Will it be suitable to be named as something like folio_contain_hwpoisoned_page? Thanks. .