From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8660FC83F1A for ; Mon, 14 Jul 2025 19:35:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CAFFE6B009B; Mon, 14 Jul 2025 15:35:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C39136B00A2; Mon, 14 Jul 2025 15:35:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B00EC6B00A7; Mon, 14 Jul 2025 15:35:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9714D6B009B for ; Mon, 14 Jul 2025 15:35:18 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 36E6110DFAD for ; Mon, 14 Jul 2025 19:35:18 +0000 (UTC) X-FDA: 83663873916.15.CFD5041 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) by imf22.hostedemail.com (Postfix) with ESMTP id 74D3CC0011 for ; Mon, 14 Jul 2025 19:35:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=gRPf0f6N; spf=pass (imf22.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.161.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752521716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=KJCe0uafwWJcjAjBLJm8eV2mzcLBkCS614s8l9BK++c=; b=Phv2KX6kOz3J3DPLnonJNiDrLdlgZM1vyCjS7xYe0L6Xc6m6rh0hSgJrjBOnMvxb7OXfJ1 G5Drqz3JfPpMjr5hqvjRHYvbfkh1dP41Ak+GsCXGSnOTvpQBI9LrxwOl0E+zb2FyFeXNG+ 1HIZKwbd5tZcw2Ixg4ZrGMpwx0VA2Gg= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=gRPf0f6N; spf=pass (imf22.hostedemail.com: domain of dan.carpenter@linaro.org designates 209.85.161.47 as permitted sender) smtp.mailfrom=dan.carpenter@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752521716; a=rsa-sha256; cv=none; b=Ijf3C5tBGqrB9ptU8YUN7B70pgvGZGOHslQ23NrijFx8vMJinvpF3mX/XQYZ3EYcyMDVrO 9rgSE1n/Nvnj0c4DHSWRKkCFgycw3umYTv4uLP1Vg4Er4JfbE7qzbLjY/o7hyIm1ZHs2Ir dATGzd35c5eRTnohE0SuGLS2dNJpAVw= Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-610cbca60cdso2540096eaf.0 for ; Mon, 14 Jul 2025 12:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752521715; x=1753126515; darn=kvack.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=KJCe0uafwWJcjAjBLJm8eV2mzcLBkCS614s8l9BK++c=; b=gRPf0f6N8J4LgC2QGUcK/1nYcKoTkQcZD5Z8g/lIcc6sCkEU+I/H8aNjXH/AI+XLQK uzrLChNtOj+Q8HRwsudVaV1SuaUNZN09lwL8pPu3jd6Hw8jfEeZnk0uHO6FkjndLg4TV BXzjY2tE3XWckm9K/N1eSlxo1vLARKkmgDarh7WNnrjpJuQjfJ9oAEHCMkC202WgpVDr s83m6opE9XrFeQLHShqYHZly8uf03HDjQmZ+sjluFO7IIEWx7rEWWNeJeLqmuAH4T1mc mJYuQQPIhcBIQDo6TbfopB6squjTnBhmeCvYPsEqFniEoQjCENjvcQbOgKdmmb3321Qc 50sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752521715; x=1753126515; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KJCe0uafwWJcjAjBLJm8eV2mzcLBkCS614s8l9BK++c=; b=KU1ImKfnXKZc3ADRMmqGpcaHZcJ2SLsScgVV5S3d3yKYFjj7Ed19zSzR1LbB8X3QQS QGYb3yJY6ZmeMHT5rKQ4LnaIStLqzj2B1xBTIxx1gEsjVT4Ph0y02CmsiDq3tBi+75Nf u/RRMdzbdYFm0NX1YYLueqdwOQG2NV1w9clmZsVkNtVPBi7m9BGCN6/39OORj4jfAeGh U3PZnntkNyNKmg+guIL6mNEB6i+KnuUSdVjyVfxslILAx+qY6UrprSUatms1JrUNxiMX pW/9comgvKn7YR8sZHN8STdZLMQWlxaBKp2/ZoKkJefJObbcuWBF16ZMk7f/5ZAtixka L+EQ== X-Forwarded-Encrypted: i=1; AJvYcCU7AKgev4taaH37oP2pmIt/xhZYWqykdJwP3nXJrOGDYq42g3ErRKUX5XnV3BK4V4YgXFsmBQJnPQ==@kvack.org X-Gm-Message-State: AOJu0YwlCBMJjfuM2MmF56IG23aGK7AjGR6OYwLNtn/x3tjn1zBinEp1 IEfLJ+M3s4uJjZ0Ly+72iDYDuE8DwQmpAENvq5oBaJBnfwouQHbiPwA+mN5aOBa7roU= X-Gm-Gg: ASbGncsgyxQ0xtRBcckAPNWXWKyMaB2iAmasDcCqKWJbC42z91epx9waABOsTRBwqIb 4JR08p6U6a4qHT7yj+lbCWDrQlW46FtAFdiFkJzbJuPSoO+ws7Zs9Ver0LtsadhwSYiGikYI5Zd EHzClTUxN6cZACzDgTZo/j4ob6X7EUfx6C89iBPmbZfAnc+pyntDrzQDAMkq6yChlkn7d901pSZ SAl+Ti2egyn87GnIuPUuCLS8iP40B4ZUG7pJhMVr1QZ9ac4qNRiRPNAkv3IjQHAjZT4pDgjj+pm 1jywgM128615rBQIS3Sz20hb1zhcrZSIiSIb9ZoI1MRXJm0/rbXu1RAOUxQKTYD4J+j8dcBN3Ro 5ZUEx3JsgBxJTb9e3ZeOzENKu3m3xgr3vNlRQYn0i X-Google-Smtp-Source: AGHT+IG+HyZCdbJbsjUqaaRoAPcY8h13dOn2T4hFLwqcOwO/rH5cPhcrBnvzZPiesDDwPnJftqqQ0w== X-Received: by 2002:a05:6870:4584:b0:2e9:fd62:9061 with SMTP id 586e51a60fabf-2ff2715f4c1mr10463782fac.32.1752521715068; Mon, 14 Jul 2025 12:35:15 -0700 (PDT) Received: from localhost ([2603:8080:b800:f700:6bb2:d90f:e5da:befc]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2ff11732c6bsm2037502fac.48.2025.07.14.12.35.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 12:35:13 -0700 (PDT) Date: Mon, 14 Jul 2025 22:35:12 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Lorenzo Stoakes Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List Subject: [akpm-mm:mm-new 203/214] mm/mremap.c:1829 remap_move() error: uninitialized symbol 'last_end'. Message-ID: <9c8287d3-59e9-48c7-8504-bf51eb3d5a50@suswa.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: ufb9xeb1au64xkiteikoggoxbhjteas1 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 74D3CC0011 X-Rspam-User: X-HE-Tag: 1752521716-176607 X-HE-Meta: U2FsdGVkX19Mi7XwNYpxCgX1N9ECyiYWPCwB4tmWDhOrvYaga9mtlKpmp5cjYfjEngVATao/54NpSDdd18Ct6TVSyo0XZ8rZL99yYBHp4cNlb7wA6rB5XSK2f7x/lPxVf9ZB1L1W7mNgg4qLSXTPLowK9f4fVYgcqGvX0JaKlybJolvsKKZv3UzjDLWZa+qnhsdGvq89Fl4oXsYfg0Z14ydjoReXGFGEtg9hjxezafZXWfi5LCsf1nLm5B/lx49n1n1KVAyQMau7rKpXja5pn+kODqZOF1IR1FvPPEDafYSsMycEVwO66A3uAQduWMT+74Y1lEEkdyIFlCXhmrSIwbn0TzhqZ5F6ttNVoTFdrdQLKzKNX8zBeghcjEG5w4VvgJANgq9T68nMNJsWkGc5Oj3hf+oAB0AN/USweEc82FgVVE3EYx9dAHrbhlYUV+qStfTMfHU27wzE1kuE5StG5cJYcPWylA66ZukgSLVs7LepX2nqPuo/bk8XqYUDQh+5HU8BZFOOFfxtFQ269/DcFsAIk14WUKQ6QkVTVY1WfIcXC5ML5tHz/GWOLQ/ZMvjuQTiID5e46cVlhk6Ho6HpADGTHyMC4i0hudz9r1cS9wnD5yXc4PWXZzZokZqUml5TJ36Hqz4ViQZhzk394qUbtURAiJz5ryHNl6kEaNb8jZ8P+BSewiuSq2HMyMyOiJZb4rmcghFNSCohbIL3a/9IsHIspT2lBZj8G1dQc+7AYFU05hE6Nbl++W1010yxwQY1x2UDqOi/uzd7jpC5vwkGaoAXXehiEpHmVs9yH7Yr0xLbHIOeccMGLJ4u+JAeclNFVEdpwW5DXQmOuvC0g8mBB25ydSPwLz2kJsHtH4J4d3vWlrEFbaB6hSJt6Ue0J70l2/Qm568kvgn+x115hQiYcbBr9omzJqYUh929Njd1lp6nKHh+3Hx04EXWtGh4ISmE1beAX8P4OBMB4ks4NRt 8EvJrKZX 9JjCpXHhC0pcWCJGE9Xn2sIHqjpXUjZWupRqiYFWk2BRLtGp6knFZPLLOO2BsfZHeCJbwvmKmw29WyDR7vbfnST2+KbK/pjgaYHkFyvArBly4fCuX/xklJFk4mjGHxpGP0NdOVywCt912NAxiBpywloUUUQfzPjRjsPRxev4QCzedhMQGA3rN4VTGZEDTU6/EKXrDk/ML1o3TDzJeBU5/hQPlqZUTuIlLx07cdXZj00ShsfLQRSuQafQjzvvMJUek5N4g6oblrUB8tbHLLkgo6Lwh2SXXxp1mJxQsK/Ivl623LdR6Th79k6H20kCCFHU3M7pzCFkUZ77JeWluIT9RGvB1SS9kif0c8wjwkWxOi/wur9zTc7SmxnzNVjjcZzEgbwjjUIteG2TQFDLHCXQNuJwpckv3JYGW7l3AYEAm+sDcYtoJNcY6jF5IBteJV7yDu6fIyP/sWFBZfD9fXIxwTHquJ3KIulq3awr70HcudOjKjmTN5y5H2UXfkzxLyNh3Laiz0ElC6bdleVU7iGopZTJGdAaayG2ulaX9oGi2HZNTtKFLTOYJfAEPkw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-new head: 9911a6d0676c211ea4df7eb8fe82ee6a0bb64fb4 commit: f1d4bfd28bb6e2e82f5fc58c7a0e17b7e15bba29 [203/214] mm/mremap: permit mremap() move of multiple VMAs config: x86_64-randconfig-161-20250711 (https://download.01.org/0day-ci/archive/20250712/202507120401.DCzwzjow-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202507120401.DCzwzjow-lkp@intel.com/ smatch warnings: mm/mremap.c:1829 remap_move() error: uninitialized symbol 'last_end'. vim +/last_end +1829 mm/mremap.c f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1785 static unsigned long remap_move(struct vma_remap_struct *vrm) f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1786 { f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1787 struct vm_area_struct *vma; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1788 unsigned long start = vrm->addr; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1789 unsigned long end = vrm->addr + vrm->old_len; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1790 unsigned long new_addr = vrm->new_addr; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1791 unsigned long prev_addr = start; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1792 VMA_ITERATOR(vmi, current->mm, start); f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1793 unsigned long res = -EFAULT; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1794 unsigned long last_end; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1795 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1796 /* f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1797 * When moving VMAs we allow for batched moves across multiple VMAs, f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1798 * with all VMAs in the input range [addr, addr + old_len) being moved f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1799 * (and split as necessary). f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1800 */ f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1801 for_each_vma_range(vmi, vma, end) { f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1802 /* Account for start, end not aligned with VMA start, end. */ f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1803 unsigned long addr = max(vma->vm_start, start); f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1804 unsigned long len = min(end, vma->vm_end) - addr; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1805 unsigned long offset, res_vma; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1806 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1807 /* Merged with self, move on. */ f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1808 if (vrm->multi_vma && prev_addr == addr) f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1809 continue; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1810 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1811 /* f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1812 * To sensibly move multiple VMAs, accounting for the fact that f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1813 * get_unmapped_area() may align even MAP_FIXED moves, we simply f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1814 * attempt to move such that the gaps between source VMAs remain f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1815 * consistent in destination VMAs, e.g.: f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1816 * f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1817 * X Y X Y f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1818 * <---> <-> <---> <-> f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1819 * |-------| |-----| |-----| |-------| |-----| |-----| f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1820 * | A | | B | | C | ---> | A' | | B' | | C' | f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1821 * |-------| |-----| |-----| |-------| |-----| |-----| f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1822 * new_addr f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1823 * f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1824 * Now, new_addr may be altered even with MREMAP_FIXED set, due f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1825 * to e.g. alignment changes from get_unmapped_area(). f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1826 * f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1827 * So we map B' at A'->vm_end + X, and C' at B'->vm_end + Y. f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1828 */ f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 @1829 offset = vrm->multi_vma ? vma->vm_start - last_end : 0; ^^^^^^^^ The "last_end" variable is set on the next line. I don't know the starting value of vrm->multi_vma so it's possible that this is a false positive but it seems like a legit issue at first glance. f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1830 last_end = vma->vm_end; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1831 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1832 vrm->vma = vma; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1833 vrm->addr = addr; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1834 vrm->new_addr = new_addr + offset; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1835 vrm->old_len = vrm->new_len = len; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1836 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1837 res_vma = check_prep_vma(vrm); f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1838 if (!res_vma) f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1839 res_vma = mremap_to(vrm); f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1840 if (IS_ERR_VALUE(res_vma)) f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1841 return res_vma; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1842 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1843 /* mmap lock is only dropped on shrink. */ f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1844 VM_WARN_ON_ONCE(!vrm->mmap_locked); f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1845 /* This is a move, no expand should occur. */ f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1846 VM_WARN_ON_ONCE(vrm->populate_expand); f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1847 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1848 if (!vrm->multi_vma) f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1849 res = res_vma; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1850 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1851 if (vrm->vmi_needs_reset) { f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1852 vma_iter_reset(&vmi); f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1853 vrm->vmi_needs_reset = false; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1854 } f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1855 vrm->multi_vma = true; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1856 prev_addr = addr; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1857 new_addr = res_vma + vrm->new_len; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1858 } f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1859 f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1860 return res; f1d4bfd28bb6e2 Lorenzo Stoakes 2025-07-10 1861 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki