From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2E1D1D879 for ; Tue, 15 Oct 2024 15:42:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 450776B0083; Tue, 15 Oct 2024 11:42:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3FF456B0088; Tue, 15 Oct 2024 11:42:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29F686B0089; Tue, 15 Oct 2024 11:42:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0DF2D6B0083 for ; Tue, 15 Oct 2024 11:42:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0A74240698 for ; Tue, 15 Oct 2024 15:42:28 +0000 (UTC) X-FDA: 82676253618.15.2DA7726 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf24.hostedemail.com (Postfix) with ESMTP id 6C7DD180023 for ; Tue, 15 Oct 2024 15:42:29 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dAuKOA0b; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729006807; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yCgrahaTrhKOIckAKrhaa+/bWy4C0fCSk2G7dPS9pHw=; b=DjFnQCjjzqCC+NbUDvQqj2kRXuN51WIUAcuk96gCuDAefN+xfoWjjnsEpS5ABr2t0hDNI1 pGeZZE8yh6N+e3GNr/mW9CjooJDLTUrUN0qQ41TOZiOnrxHRTj74bgXgWJzLQesXIn7tF2 FTHwXzmDb4aVzwfdPfnP7gQQfdx2Oxs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729006807; a=rsa-sha256; cv=none; b=xQt0lGuBjWMQJQBNuRe/U9KG7XJhvpqvQ6DTsG0Tr9fOVYzF7iPQZarlxnQV602+rtAvrr i+DxmbrqDkLrbiCa9js1UEkEMddX75+Frg5Jf2hvfSVNo5Ue4b4UtN0K5zXX0X1RL3K81/ 9TCHRyAvMRpOaIrWQzsByIHVhy5h7XE= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dAuKOA0b; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729006950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=yCgrahaTrhKOIckAKrhaa+/bWy4C0fCSk2G7dPS9pHw=; b=dAuKOA0bNaK+uKDpcb4adxG7/4D9XwfIb3rko5JHEOrkSMl0W0cghNK4ltOhUb3aDg+rih JHiQ8W52IlZXnLuNC1d0/3kngjuJUlGvDu5o5coYF+7zMFGGtJ3nBXUyHZu3PmXVX9yBJ3 8vUH0yHcpr04m1BMr6Z4pmIOhr4qg3s= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-417-aYkyQWDlPJm4CLB8wisFJw-1; Tue, 15 Oct 2024 11:42:29 -0400 X-MC-Unique: aYkyQWDlPJm4CLB8wisFJw-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-539f7abe2e6so1998663e87.1 for ; Tue, 15 Oct 2024 08:42:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729006948; x=1729611748; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=yCgrahaTrhKOIckAKrhaa+/bWy4C0fCSk2G7dPS9pHw=; b=Bxbj/skoG4oDpda536lHNqcCwCT5DKXI5ooIryJWPPqeJHitjccrCq5twxQ2Zt5TrI UYME6pvy2AYEtkdFLZpg8EWpKXwCMKrRBo8a/aKEkOVxSfUoNy8QfbF6s2Ztt5OC5JsW obRgMhFyfZgDiCJzdlAk6E1AvvZ0wfC+EMxnpaMnWDr2W1d2Y4oGL7yYSW0cIVZCpQON v9aszRD3mf0cD1DbljIXxrvmRu1ohdUb9I0ev/Z0U6rskcAnSW6mxHeMvBW+dPPh2K4t LGBud7facU24oVCfGkHZBbe8rdGjeY4IgUqPZZfmSlu3/oqeVp9NHe93aaBKLdMIEuVL LV4w== X-Forwarded-Encrypted: i=1; AJvYcCXky34bOyeDu0D6yCTUqPZZlNw6qvCOjwy99xfdQPbynCELfGeUtt9uVx3idDFEGxtTW51vIFo2Hg==@kvack.org X-Gm-Message-State: AOJu0YymeQ66KUksnuOuc9DRIvnGOjuIzzVXYu+o3KGohk2rMENGoHFI WB+v/VsUMQHPALXlCwBs29VxlU53tYRosNdg1eIPsKvsfIrij/xI4jDYdpFrCvZEANnxjUwnTm6 Xr5C4k8ZxKJWro5s9DL00EUR9O440dxnf7uccAmhcttpneVm7 X-Received: by 2002:a05:6512:12d6:b0:539:93b2:1372 with SMTP id 2adb3069b0e04-539da5abc99mr8383598e87.51.1729006947812; Tue, 15 Oct 2024 08:42:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHVW574cmL1pxEgo/iF86oTmZutmZL4ggDc0SlBni3S0Liv2hijpNUZb737CpeKdanAF8RWIA== X-Received: by 2002:a05:6512:12d6:b0:539:93b2:1372 with SMTP id 2adb3069b0e04-539da5abc99mr8383548e87.51.1729006947295; Tue, 15 Oct 2024 08:42:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c730:9700:d653:fb19:75e5:ab5c? (p200300cbc7309700d653fb1975e5ab5c.dip0.t-ipconnect.de. [2003:cb:c730:9700:d653:fb19:75e5:ab5c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4314209688dsm18864365e9.14.2024.10.15.08.42.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2024 08:42:26 -0700 (PDT) Message-ID: <9c81a8bb-18e5-4851-9925-769bf8535e46@redhat.com> Date: Tue, 15 Oct 2024 17:42:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/5] alloc_tag: config to store page allocation tag refs in page flags To: Suren Baghdasaryan Cc: John Hubbard , Yosry Ahmed , akpm@linux-foundation.org, kent.overstreet@linux.dev, corbet@lwn.net, arnd@arndb.de, mcgrof@kernel.org, rppt@kernel.org, paulmck@kernel.org, thuth@redhat.com, tglx@linutronix.de, bp@alien8.de, xiongwei.song@windriver.com, ardb@kernel.org, vbabka@suse.cz, mhocko@suse.com, hannes@cmpxchg.org, roman.gushchin@linux.dev, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, pasha.tatashin@soleen.com, souravpanda@google.com, keescook@chromium.org, dennis@kernel.org, yuzhao@google.com, vvvvvv@google.com, rostedt@goodmis.org, iamjoonsoo.kim@lge.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kernel-team@android.com References: <20241014203646.1952505-1-surenb@google.com> <20241014203646.1952505-6-surenb@google.com> <6a2a84f5-8474-432f-b97e-18552a9d993c@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: mhoifs6py5jfcy46qat8b9prha68rwqp X-Rspamd-Queue-Id: 6C7DD180023 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1729006949-137340 X-HE-Meta: U2FsdGVkX1/O1w06XFJ3QRQuUsGBWkvy43QXt7GtsxrKp1dGnEJQlpXJY6n+v7AHVVVAaqg4K+wUSbIuDibcRyXsftn0vhwOkoNpkIhv/izQUkvnQH9xcohnWWEiOmG+nwSY+TBUtP3zwoQjJMWMrmSb6Fp8Z4ne05qA0zUO/Ke9PFh9pyH+ctYejsSh2GGC6hUIUpYpy5UM+VTAAeMIXfG3mry+ltFnEAsFkgtka8xe7+VJqQwvpLK6oKQBtHiWMpKIDOv39XiofyeuAzfAYVe8iLp4BlVMB+nQJFKA8f3ojjJh0rFNEFqZyud4quTOrJFWAKQiycfbq/LTUTY92IcEW+Po5k2rGGDZUHiQ51vBZhdbIi/sDvQKJ8WtTUeWH1LBbRH4HDypUDS0dM0/radt0r8xR2C3YC4jLhbvFLZ7cJd153rcdKmtRgOhRxyq7w+WtTByfD8CMYXZ/OYxqgOyxCbsCB/7GZ8nQK2Fuy2OQ7DqT1zDB8l1f1SybwvaNn22k+DgzfXOgdAC9CwTIDerglOnkWO/pHbGEW+pH+68xEUBcIjoccF9U3W1owf/DNrR2SZ1AZfYziWoZvtUmWun1opBGB06ggsu0tp8KB2DzHc9b8vZEyfGVx+sdf87s3uk2bUAF2M+v1J73mtvn5NFtmm07tZulkRmmXpMqDb4uFdjsREl+m6z0LB9DUQk1vtJUMxVc2BY2jHD6YvYTlvZiHNLY9JD0JrIDQ5mK2ud7VjiM0yM3SBT+ngQrE7RJlIhyFRTLUzMdK1Heggk0UaVkDwtcNxcgN9PPLe5hmgM9CaaRvY78O2/U8uuVhvyrzuSifS4uGOQXph+iDbYZHI+cx9dWb8CA0qq0CiSiGiwiVWs/UelbhPgX0zix1VKZT9YW56PuBtNaiupoThLGNAC3JSyehC+0izuurTo31oQl7XE9qMGXTUNBshHtgr9xeU/wH7nPvYYc20CHQl VLPX42RK k+xCEaPVvpT/r/ilopGjKlwU3WhBC7Dvui39zFVz9lUCq1bdNqJLx2j0FRsmTSUiI8l6moOMMRj/lMZ3sQLVMkUrKUDY5AdlU+d9ndhnaWuUXFB+yyVH3LpguRlHRtnA8bEdgedX/cBSw9xmCrGbh1nFO/igzORzWun1Me5lvR8Gn1BH9dv6WMEqsRMWVKQ4h0g9Tlerlepvf17KVFWmKQh3PZHTLaKvH/WJLGcYuqPWc0LldP9hrQ9BPwJvXsMKT8fFgPeYZfXjd7Qw7GFDjRaWvScIKuu2vZauRfJNvtH7czs/ZDnWdzQCDtMq/0qh7iEf3zo0Huyk+jSaNU5GZVJZ9w3SYu2qZ9xSE2dhrZhYxq1VUnDlU3IntV6nfc9FGUfZJ8F2/J0znHiVG2s7XySelFR4ufDldrbKBT4qyEdpuTn27151tuwjSDAq0RWf+3KdkkWbnmGmoR/AmbelNYKayv7r/L14d8V/TDkJc93+1LRhj0bOHBEmHmD2+4PHWxM5UidYqj47sqSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 15.10.24 16:59, Suren Baghdasaryan wrote: > On Tue, Oct 15, 2024 at 12:32 AM David Hildenbrand wrote: >> >> On 15.10.24 01:53, John Hubbard wrote: >>> On 10/14/24 4:48 PM, Yosry Ahmed wrote: >>>> On Mon, Oct 14, 2024 at 1:37 PM Suren Baghdasaryan wrote: >>>>> >>>>> Add CONFIG_PGALLOC_TAG_USE_PAGEFLAGS to store allocation tag >>>>> references directly in the page flags. This eliminates memory >>>>> overhead caused by page_ext and results in better performance >>>>> for page allocations. >>>>> If the number of available page flag bits is insufficient to >>>>> address all kernel allocations, profiling falls back to using >>>>> page extensions with an appropriate warning to disable this >>>>> config. >>>>> If dynamically loaded modules add enough tags that they can't >>>>> be addressed anymore with available page flag bits, memory >>>>> profiling gets disabled and a warning is issued. >>>> >>>> Just curious, why do we need a config option? If there are enough bits >>>> in page flags, why not use them automatically or fallback to page_ext >>>> otherwise? >>> >>> Or better yet, *always* fall back to page_ext, thus leaving the >>> scarce and valuable page flags available for other features? >>> >>> Sorry Suren, to keep coming back to this suggestion, I know >>> I'm driving you crazy here! But I just keep thinking it through >>> and failing to see why this feature deserves to consume so >>> many page flags. >> >> My 2 cents: there is nothing wrong about consuming unused page flags in >> a configuration. No need to let them stay unused in a configuration :) >> >> The real issue starts once another feature wants to make use of some of >> them ... in such configuration there would be less available for >> allocation tags and the performance of allocations tags might >> consequently get worse again. > > Thanks for the input and indeed this is the case. If this happens, we > will get a warning telling us that page flags could not be used and > page_ext will be used instead. I think that's the best I can do given > that page flag bits is a limited resource. Right, I think what John is concerned about (and me as well) is that once a new feature really needs a page flag, there will be objection like "no you can't, we need them for allocation tags otherwise that feature will be degraded". So a "The Lord has given, and the Lord has taken away!" mentality might be required when consuming that many scarce resources, meaning, as long as they are actually unused, use them, but it should not block other features that really need them. Does that make sense? -- Cheers, David / dhildenb