From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93168EB64DA for ; Thu, 20 Jul 2023 06:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1416B2800B4; Thu, 20 Jul 2023 02:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F28428004C; Thu, 20 Jul 2023 02:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F23272800B4; Thu, 20 Jul 2023 02:09:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E2CA828004C for ; Thu, 20 Jul 2023 02:09:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8CC05B0610 for ; Thu, 20 Jul 2023 06:09:35 +0000 (UTC) X-FDA: 81030963510.26.C8652EF Received: from out30-113.freemail.mail.aliyun.com (out30-113.freemail.mail.aliyun.com [115.124.30.113]) by imf29.hostedemail.com (Postfix) with ESMTP id 7DF6C120020 for ; Thu, 20 Jul 2023 06:09:33 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1689833373; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1WQMH4Ov7vMfgpWkWZTsjpjYRxtzW4RCBf90Xqi/JoM=; b=LUkL6YmMap2N1E5r9Du4k1JjowzMqJa8yPf6tPk0iEzpYqJ02vDMWItw/+vnh8eI7IzyIe f3WuPvjyMIKgD/rF2vNrW9dJ5nYJiH/6AsMQImZ79wa+KF2DKm8AkIF8uhPXtdK2OeeDL7 C3aFMymHtqmAmveYKGf8Nuqwe9qxq2w= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf29.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.113 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1689833373; a=rsa-sha256; cv=none; b=n0cuVtevLbwk8KVrWtABdnXGgrTY1pqJdXRcYXgGOwHdiEd+RoiM9U7qV4EvbFYFpndfpb j4sJmaqBCxKeTdIxuHVq1U1MXfW1t+1jq5PBRMVQEXOuOZRAz7rke1Ibpu47kaIVJWLyAB XSJ/R+NLZloodk9rLbg1N9CQezYAAtk= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R941e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Vnofr4u_1689833368; Received: from 30.97.48.52(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0Vnofr4u_1689833368) by smtp.aliyun-inc.com; Thu, 20 Jul 2023 14:09:29 +0800 Message-ID: <9c6efec0-42ae-6b48-dd42-0ed7a0d5544d@linux.alibaba.com> Date: Thu, 20 Jul 2023 14:09:49 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/2] mm/compaction: avoid unneeded pageblock_end_pfn when no_set_skip_hint is set To: Kemeng Shi , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230720115351.2039431-1-shikemeng@huaweicloud.com> <20230720115351.2039431-4-shikemeng@huaweicloud.com> From: Baolin Wang In-Reply-To: <20230720115351.2039431-4-shikemeng@huaweicloud.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7DF6C120020 X-Stat-Signature: 6spsris7919hw5agatwk4xpof4c11gbu X-Rspam-User: X-HE-Tag: 1689833373-624749 X-HE-Meta: U2FsdGVkX185ufxY+mBacw5+nfztualUbmxggdZL68RJvP8ZydMkaoraegW5QWQiF6ea8V8g6iYkUHbzAuv6DaVs4948Y659lBLYJ51w4WG5nz9WYGqqdYAMyTTRUJkdxZm0sZu69gox/F/2d5jdR1JxSarL2Dqib5htNlW9Zy1dfsGVloH6q7sj3ATnzUGDVFZvXH8eImCYWat+9e8ETIRG9rOU9jRdykANElrXwiXr3zQm+KicApH2G7u8Btf0e6w1J/LRzEI1UR9TYGgUEAoUIvlHwT0OzZAiZmyTK1LLMH6CtAppD5vQpcWCZ4hLv2/53g7z7DCHnkXOaEsGo570NqCfWIG6JpBzkl6crXZNPXP9Sid8HH3zJt/iRT66iXT+SuQpYpKz8HIdmDg1SyzFHicfYo92sRhe95gCBXYRdErIdISPdOklnuvhKfgC2xbR6Qe5pLS8pIz0/poUKePoLo8MwaBDQJx60b5uvayrGS4HXpNgEd1Us/QbgqLRIwSya+y3NJuEfRKb1otVZppePx0ic9py7wUj42MdTQsAVVcLioaB4cQiPqce6m1cnFUGybgLBfLniI5Va1GmHnStwGfKuHZwgbOMro3jroHZYMRXRLBe/0LaOVLs08FbtliOEyBVtIxX1AkVQd/wWrAnd85CMw4c7dUl5EGZ77m9lF7dl0x4/UUqTrgLhZeZbM7PzPhTAXeEibUx1u52wMljxuENA8072NBWqJ5dzKezS3jteJ8p2th+U7+4gdV8YEutykHhNge9O7GytCrTzcxjAfXOsebXDH85Bw+qQsYSduVbM2srwWWP7kZI4xVdO2KRtKAlwQR/Qz7hQg4rHQwxTKbDbyhrfonoNBppXGy/D1v16mnIJX6hXzeenNnzghBHqPB8I04VYvpY1rkqUVWwoMcVV9CQ8XFTc3JDNSq3Le9wzdM9iD+ODNUhiDKs51wCQNkksD31Mrl76fY L0I56DaP sbS9yWRw5gGuQg0lC/KxNNmxPpuQSSfVboPaq+FfHLMUaOb5dnQzvJERA3//99afSpHIC4/48OX7FEwWJxm5od798C6asAOWcPMMBrOmLGj4tWg86p+rCjBeISc5CB6cBB29xgr2R0MdolfV0NQ2heItXGMkYdplk6cUqV+lbNVoONO/PGV6BRsr9/7GSeFZYaS2i6pqeByhGonopxrlw2o6EJaspCpEW0FcMGfIcHF34yao= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 7/20/2023 7:53 PM, Kemeng Shi wrote: > Move pageblock_end_pfn after no_set_skip_hint check to avoid unneeded > pageblock_end_pfn if no_set_skip_hint is set. > > Signed-off-by: Kemeng Shi Reviewed-by: Baolin Wang > --- > mm/compaction.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index c0d8d08fc163..9b7a0a69e19f 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -458,12 +458,12 @@ static void update_cached_migrate(struct compact_control *cc, unsigned long pfn) > { > struct zone *zone = cc->zone; > > - pfn = pageblock_end_pfn(pfn); > - > /* Set for isolation rather than compaction */ > if (cc->no_set_skip_hint) > return; > > + pfn = pageblock_end_pfn(pfn); > + > if (pfn > zone->compact_cached_migrate_pfn[0]) > zone->compact_cached_migrate_pfn[0] = pfn; > if (cc->mode != MIGRATE_ASYNC &&