From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9CE2CD1288 for ; Wed, 3 Apr 2024 08:13:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16E176B0089; Wed, 3 Apr 2024 04:13:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F84D6B008A; Wed, 3 Apr 2024 04:13:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E64E26B008C; Wed, 3 Apr 2024 04:13:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BC2376B0089 for ; Wed, 3 Apr 2024 04:13:35 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4AC551C0F8C for ; Wed, 3 Apr 2024 08:13:35 +0000 (UTC) X-FDA: 81967506390.26.45BBA3E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 12176C0002 for ; Wed, 3 Apr 2024 08:13:32 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=clQ8ABpE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712132013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BdVP1mpxTOuI3IwUquFLNg1sOnbLVFcePKHywg/tQHU=; b=aO8LD30DUBSV0p8NsQMY3M+j2RzJOpmFZigJxNUV1IC2NwyDWTT+guVzv2BnWgnVXWWd+D g+9iyor4twOxB6po7HL5XfLJ3icf+TKUQ0uC18D6BnDKKOMFgp9IrmpncKzgyxAiPBAWzY VwiebpYoki6kmopeHyfDRZnlXuG+Ags= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=clQ8ABpE; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712132013; a=rsa-sha256; cv=none; b=n0QSY9OucTH5E1kQh/T1rMeCHvrKxw6o4m5/GQo0oYUNdDJL4os9V1sF1EN6rd1qH4L84T XE3thYaY3PEIKw+3zOLxCQMw21AxnSuzpamMT1e+7JJS5U1lZK1KQeiUJomqcpOfb92nrM VSOEmN9KpuILS7BOZIyFHtahaBgNjHs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712132012; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BdVP1mpxTOuI3IwUquFLNg1sOnbLVFcePKHywg/tQHU=; b=clQ8ABpEam9PAjoD2gZ5yQBaKDcey/0SqOh6jSONA4cfyCtLfKb3LtliNdXhafbnrszyk5 5dzpgh8kPDm7qyQyE/AklgbF+mfB1tYVLMxLIW/BPdUP528y/Bo7gZAEqYlGwvmN2OOJQW /mxupvI6+GiK4zDtD7clsrFg9XIvGjw= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-1ylq1u4xObKYAa90Mzf_Jg-1; Wed, 03 Apr 2024 04:13:30 -0400 X-MC-Unique: 1ylq1u4xObKYAa90Mzf_Jg-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2d48d13b3c9so47024511fa.1 for ; Wed, 03 Apr 2024 01:13:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712132009; x=1712736809; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BdVP1mpxTOuI3IwUquFLNg1sOnbLVFcePKHywg/tQHU=; b=gMdwHYo2vgoc96Imst03SP5JgFWplSbB3ROVnppl/c312anbA+RigXItGjl2mwa78z rYO7IRFk08zyuERvO9a/3OS0zmffExYEmHEsBoJ71JmElo19919zTkhKSXg6V9XEG/rf DfbjBQUNZmgn4GAvYh3WShTkHC9XHXPfe+fYvyUgsOSALOHJoVndfX1HKi4uflkIOqWS geaQL3dCKFkM0fIy0VeCO0o3BA8KwAMqiVt+mqh6laxVYQJGjTwV7upBHDIkGpO96+nD 3f6gsHDiihVf/pn1HfPoW5R33YXw6E5/lVsTy+DRX587iGzZ3ZGbmCXc0/dW6WBET2aw 3YkA== X-Forwarded-Encrypted: i=1; AJvYcCXr/tulvO0P3mby+IEwuw1TW1en6NxqbLKJ/lCs6f4AmqMcs3Z6kaHx4P7c2O2xJq1QRkkhrF7hxlC3kdm4LPjzJf4= X-Gm-Message-State: AOJu0Yy2HhXUgRe8Vy4LvEwSdyW6NkB7ARpZ2W0fCyfTFmIEvDXTCT4c k4AwKkHv/Wo6lxdXTuy5ZWOxpAW3so+xvS5HVV8yRGTkoXyTxnocQBoVJoDCeNr4C+/rDJ0saTq UT2paTJnPgJ0In9z55XkMKeTmXmgfHXniIeThkAOphUXgAbTN X-Received: by 2002:a2e:8796:0:b0:2d6:d5ed:6555 with SMTP id n22-20020a2e8796000000b002d6d5ed6555mr1219473lji.25.1712132009436; Wed, 03 Apr 2024 01:13:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETALGAkFjoBC9pFeLtKhAV/rPUlNWqQ66piqhdC4fsKLDbGtOMyFR9KJRxL3MYvTQfn+h2LQ== X-Received: by 2002:a2e:8796:0:b0:2d6:d5ed:6555 with SMTP id n22-20020a2e8796000000b002d6d5ed6555mr1219452lji.25.1712132009034; Wed, 03 Apr 2024 01:13:29 -0700 (PDT) Received: from ?IPV6:2003:cb:c73b:3100:2d28:e0b7:1254:b2f6? (p200300cbc73b31002d28e0b71254b2f6.dip0.t-ipconnect.de. [2003:cb:c73b:3100:2d28:e0b7:1254:b2f6]) by smtp.gmail.com with ESMTPSA id t20-20020a05600c199400b0041401eb021asm20652453wmq.24.2024.04.03.01.13.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Apr 2024 01:13:28 -0700 (PDT) Message-ID: <9c5f83f6-1e23-4c0e-85bf-454c1e3f07c7@redhat.com> Date: Wed, 3 Apr 2024 10:13:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: add per-order mTHP alloc_success and alloc_fail counters To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, willy@infradead.org, ryan.roberts@arm.com, cerasuolodomenico@gmail.com, kasong@tencent.com, surenb@google.com, v-songbaohua@oppo.com, yosryahmed@google.com, yuzhao@google.com, chrisl@kernel.org, peterx@redhat.com References: <20240328095139.143374-1-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 12176C0002 X-Stat-Signature: 3f3euutxtohfo4d48k4e9dsox7pdkf55 X-Rspam-User: X-HE-Tag: 1712132012-916659 X-HE-Meta: U2FsdGVkX19uSx2gOVXCv7KnIQAmzZ/MkzR9JIQJXyRBNxl0vYuIW29GcFnbM+r6HOiViYTsywQHSOZP8xQTrf+XU20Xt1YfjZFIfTeSwsYhejOrnCOBuOq+W32LSDxrsJ9U8Ws3WRGVEpIZRTmHNyFFMK+sRfr4Bo/c6Fz4fJ13YOnMjFdK8Dl5QWUS134gf9lG2YSE2OeiGP66j3ic+yG/rErmQcCbbP5gzoetYgrDQ5Wweipzsli+D28tpZzPHdrJXoIfXraE8nvPDXuwT7I5WcT9pUU7Sl/VqsNH43SOnGQ7KghUA9fC/dOsBhp6i4dJUTMoZKglYo8k0rrAmTA+02su8gVLCcF9YTwUpl6UDokh4Sgk3YYcMigf3k7vnyyInqW0F+IEft8BJbj8raLAA3pnUm4ePpCQgeVDSZkvFwAM9Gd+qeMYG377KXRSpmeOqNU7/v/BnGeIa71WjY7DzkL0lTk+1ohE24nzQ4m7a7hbWKYvc6Gh/mRtSuR+r9vOeqN5lPfmT1lEc1uXyYOPDSCZZAbaEl2/Ubc1oYEliDVaN0Cv265bQo6V84sWrsmPhEUvBg7sh8EugH7klyxew31z9dHNxIJIdAY/LM6vtbqQ2MoBhpkRU+/4XDAQTmTPxC347uStDX7YZnV5+dx5uqJeDm61lL+2HsHtyBspBiBPYb5TzNXtXA0uSR4jk8y6Hp5hfgcN9LaDNiopax3k7N8WTS1tuKf9fzSApT2aW2pgJFMcViS8zEjP2QL1u28+i3hJIZXs0TI1OrJaX1t7ezg3GTsw/RJWXU6jLEAz0c9oFPmKj4iQczeIqKJ05EJyS/I+Q3L7jh2VYnP7+28mqJdH2i8jU10qWkmMrAcUWmHlBwZlxF//0vqgQHHYKBhYlVAWTLIzenMhPVXv9PqbqkUIECb3gU3vIVN20gsTq5TrUGwhZDiGKDT5DPLD8aimb5arjgfNh3DLo2G 8dTJ2n6k XUynPvN7y4P5C2yorneCHhtV4vjm4q5wj1oeyf90P1nthwnzF4ZLlcWJrQJjtbI2tHSJIBwPjZbQ/GhxLvA0gq9Rq4tMCAD5Dkt1IXJ+Zp4Ir+aOcjBZrtL2Ez1W6jx0VmIIGZtsOvjZw+C0AwNzcJiENfvNXyNuraDEGW56/fOBtFjbRYvsVvG1PGpKLhWjJHmXRIyvANR/nCHFoSbqEi0GMNQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.04.24 23:29, Barry Song wrote: > On Wed, Apr 3, 2024 at 7:46 AM David Hildenbrand wrote: >> >> On 28.03.24 10:51, Barry Song wrote: >>> From: Barry Song >>> >>> Profiling a system blindly with mTHP has become challenging due >>> to the lack of visibility into its operations. Presenting the >>> success rate of mTHP allocations appears to be pressing need. >>> >>> Recently, I've been experiencing significant difficulty debugging >>> performance improvements and regressions without these figures. >>> It's crucial for us to understand the true effectiveness of >>> mTHP in real-world scenarios, especially in systems with >>> fragmented memory. >>> >>> This patch sets up the framework for per-order mTHP counters, >>> starting with the introduction of alloc_success and alloc_fail >>> counters. Incorporating additional counters should now be >>> straightforward as well. >>> >>> The initial two unsigned longs for each event are unused, given >>> that order-0 and order-1 are not mTHP. Nonetheless, this refinement >>> improves code clarity. >>> >>> Signed-off-by: Barry Song >>> --- >>> -v2: >>> * move to sysfs and provide per-order counters; David, Ryan, Willy >>> -v1: >>> https://lore.kernel.org/linux-mm/20240326030103.50678-1-21cnbao@gmail.com/ >>> >>> include/linux/huge_mm.h | 17 +++++++++++++ >>> mm/huge_memory.c | 54 +++++++++++++++++++++++++++++++++++++++++ >>> mm/memory.c | 3 +++ >>> 3 files changed, 74 insertions(+) >>> >>> diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h >>> index e896ca4760f6..27fa26a22a8f 100644 >>> --- a/include/linux/huge_mm.h >>> +++ b/include/linux/huge_mm.h >>> @@ -264,6 +264,23 @@ unsigned long thp_vma_allowable_orders(struct vm_area_struct *vma, >>> enforce_sysfs, orders); >>> } >>> >>> +enum thp_event_item { >>> + THP_ALLOC_SUCCESS, >>> + THP_ALLOC_FAIL, >>> + NR_THP_EVENT_ITEMS >>> +}; Why not simply "enum thp_event" ... "NR_THP_EVENT". >> >> I'm wondering if these should be ANON specific for now. We might want to >> add others (shmem, file) in the future. > > I've two ways to do that > 1. rename to ANON_THP_ALLOC, so that I can have SHMEM_THP_ALLOC, FILE_THP_ALLOC > in the future; > 2. let THP_ALLOC cover all of shmem, file and anon. > > following vmstat, actually 1 might be better as we have both THP_FAULT_ALLOC and > THP_FILE_ALLOC for pmd-mapped THP. Yes. Because anon was first, people just named it "THP". Then, file THP were added later. Some of that needs a cleanup. > > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > THP_FAULT_ALLOC, > THP_FAULT_FALLBACK, > THP_FAULT_FALLBACK_CHARGE, > THP_COLLAPSE_ALLOC, > THP_COLLAPSE_ALLOC_FAILED, > THP_FILE_ALLOC, > THP_FILE_FALLBACK, > THP_FILE_FALLBACK_CHARGE, > THP_FILE_MAPPED, > THP_SPLIT_PAGE, > THP_SPLIT_PAGE_FAILED, > THP_DEFERRED_SPLIT_PAGE, > THP_SPLIT_PMD, > THP_SCAN_EXCEED_NONE_PTE, > THP_SCAN_EXCEED_SWAP_PTE, > THP_SCAN_EXCEED_SHARED_PTE, > #ifdef CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD > THP_SPLIT_PUD, > #endif > THP_ZERO_PAGE_ALLOC, > THP_ZERO_PAGE_ALLOC_FAILED, > THP_SWPOUT, > THP_SWPOUT_FALLBACK, > #endif > > And reading mm/shmem.c, obviously, shmem is using THP_FILE_ALLOC. Right. > > I will rename it to ANON_THP_ALLOC in v3, let me know if you disagree :-) You should give people more time to respond before resending. Please try sending new versions only after the discussion on the old version finished. Otherwise it's going to be a mess (because I won't repost my feedback to v3 :P ). THP_EVENT_ANON_ALLOC might be better, so "THP_EVENT" would be your common prefix for "enum thp_event". -- Cheers, David / dhildenb