From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80F9BC5B549 for ; Mon, 2 Jun 2025 09:33:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D94166B026E; Mon, 2 Jun 2025 05:33:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D445E6B026F; Mon, 2 Jun 2025 05:33:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C33396B0270; Mon, 2 Jun 2025 05:33:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AA5886B026E for ; Mon, 2 Jun 2025 05:33:16 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1FE56E91B5 for ; Mon, 2 Jun 2025 09:33:16 +0000 (UTC) X-FDA: 83509947192.02.18F81EB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id AC25AC000B for ; Mon, 2 Jun 2025 09:33:13 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QqZN5gCf; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748856793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AGFrAeg+YrLg6JnrL0SvX9pGyMf+6/YBqcb6y1L9Yas=; b=teQcYiK5/HwKsafB7wpcZAYfGba81Iy7TGazmXEv8bVcnpduoyOk5+5n7dCS2IajQr6sTM k4tBOyOZpq2/41fD1/FcV2EXwyu8hmBJkowl+upU2FuI1Ypb0rh1PmMoUfn61ebjyTRK7t UtBIomYq+PdpGiQstXt/R4Gpafqt2Uc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748856793; a=rsa-sha256; cv=none; b=NPBwXakQktHFXqQYPIYvaNP92zhHckE9FHVDxb5z6RkHE+5urgw+xfWzGWWpdHX7udnAnl MoLiKoNuxOBNja8jpL19So9Yy7gIV6wdiBSEqwIUn97theVCt0/d/Pr/71pBd07gtYOea5 NwYe9MOvqxgMIOidSrvsz/KRRmEiw6U= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QqZN5gCf; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748856793; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AGFrAeg+YrLg6JnrL0SvX9pGyMf+6/YBqcb6y1L9Yas=; b=QqZN5gCfUJO+auOj5igrAZqqjFAdrHwOU3EBmfNI6mJxB5f7/u5kq/AyMBO8L3dH2zmEW0 x6zgexSRWa/Aqp7+8Vls9pZ8L6V9cgqWwv/cGBThOEr7fo8/00h+AT54ZY+txi3G5FafZM Wmy9gPboPUCIqAduvDlNWYgzAqheA0Q= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-MF86Sn1vOguqQJNnCAd0LQ-1; Mon, 02 Jun 2025 05:33:11 -0400 X-MC-Unique: MF86Sn1vOguqQJNnCAd0LQ-1 X-Mimecast-MFC-AGG-ID: MF86Sn1vOguqQJNnCAd0LQ_1748856791 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450d021b9b1so16598375e9.0 for ; Mon, 02 Jun 2025 02:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748856791; x=1749461591; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AGFrAeg+YrLg6JnrL0SvX9pGyMf+6/YBqcb6y1L9Yas=; b=GlUzpZ3rF8v68JMq0CgllfRUJSUrIAY0CVuZmL0lYqsFeo46motg8EdKkypHc6NJkA 2U6hiM+eA3z5OROhcZ1S4MIYdyVwHBndM+OyJlJNTwcvkLFpz+1QN+K3mC0yrIM/Ga7O 7kajEOUs70DHFz1VW/mwN86qWB4zwijoNOX0dEZKq6quRHtK/bs1YOo9Eu0HbAXPwFL3 vGtsjLXSKtX4AFiaY7sW3dJYs8sUVx0LrMvytG9ahk85tWJQq9GtCq82wYfXChx5p3TW yrutaLAhQlC1RTcNdF9/jlnVp/QN/FM1rpk6VcJt89/ngCd2afMBtkFxO17/QnqkRAZ4 Me1g== X-Forwarded-Encrypted: i=1; AJvYcCViiEp7uWlUP8iqm3Irrkp9QRQvk8+bc0rB7YDlESa+1Oe7zxbmsQTRqXohKZkmgQA3yrophmCcUQ==@kvack.org X-Gm-Message-State: AOJu0Yx/Fsg9/uVl4R02pdyde5msNTN+c4d6dQopZrlnnkIGf5R1JtZV mWa7Wss1EphxJScpPxs+E5wHT4ITOm6XplurE2mlT08qZh9zC+X35Wn5lIO4yX3vFkmEp8ZSh8u j2xuj8bwo5otJSmjnnq8F/TacruIj5hhAkzf1ps9KszmzYe0YzjPx X-Gm-Gg: ASbGncsIV1wnxvNNtUN+OeSzYqcyArZtbmBAWsNwbar3YGScThvi8JBz8Mzj9i1xIS1 YYSLKRSRwHBcTVSV6mcRTQ1qJvlJiVtqW1k+vftm5DRVk838+p3yXqaqI8DqRYvKYimfMsSqUdX MIByNFRciiboJhrhDutcvxJDGXz95DBRuPxPcvbrahqbAkOFbse29zdKNQTGA7FgkbxtwCgtAk1 5J/+FxLH/1ak34Zir2v44wCDpZWvtyalejah5B9oPF6nA2MBGnujn3bcffzuT0PCRQ23eK/6naU ICjyb62/NC6mcQDtqO9ZvDRuC5/kWdy2U6n+bMEZaY4tytVfXY1Th6Zr1uwqEsY+/wuwPCMZpTh amsyk9OWmft3StU2Bs1rvhVjAeezYNR9ONt6niAE= X-Received: by 2002:a7b:c008:0:b0:451:dee4:cd08 with SMTP id 5b1f17b1804b1-451dee4d1b6mr8272065e9.23.1748856790651; Mon, 02 Jun 2025 02:33:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkU7ZRpR1NEtSY/JfKM4+YPIoKTdq1NhU5Keu1p6sA2PS3/gG8eXtp9j/HneCiN7kQj1M6xw== X-Received: by 2002:a7b:c008:0:b0:451:dee4:cd08 with SMTP id 5b1f17b1804b1-451dee4d1b6mr8271525e9.23.1748856789835; Mon, 02 Jun 2025 02:33:09 -0700 (PDT) Received: from ?IPV6:2003:d8:2f34:a300:1c2c:f35e:e8e5:488e? (p200300d82f34a3001c2cf35ee8e5488e.dip0.t-ipconnect.de. [2003:d8:2f34:a300:1c2c:f35e:e8e5:488e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7fc1b60sm117663315e9.34.2025.06.02.02.33.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 02:33:09 -0700 (PDT) Message-ID: <9c465b24-8775-4852-9618-0873cbf2aaf7@redhat.com> Date: Mon, 2 Jun 2025 11:33:07 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/12] mm: Remove redundant pXd_devmap calls To: Alistair Popple , linux-mm@kvack.org Cc: gerald.schaefer@linux.ibm.com, dan.j.williams@intel.com, jgg@ziepe.ca, willy@infradead.org, linux-kernel@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, zhang.lyra@gmail.com, debug@rivosinc.com, bjorn@kernel.org, balbirs@nvidia.com, lorenzo.stoakes@oracle.com, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-cxl@vger.kernel.org, dri-devel@lists.freedesktop.org, John@Groves.net References: <2ee5a64581d2c78445e5c4180d7eceed085825ca.1748500293.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <2ee5a64581d2c78445e5c4180d7eceed085825ca.1748500293.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tkL7eL3kixEbQr09ZrF8KPxxtm4NsAKgcdnj-lb4UpU_1748856791 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: AC25AC000B X-Stat-Signature: 5y3k5gismdqofu5ew1h3fai8bh6dz5ti X-Rspam-User: X-HE-Tag: 1748856793-719531 X-HE-Meta: U2FsdGVkX1+S3f3Uq9VL6X38ArRCfbCvB17xjGx7ASZCbRoXMriSBJNWdVpS0G4Kzx4bHXv4ZYIlhWm0Yr6JJ5xC+Jd/tzk3JDyjt90DZCaSoFikhLpffr1fk87o1MGqZxnbEPwEAV5QPL0vAguUgS6pvXoumWKDtWgeKW/LsIOLzwQ58PArXH0ka6NmO0G1RLLuhCly2XwvgVS3DSgdgfEDBdrInonRtyFG6c4vnIA4Yvx1fdv+3ZoG7TsEBMnC5LwdFtJzk5ZALX7UiPfUBMTLm2B0K2QAvimDutH5tvOl8v0w+oe/RAFtHqQUv+f6NxCLNWO/FiZXmYnMmoHJShldYwkjxY6D4VO/US5og5OXALMEeTOnF+WcDW/kDD3hehLVSD4yI5vUYW1URryufSaZovQEPWxHmPRM6ZDeB9u8CC4Xp0MHGf1X+XWRHsKJOiyjfKiOn19mIEfHdua3snoOJMpZn7in204IhPyvtti/lMm+7vUM+22s1WhRcxqTmYWh20UfxK+STUgqWinFTavKFnXepjeRrTPJIQYgC5Vn1Y+fiUz1oNPJDsxv9CFNgSDNoVXaJPyVOS2Dp9U86ovV9mIe26skmiHzAES4e1rjtU/w2nsExgOeAIpsmuAz8nZ/zejvXu8ZaNjWDSbF1B/e4hp8HHRr5nYXLTcjB6wmdkiO1WYnjWYrMRo+LrEza+IKK4yoU5fbK1xY8zOaxmzxW7vbgaxfY1rncQyuDqs1NlBa1T7AXcH9vYOD8je1vwd9pecHJIlj1RWR3+vqzaL/2ztghBVbRmbVIvtHRYlVm2c1vgnOka1w0Rfk6dMnA15Qnjm1bWP3Gs1sxerjQi3jYWW4UtD0iaH4xp7gF6tMwX5dgq3bt0kYEORDJ6N5q/dJ7rWkrVf6tST5uqoZ+Af6ZT7yGMWYIXXLHLm3p6NQkpjcx1n/zDZfogKJDjSvL6F4aIZQ4OCniAcBHpD r5nd/2jH ZTPKPBK3by/+MGhc1NdQux2r68vAOM9isaffFdkYrKxcLAQkD8Qaf73xtSuoT3a6VvZalHCj8CjJr8+y+YhzfzDATcjRbXyPNxIQEioZt/0oLzP1KXc8ewM+uzQd2ttPLrmCLlpvbq72V8UEOxu5ZVJl3oeWM/flhaxUU3D1WMlxG93jucnR3imgdMtyanXhSeBZxmz0CVvLbP3knDQATtYSA4jQSIzoH/r2xWPSNPrK75etCvdPQqyLDLmUD6+eIOBFbarn3MXovU++U870vNC0fvUvNGDVYsYAk5zIeuWRNsPg90hMMKqu5VdLT+bw/qSKoyAyxWdaTkcx3eCaWNlqOJzldxtqNYAyUF1/qYbS12Qw26T5Rxu0g/NjPIDXQWELe3ShV1cuD3LKj4pARL8aIqC2JrwLksiRzTHVli4Vytn5j6cESpxxDQtpglvX/ocPkV4FFfnyDEaADZ8Sta1BGb7dqvOaF8V2YgcrgIfNjBljMKUHOLlZ3j3qCIfl9m74zzssntpYe/wk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1398,10 +1398,7 @@ static int insert_pfn_pmd(struct vm_area_struct *vma, unsigned long addr, > } > > entry = pmd_mkhuge(pfn_t_pmd(pfn, prot)); > - if (pfn_t_devmap(pfn)) > - entry = pmd_mkdevmap(entry); > - else > - entry = pmd_mkspecial(entry); > + entry = pmd_mkspecial(entry); > if (write) { I just stumbled over this, and I think there is something off here in the PMD/PUD case. vmf_insert_folio_pmd() does a folio_get() + folio_add_file_rmap_pmd(). But then, we go ahead and turn this into a special mapping by setting it pmd_mkdevmap()/pmd_mkspecial(). Consequently, vm_normal_page_pmd() would ignore them, not following the rules documented for vm_normal_page() and behaving differently than vmf_insert_page_mkwrite()->insert_page(). folio_add_file_rmap_pmd() should never set these things special/devmap in the first place :/ What am I missing? Note that fs/dax.c calls vmf_insert_folio_pmd() for PMDs and vmf_insert_page_mkwrite() for PTEs. Consequently, PTEs will never be marked special (corner case, shared zeropage), but PMDs would always. Hm? -- Cheers, David / dhildenb