From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFF60C8303D for ; Fri, 4 Jul 2025 14:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E3056B00FB; Fri, 4 Jul 2025 10:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 33DE86B0102; Fri, 4 Jul 2025 10:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DEE16B010B; Fri, 4 Jul 2025 10:09:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 06EBB6B00FB for ; Fri, 4 Jul 2025 10:09:36 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 7C29EC04A5 for ; Fri, 4 Jul 2025 14:09:35 +0000 (UTC) X-FDA: 83626765110.10.C8E13CD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf10.hostedemail.com (Postfix) with ESMTP id E5176C0016 for ; Fri, 4 Jul 2025 14:09:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ARyHvwE5; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751638173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nt7xUyaSY2bwlKzrDx5dkOnSZrDMwc3BRrdM7IQmPSg=; b=S7LDmt+4gTvkmG0xPiYQ1cjyUZsmQ5SRTa/Ja5gX3X/8gqso5xiE9mtzNKTkf458R+YUO8 VABtgihEd0GteyLqCkeAjht2lM5kfaItFSVoBy/G9x4w3B/Tnms6ksT9DfTrtKEUQWtE0V tLE9UqTSsigSb8yc+GiPzhkCL1chQHc= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ARyHvwE5; spf=pass (imf10.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751638173; a=rsa-sha256; cv=none; b=61yZqWowEZF+zxo+H99gFyZ8GA4uFtXmggkpZyaBlnExzfzx/d+/qjbrwM8U58B48nQgrj nIxNMeZZZ7Z3A5X9soIDAt8vam9FI0pNxawsgqmaAxCRh70ojcQ81e+TvievKYIBzxHhP9 kGcU+ck0XlqGky5RCU1X87BQ6Ae9MXw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751638172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nt7xUyaSY2bwlKzrDx5dkOnSZrDMwc3BRrdM7IQmPSg=; b=ARyHvwE5G5jkmUhq7NoiJgjNdYWz8tVOKtrRiLqu+O2gZqshRgztgAK0eFXNT7+7N1QxnS Z6Q+lHEbI+QcVWjqp3DwoB0HsoP0i4fXXihLWjzLbAGtytXRmjuab5RzuLsoR0XF6k406x sJ84h3mZvyt1+rUotzoXErfNtWu6ubI= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-687-A92ArFSmNX-M7D3VepQoCg-1; Fri, 04 Jul 2025 10:09:31 -0400 X-MC-Unique: A92ArFSmNX-M7D3VepQoCg-1 X-Mimecast-MFC-AGG-ID: A92ArFSmNX-M7D3VepQoCg_1751638170 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4f6ba526eso663571f8f.1 for ; Fri, 04 Jul 2025 07:09:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751638170; x=1752242970; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=nt7xUyaSY2bwlKzrDx5dkOnSZrDMwc3BRrdM7IQmPSg=; b=dvcFh582yhx5W0eQHBO1DlH/3SbvhN6m3xch1vXfEfdwjuPuI++gMZx2wWsd45I2/c rn+kIfOpHdkUCBtISzRlSJPo64goGRyKpgsQmYFtyMhugdZRQHQzZqDpuBxJFveKVBls Dy+znHv7XkZHpDoNCr+19ubb5wojTYOfZIodBXE+CrG4V+l9Es18EoeW5IEWHnSCPSmv B/vjnJTYUUlINMMtN8RDtdLIVlsxvzdnuqxjV7LLfw7CKwDXXXB8fxshhUQiYgb4Qjv1 I1Ly5Q2vR5qOd3v4/kIKAQRn0BJrYvbWTlrlYrYp8ABdZBuoUmhS9BzU4au9dBHQ03Rb 0Yvw== X-Forwarded-Encrypted: i=1; AJvYcCWsqz7dvLn8jP7PWEqJELR0fI0vZfRH7A/9s0n+1VlIZM3qUM8pgpyJnmAzmsHywMyJMBJXYaRDVg==@kvack.org X-Gm-Message-State: AOJu0YxvqbGIED2K1BzhnUnAqgbYmwH4cyyu85kN0GxEVcw8FlvRDE4H spAGUYsGLIOvKNDgfPVJfNe1JPtXzPfPzce8/cvZLNIzB30VuH4FmKb17Wh2mvLFLY4k9fSeodg yvzvjKrNyi/JzrTnX66Uwcg05MVI38RjB6m9aZ9uD0elVd53exQlW X-Gm-Gg: ASbGnctcWF012Uh+PecGnVK9i/fjFwvG5t5XY6sLw8LKOUkPTEHYBkWS7owBPWi7Mvi 5T8WAG+k3PG04cND8YEwfrrWXG09uIPTZrFS/5Peu2OhnCREGzU3kY0fJIGnwmugHpuYD5n/ZtT SdbGN0w/ouz3tPE7CIM6JqNezzHyeWw62RarSLleS7ikFdnK97mXAQFlLjMrGNFcU92fA/6Zqx5 B4AlFsU1RwP9W1UpcdFAp0DIYH0lq9dtr+OQx37sF2Fb9X+nYvOXlS7h58v516rNP/AqwhCsvSj rTDvO6tpQ5mLgtFpo1yqz+cDivGFgnNZIj2fmWS7+5ZwqYRO01mKHxtv5UxUgsrcwcqhTBb/IsN SyvlMHEmrL2/nq/mBNx9W1QhUzTRnA9gNEKpt+t6Ukd8cKZc= X-Received: by 2002:a5d:584c:0:b0:3a4:e68e:d33c with SMTP id ffacd0b85a97d-3b49661da3fmr2465449f8f.47.1751638169896; Fri, 04 Jul 2025 07:09:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHyZaHm3cvEEMqssF8essbFIJLOElulWn/9VcRsQbLa7wt2W+gUgffDY85V2Xx5K0zPawIpyw== X-Received: by 2002:a5d:584c:0:b0:3a4:e68e:d33c with SMTP id ffacd0b85a97d-3b49661da3fmr2465397f8f.47.1751638169344; Fri, 04 Jul 2025 07:09:29 -0700 (PDT) Received: from ?IPV6:2003:d8:2f2c:5500:988:23f9:faa0:7232? (p200300d82f2c5500098823f9faa07232.dip0.t-ipconnect.de. [2003:d8:2f2c:5500:988:23f9:faa0:7232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b16865c2sm27363175e9.19.2025.07.04.07.09.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Jul 2025 07:09:28 -0700 (PDT) Message-ID: <9c45c671-9330-493f-9a8b-2c08062ea0f9@redhat.com> Date: Fri, 4 Jul 2025 16:09:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 3/6] KVM: arm64: Block cacheable PFNMAP mapping To: ankita@nvidia.com, jgg@nvidia.com, maz@kernel.org, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, ryan.roberts@arm.com, shahuang@redhat.com, lpieralisi@kernel.org, ddutile@redhat.com, seanjc@google.com Cc: aniketa@nvidia.com, cjia@nvidia.com, kwankhede@nvidia.com, kjaju@nvidia.com, targupta@nvidia.com, vsethi@nvidia.com, acurrid@nvidia.com, apopple@nvidia.com, jhubbard@nvidia.com, danw@nvidia.com, zhiw@nvidia.com, mochs@nvidia.com, udhoke@nvidia.com, dnigam@nvidia.com, alex.williamson@redhat.com, sebastianene@google.com, coltonlewis@google.com, kevin.tian@intel.com, yi.l.liu@intel.com, ardb@kernel.org, akpm@linux-foundation.org, gshan@redhat.com, linux-mm@kvack.org, tabba@google.com, qperret@google.com, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, maobibo@loongson.cn References: <20250621042111.3992-1-ankita@nvidia.com> <20250621042111.3992-4-ankita@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250621042111.3992-4-ankita@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: dxZ4OxJid5XpAHvCy25PqF-tGyaOe9WhjOmnTpSufn0_1751638170 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E5176C0016 X-Rspam-User: X-Stat-Signature: qa8ydk3gdxqfworzit5a6xz1z8xt993f X-HE-Tag: 1751638172-509920 X-HE-Meta: U2FsdGVkX18HEzs0CoiRA8Z0SqrrXJaUkV8dmZBGAHPyVqdtWpdzBwGRnJtNOjzuGlBdY3X18HM5cv8pD5nNnc+mRaOg2OTEGxJtacZ7+HudxXHtENodEL5khKEy9PyczA/x84QANOcjvCl/gSV9lDhn9PFgUwFfYC+HmzE1B7Ay7lIxykZapA49gg7ZnhBS7GW0qPGNSQwCOMqm4s/lPkPPwHzrNiLfxmgieF6Nx8V9wP+Pxh2WSxYJGdS8S3YK75SJEFkH/J5ncRwPd3vkjiTA+0mZANai2nczkgEInWqhdVsM9/RERCllodW477ekCbbb6FaDuUruDc0Qd4U2Pvpsu5L2nfup20sI0pHKmCBTSwlPy9ftENRNcUxkOHBPxA8VJmxk/n+8CbPN+Xd2vLQBpOq5ELY3xRp3XjQ2f1/+MipZqmB70GXxo4S3klcmlOTIrHQekQGcHujaTpfDF0awmjdK8H9nGQUc5YZAaV7TmLTJEFTAwzU1FXOWNVPV8mnBOVId6EJHrGND0E8WW7SnAvZyfypYspoi/ZZsmgwpU3qSvjTBGA3TwUcYwjShvMhWt0sOIsLlfEp5Z1/9Oxv2tTJGGHm5GOgbap0N4fMjKqxZUe1/aWeURll5++RKlVbHYvuFj00HsOPJalj01uh742gfN28A+MTL439qpXKYpEgKwuCijKPKIuesPJUUbRslT0MvUVJjpJIpIbITdT3HVS4dg2Xt8weLCJxc7o6t7Dl5jJFvVJ5W0vsXx6e9XaVATzRQwZAWVI99ZJcI8+MLdtOGtNHoJUczGECKxsrvUqzSz+D0P+oNK+ZYgEul7eFBc2CiSygYQntLjv3j2/WheumLL2Ms58N3RRMAXMiFcW2DnHHo+T2WcTjlbxHCNWKabFtqX52lBK8fImzTKYYP0gvIHnRFhYRyyKzMY7XpDXU779r+BeYEe3E19Luon7Rwci5w2ZaSBRw/O1u GHYmdjpH Tg26HA+MrteYRBXGIdy9ZNmKsb4juwmfSFG2CjQ1sXjv3ftwtptGXKmj444e5pzP5QVIyqYua9DijBYBG/PR1pkVo7l0ixpIwc7CyVcgplKQKNcgonH5ABuP6JzwR/Fbya59FmfcN/c43cVFeBg86zjGIt5Xyir7vhXwKJwCcwngRdbBcJBjhFaSnjXSbR/+9HOTN0a99sSEeFvRV8ajrT9jT16FWGLRf5Ik3t8BMhCghMTcdQI1emAnq/q0dKvYxGgXLKxMCGCGMy9XmTDsuvOv0RG5CfUmZYPGjy8vSK+uNmI6S2mDV/TZZGAdyDqEPfpku9O8kiM2ROEPnlF/G+XycgxVICyqOrXsfpGfiU3SzkGsSDYSO//Eku+RGVdF2ZIALCBRLXRYp66WjpgIFs4XuixPRmvEYISC2RjnARRxJ/6X5rRIIx3G1U8oX6lyuHKT8jGv0FR/c1LgMYcP1rmYETevc1kt0G22fRXdzIIDPtrVBiPKeyYg99wFbgqAOzuymTQcSOP+1GV4Z1RtCK6skZB8Qsqb+Ln3fR9CiWAvqQEFLT7sMndcKSg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21.06.25 06:21, ankita@nvidia.com wrote: > From: Ankit Agrawal > > Fixes a security bug due to mismatched attributes between S1 and > S2 mapping. > > Currently, it is possible for a region to be cacheable in the userspace > VMA, but mapped non cached in S2. This creates a potential issue where > the VMM may sanitize cacheable memory across VMs using cacheable stores, > ensuring it is zeroed. However, if KVM subsequently assigns this memory > to a VM as uncached, the VM could end up accessing stale, non-zeroed data > from a previous VM, leading to unintended data exposure. This is a security > risk. > > Block such mismatch attributes case by returning EINVAL when userspace > try to map PFNMAP cacheable. Only allow NORMAL_NC and DEVICE_*. > > CC: Oliver Upton > CC: Catalin Marinas > CC: Sean Christopherson > Suggested-by: Jason Gunthorpe > Signed-off-by: Ankit Agrawal > --- Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb