From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86FD2C4361B for ; Thu, 10 Dec 2020 23:48:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 126592310E for ; Thu, 10 Dec 2020 23:48:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 126592310E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 604FA6B005D; Thu, 10 Dec 2020 18:48:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5B6F86B0068; Thu, 10 Dec 2020 18:48:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC0D6B006C; Thu, 10 Dec 2020 18:48:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0052.hostedemail.com [216.40.44.52]) by kanga.kvack.org (Postfix) with ESMTP id 37E426B005D for ; Thu, 10 Dec 2020 18:48:45 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 06F6E3632 for ; Thu, 10 Dec 2020 23:48:45 +0000 (UTC) X-FDA: 77579015010.11.van11_18174e8273fc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin11.hostedemail.com (Postfix) with ESMTP id DE589180F8B81 for ; Thu, 10 Dec 2020 23:48:44 +0000 (UTC) X-HE-Tag: van11_18174e8273fc X-Filterd-Recvd-Size: 3700 Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Dec 2020 23:48:44 +0000 (UTC) Received: by mail-pl1-f194.google.com with SMTP id t6so3668136plq.1 for ; Thu, 10 Dec 2020 15:48:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :mime-version; bh=AG5j6KdzOrOIZlpP/G9Y3cE+K8n2ovOPbsXUJ+7wxSo=; b=FayvgMRlRj18DT5FRCj2xQ+hkc14+FsGexb2ndZ1Rek0uG3kjNwv4fcZqzZVSgroTD 5hz6WjzLi0eqDuoGrSg0SDv7+IF3relQUsha969dYZ60zo8DvVlObmt3hZ5+xqXGUgb9 fUjxPVSO1iXVRso/n0LxRCwCmeadiV3AWBhyeHigIiZPDIg6ePSrNQ4y5913weR3hx2M OjQV2VJ/zg0guoP9VrOFyRsH3RA+XUFFHbbnHc7kobQ+vKik50uKRpWccpzaT2Cx+2T9 OrdS9SYkidQ185axfnJmM8JfnsZVr7beMOOtSMZuMCGVJNyGSq1Ch/YdbxweIQo5fNb6 zzvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:mime-version; bh=AG5j6KdzOrOIZlpP/G9Y3cE+K8n2ovOPbsXUJ+7wxSo=; b=EEJGo+UoALN/8TmSBRbW/fFvLuQn9KU6RrkKAMaqrAl24SbkdhKJwgq0rSdRyH41e2 kaumALLAx6aNkmQlEnoeDFNmDGrSdTixsm2coEaoEDl3i525FTB4vfpaVLyBpe7ty3v3 VZ79wBOxp8GxVqRgBlwxpJphHzNhtSfawj4dwrfzLy19Uu2YRh/sTGf39eQokucPsMjd /hzWNQVB8FoWulvXVU8+/PRkq72F/lE/pqPibo7lVfKAX+ffo4RPOi/29i/KZPL7u6MZ /Hc5Y/THymwvHesl89KF9qT5Hu8gywFVeUw8l44bKEx9JeO2yiJQxL+N5aPzkob84M2f t+Ew== X-Gm-Message-State: AOAM533g0HTqODZJwT/nJJksFG3q63Irwyim4eGamU37P55LkSg1jISr kuXqXqDyuCLjcVnalMFoli8Tqg== X-Google-Smtp-Source: ABdhPJy8eYSBSN1zLoF8WPrP3Ta3RaV5MISN51OJupxpC+nlzAgsQW/ZwYFm/vnBFekFzdFRpXnYtg== X-Received: by 2002:a17:902:6903:b029:da:f458:798c with SMTP id j3-20020a1709026903b02900daf458798cmr8325001plk.68.1607644123398; Thu, 10 Dec 2020 15:48:43 -0800 (PST) Received: from [2620:15c:17:3:4a0f:cfff:fe51:6667] ([2620:15c:17:3:4a0f:cfff:fe51:6667]) by smtp.gmail.com with ESMTPSA id e5sm7184975pfc.76.2020.12.10.15.48.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Dec 2020 15:48:42 -0800 (PST) Date: Thu, 10 Dec 2020 15:48:41 -0800 (PST) From: David Rientjes To: Alexander Popov cc: Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Alexander Potapenko , Dmitry Vyukov , kasan-dev@googlegroups.com, notify@kernel.org Subject: Re: [PATCH] mm/slab: Perform init_on_free earlier In-Reply-To: <20201210183729.1261524-1-alex.popov@linux.com> Message-ID: <9c37ff7f-813d-3313-ea8a-fd65484e476a@google.com> References: <20201210183729.1261524-1-alex.popov@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 10 Dec 2020, Alexander Popov wrote: > Currently in CONFIG_SLAB init_on_free happens too late, and heap > objects go to the heap quarantine not being erased. > > Lets move init_on_free clearing before calling kasan_slab_free(). > In that case heap quarantine will store erased objects, similarly > to CONFIG_SLUB=y behavior. > > Signed-off-by: Alexander Popov > Reviewed-by: Alexander Potapenko Acked-by: David Rientjes