From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B42DC433F5 for ; Wed, 5 Jan 2022 07:01:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78B486B0071; Wed, 5 Jan 2022 02:01:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 73A576B0073; Wed, 5 Jan 2022 02:01:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DB1A6B0074; Wed, 5 Jan 2022 02:01:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0106.hostedemail.com [216.40.44.106]) by kanga.kvack.org (Postfix) with ESMTP id 4C3306B0071 for ; Wed, 5 Jan 2022 02:01:04 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0892194FD5 for ; Wed, 5 Jan 2022 07:01:04 +0000 (UTC) X-FDA: 78995336448.26.AFE196A Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2071.outbound.protection.outlook.com [40.107.95.71]) by imf05.hostedemail.com (Postfix) with ESMTP id 4319010000A for ; Wed, 5 Jan 2022 07:01:03 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T5WAP0x7ElKOoBGT0+HB3r15kYewIjCPu5c341vPhI9P6jzEqeOmsW9CTFYqZBVAKW0GdaMjKoRH6c3yHHK8imvW4pIuYs556LkbF0gUORA6jHBHFf3vKdQXEZHMIIo94r42KxsWjNNzI0hFT+gzE5gI5x44uaTwbE5j8t+8jW+8H/HISXHS+/WAMnbF9ED84IciyxzlUq3NRSdfHmsP0QxKp+/HChdXTNkGIhi+cxcVBR1OEp0SHMxErUpnDVzenEv+1sY3ZfJmo8vJ0yi+I7BvrI0jt9ykEAXB9maOJd8CCtxfTBzorNgGlaNZnXR1VJeAKzrSIDvBI27glVlpnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MhGGfd+ejcYhZIwpvywmuE9DuyoduznrgPtTRhieopk=; b=SetDR1Gpqbz0kOR70ZNM6Mj0ecKI7dsGbNz7Xa9JbRZzSHsTYpCRPHp9bpv1AyLgqv9qoWBYhCmSshOa89quZKYKQqAyNelNBP1PpmJvgdJfLb0kDuipXnp9P4+jIIfapiqKVqWm+EHcBKiDoVIvrGj3xfVu5vbLYWqAA7KhT7sfPKKA7cMKGo8UFuaK2Qu5jMrOPXBZRPdAOjYwnpZzfADordpYGsQeevN14MRXfKQ7BsCxLNFgTfbpm693cd8mKx+motu6pZgxU3M0slo1qRDx1P5BMGnfDLRnd4R5n4QryakzRgCB/FAk4MTKVG36guUUH8zg0FoNXYcssIwxtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MhGGfd+ejcYhZIwpvywmuE9DuyoduznrgPtTRhieopk=; b=kYZtyHq/LGwDnBJdLgOarLAt2v+bxNGZLG2zduTBI+Cuna1P8uNDe0kTzqHuDn6NnRrVQ2IfvMvFHzhXyXCGB/oaHemkK++6r2/WXdcu3AcRQr0E0Mnq4rKaXtNxGIT7H+44IgsWWJX4Ql6dLW/KPE13fsQ1cZFVjQkJmmpwAPq1ACylk+J9yh31abNAun2sBTs4eSCY5W9FycWcoO8Hv9Pq3xBWjpPG2+oVBwg4FUYOuaWUWkVgpXbqJN1m9HppxTjTptpCgo5NET3x22Zsbr7MILQB5Hu06nRNnos2hBzSxR9cYpzT0PCkKyv9kgLnWqy+swxSW8VqsJw3bpg4eg== Received: from BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) by BYAPR12MB2725.namprd12.prod.outlook.com (2603:10b6:a03:6b::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.14; Wed, 5 Jan 2022 07:01:01 +0000 Received: from BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7]) by BY5PR12MB4130.namprd12.prod.outlook.com ([fe80::8496:16fd:65c5:4af7%4]) with mapi id 15.20.4844.015; Wed, 5 Jan 2022 07:01:01 +0000 Message-ID: <9c322204-6987-8b04-623c-147e79667a13@nvidia.com> Date: Tue, 4 Jan 2022 23:00:59 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: [PATCH 05/17] gup: Add try_get_folio() Content-Language: en-US From: John Hubbard To: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Cc: Andrew Morton References: <20220102215729.2943705-1-willy@infradead.org> <20220102215729.2943705-6-willy@infradead.org> <3ac8af50-dff6-4a0f-dba6-8b8fe5f611d4@nvidia.com> In-Reply-To: <3ac8af50-dff6-4a0f-dba6-8b8fe5f611d4@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-ClientProxiedBy: SJ0PR05CA0129.namprd05.prod.outlook.com (2603:10b6:a03:33d::14) To BY5PR12MB4130.namprd12.prod.outlook.com (2603:10b6:a03:20b::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 53bd45b0-c488-43d5-3d82-08d9d0192225 X-MS-TrafficTypeDiagnostic: BYAPR12MB2725:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1060; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vzQXiPfuxHxvq8UlIDOn8NQpY8E/VO1rmjplSf3FyWcDAtgmC8gPTLNRWtz0ePMPG5nvmX7We1oZorVV9/ODEQF7v44ih/C6ATQPXbRGh4BTqSS6nko3/8lyfeDQK7m4G5PTGiUY/oni/MWyNJPcz/pjCrUEC8drnEMZxIZxIGmX3vabx7fAW8aXCwl3iBXShbDkhXeve84VlWn8CQ/bniKUUuP1p2CRuJoYrjO7L6X9DKGdMr3+N/h4+my//56W0zSCptf5TQ41fx6hsIMltbZSO2ituUZH01QH1hQWSa/1PdebVAH+0YrG0MevQHDQ2TfqiJNZ9rI5jwayY99wZ06lKT7d26BeVUXPUzztQx/n59pCXminq6x97up6yJV0wub6ZPMjvjD45xOMhKSSAM+Q6YRPrICXTPiNu1Oqe64zl6v0wFuznBv+10vOx2cSb5YdjnhuVDHMKqQOhQnK+L4k5z79eZWLy2I3hJIMhaHNXqIsGFHUH1aCE4jIN6S1lj7ULLrTZZ/6FGhM38NgAkpmT2rK/sdtdykqIB/t8PZlQNNg1NG2dNzE/WZtBPCSoVTBj1QP9hy+YeYM6tpeTBA3VzGsWuJOGrQ/96ecMi0Suk4UkwdB4kHklhE5o86OG6WaxKpfHwfgwSIyHYslvFnuM/UpPfujnfqYor1+muiBVAdkT/WiJ5JUp68bFWSzvVJWpRq/NLleQrftqcRPEbLFrtw1makoLviU8k7Txq0= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR12MB4130.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(6506007)(4744005)(186003)(4326008)(2616005)(2906002)(36756003)(6486002)(26005)(316002)(66946007)(66476007)(38100700002)(66556008)(53546011)(5660300002)(8936002)(508600001)(31696002)(86362001)(31686004)(6512007)(8676002)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SmV3dTFEendySXQrWHkyWmdDS0UzU1haNVVBU0ZpVWZsZ25lekNGTEtSQkpQ?= =?utf-8?B?VGVKcC9iSjhDd3dteDVvR0hmZ2RwWSs3c1VONnlKOVZPTDN6am9aaU5DcDV0?= =?utf-8?B?TktVNERGT0VrdkpXdmV3UE1aaHFuWmFtdkZaRmV3UmdWMmdXYjkxNnpUYTRN?= =?utf-8?B?TlU0RlNQWFR2R1plM3NabzA0NklmWkNNM0lLODJIUS9xS0pWSTZjMlZLL1pv?= =?utf-8?B?THhjQnAvSUwwcHVLNmJxME1OVGd0VzVNNUNnSFBZc3pkbkQwbnNYTExkMzNs?= =?utf-8?B?SnFSWThiRWNlYnBaYmhyaEFid3dVck9TTmpnU0dkSXBJdm4xNUZpUzZOYjZI?= =?utf-8?B?U0J2QjdVb0lHckFNTFQ2M3FqM3NZWTgzZ1poUWR2T0IyanRpaGZwazRTK2ZS?= =?utf-8?B?a040WlpxbnIwdXZJL2o4VWRMS1cwNW5lbWxqRjBDaTF1NWZzb0NNUGpBNkM5?= =?utf-8?B?am14Y2V2MU9aYUt1SHdPbHRaT2FuMUozNlJablhQMEU4SjFPUWxXOGpqSEYw?= =?utf-8?B?Kzc1RFQrdHZXNDVRc1BZajUyOVRCYUNFb3p2ODFMdDhPVHpocWU3OE1QZVR1?= =?utf-8?B?OUFLSFlMKzVTRDBOei90RFVFVlUycmhSdUNmVDE0QkYwQ3RWMzRlQ1FMRkV6?= =?utf-8?B?NktVbCtQU1NqaC9HNWpUdEh2aStmcEl2MWtBMnpPQzZ6QzJsTGhtL3hvb1Ew?= =?utf-8?B?VDloSXc2REJ0RG1DRzdEb0hoOHVlb0xKOTJ1djhyZnZXbUNJTFBQd2JNMnFl?= =?utf-8?B?VmhERm94U0o1T2Y5aGp2Tmw5M3Rma2VYUUY0NjgrM2tEeDFxSExlYTNLekd5?= =?utf-8?B?ekgwb04yT0pXTUNWME9FcmthbHY1SEQzV2ZhQWVuc2QrelZnZ2xKQVA1c2dS?= =?utf-8?B?NGkvRTVkMk5tYzJiRTVFWEdsdUZyMEUzUG84YzJFdXNveWlPMHRRNHJQcHRK?= =?utf-8?B?TmVHNHlEZlpLdWFJNW5vZ0hVS3hKb21UOTNnNVRtM0dJSkVHQjVpaEE2MWhL?= =?utf-8?B?WVlLL2ZPUm9Wc1R2c2MyK3oyYlc2aGMxanEzWXV3T29jeEFOSjhkNCtLTFhU?= =?utf-8?B?d1lKOENQQTMvb0RlSDh3OUJMNWdCS1R0V2trelhBNUxyMXZHZTlXYkRra05K?= =?utf-8?B?RE1Vd0pGaHB5Y3hoRFVsc1hyYS9JZnk1ZVc0bHI4Q0owTFQvd1RWWjhuU0Jh?= =?utf-8?B?Z0dtYllDSG9JS2kyOHZkRHVaMWM4cmcrSkVST0w3WWJNQ2pvcXdLMWtHdUJq?= =?utf-8?B?UWhRWUhhY1QyMkdrMzE1U0UvTVlHdk45UGNJZ0piYWs1VWxpM2RWdGRVYmJ0?= =?utf-8?B?S2hjMHFNa000QzllS1ByYzh6MUppVVgzNHlHV3ltc05xY0tGTDM3M3JoSGkv?= =?utf-8?B?S3dFaVZBaVBrRjlCTklnMCsreUpNdTBHeXd2YTkzT3R3ZUU2a0p0ZHByanhp?= =?utf-8?B?L09WcU1TY1Blc0dJVTV0dTRlZ0tYMXlXMHprVVk1d2RNL2p3R2pQYWNoSHRK?= =?utf-8?B?UnF3bWVkdWQ5VUxvK3l5RmhzR0tVWEpPS2Y2VTJBWkcvVG45c0MrdHZEN3pL?= =?utf-8?B?cnVpRzlZT25rQ2pkNFRxZ1lSaUxZS2NaZTlZYjJJdmlDSno5cnRjbmFLOUZI?= =?utf-8?B?dlcybk5qckErWE5qRlJrRm9pSzhPYlJNd1JCVkJ2dmZlbWl2TVE3WmF1aFlF?= =?utf-8?B?MlVtdEVBTDRkYm1IbHJMZzVqcGZIMEYycng4bkFlVmVkZ1BESVI4a2g5U3o5?= =?utf-8?B?UVV2REZQU3FKQ2pmWXNMQ3k5QnBCREhGcGhMOGlTTWpsNFIwcG01SVNtKzNa?= =?utf-8?B?cGFKaTlnQlE1U2FROTEzV1phdG1PS0RJeUdnZHgvMWdDR1ZMWnpyRUN5ZE56?= =?utf-8?B?MHJWU053bmxnKzNUZHZYSXVjZ1FDODU1RTdXVGtzdW9NWFlzNjB4TWdLSGJP?= =?utf-8?B?MEdKMklRUjNpVjlWODZYL2g4dm91ZVhJdjJLRHRmTUFzTzZuRmZTMVBpOTl0?= =?utf-8?B?cTIwK1JIM3FSazhqRS9UWlk4TENjRmFPekRkYlpsMThXTlBzRkNlUkZCRlZ4?= =?utf-8?B?OHpYTmYrb29tTkRxUWRLL2ZtWlVYeGkwbndYVlJFYU92dkNseStDZmxnaDhZ?= =?utf-8?B?UEhZbUtnd21rRk0rd05YYmxQZUNUcXM2SldTZmhxejZHM0pBcGlyZXFJQlhS?= =?utf-8?Q?DniO2JxlDEAk9F5YJXhr8D0=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 53bd45b0-c488-43d5-3d82-08d9d0192225 X-MS-Exchange-CrossTenant-AuthSource: BY5PR12MB4130.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2022 07:01:01.7135 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IKZpbqzvjbwHqY34JW/WKQjeGYox/laPRkU54mBFSZhBbEQnN2r+nBAwg7hB9vF+Ygke22Sy6h1IQ5yhPdFTSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR12MB2725 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 4319010000A X-Stat-Signature: 7hwq564jg53bdzsyg4s7mt45zjb48n8b Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b="kYZtyHq/"; dmarc=pass (policy=reject) header.from=nvidia.com; spf=none (imf05.hostedemail.com: domain of jhubbard@nvidia.com has no SPF policy when checking 40.107.95.71) smtp.mailfrom=jhubbard@nvidia.com X-HE-Tag: 1641366063-982104 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/4/22 17:25, John Hubbard wrote: >> @@ -128,8 +129,10 @@ struct page *try_grab_compound_head(struct page *= page, >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int refs, unsigned= int flags) >> =C2=A0 { >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (flags & FOLL_GET) >> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return try_get_compound_he= ad(page, refs); >> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return &try_get_folio(page= , refs)->page; >=20 >=20 > Did you want to use folio_page() here, instead? >=20 ...never mind about that, because I see that patch 08 gets rid of the "->page", anyway. thanks, --=20 John Hubbard NVIDIA