From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3EDC64ED6 for ; Thu, 16 Feb 2023 09:47:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81A5E6B0071; Thu, 16 Feb 2023 04:47:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CAC96B0074; Thu, 16 Feb 2023 04:47:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6945C6B0078; Thu, 16 Feb 2023 04:47:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 591E86B0071 for ; Thu, 16 Feb 2023 04:47:08 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 19C7A1A116B for ; Thu, 16 Feb 2023 09:47:08 +0000 (UTC) X-FDA: 80472676536.28.56713E6 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id E0CA5A000A for ; Thu, 16 Feb 2023 09:47:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cnd1cPOW; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676540826; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n9ZbC/yZoS+EllJFHjVEOvoIsGMwmzQvn0ZNh0HypLA=; b=lO9jea2eH6Yzm3MNG0u7wRMN35MVQgNng/yIWCwJxghiwXGeKAXjSGkzR88ngMrwBT0j/u sjauhTvvlPqcYvn33aEGOIEhVE7mw1eoOPUhbjcehE6YhzAASzvQag3ccVdWnbEbZrWm+c g/e0clqN7NHCxv3qgG/OvWMyQV2S1jU= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Cnd1cPOW; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676540826; a=rsa-sha256; cv=none; b=ymTohsqn0DEUYALzcSKyC+9vL2O8gfoP+CP5/A78QHroovRCoR6dP47/u9c4X+CNXWAie+ mXqQor2CfNpmbkibzdmOY4nBMTPQzuydwavveBvOKturgKlAln91M82iTCLbtQXiEtgtv/ KS4fbmKH7yNd+NGyItKdl92Mfx1M1N0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676540825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n9ZbC/yZoS+EllJFHjVEOvoIsGMwmzQvn0ZNh0HypLA=; b=Cnd1cPOWP6swcf5d81AnUK/taYmoXZsw7gvsCeYN0hg7xm+aNIH12TFKgxSSF7OxfV1FTs Na2j77aVuq3zx3ZEL6ThaDKqXG6FWpXoqN00R0o/oG7x4ARbnH9bMy5seStS4UCPQptVgx 5+HiQFk0MIgJZrIgoEJr/fVBccxBhbY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-661-dGah6WnUNYaeOH_Z7COuSw-1; Thu, 16 Feb 2023 04:47:04 -0500 X-MC-Unique: dGah6WnUNYaeOH_Z7COuSw-1 Received: by mail-wm1-f70.google.com with SMTP id p14-20020a05600c468e00b003e0107732f4so616101wmo.1 for ; Thu, 16 Feb 2023 01:47:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=n9ZbC/yZoS+EllJFHjVEOvoIsGMwmzQvn0ZNh0HypLA=; b=N1RQNsjZB6Hq/jDWgiuOgunPFLpYafCoA4NidW54A9TraPTT8hMSMwT6fzbKUOQoGG v3AXHnETLeJA14lIgAfDyPgxIc/TY/nUzymeoIMJSeEqNLua0qH2rLMrietKB7hIxfSf Bt4Wx+x/hFZtHqiYJgspzT0supt2f7LHm5vQtNcd6osUPzcaB+CdciLnFI+BFOHDSTzT 6yg0KQUQYhdK78I+APdg0LWt3VYG4Y+DUIHehhvL60t5V7ghN+obYnA2FsFIeg7E5cmW m/jksE30+RfhwMqn+Jt78WGk3EBszr3WcBk5VPARJbDYIB95enOE36Se097GOad7E1m6 9Zuw== X-Gm-Message-State: AO0yUKWf4Xz//crSV1MYsPlRpYMCgcHS4jPA0DU2LiFm/VyV5x5gpOpP ccKVgcmIiOY+aQz3OYGalDUVBn1POJALLqz7C1c8v37KevbZmYI9dhFfhCPQJbeBhA7a1kMNZJW UIeyXpbbmzOo= X-Received: by 2002:adf:fc8a:0:b0:2c5:5836:4e11 with SMTP id g10-20020adffc8a000000b002c558364e11mr3768185wrr.55.1676540822913; Thu, 16 Feb 2023 01:47:02 -0800 (PST) X-Google-Smtp-Source: AK7set/YsK/s/hRdvzQyrsSnlrgQI2zLVsRG2a7mY/dJri7gXuWBq3Omxd+uIv12aRYY3hHjUxMqrQ== X-Received: by 2002:adf:fc8a:0:b0:2c5:5836:4e11 with SMTP id g10-20020adffc8a000000b002c558364e11mr3768171wrr.55.1676540822595; Thu, 16 Feb 2023 01:47:02 -0800 (PST) Received: from ?IPV6:2003:cb:c708:bc00:2acb:9e46:1412:686a? (p200300cbc708bc002acb9e461412686a.dip0.t-ipconnect.de. [2003:cb:c708:bc00:2acb:9e46:1412:686a]) by smtp.gmail.com with ESMTPSA id n15-20020adff08f000000b002c567b58e9asm1028087wro.56.2023.02.16.01.47.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Feb 2023 01:47:02 -0800 (PST) Message-ID: <9c274928-1118-1b31-9aff-07cd246cbbcf@redhat.com> Date: Thu, 16 Feb 2023 10:46:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v2 1/2] mm/memory_hotplug: return nothing from do_migrate_range() To: SeongJae Park , Andrew Morton Cc: Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20230215230300.61125-1-sj@kernel.org> <20230215230300.61125-2-sj@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230215230300.61125-2-sj@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E0CA5A000A X-Stat-Signature: h7dqf81icapn3kgkc1btnz48cgma9ink X-Rspam-User: X-HE-Tag: 1676540825-3684 X-HE-Meta: U2FsdGVkX18Sw7AWmBuSkZpm5GX9OnJnJhA46A/FVWG7c7u9DX6kasCKA3fQrMX9nu9HJTT76lBOaN6iUcCu1i9M1OtCj2erin2bUyTg7DPbcxSp6TRGmpuVbFO4OTbBsk+hKlJj6+o1n4ab+4V0bj1qXREm4qVH5eLgsdoUvauXDzBIPMSsYN8XvBfgwuKHIaMVazbYJ6SAM5SQDPV1psfcTiRWV3/S+DxdiKIvfkCVftHorUyw8cpQ56tDiEY2L6F73tOysyVdFygRs5uZciqn2FKyRiktwEEVTFpvQMsxvPMf/kWJMVgYe5xtuNtflGUNTaaBHcHD92vkCbOWLuOs6dnXRAGozl+xIPeafWMJdBlAMjNKRC/Ym7F5Bi61nqlnfM5jjdBsknkvWxG6Opm2H+Qvn/pcfpzY6uHqGIQ6wbJZCA7kBBUnc3JSsVPrQPHddIKi0vsyVJ23M/L70TH3VZYw+PWZjoMlkqV1ZXeidc5p9XmTZUOagT+Obd3AbJVpPQBYBErhbJQ4yV0gxwxf1lQybJn99BB7NTDtcnwAduhB4hZ0qY3xKD/uxmUhG+77cHDKCnZPEUj3rjJOT902eiT1ImL3Tc9X1iZe8+UOFmVrDtSuqRvJD0XzYxRPIkflb1qtDc4yCRvThQyB2QkiNt4R3SLLQglZOGCJsmQP2s/IERIQntvAqvx+VTk7WrWIJXFLoIZU5XOOE/gV7MwaGWSfUccTrfik6VD23jVJ365XSWFulGRT5HbSBgr5u1GN8B6G5i4h90Xva9nPJkQDvI+u7DAkhxRVmDPCQW8UZbc3VKsHtMmpTLtFE39CUtYVM34IpKgsd9g98xHrmfWrqLz8DP+1oclqe5kNQaZDahz6gmCjMmjRn/UzZKhkAjk2/vc35MTxX+IKEmEQtNDfFhtRsUfx6yxZaJhux+cIwWOYZv/Pnk+h7fSTT9mDXEb6ezaXtQzDXn2ON3Y PnsmPp+t 53tnZpRen135Q2gf+THXeooqb1WHMSFJTzuI68aYujU7agcuS+OMyJedpxDpvuqu3+fQ3svbI0WTCIlYH7RHggYRw9zQrX08VgO4nmCo7kVIOpZ176/I9w93uT2T60Z0m9SKqzJpu+s2X09zol1kxJjWW3Oy/m4XErFMp+YM1t4ZCoedwIMmQHkSi3zrTvMlHsFMTAYZIby0IGZ3wGtIHSfgq0r9thRguc2gk7nPjIYXVnOYvse9DJg4k2G1Dl36hnpmcgXPYvqISFGO8oAvOMxsRKi6dmGJLeS8egPKCZQBRQh9wtQmYP5R6Wh+yHePVDUsaRRp2RKCe71mcbiVZO9xelxe1OwqjxFomXFOMmpkrj0ayPheK+W5DIGk46jsTC0tx6ZS17XmNnZd0V0RC1i3fU90RcNJOf6ymGgtl9u0CZOOT4H164qCPpQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 16.02.23 00:02, SeongJae Park wrote: > Return value mechanism of do_migrate_range() is not very simple, while > no caller of the function checks the return value. Make the function > return nothing to be more simple. > > Suggested-by: David Hildenbrand > Signed-off-by: SeongJae Park > --- > mm/memory_hotplug.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index bcb0dc41c2f2..6c615ba1a5c7 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1620,8 +1620,7 @@ static int scan_movable_pages(unsigned long start, unsigned long end, > return 0; > } > > -static int > -do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > +static void do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > { > unsigned long pfn; > struct page *page, *head; > @@ -1721,8 +1720,6 @@ do_migrate_range(unsigned long start_pfn, unsigned long end_pfn) > putback_movable_pages(&source); > } > } > - > - return ret; > } I think this patch should also stop initializing ret = 0 inside that function. With that Acked-by: David Hildenbrand -- Thanks, David / dhildenb