From: "Yajun Deng" <yajun.deng@linux.dev>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: rppt@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/mm_init.c: remove redundant pr_info when node is memoryless
Date: Mon, 11 Sep 2023 02:57:31 +0000 [thread overview]
Message-ID: <9c1bfbeb50ac0d4fe728c45329c958607f13d88c@linux.dev> (raw)
In-Reply-To: <20230910143004.e8191c8ebabbe7ddd0fec6fa@linux-foundation.org>
September 11, 2023 at 5:30 AM, "Andrew Morton" <akpm@linux-foundation.org> wrote:
>
> On Wed, 6 Sep 2023 17:11:13 +0800 Yajun Deng <yajun.deng@linux.dev> wrote:
>
> >
> > There is a similar pr_info in free_area_init_node(), so remove the
> > redundant pr_info.
> >
>
> Please quote the before and after dmesg output so we can better
> understand this proposal, thanks.
>
before:
[ 0.006314] Initializing node 0 as memoryless
[ 0.006445] Initmem setup node 0 as memoryless
[ 0.006450] Initmem setup node 1 [mem 0x0000000000001000-0x000000003fffffff]
[ 0.006453] Initmem setup node 2 [mem 0x0000000040000000-0x000000007ffd7fff]
[ 0.006454] Initializing node 3 as memoryless
[ 0.006584] Initmem setup node 3 as memoryless
[ 0.006585] Initmem setup node 4 [mem 0x0000000100000000-0x00000001bfffffff]
[ 0.006586] Initmem setup node 5 [mem 0x00000001c0000000-0x00000001ffffffff]
[ 0.006587] Initmem setup node 6 [mem 0x0000000200000000-0x000000023fffffff]
after:
[ 0.004147] Initmem setup node 0 as memoryless
[ 0.004148] Initmem setup node 1 [mem 0x0000000000001000-0x000000003fffffff]
[ 0.004150] Initmem setup node 2 [mem 0x0000000040000000-0x000000007ffd7fff]
[ 0.004154] Initmem setup node 3 as memoryless
[ 0.004155] Initmem setup node 4 [mem 0x0000000100000000-0x00000001bfffffff]
[ 0.004156] Initmem setup node 5 [mem 0x00000001c0000000-0x00000001ffffffff]
[ 0.004157] Initmem setup node 6 [mem 0x0000000200000000-0x000000023fffffff]
next prev parent reply other threads:[~2023-09-11 2:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 9:11 Yajun Deng
2023-09-10 21:30 ` Andrew Morton
2023-09-11 2:57 ` Yajun Deng [this message]
2023-09-11 7:51 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c1bfbeb50ac0d4fe728c45329c958607f13d88c@linux.dev \
--to=yajun.deng@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox