From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D01C00140 for ; Tue, 9 Aug 2022 01:13:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AFD68E0001; Mon, 8 Aug 2022 21:13:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 637A36B0072; Mon, 8 Aug 2022 21:13:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 462D58E0001; Mon, 8 Aug 2022 21:13:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2FAA16B0071 for ; Mon, 8 Aug 2022 21:13:19 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 04EF81C5BCF for ; Tue, 9 Aug 2022 01:13:18 +0000 (UTC) X-FDA: 79778280918.17.364E367 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by imf18.hostedemail.com (Postfix) with ESMTP id E3C441C006A for ; Tue, 9 Aug 2022 01:13:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660007598; x=1691543598; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=gLa0l7sj6uDna3DrmV4R2FSIdMdr+bgXyNd7vyf5bXQ=; b=bBrx3U3CHjDwV1LDlB6IkjFx0JzDiXLeGgaPx7FXNgBmruBP3lR6mZ22 v3KvYI6OqPzdauwPHt5J6rkKv3Fr7/RBbgLesfEhUUZgrag5GieGQegBr SwQ/C6Styy6bbc3bp17bWfS77yjruNlB1eDejBaAIgsNmX3Owa3BbQzlH K0asX6QvgTpQ0MdcyllBTnu2fMVhJ90tZtvEu0WPq/uwlu0RlcE2zO5Wx elg79KfC52WuBEvVL4mrq1bQ+SBh7W58WsH41Kx5uAotpAEZZX5A9fjJH PoIjoCyBOhN2wPEjvm2eYb5jFTTzVhblpcheEuAkOSiU8lGDXJR+5i+iO w==; X-IronPort-AV: E=McAfee;i="6400,9594,10433"; a="270502119" X-IronPort-AV: E=Sophos;i="5.93,223,1654585200"; d="scan'208";a="270502119" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2022 18:13:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,223,1654585200"; d="scan'208";a="672704004" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga004.fm.intel.com with ESMTP; 08 Aug 2022 18:13:16 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 18:13:15 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28; Mon, 8 Aug 2022 18:13:15 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.28 via Frontend Transport; Mon, 8 Aug 2022 18:13:15 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.28; Mon, 8 Aug 2022 18:13:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ikbM6Sz3I8EfqhfYN+TurP2Aaq7mZkE50H2MH8fVTY8Wh6qn2lbNoeaWBs395B9sxIRdFO6/N9Tzl3JBtBZhP151MXExeTc2lDLMvZ/QUcfQd6rrimZxPFKgixxwKANXBJ7zbISbT/7Qf4uePrI4dAN2xv6DckfYmuJGWBIyklvprriK8knKbBr8Utcg1SiUA0/ANuveotpXes56LapZ7dlw54ivm+csKhaxky81kJqn8v5OwQWbjNC8qm8baA95mwz9ArWqx8oHWPGrZGnLCNlIsk/eJxeczb5CzLjc7YdibrckNfmOi1Mr+JNa1qHxY2Jq09bLLTFn8fYeStcycA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WGOuSRddWsiQvx0XEod9RfXw2BWFXt6w4JgYnqIYjRU=; b=O50w00njd3lbfTqeAMK9XJv85k3S6hnIKueT6fpTrXU9qpqvRuk1rabHiQKlORc+tw9uu70jwSrIxkhB3DO0PQPiWYUnFAkyva7hzmo+mwqYGmYkzRefibOkBNpSBgttKupCmnSLZhqXrPrDikNgaBUArYseMKPIU5TYrIh4Je038Kdx8K/uk+0M5EqNpvxWW5pCyDpS630Q+SCPw64O6AbRZj+dXy5Fh6OOJE0XkwzW5F2dNhKltRInzeEgLxX/6qf2PGmFzBM6X+CynhkkUKrcBHMmhoE08Yo/72y63cdsm5TBmU05el7Rc0cuZFyAardSPeLYv4uxtu9kD47zjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) by BN6PR11MB1410.namprd11.prod.outlook.com (2603:10b6:404:4a::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Tue, 9 Aug 2022 01:13:12 +0000 Received: from CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32]) by CO1PR11MB4820.namprd11.prod.outlook.com ([fe80::552f:2392:56f8:ca32%3]) with mapi id 15.20.5504.020; Tue, 9 Aug 2022 01:13:12 +0000 Message-ID: <9c16b712-b5e7-df79-e7de-0259086bb3a9@intel.com> Date: Tue, 9 Aug 2022 09:12:57 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] mm: release private data before split THP Content-Language: en-US To: Yang Shi CC: , , , , , , References: <20220805062844.439152-1-fengwei.yin@intel.com> From: Yin Fengwei In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR02CA0021.apcprd02.prod.outlook.com (2603:1096:3:17::33) To CO1PR11MB4820.namprd11.prod.outlook.com (2603:10b6:303:6f::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: da7aef88-34f7-4705-76f3-08da79a45425 X-MS-TrafficTypeDiagnostic: BN6PR11MB1410:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kpLGlpOh+koGbOsymw6Ic881/80++7t4vttUQXBTIZIxkrslOPca33Fxheb5wZNpDs3zEuut/91Sl0JYq7DIwSGn1nXtLRZj0UoLhuMIOxWjmX1p+pkKlPJ+PmDcrda+RR+kwnZrgQpTu6ALe4dyNd4wMfxwy688hMCuee6rUhfMDItJwNphN+BpI0w9vrxhMQ7xhJObG+0OQ4ImCGHmS6xroHNkVBNTHWrKVFhzZgWgbAinkM9Cg49GrqtrTZNW7wf5kIGJQbE3MMbl5ekHOlmATgr0adE4NcrIXv1qtbvyI7ExG/W6aAQOU1+1M9VxVA0zj7er/5Rf/6DVwLjtchiZumcmGVu0FgIEziVXrWEnDN1YteInLMZOtMiEwERvp+wjpZDTZyWaqjn70PmivtqaccEbOIcL0XY56Q3c1ZKNUATXxgEW5PsqhNYqgl+P0aXHFtXU5KEJb1rWbzIrxMjIsUl9UWUOVxLqReyoj4dxhGbwXfAm5HlxDEeKlXbLRbyDSNJikpPQdv6VlwonMpv3lWhELqS7Yh3cpo6YnvHbVmVYv12Qk6eioUci2E6k1ctI2D/BN5o0uKHdyg0ywQ8DuI+AgdooYXhh8nwuDSQWPgw14c/gZsRzwLIIpu1sxviy0DCZwkoQKVWpKzZAQBIY9O1pB4pML5/JxsQdcLoht9UTyeR0eXcdCqw6JzOGE/P/RWlWiZInYBVt4AbH0nrUBhBi18i+uF9SBSb+xwANf7LBo8VrjouytNRyWbiZyxeUbGu4nM3vk4BgdHQi6n46+HVjTVfusSSrRIkO1VJONsaZm0x2u8LMj26+yIU91ZD9RnTmMO6e0tbMIFNqVw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR11MB4820.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230016)(136003)(39860400002)(346002)(376002)(366004)(396003)(82960400001)(86362001)(31696002)(38100700002)(66946007)(66556008)(66476007)(8676002)(4326008)(6916009)(316002)(2906002)(4744005)(8936002)(5660300002)(6512007)(26005)(6666004)(53546011)(6506007)(107886003)(2616005)(186003)(41300700001)(6486002)(478600001)(36756003)(31686004)(45980500001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0R5RVN4TUxpeXlWZmRRUzIzMGxVeWpoeEhuZ3NpZ2kxeUJrSURaaFByWmlo?= =?utf-8?B?SjMyNCswT0dFUTFGYnRHejdmdzdRYkpWSWx0SGpUYlRWK0RydUtVME1URHBO?= =?utf-8?B?Z3BzaTM5SDlHc2RYa3N5bk9DWVowSFp1R0NVcXBsQXlkd1gwcFhURHBYTDRq?= =?utf-8?B?TytmQmVOTE85K2ZGS1JFdERLUWEyNzN3UmNqcWU1M2RjcllnbUhHOTFoQk5L?= =?utf-8?B?K3VUY25zOVc5NC9yV1lmdW9QTXk3OEpwWkh0eEc3QnZqZGZlb3ZEN0FURmt1?= =?utf-8?B?cGxIRHVmMzV6VjdBQXdJbG5FRE1jVWMwUWdtWkVXaDYwZi9QdUpsOXQ5QklP?= =?utf-8?B?bHBheWhlUjJuaEJZUUtLeDlpWVR3NWJKM1lYdUI0c2hKZThHQWhCTmRzaHdh?= =?utf-8?B?eFVnalhqdTZPaDFsRlZNbVVIaytnVnEyWWYxdStoeHRJRGE4Vk5odnhYQ3Yw?= =?utf-8?B?UEJTTDQzRVZvMFRkdVM4elRhaVJ3c3BCaC9iZGNRbHl4RStFUFE5bjBNQnhL?= =?utf-8?B?blpvTGh5RWNHYkR1djlHczQyaFhUemNWaU56aDhTblZmRzVXUkl1QU1nVlRP?= =?utf-8?B?YTJwcE0zY0lpUllkV2tJTE92UnVrNEJvRThyWmtCSDJ5bHM5MWsxRVlleXJU?= =?utf-8?B?L1owbmV6OUw5S2k1YUJBRWp4T0JBbmlYWElPNHhIcG0zaWpEeUZ3eWZVMW8w?= =?utf-8?B?eFRBWlZocTNsZnNBMHVGL3hDNitMNzZDeGx1TGNKbzRjdjYvbjhTUHg4OERC?= =?utf-8?B?VFhqazk0NGJWazFGZGkzajFRT2JBQStPdkE5U1ZlZS9aTWdIMTV4a2JEd2d0?= =?utf-8?B?aXpxUlZrZVd6TkxuaWdXbmh5ZWFUc1JyZ3pGZGtKQjZ5RmhVMndPWFFkcERC?= =?utf-8?B?NHdvSGhySDFkQ3BhbEx3Uk5CazdieVNxVTdqZENmZUJOck5xdFRjWTdwdCtY?= =?utf-8?B?U1g5YlhpQVdNTk1TU3NKZ0p4WnZBeWJQK1FTSVdRa3ArK0ZiWXpwblFKT1Bw?= =?utf-8?B?cm9MUVIvNk8xTjhmdys0UkV6OTRxWXkvUU1IS2pldkdUMVFjQXRwUFFiQ0lW?= =?utf-8?B?cnliTzZjdnFFWDU2YktRa1hRSzhBREJJdmVlc2t0MFFrM2l0R3dJRW1YajB1?= =?utf-8?B?T2puZFJ2MFVvclZjdGpGOWtZMWJYY2pFNFBxMm1pazFBUEp3KzNncTV2aTBn?= =?utf-8?B?K2k0WTlRckEvR0tTbDZsUWpMY3JzS1RDQ1UyZXh3YTR0MVRHYWZ3cjF2Rlh0?= =?utf-8?B?QUJycFRhM3BkdmI0d1RNMU5zVlROcXhFVjR1aTFmT3VNYkJGSnR2VVhLVVNn?= =?utf-8?B?a1ZBanQ5MlBwTzNrUnAxVzV5TkN5OWR4b0pubXp1MStDbks3b0VNMWFjbG5Z?= =?utf-8?B?KzlRUmMxUFIxK21SL2Q2RUdlY1JaQzlrK3NZcmdoSTY0R2w2cWJGRWozNVN4?= =?utf-8?B?T0pyZ2wwRnB3ZnpsZFlNWU81b2ZCdjNOaDZGNjI3SzdVeFpvRUo1ejNKNDV4?= =?utf-8?B?M0RSK0lrTk5mclZ2WUh0V3kzd3FvOVZwOU5jL3hQUUhHVGFhZFpJZytKN2hs?= =?utf-8?B?Vm9TRHoxWnRacUs1eU1lTExzVVcyWHFxU3hxeXEvMVdLSmM5YmpWSGhCWWMw?= =?utf-8?B?aGVPUkRoNDdlZWhRT3JweWRpUGdNaVQzbWNOVmFkSGxDODAyKzExRDJmcmts?= =?utf-8?B?bFAxcEVadVVid0g3MXU0Q09Pc3RwYTZVb1VFUUJkVnVFU29MbjNmZklFaEkw?= =?utf-8?B?eEFuM282MlNKZ0kzZmhta3F0dXNXc1FyUGMzQnVybjBnV0psaDA3WEIrSGVP?= =?utf-8?B?U3dBT3hEdEdGWEQzM1pkNEFKbTZ5NVNSWHFlVWVUVW1KWkxyRVViekFZd1NU?= =?utf-8?B?S3BISlNXaTRFMHR3NVhTOUJjMDlSTnZYWXlsSXJ1aWFuYm5XQ21rNEtJZUpG?= =?utf-8?B?NzRTQWE3T2R6NHlSTzkzdEFKeWNLMlJRWi81MDkvSkNBUTVYTFJMeVI3emt6?= =?utf-8?B?QjR3N2pOOHVGaVFjRDJaVlpsekVjTm1EdnB2U0N1akxSNzlKbFJYLzRxek5r?= =?utf-8?B?M0tJZnFuOVNnNlQvNlV3Uk1udUZaSTNuY0xZYmp4cXdOQ2ZQc21wTm1Fc2V3?= =?utf-8?Q?RR72bWGGYkM56U+RB2URaj+4G?= X-MS-Exchange-CrossTenant-Network-Message-Id: da7aef88-34f7-4705-76f3-08da79a45425 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Aug 2022 01:13:12.0778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: KF/fMhCHI3DvIYilf4n+Y6y0GdXSokOMiyUVq4kqRa4hJKRGk8OBM0IKuwtIJbH9WFZqvtXuX/JLE787OuId/Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB1410 X-OriginatorOrg: intel.com ARC-Authentication-Results: i=2; imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=bBrx3U3C; spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1660007598; a=rsa-sha256; cv=fail; b=YDW3e7hZa5ShwcY2JLkG9b2FvI9ldWLF9/cICnz4V35zypw1JZv7dilqOpOkLqgmRXNne+ qz1XtybWgeiyczrb2aXNS8mfr9wXXDkvPbx2bMSeWM5J+yjbDlVLR5fcHNaBa40+6lT0eL /mGIzFM6ND6s6iDs2vI8Gm+TNkzjqas= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1660007598; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WGOuSRddWsiQvx0XEod9RfXw2BWFXt6w4JgYnqIYjRU=; b=PQ5kTwrZIxWcgtXF3cEOjoUvdJeBA+eR9/FrkAhBfpGYqlVEbuIZgcZMmvxXaGA8mqX/4U aWtyTzDDvQDgCCthAiUqOTnHJFilhJg478TydtdPP4tsM6zcDh0ARYP2OnKUbWolHXJa7a v3SVDHCxitxbEp4Bo8pQvl7dkTODHV0= X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: E3C441C006A X-Rspam-User: Authentication-Results: imf18.hostedemail.com; dkim=none ("invalid DKIM record") header.d=intel.com header.s=Intel header.b=bBrx3U3C; spf=pass (imf18.hostedemail.com: domain of fengwei.yin@intel.com designates 192.55.52.136 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=pass (policy=none) header.from=intel.com X-Stat-Signature: cbmiiucaoo3mmedfeaa9ubw3sbmfs48z X-HE-Tag: 1660007597-265205 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yang, On 2022/8/9 01:49, Yang Shi wrote: > The GFP_KERNEL is fine for most THP split callsites except for the > memory reclaim path since it might not allow certain flags to avoid > recursion, for example, nested reclaim, issue I/O, etc. The most > filesystems clear __GFP_FS. However it should not be a real life > problem now since AFAIK just xfs supports large folios for now and xfs > uses iomap release_folio() method which actually ignores gfp flags. Thanks a lot for the valuable comments. > > So it sounds safer to follow the gfp convention used by > xas_split_alloc() in the below. The best way is to pass in the gfp > flag from the reclaimer IMO, but it seems overkilling at the moment. It's possible that the gfp used by xas_split_alloc has __GFP_FS/IO set. What about to use current_gfp_context(gfp_as_xas_split_alloc)? Regards Yin, Fengwei