From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51A65C4345F for ; Fri, 26 Apr 2024 06:30:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA5B46B007B; Fri, 26 Apr 2024 02:30:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B2D8A6B0082; Fri, 26 Apr 2024 02:30:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A6186B0083; Fri, 26 Apr 2024 02:30:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 78CA86B007B for ; Fri, 26 Apr 2024 02:30:02 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 24515A2243 for ; Fri, 26 Apr 2024 06:30:02 +0000 (UTC) X-FDA: 82050707844.18.64DC8F9 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf10.hostedemail.com (Postfix) with ESMTP id 7DF85C0016 for ; Fri, 26 Apr 2024 06:29:59 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QxpEysCn; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of sourabhjain@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sourabhjain@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714113000; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mDlcWK1a2zODr0FhRKh0nn8zrpsPBX6nIzk2EeTf87g=; b=W2RhsjjPiVPSZfVqi3d74hoQveLID0WHDC8/dpIezFbMhHExzOZBcjb7mxgg4Zzq9PxdP9 xCA+naUUk22RSQiQEmp0JkbB+u8DJmdONPMpOkQ8t1E+DrnUl4gb3mJ5tK8waK9NDhViel 4o5Ty/3KzfsDD5Nrv9LOoVIcUaY90bI= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=QxpEysCn; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf10.hostedemail.com: domain of sourabhjain@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sourabhjain@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714113000; a=rsa-sha256; cv=none; b=eVq0pID0+EZ33HrXzima0vOnZwDII6DRaTsvqxsc3ez3JYvjg6Jj40QGyuQ4yhM7KD/hIO xOeN2vUYWTyQOiHkg6/f5Zjy6EIx2DjRqHAPJ52JJcVxWs3l+Ot0RJ49ZDhJT4dRPnQAdB stWXHoeu/f3AEsGLLx9zPXiTTSPVub8= Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 43Q5H4XE023039; Fri, 26 Apr 2024 06:29:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=mDlcWK1a2zODr0FhRKh0nn8zrpsPBX6nIzk2EeTf87g=; b=QxpEysCn5/dFT7KjmR/8Y7gv51YPE7aE4AxkDmNb2Bz39hZNKEzE+JXR6AnhVxwlw4/X 6m7n7094yPWVV3U35vOf1/f/KXps9IKYC2L6zEusuYlQyJjr+MN7C9eEmqeu6NvKYRaK v4mkLHop5ABsR6Jy7cjzr4msb5LzSsk9ai6JmaVWW+QfE6wr6L4GTL0Mf72rsP7/fqQO FMKJNIdBn16TiQKfcGF2YkEliaTlVTeiDEQHDng7k/OtJBY0XU6cR1UpsRNCknHki8hA Ns5fXmheR5czlYWjGCn2AIfYyB91yRxFQFLRuV93hGFDgcuhjEfoqa2F6n/0LCdfh7MT bQ== Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xr5yxg5s2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2024 06:29:53 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 43Q3huwr005736; Fri, 26 Apr 2024 06:29:52 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xmx3cvy0f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 26 Apr 2024 06:29:52 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 43Q6TmDj51708262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 26 Apr 2024 06:29:50 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BB71B20043; Fri, 26 Apr 2024 06:29:48 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A7C162004B; Fri, 26 Apr 2024 06:29:46 +0000 (GMT) Received: from [9.43.111.8] (unknown [9.43.111.8]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 26 Apr 2024 06:29:46 +0000 (GMT) Message-ID: <9c14d5bc-ffb2-4ddd-a5f1-5d419e88b187@linux.ibm.com> Date: Fri, 26 Apr 2024 11:59:45 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [linux-next:master 7646/8170] arch/powerpc/kexec/crash.c:488:2-8: WARNING: NULL check before some freeing functions is not needed. To: kernel test robot , Michael Ellerman , Stephen Rothwell Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List References: <202404261048.skfV5DDB-lkp@intel.com> Content-Language: en-US From: Sourabh Jain In-Reply-To: <202404261048.skfV5DDB-lkp@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: _xj613nCTZOGl2BuS2utqVC2nOeX7RZk X-Proofpoint-GUID: _xj613nCTZOGl2BuS2utqVC2nOeX7RZk Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-04-26_06,2024-04-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1015 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2404260038 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7DF85C0016 X-Rspam-User: X-Stat-Signature: r1n4y8iqfend6hpa8ekup5ymezot8xhm X-HE-Tag: 1714112999-761645 X-HE-Meta: U2FsdGVkX1+GRJezuV5dMkyWa0Es3t8jKreMInGHukagSx7YG/eJg2yVSZMABSqUD2BvVQ2T1kh6mENrWvfMrbNbff9jd5Zi2pl/rLT0Vzsns8ssfd7LdqUU9s6PelXbyg+TgATDqm7+qfEX55k62fyTgfUPY9R/Db7iozxPGd6kAOSOMy1ZLGVbijp89gNtfuTZhWvbzYN7X87iaw5dF5e2cFcHlKv3Qbv+AhWg0S2ojLZUqSaKv/RtkrKL7AFaCAE8Nnvf/bBTxivkvVaXxiOek/c9PmD1mz9BJzE/jeMUJRX7H1nu86Ug5A8wu8EUXPOYvdUAiiaV6/tjs1+ZnumDwy6aUT5O/6OM4fxSfG9E+kTYemLjHXL6E9DPAIdquwCR8B5vFv9YzV/rJX6ZtJBwf2vaL0HbtjmK9Qj56PsxcpR5YPAFecPxdRQnuVo8FFZnGLP5NAGdR7BjmiMfKzmB/HEGSUB9kU8DV0HKoeBk+NfVs3iLiJQveowNuABs6d42+0jNqGIw3hIeOoiMLuetAolk2WlTGqeMF/IF2IPpAriY4mFHuEwW3D2SZ6lDJO6kd0SLuNWRwQGhXOWnrPhfgSy8oLRdp60dxKHfOH8OCTOIYZv3s20J/nPHmGC0i+K4YIfuTueBVfS4MC49daZDvlL8v8Xy2OcrDyrpdPJmQChYHBrWuJPRCFte/B/IKBqGO/qQOHCSi85ftk1HdYb09jk9s/u03FRD/eII8291acqpPGg03/pQJAUOnggTR6QrAhxlh9lZwp1E2h94DBazX0kod+Gm4WHsVP5+keaJFTvvFAugr0+UlTCqkyryXYmOOwOD4qD39HZSyTVY+z6iCAN0IoW/TrHdKklDKTZakXd0ychKzq+N3kg3Lla+nfAnf2I62Z4Iaz961ReBfiSGSLY6/wmoVzGjpizdo4fM8wzEvOOsHdRhyvElB+co0ORXf+Ff0aRc3sV2eQF Po+rPrgB As6yqZDcwodEPtumOV3vx8jJr9l03g2RFN9CaQpmP8Up3KjgWuVcZ7l1t2Zib79Dw2b6hc+rnrgduRsPmM4IgzeoKC1Jx3KNxEvKUK/WD9FoBfQEQAdNwqRQ2ftm7L0NvlD4I5m1BQRaarKxqC7fIS3QBJ7a377AuxLZS+SLOp4OwEAl22yec5cWXZ9JNlfnTJGGPV2HkCCq+ckxGCOqv1u6qmEnTfO90eLIOVeafDpvlB59BEvWC38oEFQbsh+mPszuo9ehLkXgrRhJ+vQ+evJ+Plja1tcX8xOzrKeJmhDJljMJPSV6HgGK89Fcz/iUguNs+KbR33MxDkf0BjbnHBxcYtb8sc3WFXs6W7+s6ilTtWxEKx0Wm7VKmlJoRFGMqIBe3qPZ8S0Ajbm/fsNYtLretYNpkwFcYYUtMDlvB5EWAekP8jRbFVKZwTymB5VxFJ2grRzqiudwAUd8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Michael and Stephen, I fixed the below build warning in v19: v19 patch series link: https://lore.kernel.org/all/20240426060728.559753-1-sourabhjain@linux.ibm.com/ Only 6/6 patch has been adjusted; all other patches remain unchanged. Please consider the updated patch series. Apologies for inconvenience. Thanks, Sourabh Jain On 26/04/24 07:57, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 5e4f84f18c4ee9b0ccdc19e39b7de41df21699dd > commit: 849599b702ef8977fcd5b2f27c61ef773c42bb88 [7646/8170] powerpc/crash: add crash memory hotplug support > config: powerpc-randconfig-r061-20240426 (https://download.01.org/0day-ci/archive/20240426/202404261048.skfV5DDB-lkp@intel.com/config) > compiler: powerpc-linux-gcc (GCC) 13.2.0 > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202404261048.skfV5DDB-lkp@intel.com/ > > cocci warnings: (new ones prefixed by >>) >>> arch/powerpc/kexec/crash.c:488:2-8: WARNING: NULL check before some freeing functions is not needed. > vim +488 arch/powerpc/kexec/crash.c > > 418 > 419 /** > 420 * update_crash_elfcorehdr() - Recreate the elfcorehdr and replace it with old > 421 * elfcorehdr in the kexec segment array. > 422 * @image: the active struct kimage > 423 * @mn: struct memory_notify data handler > 424 */ > 425 static void update_crash_elfcorehdr(struct kimage *image, struct memory_notify *mn) > 426 { > 427 int ret; > 428 struct crash_mem *cmem = NULL; > 429 struct kexec_segment *ksegment; > 430 void *ptr, *mem, *elfbuf = NULL; > 431 unsigned long elfsz, memsz, base_addr, size; > 432 > 433 ksegment = &image->segment[image->elfcorehdr_index]; > 434 mem = (void *) ksegment->mem; > 435 memsz = ksegment->memsz; > 436 > 437 ret = get_crash_memory_ranges(&cmem); > 438 if (ret) { > 439 pr_err("Failed to get crash mem range\n"); > 440 return; > 441 } > 442 > 443 /* > 444 * The hot unplugged memory is part of crash memory ranges, > 445 * remove it here. > 446 */ > 447 if (image->hp_action == KEXEC_CRASH_HP_REMOVE_MEMORY) { > 448 base_addr = PFN_PHYS(mn->start_pfn); > 449 size = mn->nr_pages * PAGE_SIZE; > 450 ret = remove_mem_range(&cmem, base_addr, size); > 451 if (ret) { > 452 pr_err("Failed to remove hot-unplugged memory from crash memory ranges\n"); > 453 goto out; > 454 } > 455 } > 456 > 457 ret = crash_prepare_elf64_headers(cmem, false, &elfbuf, &elfsz); > 458 if (ret) { > 459 pr_err("Failed to prepare elf header\n"); > 460 goto out; > 461 } > 462 > 463 /* > 464 * It is unlikely that kernel hit this because elfcorehdr kexec > 465 * segment (memsz) is built with addition space to accommodate growing > 466 * number of crash memory ranges while loading the kdump kernel. It is > 467 * Just to avoid any unforeseen case. > 468 */ > 469 if (elfsz > memsz) { > 470 pr_err("Updated crash elfcorehdr elfsz %lu > memsz %lu", elfsz, memsz); > 471 goto out; > 472 } > 473 > 474 ptr = __va(mem); > 475 if (ptr) { > 476 /* Temporarily invalidate the crash image while it is replaced */ > 477 xchg(&kexec_crash_image, NULL); > 478 > 479 /* Replace the old elfcorehdr with newly prepared elfcorehdr */ > 480 memcpy((void *)ptr, elfbuf, elfsz); > 481 > 482 /* The crash image is now valid once again */ > 483 xchg(&kexec_crash_image, image); > 484 } > 485 out: > 486 kvfree(cmem); > 487 if (elfbuf) > > 488 kvfree(elfbuf); > 489 } > 490