From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF73BC432C3 for ; Tue, 19 Nov 2019 10:05:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7EDDA20857 for ; Tue, 19 Nov 2019 10:05:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EDDA20857 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 36D996B0271; Tue, 19 Nov 2019 05:05:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2D0E86B0272; Tue, 19 Nov 2019 05:05:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1BF536B0274; Tue, 19 Nov 2019 05:05:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 01C8B6B0271 for ; Tue, 19 Nov 2019 05:05:46 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id BABBC1EF3 for ; Tue, 19 Nov 2019 10:05:46 +0000 (UTC) X-FDA: 76172595492.12.leg02_89a978852492c X-HE-Tag: leg02_89a978852492c X-Filterd-Recvd-Size: 2574 Received: from out30-131.freemail.mail.aliyun.com (out30-131.freemail.mail.aliyun.com [115.124.30.131]) by imf01.hostedemail.com (Postfix) with ESMTP for ; Tue, 19 Nov 2019 10:05:45 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=18;SR=0;TI=SMTPD_---0TiY4-pZ_1574157939; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TiY4-pZ_1574157939) by smtp.aliyun-inc.com(127.0.0.1); Tue, 19 Nov 2019 18:05:40 +0800 Subject: Re: [PATCH v3 1/7] mm/lru: add per lruvec lock for memcg To: Matthew Wilcox Cc: Shakeel Butt , Cgroups , LKML , Linux MM , Andrew Morton , Mel Gorman , Tejun Heo , Hugh Dickins , Konstantin Khlebnikov , Daniel Jordan , Yang Shi , Vlastimil Babka , Dan Williams , Michal Hocko , Wei Yang , Johannes Weiner , Arun KS References: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> <1573874106-23802-2-git-send-email-alex.shi@linux.alibaba.com> <20191118120815.GF20752@bombadil.infradead.org> From: Alex Shi Message-ID: <9bfbd4f0-3502-7186-34ad-d302bb526fc7@linux.alibaba.com> Date: Tue, 19 Nov 2019 18:05:39 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191118120815.GF20752@bombadil.infradead.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =E5=9C=A8 2019/11/18 =E4=B8=8B=E5=8D=888:08, Matthew Wilcox =E5=86=99=E9=81= =93: >> Thanks for comment, Shakeel! >> >> Yes, but considering the 3rd, huge and un-splitable patch of actully r= eplacing, I'd rather to pull sth out from=20 >> it. Ty to make patches a bit more readable, Do you think so? > This method of splitting the patches doesn't help with the reviewabilit= y of > the patch series. thanks for comments! I will reorg my patchset for better understanding. Alex