From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 525C9C27C79 for ; Fri, 14 Jun 2024 18:00:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 004B06B0157; Fri, 14 Jun 2024 13:54:44 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C41F6B015A; Fri, 14 Jun 2024 13:54:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5AE7D6B018E; Fri, 14 Jun 2024 13:54:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CA6206B0163 for ; Fri, 14 Jun 2024 13:52:15 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0F663A08DA for ; Fri, 14 Jun 2024 17:52:15 +0000 (UTC) X-FDA: 82230238230.19.1A41EDA Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf07.hostedemail.com (Postfix) with ESMTP id 00A6340010 for ; Fri, 14 Jun 2024 17:52:12 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h23J0G5h; spf=pass (imf07.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1718387531; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2jpal37P8aG8bHkz45viTb/GLat603mbjaFVLOrsupo=; b=x1ZAeMGcCrhNK7XHgHnjAsc/evkw8m2aqAxl/B6IyF4dad1rv1Wu7g6c6MCKc/2TCG3A8O DdwzU8XampgtI5v1WS46vFemym6S6d3iKjnWtGSoyupTQd5xHDec1BbRba4xn+/OEhQ7BZ 2ARIbgQ9Rwjosd7N6ledw8l3uuw49pw= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=h23J0G5h; spf=pass (imf07.hostedemail.com: domain of jlayton@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1718387531; a=rsa-sha256; cv=none; b=e+tflUMwQ8YUYWOP18Ebm0HXb9akWbvIlbDLhn3YX2NEB2Az34DtHpCqJwab+eEmCCv9BQ fs8c0jZWpeKwN0o7Pof4CYGBTA1syyKUmT7A4+WHIe8oabGMSOhZxiB4hCYSWQ+BMGDkMS fxTv+tMP4R/0Hs5nufsiTnRv+TD8jyg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id B527ACE2C49; Fri, 14 Jun 2024 17:52:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D059C2BD10; Fri, 14 Jun 2024 17:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1718387529; bh=PshLP8F/G7lzbUSaaYUvzQ2G4ZHraykzh3cvrdJcDwE=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=h23J0G5h5hrrJ7WGhU0ptT7zWQzsKadQsf/mP5EjBXnQPm0IquooK2IdBxUgPYUMA 3luv8aBRQK+vCEzZ8BeHKFiXPKhyA101913bAjbic9Rv1xGq06lat67uNSoVSI9Lxx cueQiT/FmcYGBp8M/dSBHkAVx3h0a8HNSi9RaFVygENoOF9Kznq4ABoqlZrJ0CwHYI Trnzo0WtFEy5lfUQJNDFoq+0NjFUuJ2ZoPwy3M0eRRJT6+wCkvLeQejBmDxU0aZSF1 EThFyY05VL2RL4D1TPs816tGRSk1fCnLoa7SNY2OJoHbXfcHlrEmDSnEvhBp1unUU9 Goh/l78Sy+8nA== Message-ID: <9bfbc01c4cb0d3713a160a5d00e8cc360ee6bb60.camel@kernel.org> Subject: Re: [PATCH] nfs: fix nfs_swap_rw for large-folio swap From: Jeff Layton To: Christoph Hellwig , Trond Myklebust , Anna Schumaker Cc: Steve French , Andrew Morton , linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org, linux-mm@kvack.org Date: Fri, 14 Jun 2024 13:52:06 -0400 In-Reply-To: <20240614100329.1203579-2-hch@lst.de> References: <20240614100329.1203579-1-hch@lst.de> <20240614100329.1203579-2-hch@lst.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) MIME-Version: 1.0 X-Stat-Signature: t88k8bz8h31u4437mpjar4wicy39m4dg X-Rspam-User: X-Rspamd-Queue-Id: 00A6340010 X-Rspamd-Server: rspam02 X-HE-Tag: 1718387532-187354 X-HE-Meta: U2FsdGVkX185amfm1PsVYwRkF19ukfWnfW7USq6gNohBUEEubQ5Nvukc6K2mKVJWkcYJQwN2M6vXaG9CecVbKb7+s3yrZP5pqOza9xRvF5g6qmXBvEc1b9X1dtWqu900MtCUhTqBpBcNw1F/PBqzxNITt576Qml0208fgAGI3hGuR1NuI6ovSexKmUSro1HPhgQlqRQbHikQjRGARW9Ya5QbbRGgoDEbyD6K8AGT2yhGzqrBu2EHce3RQEuL9GE9yRM34YtQZzc2HLD2UHwun69fkQ6z22oNVsqqyo9J9PP9DIbtc0lJDZN0kYZR7kHQItrD0ke+h3skLWEk6635Dk6FCIXz51SbtAAvfki8Bv27UQsI2VX60sheH+/KRgI5Yz0AW8hd0AwCJmY7VMpovzfl3HGMRP+0TnTp/VvZk0RXm63sOHWCTJL5SXgX9KM7Qf3ydCP1tXh/x93c4MITmFIk8snj5T9F4U/XIXFCCCVS4mZX5zs54FOljIg79HK+qk+Hhd/aiR43jQkDmteLGSIZefE0JLUOaG7C7sRzNSUsFtNcWVg6HLU0sRGsISn23y3Pdwp42s3Vej+XjXPnD0r+9I4YLguYuBZcsbr31d8awizYBok3p7W+4Q5RlGq9dOyCme6RcYWTL41S68qOI6irkrsntygbKLlafV43g5ACqi8zHAjjZmufV33OmO+yUPSg50ZPrj+vqpuEb4yk+A9NoqNjvJBWzHXqwTWytRU9uFaoV+HuBvmE2seykl8Vz+ynOBMY+whbd+0OfZwG0UO50selIDuDz+Ph1kkGfRGjHLU51cpg/gGGa+h9G1qmg0wVwMjocdgbh95RjopumSf5ZS49YQ6JoYRvlHdSUbAsLfkgwuzGwmf7rafR4gECfCr3K12xCbYfr+gD7bG3RhXc+9D5eoLsGFjRKtnJG51YFsCNg2POalulaVwyTNrpseMdCp4OVVuCG5l0ZX7 8CumC0Cf 247LX+06nP7k6EirCYl1srgCYJACnEgIwxZw2FvBbReilPOhNCqOb6KVtPShNh0TpoBb03MH/XWw8KMQTDrGrJ6d8KFM9k25SXgEy5bLA947lmbkIJBjKSUk1jkNt9mA6M/kuZI9sJsHBkWbt4oMMHkYPf6GSVzz0bzTONnrLkt17hrMCH53IroXDFeg7aiF/YPl5jb1EmBiMFWzYhveu1l87GojbwOZXoy3FqpTRDZP0GRKJyvNdQrfoRWUVPU6thY8A8rTv/vGuFuYMrwU2m/dbsZ11+wts/zq1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2024-06-14 at 12:03 +0200, Christoph Hellwig wrote: > As of Linux 6.10-rc the MM can swap out larger than page size chunks. > NFS has all code ready to handle this, but has a VM_BUG_ON that > triggers when this happens.=C2=A0 Simply remove the VM_BUG_ON to fix this > use case. >=20 > Signed-off-by: Christoph Hellwig > --- > =C2=A0fs/nfs/direct.c | 2 -- > =C2=A01 file changed, 2 deletions(-) >=20 > diff --git a/fs/nfs/direct.c b/fs/nfs/direct.c > index bb2f583eb28bf1..90079ca134dd3c 100644 > --- a/fs/nfs/direct.c > +++ b/fs/nfs/direct.c > @@ -141,8 +141,6 @@ int nfs_swap_rw(struct kiocb *iocb, struct > iov_iter *iter) > =C2=A0{ > =C2=A0 ssize_t ret; > =C2=A0 > - VM_BUG_ON(iov_iter_count(iter) !=3D PAGE_SIZE); > - > =C2=A0 if (iov_iter_rw(iter) =3D=3D READ) > =C2=A0 ret =3D nfs_file_direct_read(iocb, iter, true); > =C2=A0 else This definitely seems wrong in a large folio world. Reviewed-by: Jeff Layton