From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A3A5C00144 for ; Wed, 27 Jul 2022 01:53:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1711A900003; Tue, 26 Jul 2022 21:53:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 121ED900002; Tue, 26 Jul 2022 21:53:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F2C0B900003; Tue, 26 Jul 2022 21:53:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E291A900002 for ; Tue, 26 Jul 2022 21:53:49 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id BA07F140878 for ; Wed, 27 Jul 2022 01:53:49 +0000 (UTC) X-FDA: 79731208578.10.AE3C804 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by imf11.hostedemail.com (Postfix) with ESMTP id 19C7C400BE for ; Wed, 27 Jul 2022 01:53:48 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4LsxcM33HMz9sxv; Wed, 27 Jul 2022 09:52:35 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 09:53:45 +0800 Received: from [10.174.178.120] (10.174.178.120) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Wed, 27 Jul 2022 09:53:44 +0800 Message-ID: <9bf50501-fac5-cd59-660e-52a6b779865f@huawei.com> Date: Wed, 27 Jul 2022 09:53:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.0.3 CC: , Subject: Re: [PATCH] memblock tests: compiling error Content-Language: en-US To: , , , References: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn> From: mawupeng In-Reply-To: <1658804705-16996-1-git-send-email-liuxp11@chinatelecom.cn> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.120] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658886829; a=rsa-sha256; cv=none; b=vNptfMnDci1Zys7/iLP/ivv7tCNeeHURLC5N3liXV6d4kPWCqW1YsQYzDhhmf6Rgg8RbWP MGO7ywTuKn/CTAzFRKEMAD81kAxfnSqF4wlzmSaBgPtwKXLlUjnOFCdjDo6AgT4w0+44Jd 0rDBvxIdlu+AGTC9olMqTYT2u56XJIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658886829; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ucYSvXdpJN2w3n0hKfIcGWi4JiVjDc+IEJf5rIFIzHU=; b=Rov6SxwVkWC7SpF4o+joMSZlk3lELQOrH+jzZUemUeVynN8lyJ3aCHEJr4f7Mtdchw2Zy5 MPMC8XAM9hd8maIAySF6069PUR5xGLOJSpin2ilxvWAK0CMgjPRRcxRLQUp05Xyqrr4vSi G/pAW+MnEqgMAOBHXCFgaMB3kCHoJZo= X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 19C7C400BE Authentication-Results: imf11.hostedemail.com; dkim=none; spf=pass (imf11.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.189 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: 688q3mh5eckjkf3ojih549fbjwxk574o X-Rspam-User: X-HE-Tag: 1658886828-520240 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/7/26 11:05, Liu Xinpeng wrote: > memblock.o: In function `memblock_find_in_range.constprop.9': > memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited' > memblock.o: In function `memblock_mark_mirror': > memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore' > > Fixs: 902c2d91582 ("memblock: Disable mirror feature if kernelcore is not > specified") Fixs should not have word warp. Tested-by: Ma Wupeng > Fixs: 14d9a675fd0 ("mm: Ratelimited mirrored memory related warning") > > Signed-off-by: Liu Xinpeng > --- > tools/testing/memblock/internal.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h > index c2a492c..cf67e6e 100644 > --- a/tools/testing/memblock/internal.h > +++ b/tools/testing/memblock/internal.h > @@ -9,6 +9,9 @@ > static int memblock_debug = 1; > #endif > > +#define pr_warn_ratelimited(fmt, ...) printf(fmt, ##__VA_ARGS__); > + > +bool mirrored_kernelcore = false; > struct page {}; > > void memblock_free_pages(struct page *page, unsigned long pfn,