From: Eric DeVolder <eric.devolder@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev,
Linux Memory Management List <linux-mm@kvack.org>,
Baoquan He <bhe@redhat.com>
Subject: Re: [akpm-mm:mm-unstable 62/89] include/linux/kexec.h:41:2: error: #error KEXEC_SOURCE_MEMORY_LIMIT not defined
Date: Wed, 5 Jul 2023 09:21:46 -0500 [thread overview]
Message-ID: <9bf2aca1-ac14-506e-bf7e-07fe1b071668@oracle.com> (raw)
In-Reply-To: <20230703131726.d505551a7ea964341ece91ba@linux-foundation.org>
On 7/3/23 15:17, Andrew Morton wrote:
> On Mon, 3 Jul 2023 13:34:21 -0500 Eric DeVolder <eric.devolder@oracle.com> wrote:
>
>>
>>
>> On 7/3/23 11:31, Andrew Morton wrote:
>>> On Mon, 3 Jul 2023 10:31:34 -0500 Eric DeVolder <eric.devolder@oracle.com> wrote:
>>>
>>>> Here are three possible courses of action:
>>>> - do nothing; preserve existing behavior as intended by the series (even though problems like this
>>>> can occur)
>>>> - fix it with CRASH_DUMP selecting KEXEC to eliminate the problem
>>>
>>> This one, please.
>>>
>>> Or make CRASH_DUMP depend on KEXEC.
>>>
>>>> - do not fix it but document the reason why this problem occurs in the commit message
>>
>> ok, great!
>>
>> I also have an unrelated fix for riscv, and this correction (for both arm and mips). Is the correct
>> action to post a new v4 version? Or is there a different method?
>
> If the changes are small then I feel that individual fix patches are
> kinder to people who have already reviewed the previous.
>
> But a new version is OK if that's more reliable.
Andrew, I chose to post a v4 since not all pieces have RB/AB's, in particular the first patch
introducing the consolidation.
Thank you!
eric
next prev parent reply other threads:[~2023-07-05 14:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 6:31 kernel test robot
2023-07-03 15:31 ` Eric DeVolder
2023-07-03 16:31 ` Andrew Morton
2023-07-03 18:34 ` Eric DeVolder
2023-07-03 20:17 ` Andrew Morton
2023-07-05 14:21 ` Eric DeVolder [this message]
2023-07-05 21:15 ` Eric DeVolder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bf2aca1-ac14-506e-bf7e-07fe1b071668@oracle.com \
--to=eric.devolder@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox