From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73A5AC0015E for ; Wed, 9 Aug 2023 07:40:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC3E36B0071; Wed, 9 Aug 2023 03:40:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A75646B0074; Wed, 9 Aug 2023 03:40:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 964B38D0001; Wed, 9 Aug 2023 03:40:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 88AC66B0071 for ; Wed, 9 Aug 2023 03:40:38 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 548B08089B for ; Wed, 9 Aug 2023 07:40:38 +0000 (UTC) X-FDA: 81103768956.19.931510A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf19.hostedemail.com (Postfix) with ESMTP id 2C96A1A0016 for ; Wed, 9 Aug 2023 07:40:35 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PlhCqFwO; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691566836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/LEhUIxJl/IFM00b8bM6YoXNVYz7YZZV5m6MYPcbPp8=; b=C5J+2YYu9J6sOTBkQ+6NLnVmRRtMRKI1y3xeNnLS3Who8vy/iSf/I5nPol8VFRbSDvNVzI nQvjkYj7XDnjmr5fZIzyNF+oNDH/wLalC10sp52qq36rJDQyzLqDiM/noKk2wBtblStz3z 6FLUWD5UybJuy3LWvrvpw4aXu7uNAkg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691566836; a=rsa-sha256; cv=none; b=mynU8nVwmdIu5UFUN2MabQXFe+RZgSv9/ZepaIeO0e0F7BhQjcJz/gVhnVxTDrZaFupmeI jyg8p7DzyrlZonMKs8A0K/rv5FmssRLIvTST+lG22sGdpBvXxmVj7YFAK2itQpDRU9pD0G aksuDTMatlBAfLuza4stQsUaTvRj7eQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=PlhCqFwO; spf=pass (imf19.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691566835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/LEhUIxJl/IFM00b8bM6YoXNVYz7YZZV5m6MYPcbPp8=; b=PlhCqFwOVuw5Qj5f8dSkWlU+3ACNxTpIz8+F6MMC/GxFVCZch+l8BdPSHjDUgyOUarJQVi yJ7bSfQ6dblycjqrv5HKwwee1zPZkE4JfSw2mC9DCOJS3BLVQryoZ2FnwLl4US2HeH8H/S kG8ZpEUd9Z7+W50vCIWmIPEvFcsIA6k= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-Czu_gstzPoeVMQK2WdTUUg-1; Wed, 09 Aug 2023 03:40:33 -0400 X-MC-Unique: Czu_gstzPoeVMQK2WdTUUg-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-4fe275023d4so6367001e87.2 for ; Wed, 09 Aug 2023 00:40:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691566832; x=1692171632; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/LEhUIxJl/IFM00b8bM6YoXNVYz7YZZV5m6MYPcbPp8=; b=lTP1t1klhfFKIy0OftAvPADrs2xPeZEDeDPevwQypI0DURqEIdFr4StxaW/za7FDL8 N1eoF75W3j7HWSrze/jsciVNzdukAZJqr+T57Aln5UGoz46rZd42ZWVyhB5vy+w3Ss+5 FDgi6bByjpfwDRSzWJU7ACF1gkRY0Kl+Ubd35AbGJENiVE/1aEe71ARVgsq6TOCwdqj3 Sq3CpVlFP0/Btp8T9n/qthhzhhpoT3kfpWPBtEsa4yyPXYYj0sbIW2gWxu98l6V8Nt67 ogkqDyV3fxgHgoIMNU/jgJpJWi9Xu18FXpVApoYT22IhZ/Z7aXfHkSZuZkqTrLLooJuJ /VcA== X-Gm-Message-State: AOJu0Yw7P0+A5SxUWVzPQV1A+8Da46ClcTp4/puHQqrqQkOxEbPAOv8I dQLknLVzg2tDpBU5WNsKhi2GFoay3S+O5HwTamG1bynbeverlexLb3AyCBD54hKxIGL8TynZXRL WV7Qy0sRE474= X-Received: by 2002:a05:6512:308b:b0:4fe:4e2c:8e52 with SMTP id z11-20020a056512308b00b004fe4e2c8e52mr1489203lfd.42.1691566832099; Wed, 09 Aug 2023 00:40:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqwaJvbsNipfh7mF2DC+yBtFdSuN+yQ+efavTgP0AkGl1wSMeLrq022vVlQQitzwa1YkE6Bw== X-Received: by 2002:a05:6512:308b:b0:4fe:4e2c:8e52 with SMTP id z11-20020a056512308b00b004fe4e2c8e52mr1489185lfd.42.1691566831740; Wed, 09 Aug 2023 00:40:31 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6800:9933:28db:f83a:ef5? (p200300cbc70e6800993328dbf83a0ef5.dip0.t-ipconnect.de. [2003:cb:c70e:6800:9933:28db:f83a:ef5]) by smtp.gmail.com with ESMTPSA id b13-20020a05600c11cd00b003fe1a96845bsm1093295wmi.2.2023.08.09.00.40.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 09 Aug 2023 00:40:31 -0700 (PDT) Message-ID: <9be602c1-d627-6302-be1c-66c8068c7ecf@redhat.com> Date: Wed, 9 Aug 2023 09:40:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] selftests/mm: FOLL_LONGTERM need to be updated to 0x100 To: Ayush Jain , jglisse@redhat.com, akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, bharata@amd.com, kalpana.shetty@amd.com, santosh.shukla@amd.com, Raghavendra K T References: <20230808124347.79163-1-ayush.jain3@amd.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230808124347.79163-1-ayush.jain3@amd.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 2C96A1A0016 X-Rspam-User: X-Stat-Signature: t3z7sqporr1cxrhq1ngqi5aqcjac3uck X-Rspamd-Server: rspam03 X-HE-Tag: 1691566835-783560 X-HE-Meta: U2FsdGVkX1+leMy9JHKApHt9WDETLBSHFOyxY7EWUYlqqGwhzpkEkzmjXvIQzSeP/Un+nWaka+YrdTtyzCdhBbjjqD+s2ahQPInCGEQPyZqOaT4QntKC7BBziYIlFcmG0nmEiK1VD4OrkgtlrAwlsrSo2w+ND+ZfZeIfHs+LpUs3lnO49VE4GB9EoZSZg5T5lK6riJoZhceUxcjtL0THG045sYuxWs0xBjmEKICJZbV3nXWiO0MZlXIhzvPonRtuII4FzCNoHTKkH6XmY8DgNqfrFurgtQwlNtwMRH9JoGIodXQK/CDIJEP2VtwpocBxJtCfMPsoZ6t/miOMCcbj5XGeCExUNcO73zQtos3ocv2tIEnIQwqikkPH03sSPONpW7BQ/7EwgAbk/qyzudanyC0t0LRfij6DaFX0oixyr5yL8WeYwKc75YPD9dO2iWSESnjOolhbLfmgWkM5RyDqvCzC6hygVYz4AgQWn12Vdd/PF2q7FBjdC0Q9Wmb6I6g0bqc2ZmWUrcHpR1BXqKuAuAm7dkfcnnUwGFW0hxFbtx1YuuFJam6nPoHGWq6gHxqghx9UUljePHiYbdfhWneTQ9u6bi6LqN82xM8cb/nntj0OoawT0ektiJHucDFfP40ygvN/OMUCG/XyzEWakma/p9cKtyDK1cs4fMwY4uoLJFmeASrvEOyVEK5AJDrTsqbQFfka/Ag+YEgUmZgg+0pdEiHECzUcWFUWiQkWThu4SBD9Uc3qkiHvg1bvn/r2IPqnYH2rJGiJ9vMIOBwmpPCVFDuVHxLovs46mcTew4+m89mafkBnGDMvZpSun+DxXt36f8D9UW8LJ6FHQOESGp7G1rJwo2b7rUBFTHc2yKVvAdJbsoq6psDe9W+nT55zxS7VZpizuh5TzuMpuT9zpluJygC0ZMe0MhCcg3esY5h0pD4EYz2t0xcnalkMWXlSgK3J7URwWFJwFX7hK11tk7h rLPMC+ow +B6yjtNV1+FeHsMlnZilj5pBogXLC6xPNo/OZfMaYqnww17sCoVOm2ilC9Z5Bf3zggcKeCzs9/KV85OCKF8X7CIAFda3qpA9wApChohYoSsjKUmb+HJMqQucXAPmibyI5aJvwxgBFlG4afig/sQwl1IxECSDaBXvlzNkd0JcAJq2dR383Ij2DyU+fAWABM+Sk4Z6o5Mvw0Fxjv+u5K+7pRkzb4nzuw+eD504IdzGdeBiVxxVwO2VCCaH39WFi/pC/W/1ejfxia8iPnQkQtXlYhDFsIeqlU0FPu8m5V4W/3HvWTYk9FaBtrt95t73KGjp1ryhfIoZTj57ft90Jdk9svDWbmIj4J3MDHG5r7QZLqdeKCm11kX1elfxfQZsKk869U4Y3UFDQq0bNvNTyORFGgfZaOuYBzxBuz5Bg8y1uztqZ0m6yRnKqPuZOl3o/q12WNAI+S1okIHlAigjUMMfF49p/muhqi6jwQvlM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08.08.23 14:43, Ayush Jain wrote: > After commit 2c2241081f7d ("mm/gup: move private gup FOLL_ flags to internal.h") > FOLL_LONGTERM flag value got updated from 0x10000 to 0x100 at > include/linux/mm_types.h. > As hmm.hmm_device_private.hmm_gup_test uses FOLL_LONGTERM > Updating same here as well. > > Before this change test goes in an infinite assert loop in > hmm.hmm_device_private.hmm_gup_test > ========================================================== > RUN hmm.hmm_device_private.hmm_gup_test ... > hmm-tests.c:1962:hmm_gup_test:Expected HMM_DMIRROR_PROT_WRITE.. > ..(2) == m[2] (34) > hmm-tests.c:157:hmm_gup_test:Expected ret (-1) == 0 (0) > hmm-tests.c:157:hmm_gup_test:Expected ret (-1) == 0 (0) > ... > ========================================================== > > Call Trace: > > ? sched_clock+0xd/0x20 > ? __lock_acquire.constprop.0+0x120/0x6c0 > ? ktime_get+0x2c/0xd0 > ? sched_clock+0xd/0x20 > ? local_clock+0x12/0xd0 > ? lock_release+0x26e/0x3b0 > pin_user_pages_fast+0x4c/0x70 > gup_test_ioctl+0x4ff/0xbb0 > ? gup_test_ioctl+0x68c/0xbb0 > __x64_sys_ioctl+0x99/0xd0 > do_syscall_64+0x60/0x90 > ? syscall_exit_to_user_mode+0x2a/0x50 > ? do_syscall_64+0x6d/0x90 > ? syscall_exit_to_user_mode+0x2a/0x50 > ? do_syscall_64+0x6d/0x90 > ? irqentry_exit_to_user_mode+0xd/0x20 > ? irqentry_exit+0x3f/0x50 > ? exc_page_fault+0x96/0x200 > entry_SYSCALL_64_after_hwframe+0x72/0xdc > RIP: 0033:0x7f6aaa31aaff > > After this change test is able to pass successfully. > > Signed-off-by: Ayush Jain > Reviewed-by: Raghavendra K T > --- > tools/testing/selftests/mm/hmm-tests.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/mm/hmm-tests.c b/tools/testing/selftests/mm/hmm-tests.c > index 4adaad1b822f..20294553a5dd 100644 > --- a/tools/testing/selftests/mm/hmm-tests.c > +++ b/tools/testing/selftests/mm/hmm-tests.c > @@ -57,9 +57,14 @@ enum { > > #define ALIGN(x, a) (((x) + (a - 1)) & (~((a) - 1))) > /* Just the flags we need, copied from mm.h: */ > + > +#ifndef FOLL_WRITE > #define FOLL_WRITE 0x01 /* check pte is writable */ > -#define FOLL_LONGTERM 0x10000 /* mapping lifetime is indefinite */ > +#endif > > +#ifndef FOLL_LONGTERM > +#define FOLL_LONGTERM 0x100 /* mapping lifetime is indefinite */ > +#endif > FIXTURE(hmm) > { > int fd; Kind of suboptimal that we are passing in FOLL_ flags. mm/gup_test.c should just have provided an abstraction for that. Acked-by: David Hildenbrand -- Cheers, David / dhildenb