From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A60E77188 for ; Tue, 14 Jan 2025 14:51:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC0B8280001; Tue, 14 Jan 2025 09:51:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A48706B0088; Tue, 14 Jan 2025 09:51:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 89A97280001; Tue, 14 Jan 2025 09:51:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 67A4C6B0085 for ; Tue, 14 Jan 2025 09:51:19 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id EE208140AE5 for ; Tue, 14 Jan 2025 14:51:17 +0000 (UTC) X-FDA: 83006345394.01.668A966 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 604E7C0015 for ; Tue, 14 Jan 2025 14:51:15 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dWZoBIcx; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1736866275; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=frCMXuewTKaMxoSv5HkrB79R79VgidnpZu3s0YCdJnw=; b=jQkQu1MNPKG4chg3dGmuJgpv2qNJIjkX63xMJGZxhH8tpadgx9tVtiNhPlO4p0J08D1QVO 2TgrbtwpmaEdg97JLc7zYLblr6opu+i4/rckZZG63CHyJrB/Xb4jBeoMSdepX7KS2NwvAF doS1/NF3CwWN3EGENNMtxDebITzZaRc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=dWZoBIcx; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1736866275; a=rsa-sha256; cv=none; b=0UOHgTa6FyYsske6PQzFSyBmSt8WJHAa3nAzYr/IlY8dPlH9svKQMSg/lMR48WMPIR9B8w q7PCqcFxPiDchEsxWbIMmWOfO7g46RsKcVDyUJwrX+2VUncaUIJHvSVdSJ61lgQ5q7j8Zs zlUPeLInduHLVKh0KzJz6Kj4mboecSY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736866274; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=frCMXuewTKaMxoSv5HkrB79R79VgidnpZu3s0YCdJnw=; b=dWZoBIcx0zJ92OM3plebfMSeLJq9TcAaFdKcaabvH0IIguIB5l9bG8jnU9/ue3Upza+tvp tugMdrIAqB+c1ZrNcgHzNfbffxG0pXIgZ3SQfQPTsjmhFMqV5lgRLVuq7bqRF3wNWx4JDr 9nciOhTfrWQJUDpuPx12DSQtyHUGtA4= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-668-NcqA8vVLPbS_QvICHhP18g-1; Tue, 14 Jan 2025 09:51:13 -0500 X-MC-Unique: NcqA8vVLPbS_QvICHhP18g-1 X-Mimecast-MFC-AGG-ID: NcqA8vVLPbS_QvICHhP18g Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4361fc2b2d6so31290785e9.3 for ; Tue, 14 Jan 2025 06:51:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736866272; x=1737471072; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=frCMXuewTKaMxoSv5HkrB79R79VgidnpZu3s0YCdJnw=; b=tU4FsJyEyYsSsEHWbdOigWpW6B8DcmMoPyM9V2iHc+q6Fss9kQhDU5S8EhezyvvjLn o8B+YKnSdHawyvlpAam4W+lnCzVAWaxQzb/fo+hc7G8PWHPO2m/bd+xNkTgnTWxibXqn EZW8HndzrlV+40n4yZGe8Bl2IPbAfGp/RyoZG6zecCWTLwOQVCqh188wzJLkGLhBhmkc iZKbnNoA+OPX/tljFXzfSPmS9I3Cnb90jGlMwZkKBFhmV7dfx8wB31bztJJUBnd7PhKn b4wAmHXGeNIsIw+GEY9Pp2dGeV5KwEJTf592QAaUOfIgNNKgxqHKWK3RvbIGuaQ5qSQs neAg== X-Forwarded-Encrypted: i=1; AJvYcCX4zkQFqCblDcUR5EhPLmNMomawYim3NO3+IHnVrIFPVPDqMS/7p3hAWr8baCBe73E1uwv5xkcZiA==@kvack.org X-Gm-Message-State: AOJu0YzLIGamNnpoIBEBQQeoM7ThutSulvgWaCrk0KeZXxFodhHKJFdX b9ZHAvxbKs9b3P9XWa9VmJCNRRNZ4WyR6r1d20miQrwUH2wCqTcwJNQKdEyxpMheNSkxDEKvN9g yOuPFB3wIwAOS5/EwYnTViuHdhjh0YtRKVItyXRjuiFQDHACx X-Gm-Gg: ASbGncvoqWZN72Yvqi39GzRBEVOqpXZUfdnUR6ZNd9/h+jfbUNesFsNpLOjOlu4FL+d 59YEwv7wVgb1DPCak+KXKjdG1ISzKI5qit2c5ehykoUzig3VWpgYhSYMTGPc9guCqATTseA+qP2 eXKzdwhVf/uAIR+ZRTRaOWYRBKI0p6Psf+TcRLQRQVb8+BXcf007fCvy25Zab/D31GeT1Gfv7Yd 5GJQpDtYXk0iT5JfmZWj2svSjQaQNVcsdxqDZmMwHkVK2kp++Bwkt5A1XyiQkBvCFuDcKJ/euVv X4JzUt3bk/H8XnrL6qK6tNpbYU/HI+V9B1P4qbryTKdwBFDA83gCLDPlbKPlUfnd5gPDlJK/Xx6 jzv+qkfJ+ X-Received: by 2002:a05:6000:18a2:b0:382:49f9:74bb with SMTP id ffacd0b85a97d-38a872f3202mr24489594f8f.35.1736866272041; Tue, 14 Jan 2025 06:51:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IE7GJ1+W/uNTlLNM/+qMUx1r19EPlEDmBQ7z7UMM/B1+0DtBI15xOV7jFVV7enwVcHppl6EyQ== X-Received: by 2002:a05:6000:18a2:b0:382:49f9:74bb with SMTP id ffacd0b85a97d-38a872f3202mr24489568f8f.35.1736866271639; Tue, 14 Jan 2025 06:51:11 -0800 (PST) Received: from ?IPV6:2003:cb:c738:3100:8133:26cf:7877:94aa? (p200300cbc7383100813326cf787794aa.dip0.t-ipconnect.de. [2003:cb:c738:3100:8133:26cf:7877:94aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a8e38c6dbsm15361588f8f.55.2025.01.14.06.51.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 06:51:11 -0800 (PST) Message-ID: <9be14739-82cc-42fb-bb38-a868231cdda6@redhat.com> Date: Tue, 14 Jan 2025 15:51:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 10/26] mm/mm_init: Move p2pdma page refcount initialisation to p2pdma To: Alistair Popple , akpm@linux-foundation.org, dan.j.williams@intel.com, linux-mm@kvack.org Cc: alison.schofield@intel.com, lina@asahilina.net, zhang.lyra@gmail.com, gerald.schaefer@linux.ibm.com, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, willy@infradead.org, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, chenhuacai@kernel.org, kernel@xen0n.name, loongarch@lists.linux.dev References: <4f3fa1bb9cf4402d6131d0902472d8e9bae52f88.1736488799.git-series.apopple@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <4f3fa1bb9cf4402d6131d0902472d8e9bae52f88.1736488799.git-series.apopple@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yjYNciWTUkLkH8u928w6JtevDJpSERbMH5nQfPVHsUg_1736866272 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 604E7C0015 X-Stat-Signature: r9dx8mgj1fa77ppp1zzwair8e78kgrxm X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1736866275-481508 X-HE-Meta: U2FsdGVkX18au3F1ZPiqGt8q0aHfPXNgEJlWYbkRbAdZwisZz2CJiOKAhTqJ3Y4h23iMpJo3GXnN8hh5yRkZK9H0i0En6xAXipuDyKDfcu+tgoc0Z+yBn3pZJ7QQEcqP+pD32wvdVVL2eZfI8voY4CBC+g/mkkmjFdMRIEUdptanUc6Rl2vhEjReVR3joTsv98ckvaNkTrzbbfWNgDEDskcCYPdGl/P4/ozm8t6WmBgPYEI0Pen2ccxJX83j0suw/Xjzx80gzmO8mxFJcFWqn1N876LlMXcuVasm/e2UgTOnaDc4VnnCwGz4uMFVVlIvDOt7YPnhuT1SXpXW4P4F49gIcb1GzlvZt2xmhEdHP2FoTPM2SwqKI5SyFaFvbV80U4PLs1ik5o/4eW6hxUDIN8crWKyyQwtySXOVUs3LZRqC9oChEtiV6luED/uaVR5//rIpkePtE+bULfgg4HUuN0bUk6OqpZALE8Q0KewuXHh8Dm/OWt+H6h+gwV3TNexRP7eqgfct9UQ9AEu4pSQLqwj2pvpo+xCcc3W5LnuScTS8mtUwmVmq0JHwanNdABEUnyMQ/C1JfWeh/ul6Rpgm6wMGbHtpYJ5xrjxL3uzYe8Kr96huhAEr1yEcrIqKcy3ZR2TwEC4gGK48qiLXqTb9ejKlK6GrYTF3OMy7tiyvOqpKT3pzecHextOJHb6L4frPPwftEfTbVuCt2FV3ovCRZlChgQH4Ghk4T6J4zSuIgspJzWhVb+Fln+yK1n2P9pkWYeYsuZIAm+otwz85VxJk8AaAMOiqEJoKOUnlzCDMm6Abtonpp1kWkq7P1FST1aloP/nnTuj15ABaNXXPev5bylX4dgK7M5XqxZBZp1mLzDJVfAj4nu0tWm3nlM7NXHejzU15EMSOk3zfaG6J9IdT+/c1umXuGO0AHuIS0Dhe54MxF4W80iopHxXES4Y7iHzGO/wxMs8A89q2WCCu02b Dyemn0G+ /LB9btznAiZDxg4ZPjSmvUlipTO+P/3MBlSnRuBaSjL2djaFYXlmDIXGNBinAjVt0oVSlfV2SMJV9l9qgoKeJw8PaDV++NwtdckbTWVObc1urdjc1mBypIGcchLwF6VCq/jaGKwWrR1TRplIF9aggxzgcC1cJbcI79cWxHfqcAQSAuICZlzvHCY7Bi7M46Qedr3OhMmW2daVwKcQnCKjXZi109ZMlkixvN/EnuawbF+bUNzQDOWxotd/mmnzds5mMOYRPpgu3Uflc7oAMtJPPL7WxfZAP56ok7dUuXtu4WC6sBi2FtDE6YwQjm0EIBwN/ow92w8PAv1DTFz/+LmdajRLTpA5iEHIlVx0AMcI6+hZtM18LO1ngVv7XggXwzYXgl3ILRc6SMOK03w+Od2LWA69RceLLOsv6u3rNBxGyNKawd6oax+vq8iUT1KpKP6qs9+dNsfuPhmorUcrAUP234ft2ZmAMwQggSTIpXUTnyxeiC85UO0FMjxjpGD6/4FXomhc4cFmvTIPSfWhX7KRVjanjtYep8Whp/qF6VyT0eAMN6UrPjo0QdOx1L+XjvnMbdkKbfj8dfM0WK64= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10.01.25 07:00, Alistair Popple wrote: > Currently ZONE_DEVICE page reference counts are initialised by core > memory management code in __init_zone_device_page() as part of the > memremap() call which driver modules make to obtain ZONE_DEVICE > pages. This initialises page refcounts to 1 before returning them to > the driver. > > This was presumably done because it drivers had a reference of sorts > on the page. It also ensured the page could always be mapped with > vm_insert_page() for example and would never get freed (ie. have a > zero refcount), freeing drivers of manipulating page reference counts. > > However it complicates figuring out whether or not a page is free from > the mm perspective because it is no longer possible to just look at > the refcount. Instead the page type must be known and if GUP is used a > secondary pgmap reference is also sometimes needed. > > To simplify this it is desirable to remove the page reference count > for the driver, so core mm can just use the refcount without having to > account for page type or do other types of tracking. This is possible > because drivers can always assume the page is valid as core kernel > will never offline or remove the struct page. > > This means it is now up to drivers to initialise the page refcount as > required. P2PDMA uses vm_insert_page() to map the page, and that > requires a non-zero reference count when initialising the page so set > that when the page is first mapped. > > Signed-off-by: Alistair Popple > Reviewed-by: Dan Williams > LGTM Acked-by: David Hildenbrand -- Cheers, David / dhildenb