From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6CDC25B78 for ; Tue, 4 Jun 2024 13:29:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D9086B009C; Tue, 4 Jun 2024 09:29:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 989036B009E; Tue, 4 Jun 2024 09:29:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 803A16B00A0; Tue, 4 Jun 2024 09:29:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5D0816B009C for ; Tue, 4 Jun 2024 09:29:16 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1A4F71C0B3C for ; Tue, 4 Jun 2024 13:29:16 +0000 (UTC) X-FDA: 82193287512.24.3EE9AAA Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf06.hostedemail.com (Postfix) with ESMTP id B301C180004 for ; Tue, 4 Jun 2024 13:29:13 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dxfe8ILt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717507753; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=42V/ockWwxrYy/bRQBVw5gjEZCwTD2Wh2lZUM6jdqB0=; b=Okmh9L9bTlPM2z+qC9VRJzhUzdDlcto/hlfeWUoi/ZBFwFfea6swO4mahS4fbfWzP50lPE T5mjhtV5IXGs6o5V2MzC2wWDPheIYRSF5SjtD/iAE96mwzU0kD2eqdzbi7ZQIshVON2Cw0 a8KOdaEuFioVSwvohv382GM6o89zXiA= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Dxfe8ILt; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf06.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717507753; a=rsa-sha256; cv=none; b=QaqCaUVYVApTi0ppuCVdkKqYhcALY3lxoyuSNdlEyZ+BvqFQ7G9T6Kb6in/gc8i/S943v8 emnUPk18hbu3+zGBXmHl16jYCbEoLMIqpOfNGFXko48cH2akJoPGOxlmiJXEivqqriMS9f zk4Izy+HddPIkzjpUzafjX81fYu31SQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717507753; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=42V/ockWwxrYy/bRQBVw5gjEZCwTD2Wh2lZUM6jdqB0=; b=Dxfe8ILtsEX0sM/AgPxRMd8F6z2qvmzIIgr3gb2DHSXQlzvP6livQ1qZLYkO+pwdp0LjV9 JnfvQ/NbobWbfQNxcZ62LOu4gWLuVstJyZX5zMFMXA46c5Y0GZLEGoQltnvZZP1fLlP0s6 pVpFPdDyXlRr2ssI24SMA0wg4JME5D8= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-654-51brWmUYPP2VP3DHkJ1FrQ-1; Tue, 04 Jun 2024 09:29:11 -0400 X-MC-Unique: 51brWmUYPP2VP3DHkJ1FrQ-1 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-35dc02b991eso3194005f8f.0 for ; Tue, 04 Jun 2024 06:29:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717507731; x=1718112531; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=42V/ockWwxrYy/bRQBVw5gjEZCwTD2Wh2lZUM6jdqB0=; b=XBJtsm/EZ6oPjXiMMwIsrJ3hWtsaegelVwkIET7e1SLm3XRUVFZJjY3Sm5h9D5kZrS o1MJHLEJ7vPH49Dhyh91O7ivaROr17bPtJi/3U85M94lPdIWwcNqb9DFyNMWarF6osC5 KqUGo1S0MD3DyU9/pjn2KoYyce39AIHgoEdS2vahgSSQh7KJv7aLMtSya3lumRADpWlZ 9xRNJGikUvoYfe5R/BoCLnDHkGimyAbhGhIX11wIYheTnGKIRE+WZCKIFl1bxFgClalT gs9tt/VFWTsYt1ICWf5CyJjjyhg2b1lOTekFtKcWPYcAoYF4oKAs9WST/NL5WfrBi56f pcLQ== X-Forwarded-Encrypted: i=1; AJvYcCW+TNr8Ef716Ha8UcFj9I7+4hGhEJxm9/6xu76imaWkmYXB6UsrWt1PsMZfmEktmfSxETmt2FG2wb5TzP+oUl5LWEQ= X-Gm-Message-State: AOJu0Ywc3dchME8IOuFUVzEpyl6qQY0sRDxnv+eoCpfSYhZgLmYBG6qn LN3/jBH9+SHs75HOxGuWJJYgifYShOioC/oTWKSZR3OjdYeU3yPJUd2I/jHURzQ5iyHPuWFLXCy 8SMeDUnOuPEOL5sna6562rrVCdRZJIdWJQzqWWcIJknS9IA0a X-Received: by 2002:a05:6000:1207:b0:354:c8d7:e0af with SMTP id ffacd0b85a97d-35e0f2947e1mr7516452f8f.35.1717507731231; Tue, 04 Jun 2024 06:28:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFktQuvCXtauGgJWzfxv770xS8RoIJMbHbbiuUoVp/Wok6oTrNjlNqZ9HXfUP6Mz6SK/umj6Q== X-Received: by 2002:a05:6000:1207:b0:354:c8d7:e0af with SMTP id ffacd0b85a97d-35e0f2947e1mr7516431f8f.35.1717507730838; Tue, 04 Jun 2024 06:28:50 -0700 (PDT) Received: from ?IPV6:2003:cb:c73a:3a00:a025:9b06:549e:c16b? (p200300cbc73a3a00a0259b06549ec16b.dip0.t-ipconnect.de. [2003:cb:c73a:3a00:a025:9b06:549e:c16b]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-35dd064b5e9sm11590372f8f.96.2024.06.04.06.28.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jun 2024 06:28:50 -0700 (PDT) Message-ID: <9bc7eb69-47a7-4565-8672-636273967dc3@redhat.com> Date: Tue, 4 Jun 2024 15:28:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 00/10] use folio in ksm To: alexs@kernel.org, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, izik.eidus@ravellosystems.com, willy@infradead.org, aarcange@redhat.com, chrisw@sous-sol.org, hughd@google.com References: <20240604042454.2012091-1-alexs@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240604042454.2012091-1-alexs@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B301C180004 X-Stat-Signature: pphf9xyqfu4ope8cbtqx985guejfhat4 X-Rspam-User: X-Rspamd-Server: rspam04 X-HE-Tag: 1717507753-657312 X-HE-Meta: U2FsdGVkX1+pQeUwx0jHikZIP8fSEpJvD2fiB+DjYlH2Z6x6g6DnHrm+tcZRGS0bYzlPIEYC4SIQ9cs5BfA+SXz35ES4K7zEpiWa564yCTGfzS531zBxgsaOk96wpdqg8D/WloiCDGnhycAtwawMxzzXgUJ8H8jc28ISnrdgh4XP56TFj1AKeccTNsdxDw5x8+Iis86glAdonshpe2fbhEEapiXzk5dJ2vYwcrUeVJuxhq33ObrugBiBaDZvu991JMsebYH657a/H30HE47oyzLcJF9V0f4jz4PM6mU57m9hnEmSgcFaWGAL+f3jlKIaEQXBKma7Lm21RQL7D5Khb8iEunzKH4TFYDWvwV2LpnH9VBtFEeP+PDYIkTeW5HsDP9QzkbNboda+yZkZjq9yHzHNRPjU+K3oO1EyrtYvwozNF+FKjgvftPuiac7DqYkgoyyorfsMVsqzeFbPG3oSmN/3mjN1weQNOykqVh/4vp5Bm5QL8HUba0eWMAdBeP74kAQePHQEew+/8UmDWbcEiwfDDeepoZjw+KzRD16ysXpQNmfZHTjWlRZaifkH+DygujtNia1gXcHVz1tflgICRP3rD8dhVv4ym/49z/0E09HGpoC3Ziz74+fIRo4bbPown9KgvOKgDcYBoOiJb8xHAGRkgB/iVFyXmlf3BNwah00ylfFVEL4/ol4e7goDDUdYWptNUDHQdUezm0avKCpAo9Ho3zeUySYT3HHT4kp3MVePksVM4plbkKa3VpvfFqNZThUeRByMHYo/I82d/rBIU7tVS/7l5iaOTQUmSClqq8Yz5kdHnaysanq3wO/eywGZ5cNfX7psk1gWBqXWZII0fWZELgqw7gs2wPtDj96NdoD1Idz0USxohiV4Avgqx7ZVwIxTe50FajgUQvYkDVI6nCaYi9Oyq2eFy9nZCn8jfAWB2Gi8CVTo5sHYDggLoxztW9jZ8f2ZO8YOX8MOhK3 c8YafLoD IUgfPfF+vw9UyMi6ApTKDE1DpuQ+ThA8x4DdmlG11paFtzQF6UnjrEDrUcDP4pH9XoQuCmE0cfDLbK5DFn0VxQ7SCh1dsxmvkYU2L8Ppsl1LweybNDdFgmG8ZrHtU0nNeoshNt6rmn9/+WwxQSUiXwZBrbdICNX6CrfRiJrOClP0AoSTL9FemgPWKfG0fDvOzGWB7ZbZzekLuE3TiuF0Qe42kZzTnOeg3WXWvbjRIKFGrnwQE7rqf1/Lf9N5YruHy2RL3MZrcHprilY+Q/toKEpP/vwqiVSf3APL5ZdxILMtejoN5SYmQEA0QmoxaCLeszLDjuDxFfabFYcWPGVEq+OqMqzyh04kRT3dK74V76TLKphevVPDqOJnliXWhhzXPOOeHFyRPuEwlZPMVYtfUk5QBUYXMtfv2I28Vf0Ya0PP+OUKknWr+WNvmc9YfcCadANpWwWqjt8YFF4/zzHIvcPp6sN/Dpwok3GDt8EjZcUbwPqpnATLn96Bl0CnZ+xf8PR5yTFyepyNrIgg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 04.06.24 06:24, alexs@kernel.org wrote: > From: "Alex Shi (tencent)" > > This is the 2nd part to use folio in ksm, it saves 82kbytes in ksm.o and > passed all ksm testcases in kselftest. > > KSM still split same folios to single page if they are good to be KSM, > but will skip the rest subpage checking if a folio couldn't suit for > ksm. > > Alex Shi (tencent) (10): > mm/ksm: reduce the flush action for ksm merging page > mm/ksm: skip subpages of compound pages > mm/ksm: use folio in try_to_merge_one_page > mm/ksm: add identical_folio func > mm/ksm: use folio in stable_tree_search > mm/ksm: remove page_stable_node > mm/ksm: use folio in unstable_tree_search_insert > mm/ksm: use folio in try_to_merge_xx serie funcs > mm/ksm: calc_checksum for folio > m/ksm: use folio in ksm scan path I skimmed over most patches, but I'm afraid you introduce quite some subtle problems. Part of the rework should not be do convert things to folios that really operate on pages (of possibly large folios). We really have to be careful about pages vs. folios before we have KSM folios. Only then, we know that we have small folios only. -- Cheers, David / dhildenb