From: Qian Cai <quic_qiancai@quicinc.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
<linux-arm-kernel@lists.infradead.org>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: Track no early_pgtable_alloc() for kmemleak
Date: Thu, 4 Nov 2021 13:57:03 -0400 [thread overview]
Message-ID: <9bb6fe11-c10a-a373-9288-d44a5ba976fa@quicinc.com> (raw)
In-Reply-To: <YYQTKRrDIJbkcplr@kernel.org>
On 11/4/21 1:06 PM, Mike Rapoport wrote:
> I think I'll be better to rename MEMBLOCK_ALLOC_KASAN to, say,
> MEMBLOCK_ALLOC_NOKMEMLEAK and use that for both KASAN and page table cases.
Okay, that would look a bit nicer.
> But more generally, we are going to hit this again and again.
> Couldn't we add a memblock allocation as a mean to get more memory to
> kmemleak::mem_pool_alloc()?
For the last 5 years, this is the second time I am ware of this kind of
issue just because of the 64KB->4KB switch on those servers, although I
agree it could happen again in the future due to some new debugging
features etc. I don't feel a strong need to rewrite it now though. Not
sure if Catalin saw things differently. Anyway, Mike, do you agree that
we could rewrite that separately in the future?
next prev parent reply other threads:[~2021-11-04 17:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 15:56 Qian Cai
2021-11-04 17:06 ` Mike Rapoport
2021-11-04 17:57 ` Qian Cai [this message]
2021-11-05 10:08 ` Catalin Marinas
2021-11-05 11:05 ` Mike Rapoport
2021-11-05 10:49 ` Mike Rapoport
2021-11-04 17:09 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9bb6fe11-c10a-a373-9288-d44a5ba976fa@quicinc.com \
--to=quic_qiancai@quicinc.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rppt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox