From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9C06C7EE22 for ; Tue, 16 May 2023 00:42:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CCFA900005; Mon, 15 May 2023 20:42:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37D23900002; Mon, 15 May 2023 20:42:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2452B900005; Mon, 15 May 2023 20:42:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 14B6C900002 for ; Mon, 15 May 2023 20:42:38 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id CE21B1C8C99 for ; Tue, 16 May 2023 00:42:37 +0000 (UTC) X-FDA: 80794267554.18.457FA3C Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf05.hostedemail.com (Postfix) with ESMTP id E7ACE100008 for ; Tue, 16 May 2023 00:42:34 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Wh8br5+K; spf=pass (imf05.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684197755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m5hbCoXXCLVF8MzOJ73BXVTZCAtdnkR4Rw57AoX42iw=; b=3aj7FKj+o79KZ3iNyhxBkPVjTMGvUaY1cOszXGoJuYFR+GQOrPBHjyxYeFfVL/ZIpbR1EU qVHQRU4KHE8rFOw+fNDLFz5ogbw7EKYRWT2dWy+i2ucbQzY+Gyw019Jpv7dJh+xal3gt2S oaz3PJ40YCcnSdynLdX+EFj1cVPa+wM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684197755; a=rsa-sha256; cv=none; b=Xrj1+8bjjJEox1w+yPiq3SVULxPACKRt4SwUNLIBNvjENxW4unZTxLbvvaqnDQXQKWY7ho oLkyUnkZ+H+u/YXFxWdHSdxKO5Pl6Bp1d1i0SwrOHZKXFFQX8a7x+MJZAYCbEV5hK2zE4/ ndRI+y4ScvqW8E3ev/5euZp8n4V4O+Y= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=Wh8br5+K; spf=pass (imf05.hostedemail.com: domain of zhangpeng.00@bytedance.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=zhangpeng.00@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-24df4ecdb87so9015592a91.0 for ; Mon, 15 May 2023 17:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1684197753; x=1686789753; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=m5hbCoXXCLVF8MzOJ73BXVTZCAtdnkR4Rw57AoX42iw=; b=Wh8br5+K13gY6AURiwlRegSvBaTL8uC7EwtJq1BLOMe7e0luIc4+ha6+12UfS735zh Ocl+yPlyTErcsGBqX/VGHUw+SLnGyu4XlW4Dl5Jz0HRu/i+rhzR7tW9N0L6TKK0Si8nL 5JmMlnEr3hbtdV8SjYMk4KrqjNuM7jXts0OykrSPiss/k2yMI2Pg42JpfEy9rlkxO0nP FUO1pviYIAwcyT2SLF0aOJdc5+OmkdVXFnhmx0bwPdzQKXE7IlA5Tsj0kGrZWrmKhr/s rQSBK6FOGqfzRsw7AfObZtWEC950lfP3UeUFM0k7AK8b3viRxJI6BxK9clslOM3+d+yT QnOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684197753; x=1686789753; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=m5hbCoXXCLVF8MzOJ73BXVTZCAtdnkR4Rw57AoX42iw=; b=MmSYr7sXR8O7J0QELJVVbvWKmgzCY0tzMtT0NGXWl6/ht7hWedvefXG5bC2qYKuC8O D9Yrl7ojaV8P3IP06/TRCnyPraDBhhRoiwYsbsXDtghNK9mfrOMujR5oxtTzy8flPec7 P8PdkIjR0JM6+P7vSEmhEjVGtgHV3XRPgHxtwLRcEaSXniCt3sswu9gFcxXYt9iPRNMt 1D3reguVJEB0yR9d22nNlCo15l2FPqUXnqxknXxt/lCBGLP9HE3JEWDbnISerkdnrft0 9wS2J3k+wPxLwWQz8j5TmvlCBrYjBs/ZdOjaEqmdWiCbV3jDBTmKqXG8+S9vpkN6kBQf HOUw== X-Gm-Message-State: AC+VfDypg/wJxn5LEQ1tBf68ECBDIupsKR1LCbzMBoRB80Qeh2mjNEzG X0NNql6+LnqxdxGJyo34o7EWyg== X-Google-Smtp-Source: ACHHUZ6VEKvfhERfe5LC7EzstyaFNWASlsmnb1eGLL0HaEbarBYWN3row/Slh2nfhWkpgWg8E7QR4Q== X-Received: by 2002:a17:90b:4a51:b0:247:5654:fcf3 with SMTP id lb17-20020a17090b4a5100b002475654fcf3mr35005149pjb.11.1684197753702; Mon, 15 May 2023 17:42:33 -0700 (PDT) Received: from [10.200.9.178] ([139.177.225.227]) by smtp.gmail.com with ESMTPSA id f15-20020a17090a120f00b0024e3d26f644sm243932pja.3.2023.05.15.17.42.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 May 2023 17:42:33 -0700 (PDT) Message-ID: <9b9fb65c-ebc9-f86b-c85d-2676c1c5d0eb@bytedance.com> Date: Tue, 16 May 2023 08:42:28 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH 03/10] maple_tree: Remove __must_hold() which does not work To: Matthew Wilcox Cc: Liam.Howlett@oracle.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, Peng Zhang References: <20230515131757.60035-1-zhangpeng.00@bytedance.com> <20230515131757.60035-4-zhangpeng.00@bytedance.com> From: Peng Zhang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: 6q4ooa675ea9q1u3ttyt6x7wa4wbqmih X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E7ACE100008 X-Rspam-User: X-HE-Tag: 1684197754-873432 X-HE-Meta: U2FsdGVkX1/k1KVvTwkbR2/dN1WzOG/EVS0r5WPd7znd5AcRr+AayF069MFaUNIs+Nz57eN2ZW2DwIuloOna0TnKQpl3wORvfHVTpMnd3ckj2QfvBcQJjepD+HTNw+Tdk+LqdjbW3oxPM++evO4/gF5g2JyRAmdCZPkUDeqdeCESE8caz+itvfCgIBBnHx0fmqQogbfbJqxDchiumvk/aswEFwdQ0YuZHK2YMTGWkg4LmmjR+kkDnySAMLLemr/f5wthQhwXVFAHM8sQYdkNx8KYuaRuP0qi/NGlbTn//ylD94UgqH4xXel6b7Kbvbd+JQ0F5H4ff9geVNznN9XX3033DMAqopfJ5juUugNMUUlbPl9s72DghbD3oiTJz+fONQgwflEQujQDc69AE62ZWCPI4dS7h5WIlY+YiLpo/5kqBslDBa18bJQYkuCtUyX0h8sP8PN10ZHs8Of69G59Qkd6/EIU2AF8gvz7OAC0JVeWp/UiKQDwB77pwkbq+YLUo8b5Talp7FuByLFRmqu650ZRrnbWPNMzVz+xkySi2YNJl92pdI47ppceaqNe4hRhWGl0rmpk4jhTUILtQHVB7efPqLukav+2jI+gM8Garimgquf5Guu7+4XmmJkcwfd1khHjNU2zxjS+t2LLqbHrt51FHZb7xcBQvoikKnmiosAj5YUtUj5H+QhKyi0R9AbGq5aw8K9bRHux2xfG7u5zALrYqH94ylCZHMCts9GGGG5a6kw5Oq6j+vUT3Nw3cHuP/VMJ6FpfMaLZcl0j/Oy1Dg7Q4CKl/DZlRjAeowr7Vk9GPrjaVGZSp8EOODmH5rIOsRUFwMtoMo+VFCjsy0A3sl6oCpz+dxpHhX4nkYDN5eAI7lPXN+FpnfNU0OFn6HMuWOOy/PIkz8n4LreA5dPRRCYB9bdl2itqM+r40Z021mhzP3g7F+R5nFQF5LBIhmh5Q0QrZ6UogqOnhjSVr5z Mjy7OaFS dM2tH0hrGB0i+5TFDf7LwnOXxaRYehhlJaJ2aKlckD+ZvO8aWn35lsa/1Pydo8NDpqmqvNcy6tcgHNIEYZD81bFQTHZWVKSH3kjN5/uMx4kCSDOL5/Zx+j0gbx8XIkemcODdyu5rU+YsHELD3maKh5qB/qYBL/ZqmUPhoqHiejp0XgrbxAtWNrakXq5g0Iui5siIsw1KP7bLce9pJ4JnXc4IJrE32D7GHyrAhqmk4K/fQxeNksBtp22a6OI+v0fbCXbmzbU1ShwoDR/7fSBNerZVS9rxu8ty7Mg9Ey5hiSDWaFXhC8EkgImUuV3/WEAz8xx+UAukLTWNw/9KeS1QKGIbInEH/eiyIZ4k6gNXozn3lp72yxx5rAsAlgObqi9VDIOkfNqhd4CnLXwzYBCjro/eqTiW4qWVwleFu7O8nZGsDKNu2gb0kcvj7YA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002789, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2023/5/15 22:55, Matthew Wilcox 写道: > On Mon, May 15, 2023 at 09:17:50PM +0800, Peng Zhang wrote: >> The arguments to __must_hold() seem to be wrong so they should not work, >> remove them. > > Why not fix them? I'll fix it in v2.