From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@kernel.org>,
Anshuman Khandual <anshuman.khandual@arm.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, Oscar Salvador <osalvador@suse.de>,
Pavel Tatashin <pasha.tatashin@soleen.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] mm/hotplug: Reorder memblock_[free|remove]() calls in try_remove_memory()
Date: Mon, 23 Sep 2019 12:54:32 +0200 [thread overview]
Message-ID: <9b85f517-fee5-650a-4e18-29408ca85804@redhat.com> (raw)
In-Reply-To: <20190923105224.GH6016@dhcp22.suse.cz>
On 23.09.19 12:52, Michal Hocko wrote:
> On Mon 16-09-19 11:17:37, Anshuman Khandual wrote:
>> In add_memory_resource() the memory range to be hot added first gets into
>> the memblock via memblock_add() before arch_add_memory() is called on it.
>> Reverse sequence should be followed during memory hot removal which already
>> is being followed in add_memory_resource() error path. This now ensures
>> required re-order between memblock_[free|remove]() and arch_remove_memory()
>> during memory hot-remove.
>
> This changelog is not really easy to follow. First of all please make
> sure to explain whether there is any actual problem to solve or this is
> an aesthetic matter. Please think of people reading this changelog in
> few years and scratching their heads what you were thinking back then...
>
I think it would make sense to just draft the current call sequence in
the add and the removal path (instead of describing it) - then it
becomes obvious why this is a cosmetic change.
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2019-09-23 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-16 5:47 Anshuman Khandual
2019-09-16 6:36 ` Mike Rapoport
2019-09-16 8:50 ` Anshuman Khandual
2019-09-17 3:10 ` Anshuman Khandual
2019-09-23 5:46 ` Anshuman Khandual
2019-09-25 3:13 ` Andrew Morton
2019-09-25 3:50 ` Anshuman Khandual
2019-09-23 10:52 ` Michal Hocko
2019-09-23 10:54 ` David Hildenbrand [this message]
2019-09-24 4:12 ` Anshuman Khandual
2019-09-24 11:47 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b85f517-fee5-650a-4e18-29408ca85804@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=osalvador@suse.de \
--cc=pasha.tatashin@soleen.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox