From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703A0D3ABD2 for ; Mon, 11 Nov 2024 17:19:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE35C6B0092; Mon, 11 Nov 2024 12:19:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E93566B0095; Mon, 11 Nov 2024 12:19:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D81556B0096; Mon, 11 Nov 2024 12:19:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BB29F6B0092 for ; Mon, 11 Nov 2024 12:19:15 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 41EDC141A53 for ; Mon, 11 Nov 2024 17:19:15 +0000 (UTC) X-FDA: 82774473222.19.E88E049 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by imf17.hostedemail.com (Postfix) with ESMTP id 3AD7D40026 for ; Mon, 11 Nov 2024 17:18:40 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=SukEesPX; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf17.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731345491; a=rsa-sha256; cv=none; b=kgiJjln6Jy0hPjgb98X/4qXdiYt9TnlOXw/D7t8iY3ffzBYua+7w8idiiJGhmSzl5kLCcu a8dUMMERGYx4aRLSprxJ6rVYvds6ImH0y4ISEC2xn3yNss9a9pf+gbsQqrcZwAcLuvw/E7 AhbZhZaxmQ/MkcelfrS1MU+tu1yhYig= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=igalia.com header.s=20170329 header.b=SukEesPX; dmarc=pass (policy=none) header.from=igalia.com; spf=pass (imf17.hostedemail.com: domain of andrealmeid@igalia.com designates 178.60.130.6 as permitted sender) smtp.mailfrom=andrealmeid@igalia.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731345491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vt8QrytlM6V2BUYi8TToKbcS7cl84Bzk+nOqQuQcapI=; b=yGwf2h7uWIHYCGNJcDrk44ZRf1H1FNuMoaODzMN4/VNHZovynwhevB5PKWF6KVrN/xvGXx O7DLJGaxn22wLggkIC9w6tM0YLKr/Kfs9MZt6YmtnZ/KQvyUed+1xBOr0DgjVDRgFsNkLQ oNq7lqeGs1fFeiWTArk79BXrHPx9t2g= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vt8QrytlM6V2BUYi8TToKbcS7cl84Bzk+nOqQuQcapI=; b=SukEesPXyt7+N2QyisJfBalF7k t68isgZ8AUvFf29f8ztiWoUz/RXl5+BsbEiyJ1/O06+iatuOHkMApIPEAx4CXF58Oo7RDBEiT6GD7 nDD/EL3SJqBB0M/H4KP91d+RA4V2W3oO762eAISI06oIjwO6kDp9v4JSv0Gn/HUZrt64IgBqwG0KJ 9DPoYIupOeaO0IV/PT7S3ALl/HMzBvP8n7fjy9YeEBn3GGE5LKC4jk9NIX8kxt8MR8RpIBZ3I9Tim c3aVgtWpDVMpf0SGAHaXWITm26Mgf2s8k7Pi3Yx5prLVG7BDD4p7B7EXyz4GemVDFSP0sKP1LZBvV ITpv3WNA==; Received: from [179.118.191.54] (helo=[192.168.15.100]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1tAY4A-005ZCK-Ur; Mon, 11 Nov 2024 18:19:07 +0100 Message-ID: <9b753080-87c3-424e-a2a9-d4b04c1dbec4@igalia.com> Date: Mon, 11 Nov 2024 14:19:03 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: shmem: Fix variable type to int to evaluate negative conditions To: Karan Sanghavi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Hugh Dickins , Christian Brauner , Shuah Khan , Gabriel Krisman Bertazi References: <20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Andr=C3=A9_Almeida?= In-Reply-To: <20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 3AD7D40026 X-Rspamd-Server: rspam11 X-Stat-Signature: fu6r4xoeti7co6y9y1zr1gdphzmzraqd X-HE-Tag: 1731345520-387305 X-HE-Meta: U2FsdGVkX1/WE99UN6V22aKqkzG6JlRiL8++yEchyg6KCA5CYh5fVWLf6snQICwoV89ahw7NiufT+m64dfFIrggg26Uj9SsN0TTfGcnG7yw19OYK7R7snLBpJP0bR45jRpKUf5UfM6f6zt33ej8jtC3sPjoxCeR7pY8Opbq2r0hNIpIIQDs3exzDIjPYLc4i1Sx0TzF5CDyFeJTVv6Y1sR6s0XbkXjsYvPkypvVreqMblKsggs0ZJzAcklPda/83tPAa7gfSkISlDeVmxGuyVdIOezoTHbyZ7OuLOFK4k0tlK+XiADZIBNO65oNp22jqPueVLvaiaYmTt1d0bky0qTXVb9VOWId3YsuH/kZSwYk7EeEmX1CMOHlX1FzGn6soc7Y0UHQiVr6iNfSC1lBPgFhEqubIhljXDYxY7T1+dz7/f4JMuRtxkg8PoMCRAd27cD/u3wzNG18cr3DAelfxeuCar4lIzA3eLPRz5d359Mag0IB6BfUoCEnOCuDiIhFKZZOyzkSA9MiYvKswzyG3gGFImfZSGjAo6nn6Y2mBvttsJGa+BFuZYJyba49Da4fcoutkWlLfoSRTDSmlggyvlW1WHsmezThPVxQhcPjd2Iof280fHdEpDoGcPvUYMs06Us3FZxUtx/UtItHGRwBgIQvz9wdvl+6nuTRQI87pburPItryLJFxhKAvjgHBerIukL80mPfxGA2LCjT4LOq7ccu/jpVQGYyl0xdN/RajwiucDFRmIp+iuEiivVkU/4Gd8MWNedwl+Pr7TtA67Kg81wKWpbayq5YkV3adX9kFrZfQv5jjjy4OaR8E3IHNMdqktaA7Eg8T/SxYbuOfX698USXyh0mE7Nor6wFIHqYfAShhwuv0un0kFu0fkxHSSo1tJ+cXTN0nkTx9yTpsT7C6YGkCF+myX1RWy33psxKO2FYl7vVhNQc4S33gFCslSxJ7cO+VSX3VvwbESV9Kq0M Ph2d6JPU gN/0gNqe7vCUyPYUaic7CA5ungbQmVXXqRJe+j4b9W6lW7dzRDYXTKQy3/q2M4u/Kk18m1zuoE5jiRu28g/G5arLlbGFoxD2cqlARfpF2kZLYLDPhL07D288YkduPvKiZaprg2B855a1YdfD+kaq6708vwOqc0hm7sYPxI9R91FPIa7LYermfM20XXxpNRRa6t2HninWSYaiW37pC0gad/MfEf5ixtS1AJWyuZaxjoiOAGTPVqzkGXec+qR98Yg0ADk27F2eSvu65gJTbaSr8kg+mrk/wINIVOwG5VwllR962AxDLcNUbP6yQQFj6AirSsEB/WzOAqPzAyj2nKsk1r1ICRWwEnLA66CuoV+BtLyoKRZrwAK5qnkm/fgs5yizEBSVGnNPxb0X0meo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000332, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Em 11/11/2024 14:10, Karan Sanghavi escreveu: > version variable captures return value from utf8_parse_version > function which can be negative, but unsigned won't > let it capture, thus missing the further checks on negative values. > > Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support") > Signed-off-by: Karan Sanghavi Reviewed-by: André Almeida