From: "André Almeida" <andrealmeid@igalia.com>
To: Karan Sanghavi <karansanghvi98@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>,
Christian Brauner <brauner@kernel.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Gabriel Krisman Bertazi <gabriel@krisman.be>
Subject: Re: [PATCH] mm: shmem: Fix variable type to int to evaluate negative conditions
Date: Mon, 11 Nov 2024 14:19:03 -0300 [thread overview]
Message-ID: <9b753080-87c3-424e-a2a9-d4b04c1dbec4@igalia.com> (raw)
In-Reply-To: <20241111-unsignedcompare1601569-v1-1-c4a9c3c75a52@gmail.com>
Em 11/11/2024 14:10, Karan Sanghavi escreveu:
> version variable captures return value from utf8_parse_version
> function which can be negative, but unsigned won't
> let it capture, thus missing the further checks on negative values.
>
> Fixes: 58e55efd6c72 ("tmpfs: Add casefold lookup support")
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
Reviewed-by: André Almeida <andrealmeid@igalia.com>
next prev parent reply other threads:[~2024-11-11 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 17:10 Karan Sanghavi
2024-11-11 17:19 ` André Almeida [this message]
2024-11-11 18:37 ` Gabriel Krisman Bertazi
2024-11-24 8:02 ` Karan Sanghavi
2024-11-24 11:33 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b753080-87c3-424e-a2a9-d4b04c1dbec4@igalia.com \
--to=andrealmeid@igalia.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=gabriel@krisman.be \
--cc=hughd@google.com \
--cc=karansanghvi98@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox