From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB71CC001DF for ; Wed, 2 Aug 2023 08:24:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7BFA28013D; Wed, 2 Aug 2023 04:24:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E2B6C280112; Wed, 2 Aug 2023 04:24:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF27728013D; Wed, 2 Aug 2023 04:24:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BC1B1280112 for ; Wed, 2 Aug 2023 04:24:33 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 815EC40D7E for ; Wed, 2 Aug 2023 08:24:33 +0000 (UTC) X-FDA: 81078478026.12.4E6DD53 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 48BCA80010 for ; Wed, 2 Aug 2023 08:24:31 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTAHeXKr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690964671; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DtQormFq6iIvoR/QhqHDlvFGsNl3UyYF/d+disvIy1k=; b=aPKk/c1fE+ZDHsbkIsweOzrgTHSiP6ZRVLFcGURAXTDmvyoiri2PvGYd+WS02fvV3h/V++ Nqcpe5L9dQHXXpqmHh6FbPQ9iAdZ05I/Oq569haExI0lVmUW5h6v6t2V24ehlZguuCFG+V zTa0Drs7clMnST0nx1ZQXFs9x6eO5ZU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=TTAHeXKr; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690964671; a=rsa-sha256; cv=none; b=siEtrfcm7es1SORe+cpkxfgqij06ah944R0SmpwipIF52SW7QolNAVj2UDe4YPYSOYE36v kuTXfmy3+yCwx+0PLFEZomDqF/KD6SAX5WZVrGCXa1SDx6urMq2CF1/E75APMMhfNZPf4K TkJO6LoJwFIiHj773EU3wUDkdrNrcOo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690964670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DtQormFq6iIvoR/QhqHDlvFGsNl3UyYF/d+disvIy1k=; b=TTAHeXKruCTewgJbPI4W9XQGSlLqkxkFCURXB5zUP4ZtCVqvOLP1h3JRh6um+L3GgwCHcK votK2wcOapJxH7IBjl6F3vWKe/j6yfKXAff9S3qs3ZaqiKRwFJPbWlu/8DJpM17XKKYimP +16BAqkmBgDgYb9yo9giM+352/7fKDU= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-439-MoaWBDsuMW-nbU0mBr2K6g-1; Wed, 02 Aug 2023 04:24:29 -0400 X-MC-Unique: MoaWBDsuMW-nbU0mBr2K6g-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2b9aa4db031so57228941fa.3 for ; Wed, 02 Aug 2023 01:24:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690964668; x=1691569468; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DtQormFq6iIvoR/QhqHDlvFGsNl3UyYF/d+disvIy1k=; b=Sg8qjjbrnLn8hXpTO+HsAFHTXZKNif5GasglG1yNaSN6EF4UnKbwfZiAv0pzdr7Xiq z8+XlKlDm8i6yhj0GJOqFDvhzFoyS+EUbIGD5JWeUf2A+pZ0aHhCcYvR93LqXj17SJRw jbF+p/fg8wJNzMt9fBoZgpmq8nHpYntFvaEPDg/V0DSXcJKdDMtdwrIueZYQS/iaJKyU GHs6Gg8lOA81DzYrqcE2ApcEqK/Bequ9nHCGomKI85GLJLKvsoosy42NEEbpQdyepTfQ XjwlarOaK2T2AtJyOZRu9MpofcZb+rwcWpExrn77RPsFLfcDCgl27bLzv799gqiHWesx hs2Q== X-Gm-Message-State: ABy/qLZEokaTjU4nMTKEPaQklk+LlLtpgnoxvWQFj4uyN0MnZAkIvO3Z 7qhYLWCu8IiKOnLLIIfY0vkv/0kLOUxwuH9H9FqeM97VQZQ/MQXz3T5iZztIMzRd6Es8EUwi/kw WV8WeKMpEpwk= X-Received: by 2002:a2e:3606:0:b0:2b4:6eb0:2a27 with SMTP id d6-20020a2e3606000000b002b46eb02a27mr4403599lja.17.1690964667879; Wed, 02 Aug 2023 01:24:27 -0700 (PDT) X-Google-Smtp-Source: APBJJlFNA6gz1FZ8UuYKGErq/QQiavCiN+bzB6Z9bnEb46HGJkYdZuEyaP0A0byE8+ZAaUHNQ1TEHA== X-Received: by 2002:a2e:3606:0:b0:2b4:6eb0:2a27 with SMTP id d6-20020a2e3606000000b002b46eb02a27mr4403582lja.17.1690964667450; Wed, 02 Aug 2023 01:24:27 -0700 (PDT) Received: from ?IPV6:2003:cb:c70b:e00:b8a4:8613:1529:1caf? (p200300cbc70b0e00b8a4861315291caf.dip0.t-ipconnect.de. [2003:cb:c70b:e00:b8a4:8613:1529:1caf]) by smtp.gmail.com with ESMTPSA id l22-20020a7bc456000000b003fc06169ab3sm1043916wmi.20.2023.08.02.01.24.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 01:24:26 -0700 (PDT) Message-ID: <9b6ffb16-19e0-da2c-c4bc-d95416fdc787@redhat.com> Date: Wed, 2 Aug 2023 10:24:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 1/8] mm/compaction: avoid missing last page block in section after skip offline sections To: Kemeng Shi , linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net References: <20230802093741.2333325-1-shikemeng@huaweicloud.com> <20230802093741.2333325-2-shikemeng@huaweicloud.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230802093741.2333325-2-shikemeng@huaweicloud.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 48BCA80010 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: zji1q9ahf5yijkkj1dgdamtnbh88pq16 X-HE-Tag: 1690964671-137640 X-HE-Meta: U2FsdGVkX1/gUKVXIovy+WY2/EmwnxqohX9+hfd6bh+OmNMXOWHXaAXe5MPW47g9kuLu8nBPViMzbOw7nCP0U6QN4cKQsYh/IMmMXGokcO4CTysFD4IQBcPG5i8CUdb1U6mZPPxa35XPnbTiSS5ZZdnkBIO1JbCE81qEKNakWnGkzPn0FGz1tKCSJH2wWemYMeX/mwVc/Moxzv3RArTijVO+TbkxoE7wxOhaL1o0Px51ex7hubCiZqqjoeOOsgH4CdTBUdE8SsQl7il53xKOO2lMmrurVA+jKhyhtPm1pExRPMA8M+Uxu85mB2fY0+sV0kvuyIX+4/Nv2MznbHOksQDtnd2kCJVB9Pyzr32E9cheRBYr3/ZiLHoKbZkek75Pa95GjvXbpJUknBwLL92HnM08LdeRTJax4lZdi5RMw8E5JImhJBwB/5bRoJEwWYcB2vo94g2SIq5DxBURx69b5wzjwyR/smqnA2dB7TsU+0f19qv0gb3zK4QtXhOu4gc82Kb6A2oB7DwnNeGzRceZcU3KcKpmuR6DcjVY+173wLsDKW5bc8O4fMUCZiYnKFHRnHpWeLVrqoUymxwtiAcdu5q8/2VyiVU710btq8ytnUas9uIQu9n9dCY1xofV1lpZMAxaR4kTkRru4Oawx40LavYYjfLnxCMwKn87Unk0Sq7f0edgTpxbbomAQzgAsGf68IrBnBmPImdRzRL1NwW6GPRSiG6YUXN/zzomSqeXC4bNxbNiGRYPF2KvKN04dUlL1RDDID69B31Wcv80FRoUoKilmaxebNi00U/svEjVEUh3B4QV7CcKckuzG5jt6sVM+HWMhS78BuDFxml87OCaKJGU+1/iSsd8l4P9heodWqdkOnRkLWwFEIc0p9zZ0gOvAx/aXMd+uRxKx6scyeL3aNOpKVuzK6ZIBh+TJ0z53iql8c/5sfVLnjODdnZkkcxhSNJSEnIAMnWaC6vJxGZ ZEOhxCJ8 QqsDTmuEaMm3/N54qUTFs6p4Sft+iczktArNUisLPZedfKlvZhWx7Al10v8J7GsAmfZf7GSeBlPQzJytgJVjIRza0lFRVIqFmA3W0X7tdJNP1d62vnlLGjTfmOj1M2xLp9c08f1QnxKsxWTY3a5gEtVexKgsizN72jO9yuaRukDYht610RjoMGAFL1nJpcXorrNpTU2Kc+fbOzpcuqU2LXTZa3I+vjBjaXKHyLuce7S/Y/lBto7mTeYnt29DPwq8rQoO5EJFZyHcxjxjRaWxilntQu+oTaI12gqw6HrShDSy/+RYb1bdHS5bf7/zutCwhohmhN4VtVCY6QFKMEaeFsiIwixDGsDEmidJq15bKFmSYrEGt9UTAgJyCuHp5gs6FCjF2I+5bwJjY5q+yibSnml1xxFL6iYflyYJ4O38KcFzCK36MdeRTlA2+oti2VVWaOzZZz+h3z9zGVl5aUw0EZR+xQg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000146, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.08.23 11:37, Kemeng Shi wrote: > skip_offline_sections_reverse will return the last pfn in found online > section. Then we set block_start_pfn to start of page block which > contains the last pfn in section. Then we continue, move one page > block forward and ignore the last page block in the online section. > Make block_start_pfn point to first page block after online section to fix > this: > 1. make skip_offline_sections_reverse return end pfn of online section, > i.e. pfn of page block after online section. > 2. assign block_start_pfn with next_pfn. > > Fixes: f63224525309 ("mm: compaction: skip the memory hole rapidly when isolating free pages") > Signed-off-by: Kemeng Shi > --- > mm/compaction.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/mm/compaction.c b/mm/compaction.c > index cd23da4d2a5b..a8cea916df9d 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -250,6 +250,11 @@ static unsigned long skip_offline_sections(unsigned long start_pfn) > return 0; > } > > +/* > + * If the PFN falls into an offline section, return the end PFN of the > + * next online section in reverse. If the PFN falls into an online section > + * or if there is no next online section in reverse, return 0. > + */ > static unsigned long skip_offline_sections_reverse(unsigned long start_pfn) > { > unsigned long start_nr = pfn_to_section_nr(start_pfn); > @@ -259,7 +264,7 @@ static unsigned long skip_offline_sections_reverse(unsigned long start_pfn) > > while (start_nr-- > 0) { > if (online_section_nr(start_nr)) > - return section_nr_to_pfn(start_nr) + PAGES_PER_SECTION - 1; > + return section_nr_to_pfn(start_nr) + PAGES_PER_SECTION; > } > > return 0; > @@ -1668,8 +1673,7 @@ static void isolate_freepages(struct compact_control *cc) > > next_pfn = skip_offline_sections_reverse(block_start_pfn); > if (next_pfn) > - block_start_pfn = max(pageblock_start_pfn(next_pfn), > - low_pfn); > + block_start_pfn = max(next_pfn, low_pfn); > > continue; > } Acked-by: David Hildenbrand -- Cheers, David / dhildenb