From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81BD6C04FFE for ; Wed, 8 May 2024 07:51:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F2CB86B0099; Wed, 8 May 2024 03:51:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EDD126B00A8; Wed, 8 May 2024 03:51:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCBC06B00A9; Wed, 8 May 2024 03:51:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C07ED6B0099 for ; Wed, 8 May 2024 03:51:03 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4294A160EF0 for ; Wed, 8 May 2024 07:51:03 +0000 (UTC) X-FDA: 82094457606.14.9D615BC Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf30.hostedemail.com (Postfix) with ESMTP id 6C70D80009 for ; Wed, 8 May 2024 07:51:01 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=TyCeEKfi; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf30.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715154661; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HDiyT/vG++eQsq88B4/5UyaBvnnLoUm0K+kXEVjlnrU=; b=iCtb0xzUv/Htf2TsSpO7ULpVvWeT4D/YQRscUuuqx0S7JPdkJ66KV4Z/hyCiD69RAgJYoQ v1LK/syHM+Oufk20iFOauLp2MILi6i2hFFY+xvAbz88L4n1qF5Bf4nWqVraJY4ei3ZZsmw inWQqUZaFeAjDRTUU45AueD9Q5IK5tc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715154661; a=rsa-sha256; cv=none; b=byMc9tjcwPoFcFOohJEhF2DGDu/4wonVmTx6Pt+GhsUM7+HDCb6zEuXCvpjXiOavEPQdUl MMR795aUEErEDzzLxzbdHQ8qWINnuoZU9Q/bGPi9XlGJ2Ah4Bw3X0Sq23axqBnYFZLI4vx 8u7JJZhcibq0MaYwuLSKm7Lv5roCznk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=TyCeEKfi; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf30.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1715154660; bh=ER1Z4aI2riqIkflza4C4e1PlWp6zX494INQCy0XREMI=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=TyCeEKfi6CYhIwEaqOEpH25jFs6qvBUVq945IAEJX0ygECWU589cyU+MvgoMTwPux 6/BdQxBfA97+L51tiYYuC6Z019EIYhFF3sdDZuG2WVBm/WaUFyhWfjl8go6V74ihZL zBcgP46R18osAyST9mJimRCt5HPROCQi3DU7kLTMECfOKz73i5JJsM6E5KBVualcXQ 5gzkdSfbaSw8tyRODR4he2DEGEVliGska4eIsPBcU5tlE50l57QHTt63UZ0CRXcg2U D0N9WjN6eZpiBY81Z85YXE8KEKC/rooS7M1+Qvq169eoVStaDUIn3LxqthwG70lAAM pCsLg40TYView== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 7EA2C378216D; Wed, 8 May 2024 07:50:16 +0000 (UTC) Message-ID: <9b54b87f-f761-4e4f-8df3-993e426ebc27@collabora.com> Date: Wed, 8 May 2024 12:49:58 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-input@vger.kernel.org, iommu@lists.linux.dev, kvmarm@lists.linux.dev, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-security-module@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, linux-actions@lists.infradead.org, mptcp@lists.linux.dev, linux-rtc@vger.kernel.org, linux-sgx@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [PATCH v2 3/5] selftests: Include KHDR_INCLUDES in Makefile To: Edward Liaw , shuah@kernel.org, Mark Brown , Jaroslav Kysela , Takashi Iwai , Catalin Marinas , Will Deacon , Nhat Pham , Johannes Weiner , Christian Brauner , Eric Biederman , Kees Cook , OGAWA Hirofumi , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=C3=A9_Almeida?= , Jiri Kosina , Benjamin Tissoires , Jason Gunthorpe , Kevin Tian , Andy Lutomirski , Will Drewry , Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Zenghui Yu , Paolo Bonzini , Sean Christopherson , Anup Patel , Atish Patra , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , David Hildenbrand , =?UTF-8?Q?Micka=C3=ABl_Sala=C3=BCn?= , Paul Moore , James Morris , "Serge E. Hallyn" , Andrew Morton , Seth Forshee , Bongsu Jeon , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Steffen Klassert , Herbert Xu , =?UTF-8?Q?Andreas_F=C3=A4rber?= , Manivannan Sadhasivam , Matthieu Baerts , Mat Martineau , Geliang Tang , Willem de Bruijn , Fenghua Yu , Reinette Chatre , Mathieu Desnoyers , "Paul E. McKenney" , Boqun Feng , Alexandre Belloni , Jarkko Sakkinen , Dave Hansen References: <20240507214254.2787305-1-edliaw@google.com> <20240507214254.2787305-4-edliaw@google.com> Content-Language: en-US From: Muhammad Usama Anjum In-Reply-To: <20240507214254.2787305-4-edliaw@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 6C70D80009 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 37hm9wya3as3b6xbnyhoa1fdh7ry8q5k X-HE-Tag: 1715154661-31852 X-HE-Meta: U2FsdGVkX19t4quqkHsQihEo3WJFEkh9aiCXusl+Zr5nwfR98XR1mKgw0J15QVYMt3yT6nY66meHxQAc8oxaxcRpuu/MEgylUSrG3DUv+3W+Y/4cyx5AMSYuCJU6eYOJThc4hcDKUg/zK85LnEI35h6XxYlpWejale89u3h0gT7TK/ZNunpMbAtUX6V6FOio9LSYuOukBff0q3yyzfgb0QeRSqxTbdTbkNnFLbSoP4v+uzP0tDdIAxVEfuesEYhhBpPN0WofQ0C/vYAsetZDS5BKpsMZOB+YofKGTr+ITCnM5ZjF8/fM1/SL334NupzASxifaD6SJuCSYvYNNGn/PqNvDvfRKhf5/b7YmXTKS8NPFGekFBxp/AVrqA7TPQm4Sm2u8gzaXXCejloCcD2rc24TkCpnBohtC6b50iQNgBs2eCnIoCrey/rjzyNHhCooU6lZo19LAAasMwgSptXWcXYEvXIjran2egk8wbbX1fMk+toJ8f0tGQI+M8/Ds8RbJPGuXopq3W/d3E1lyD7lsjnNgDojjkZm/6zDS3q8rQBlPRx8ltbawzhRW5sIZBc+DEth8PXB0C4e5qT6AkhSyFb8MMg5Yu9mPafBofnfA6mfvTGHzkZeive+PTUZD5utuwUzXI3wYEDCBYIBU94jhA3Ujeif32H60Sa8W2cm1PruVxBoyAK9Ww8cVlDdEJuiIBwYedKUqox2G5dxsvpiY7Ov8Xp31oV16htkqB6Ij7sTCjxjmG52As6oRy4rERj41mcGlB1NFBNsLk1RhyB5rSIAdsC3Qr80dtM8VveZ1NCUGWg0TCXJsnIndPFWHlP/6sBlIM795f1rzxLHYyCFLa4zDL08fSFL+UHAFGYhJWlZB1ptv45yCOBqgT76Yxzwm3wOrBc8VZzpYyTrpxCYDQi9wxRz3detSNBzvWKBeCM6+wwm1Bzkgl4AquH+qlCoTqixWw3iiXqB81nXwn9 NqoBGm1c SXtQ1KjKd8Or74LxDRNMNmZepLTiyz/23Zlb+DBbcyg7SfAzF1CAjGDQI+4q26F/pNfvgrwOxGxa79ReNESrvx7UfoCrpnuukJBVA6+/L7OlnADFZr0HXKIic022YScoK7yZxLSh1JHD5wtxAAAj2ntwxSGNksiVMP0WL25Z6BZV7CEV8n3oZx7RmJ6FkBFIZ9mL0GkKMOubpxkiXPdJWrbrZvBfQShlKwbHSgLdr36hWeoiQV2MlWRsUZraqHYt7M2N+jrNyhDym7I5zbKnJdtJ/caLHRoYHoiHFAcbT4jAmAycczDpuHp39penw1Q6aL6xtBfKoGGDv26J+LIoCtfMfrwjQb8U2bB9TNk5kr6vJW0UOUhlvj53ECljiOw8/PlSsSzM0fXtFQCZP3f2MKliHb9OOa/K/4J7KgtxisWbiboioEtRMfoLW9Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/8/24 2:38 AM, Edward Liaw wrote: > Add KHDR_INCLUDES to CFLAGS to pull in the kselftest harness > dependencies (-D_GNU_SOURCE). > > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") > Signed-off-by: Edward Liaw Reviewed-by: Muhammad Usama Anjum > --- > tools/testing/selftests/alsa/Makefile | 2 +- > tools/testing/selftests/arm64/signal/Makefile | 2 +- > tools/testing/selftests/exec/Makefile | 2 +- > tools/testing/selftests/filesystems/overlayfs/Makefile | 2 +- > tools/testing/selftests/hid/Makefile | 2 +- > tools/testing/selftests/nci/Makefile | 2 +- > tools/testing/selftests/prctl/Makefile | 2 ++ > tools/testing/selftests/proc/Makefile | 2 +- > tools/testing/selftests/riscv/mm/Makefile | 2 +- > tools/testing/selftests/rtc/Makefile | 2 +- > tools/testing/selftests/tmpfs/Makefile | 2 +- > 11 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/tools/testing/selftests/alsa/Makefile b/tools/testing/selftests/alsa/Makefile > index 5af9ba8a4645..9a0ef194522c 100644 > --- a/tools/testing/selftests/alsa/Makefile > +++ b/tools/testing/selftests/alsa/Makefile > @@ -6,7 +6,7 @@ LDLIBS += $(shell pkg-config --libs alsa) > ifeq ($(LDLIBS),) > LDLIBS += -lasound > endif > -CFLAGS += -L$(OUTPUT) -Wl,-rpath=./ > +CFLAGS += $(KHDR_INCLUDES) -L$(OUTPUT) -Wl,-rpath=./ > > LDLIBS+=-lpthread > > diff --git a/tools/testing/selftests/arm64/signal/Makefile b/tools/testing/selftests/arm64/signal/Makefile > index 8f5febaf1a9a..ae682ade615d 100644 > --- a/tools/testing/selftests/arm64/signal/Makefile > +++ b/tools/testing/selftests/arm64/signal/Makefile > @@ -2,7 +2,7 @@ > # Copyright (C) 2019 ARM Limited > > # Additional include paths needed by kselftest.h and local headers > -CFLAGS += -D_GNU_SOURCE -std=gnu99 -I. > +CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I. > > SRCS := $(filter-out testcases/testcases.c,$(wildcard testcases/*.c)) > PROGS := $(patsubst %.c,%,$(SRCS)) > diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile > index fb4472ddffd8..15e78ec7c55e 100644 > --- a/tools/testing/selftests/exec/Makefile > +++ b/tools/testing/selftests/exec/Makefile > @@ -1,7 +1,7 @@ > # SPDX-License-Identifier: GPL-2.0 > CFLAGS = -Wall > CFLAGS += -Wno-nonnull > -CFLAGS += -D_GNU_SOURCE > +CFLAGS += $(KHDR_INCLUDES) > > TEST_PROGS := binfmt_script.py > TEST_GEN_PROGS := execveat load_address_4096 load_address_2097152 load_address_16777216 non-regular > diff --git a/tools/testing/selftests/filesystems/overlayfs/Makefile b/tools/testing/selftests/filesystems/overlayfs/Makefile > index 56b2b48a765b..6c29c963c7a8 100644 > --- a/tools/testing/selftests/filesystems/overlayfs/Makefile > +++ b/tools/testing/selftests/filesystems/overlayfs/Makefile > @@ -2,6 +2,6 @@ > > TEST_GEN_PROGS := dev_in_maps > > -CFLAGS := -Wall -Werror > +CFLAGS := -Wall -Werror $(KHDR_INCLUDES) > > include ../../lib.mk > diff --git a/tools/testing/selftests/hid/Makefile b/tools/testing/selftests/hid/Makefile > index 2b5ea18bde38..0661b34488ef 100644 > --- a/tools/testing/selftests/hid/Makefile > +++ b/tools/testing/selftests/hid/Makefile > @@ -21,7 +21,7 @@ CXX ?= $(CROSS_COMPILE)g++ > > HOSTPKG_CONFIG := pkg-config > > -CFLAGS += -g -O0 -rdynamic -Wall -Werror -I$(OUTPUT) > +CFLAGS += -g -O0 -rdynamic -Wall -Werror $(KHDR_INCLUDES) -I$(OUTPUT) > CFLAGS += -I$(OUTPUT)/tools/include > > LDLIBS += -lelf -lz -lrt -lpthread > diff --git a/tools/testing/selftests/nci/Makefile b/tools/testing/selftests/nci/Makefile > index 47669a1d6a59..bbc5b8ec3b17 100644 > --- a/tools/testing/selftests/nci/Makefile > +++ b/tools/testing/selftests/nci/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -CFLAGS += -Wl,-no-as-needed -Wall > +CFLAGS += -Wl,-no-as-needed -Wall $(KHDR_INCLUDES) > LDFLAGS += -lpthread > > TEST_GEN_PROGS := nci_dev > diff --git a/tools/testing/selftests/prctl/Makefile b/tools/testing/selftests/prctl/Makefile > index 01dc90fbb509..1a0aefec9d6f 100644 > --- a/tools/testing/selftests/prctl/Makefile > +++ b/tools/testing/selftests/prctl/Makefile > @@ -6,6 +6,8 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/) > ifeq ($(ARCH),x86) > TEST_PROGS := disable-tsc-ctxt-sw-stress-test disable-tsc-on-off-stress-test \ > disable-tsc-test set-anon-vma-name-test set-process-name > + > +CFLAGS += $(KHDR_INCLUDES) > all: $(TEST_PROGS) > > include ../lib.mk > diff --git a/tools/testing/selftests/proc/Makefile b/tools/testing/selftests/proc/Makefile > index cd95369254c0..9596014c10a0 100644 > --- a/tools/testing/selftests/proc/Makefile > +++ b/tools/testing/selftests/proc/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > CFLAGS += -Wall -O2 -Wno-unused-function > -CFLAGS += -D_GNU_SOURCE > +CFLAGS += $(KHDR_INCLUDES) > LDFLAGS += -pthread > > TEST_GEN_PROGS := > diff --git a/tools/testing/selftests/riscv/mm/Makefile b/tools/testing/selftests/riscv/mm/Makefile > index c333263f2b27..715a21241113 100644 > --- a/tools/testing/selftests/riscv/mm/Makefile > +++ b/tools/testing/selftests/riscv/mm/Makefile > @@ -3,7 +3,7 @@ > # Originally tools/testing/arm64/abi/Makefile > > # Additional include paths needed by kselftest.h and local headers > -CFLAGS += -D_GNU_SOURCE -std=gnu99 -I. > +CFLAGS += $(KHDR_INCLUDES) -std=gnu99 -I. > > TEST_GEN_FILES := mmap_default mmap_bottomup > > diff --git a/tools/testing/selftests/rtc/Makefile b/tools/testing/selftests/rtc/Makefile > index 55198ecc04db..654f9d58da3c 100644 > --- a/tools/testing/selftests/rtc/Makefile > +++ b/tools/testing/selftests/rtc/Makefile > @@ -1,5 +1,5 @@ > # SPDX-License-Identifier: GPL-2.0 > -CFLAGS += -O3 -Wl,-no-as-needed -Wall > +CFLAGS += -O3 -Wl,-no-as-needed -Wall $(KHDR_INCLUDES) > LDLIBS += -lrt -lpthread -lm > > TEST_GEN_PROGS = rtctest > diff --git a/tools/testing/selftests/tmpfs/Makefile b/tools/testing/selftests/tmpfs/Makefile > index aa11ccc92e5b..bcdc1bb6d2e6 100644 > --- a/tools/testing/selftests/tmpfs/Makefile > +++ b/tools/testing/selftests/tmpfs/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > CFLAGS += -Wall -O2 > -CFLAGS += -D_GNU_SOURCE > +CFLAGS += $(KHDR_INCLUDES) > > TEST_GEN_PROGS := > TEST_GEN_PROGS += bug-link-o-tmpfile -- BR, Muhammad Usama Anjum