From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E6F3C83030 for ; Thu, 3 Jul 2025 11:14:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 271A96B0124; Thu, 3 Jul 2025 07:14:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 221076B0125; Thu, 3 Jul 2025 07:14:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 136BF6B0127; Thu, 3 Jul 2025 07:14:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 03C6B6B0124 for ; Thu, 3 Jul 2025 07:14:58 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8A38F1035FF for ; Thu, 3 Jul 2025 11:14:57 +0000 (UTC) X-FDA: 83622696234.26.2F5057E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf22.hostedemail.com (Postfix) with ESMTP id B43CFC001C for ; Thu, 3 Jul 2025 11:14:54 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NXUUMy0c; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751541295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3Ul5jCDH+RN26P1OCNIEr6cA5KtO5L7bVOyzCfVabSo=; b=27TWsLHu1JS3BhEVktIjhoR6cJWCY9iYQf7DhI+SSCB66pP93sAaYeneZ9CUpWfeUqK4SQ LMR4n+3nwojMk73w37UDt03Zs2ATOIl6LYgY7DAS7eyMk+E2o1jurtHoozpbmzx3T1uDIB u0kFe4iPuUcfTSuLN5XHyaZcejxiug0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NXUUMy0c; spf=pass (imf22.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751541295; a=rsa-sha256; cv=none; b=1FHN1mu+oKjTokRt1agMKWcD8SOHqZiaisVnNVIQZ5ajHUGyJyiWeALlhvb6tkBk+eO7hp 27e2f67sUVd6VBrkT78r6CegBxALtkRBSh3RbbULRKx1amZXUl/xU+WtrzWx+oCBJ95pBA 1QLnX8HUj5MP/6Nj0XEEOIiL/P84uS4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751541294; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3Ul5jCDH+RN26P1OCNIEr6cA5KtO5L7bVOyzCfVabSo=; b=NXUUMy0cDlQ6xdwiBrtegCVQjHN7rLTIP9Xb6sA9K/WO3dN41TVarX17p1MRigh6omR5Uy KO4CVZjxktZ547uT4nB4xgMykXCmPwtgHrjlsn5HxYbsrJIjKzXoqdgsJSFo2RHGVP6D7D kCCaR0IBzyJzCXyQfwjhSUbV79zks7w= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-udKgXA16Mwiw34YB2zikDA-1; Thu, 03 Jul 2025 07:14:52 -0400 X-MC-Unique: udKgXA16Mwiw34YB2zikDA-1 X-Mimecast-MFC-AGG-ID: udKgXA16Mwiw34YB2zikDA_1751541292 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-ade70c2cfc1so670669666b.3 for ; Thu, 03 Jul 2025 04:14:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751541292; x=1752146092; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=3Ul5jCDH+RN26P1OCNIEr6cA5KtO5L7bVOyzCfVabSo=; b=TPLbT3Ry4Gay2G/wRs21jhN0orc8Htn+/i82Ej0vIONFhYyvx0xOnJWILGcPAHJV4M 4Umeg71Ls2ZbU5eUDXvf93TnhhW3qXUalJAE+Mxp5KgZnUqcMp2rbRalO/RYkxbgdzLd TCIMKND9nAamsGj0BcqJk8p0UlIJNBIPGaS8pGRSq3BCBrtRCZeV89/6dF7ef9f9EQFI U8cI8FtVlSRoq3a3fSZa+l2+Yts7gz56IkzIDlkMNxf44tZ4SdAGJPHme7Pm1nh2uOP6 XQ8dTm8UFYWwg/PJiyvzQV6K3qZ/ouv3ifljL355nv4YfERN5vJ1v0fGzxgRyJrJ80D0 AEgg== X-Forwarded-Encrypted: i=1; AJvYcCWdXQ912ntjSpMndWSetGlXNEurM09Y/AokgXW0HNAdXHan9eSn9L9OaOTjfU5gm2l2Ks6h80mB7Q==@kvack.org X-Gm-Message-State: AOJu0YxEEhe32mYagKgruRY6t9Q+EJkrU3V4BR9mjcxcq3kb3HxO3tZh TaThxI00dEEGShVWXECnca2Fx7zSNahRMS2C4SnxJA9uW2wUnTNvf+vANPWtpHLtcktDVN/axC9 AaIVuCEiVw4pPIrVC7dDakbrTBH2JZtXbQM0rRp7DzVt7sHPm/pkp X-Gm-Gg: ASbGncuTUrZPXHwxoYJXflI3oISS6ViwxJ9wNwl4nLXbxyCpd5b8I5yXzKmX7t3FP33 WrtEQnuPfXtI8siSEDxYO7uy54I2lNVf1gryTPg3f4Zq/lpmoZrbCteBDE19xZOiduO2dE2jv97 B7ocmKUcme8Nc8CIsVX0PsSanwLxV+7JG4TuQz5/ff+nncMhbmcFWGwx5ZEcQ3R0kT1YRu3bTqL NGiYAxHRjrCtLLgIpZ2l7jI/FJQ7YcltgJ+nlNTmup1ywBfiomXuPHa60jnXGia5wRr61h2K4e0 7apDUvUS1u0w03OdSre1Udn9VdVU9z3IEEt8BHsOTR4H X-Received: by 2002:a17:907:869e:b0:ae0:a1c2:262e with SMTP id a640c23a62f3a-ae3c2c471d6mr597517166b.50.1751541291587; Thu, 03 Jul 2025 04:14:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyV4wjXgRemO++dzaPvRQ7dSE6mgI+83l+4tjUB5UiJ87N8iQXzocMH2cdeFrRDzZA/f/c2w== X-Received: by 2002:a17:907:869e:b0:ae0:a1c2:262e with SMTP id a640c23a62f3a-ae3c2c471d6mr597513566b.50.1751541291131; Thu, 03 Jul 2025 04:14:51 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae35365a016sm1253840166b.57.2025.07.03.04.14.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Jul 2025 04:14:50 -0700 (PDT) Message-ID: <9b4e9e08-9849-4d55-a0b3-639439c35559@redhat.com> Date: Thu, 3 Jul 2025 13:14:49 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] cma: move allocation from HIGHMEM to a helper function To: Oscar Salvador , Mike Rapoport Cc: Andrew Morton , Alexandre Ghiti , Pratyush Yadav , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20250702173605.2198924-1-rppt@kernel.org> <20250702173605.2198924-4-rppt@kernel.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: hlUIlBTu5X19NY-fx7O2kvKmER-Yzn0NCMQC7uCKKvA_1751541292 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: B43CFC001C X-Stat-Signature: 88nixc7zpxucjh183hdgdxjh7b9rx5i6 X-Rspam-User: X-HE-Tag: 1751541294-154981 X-HE-Meta: U2FsdGVkX19+dtdC6jx8MgcnFzTdIdwBVdAUulX4s3HGtD07XcVbhDGlllYUOs+k5pISPMmZPrRTSS/3RpziNFj9jIhmDuEUdaB4pWC6BOF0sIpfdwysiVyqf7rFvrLrKtqiqFy9MA5XfrZNKe/n7En3uuurBEele65S2Fjf7ur9Q4e5poXqpPA3CcgBdwm6w7cnnR1WMryiFCi3MLwsP+8JGlAy9n1PBXs3MWQDRJPza6bW5WtpRBpqyEknBa26OfjVOniFPU3Ct0V9H2zpNTdHfYUWnd1SKwShkHkC0X970ObSN3j/Kw0nH85QDevdMNN/RHjobNGASxurBkpgAOQf8X5A0XyZG2OPPflO06fA6A5UXXoOKjGkGu4vqYt+6Huuzkf5cRCgRaOdY6yYimH8W0Dy5NheVoqacFfj07DORGZ5YPvoA4j2gPDOJsCVLLsPbovKJTnSW7U9j1f62m9uzSBpuL9Ret3BDb8kKTzTYCkMEPmTDL0DOiOZdWqoYDJPwdpv4KsOCpgDe4Ybw6kJTJNa5f8Xzx7csX4Jy5kI7TAB5OXIHF7ycV3a0oHZYnFxF3T5pGU33PmHBnJz2Yvu+vrXASMKnlqml6ncdvVEd+uJbxFeoSa4PJJXTL6GuxjF/56Gc/IX4Tsg7ZF9JYgUMVfxXTz/SDuUU7p/QqRSlyjmFOmkjqQMpMvgwoUEKiVbCATYQ/LUW2HAe1U0zX6WAvzmC3UR8cnlea+kkHBiRnUtBzSrKRnYffa6ZKh3mClRjhiZ1tYX72QwsJ4gh1kBpbVf6Jp/8IIFhWtAaRq7PMXxTznRDzBMYI0Lg9Cm544Gohy2eB0C3aaNudOmpoehTt6VgTaUf1D0IUJydmWqVvCgJGfB21iRLCM/p831k1+wH82hfGVw/vfFFTOftpZIeLc7mUv3XPuv+DxGJFu22taEH84Qg+fw9Ey5PWknsrD1yLpVOSrniM0DYPw cSBx6xd2 rMwmlYWSSw4P7SuAlvHo7AbXr2sb4WZDNrxTtjgD3QflzZUGE1pG1O74/67vmrYBTHKF9FOmuYLez9cX8oLcB9risA8td8gTtUyyUVW2zKWc02kmcd/OL6xdaY5mFALZNb9KR7YVmNlC+vrMkz5/atAxShzol+Cqenu4EbtVmIwAPI9POjQMuOwn/4fHkHf73UaB7dlMs8LWREzZxLX9o7VsTWeAxBmGbFcU4NKHBDa4DwHDXzH2u7Rz/orFjvM+TMyNeSBD1QPMrcJo60gWkH5L1NBoPzTWE9RuHYDEMEUhlvpra8Xzh6lfag7TMl73lhsVw03lq6zJPdNC/FmfWvH4Gb/RU7OtqwcuQc2MwtoDgcaLQWpUgV7wjqMU2W2L/nTgoc35ItRDGjvJDEFj/yVnMi/GKxcIhIFRcS7hnkHEj83J7tipqZ37Yz6WLvq2TvOPY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.07.25 11:53, Oscar Salvador wrote: > On Wed, Jul 02, 2025 at 08:36:05PM +0300, Mike Rapoport wrote: >> From: "Mike Rapoport (Microsoft)" >> >> When CONFIG_HIGMEM is enabled, __cma_declare_contiguous_nid() first >> tries to allocate the area from HIGHMEM and if that fails it falls back >> to allocation from low memory. >> >> Split allocation from HIGMEM into a helper function to further decouple >> logic related to CONFIG_HIGHMEM. >> >> Signed-off-by: Mike Rapoport (Microsoft) >> --- >> mm/cma.c | 52 +++++++++++++++++++++++++++++----------------------- >> 1 file changed, 29 insertions(+), 23 deletions(-) >> >> diff --git a/mm/cma.c b/mm/cma.c >> index 1df8ff312d99..0a24c46f3296 100644 >> --- a/mm/cma.c >> +++ b/mm/cma.c >> @@ -376,6 +376,30 @@ static int __init cma_fixed_reserve(phys_addr_t base, phys_addr_t size) >> return 0; >> } >> >> +static phys_addr_t __init cma_alloc_highmem(phys_addr_t base, phys_addr_t size, >> + phys_addr_t align, phys_addr_t *limit, int nid) >> +{ >> + phys_addr_t addr = 0; >> + >> + if (IS_ENABLED(CONFIG_HIGHMEM)) { >> + phys_addr_t highmem = __pa(high_memory - 1) + 1; >> + >> + /* >> + * All pages in the reserved area must come from the same zone. >> + * If the requested region crosses the low/high memory boundary, >> + * try allocating from high memory first and fall back to low >> + * memory in case of failure. >> + */ >> + if (base < highmem && *limit > highmem) { >> + addr = memblock_alloc_range_nid(size, align, highmem, >> + *limit, nid, true); >> + *limit = highmem; >> + } >> + } > > Not a big deal, but maybe better to do it in one function? Yes, same thought here. -- Cheers, David / dhildenb