From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DCF2C83F17 for ; Fri, 18 Jul 2025 05:33:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAAC18D0006; Fri, 18 Jul 2025 01:33:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B54568D0001; Fri, 18 Jul 2025 01:33:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1C1E8D0006; Fri, 18 Jul 2025 01:33:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8EB9C8D0001 for ; Fri, 18 Jul 2025 01:33:11 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4364D1D8D8F for ; Fri, 18 Jul 2025 05:33:11 +0000 (UTC) X-FDA: 83676266982.10.CC30DB6 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by imf02.hostedemail.com (Postfix) with ESMTP id 85FCA80008 for ; Fri, 18 Jul 2025 05:33:08 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JYqnjROV; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752816789; a=rsa-sha256; cv=none; b=kvY/71GVxuk9NQVhf/PaEsjU+9H+dSLj5gcZ1esxCgudxvpN8spYCnZu2ADj6wq7j5GrP6 ICDjKoNYKi6bjaYKQnbHX/pjYapusgPl4QzaUQhgE5yhZFexlsyLkLUafbtjP/qNUEAdDf dBHYzbkBB/ZBsg72V8k/fA1ZTkGs6VU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=JYqnjROV; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf02.hostedemail.com: domain of xiaoyao.li@intel.com designates 192.198.163.11 as permitted sender) smtp.mailfrom=xiaoyao.li@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752816789; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Us3y5zN8QAMlbq+3trIzybHcBAQpS6FvJUfGIuNqeGo=; b=PhCV3rcq0ROpnQRB8PU+nDgnGTljnipcslKMPA3PyrusjhueJJZHbp4iwa4sUpgESxj1Y6 OYekf2D92fQgGVpVbS1SaSoc6Am+V+43E9JrzTC0ed4RpdV+ZBHnurHE3MOXMe9Abej3kT qncAeKv2IkJ375dn3B90aHbhA5hr3pg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1752816788; x=1784352788; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=skKA5qufp6yfNZDuBB5caSttx/BReKJ+preOQVYf5lE=; b=JYqnjROVmZs+DasIvJH1YzfI29lCkDv+AffPFGYZNUqpat/do1VbkZCi ZifulmWHMm8HdLq5Xe5+f+VIJRhS1CvGAx30I/A5Z5seeYdlt+dWr3KF0 3jbXEmb//cpDZuY61a6jC+jZ7FElGCsrc2F6ZXzPiqXj2PlKYCijZFEeM OcPMY2gCNG0FtEmZaUPTeL6Kom2TkjyFIZZJDZyBYKI8LFpIW6h89/Y8a qomiPz0+k46atPPvzm79DsC/eTRz6j0LRARFw4xPCOMyJ4c2OD+mNeNqo 47YcG1rMNMSgXB5ZVqA9oZFGttf68k6XMiztWAFx2FPh0bTTGx7x5npI7 Q==; X-CSE-ConnectionGUID: oC2loYPxRH2MAscHbboolA== X-CSE-MsgGUID: 7HfsgcdgTtStKrHhQ4U4Gg== X-IronPort-AV: E=McAfee;i="6800,10657,11495"; a="65678699" X-IronPort-AV: E=Sophos;i="6.16,320,1744095600"; d="scan'208";a="65678699" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 22:33:07 -0700 X-CSE-ConnectionGUID: n0aEyWgCQzm9pzjS33gCdA== X-CSE-MsgGUID: Km5RZh//Seue6XSZKZzFQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,320,1744095600"; d="scan'208";a="181687772" Received: from xiaoyaol-hp-g830.ccr.corp.intel.com (HELO [10.124.247.1]) ([10.124.247.1]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Jul 2025 22:32:51 -0700 Message-ID: <9b425918-1858-47d6-a1cd-1b44d5898ab4@intel.com> Date: Fri, 18 Jul 2025 13:32:48 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v15 12/21] KVM: x86/mmu: Consult guest_memfd when computing max_mapping_level To: Fuad Tabba , kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com References: <20250717162731.446579-1-tabba@google.com> <20250717162731.446579-13-tabba@google.com> Content-Language: en-US From: Xiaoyao Li In-Reply-To: <20250717162731.446579-13-tabba@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: j4mnkehop35tybsan9mjjwspyt5gzcyr X-Rspam-User: X-Rspamd-Queue-Id: 85FCA80008 X-Rspamd-Server: rspam02 X-HE-Tag: 1752816788-312918 X-HE-Meta: U2FsdGVkX1854WxWx4/1ejEheFZCs+USYbvwo0i1eZDe3mbL4xDRPW1tvZWxb3lubhH7nRRBnlrh51JByuEY+Hw992iFT+Lj/VahVD18BcxHopsyoXJpICegVYN8dKBxl9eYb+BUkw2fHgMwPhwe7IXv91evsrWsuzM2HKFhlKa1UluyobwNXCYm8xEblHF0/pISIc5g1GWqYYknaCPMohgdorzcr1I+XFRATkxxyLRaBSeBZOCUuRZjJ/WEG9LTOpTk/spVNe9UXdw/lpGcrDuIyyAQZ6OQx5wohaBnqJzLuW+475zycSxMuZSjbf3K/kR3YyxgiBn/k+9w41k2dASSE8JLyIpZN9kLnEQkioU3Grefj5h2mxGs3hsw1yorQ1nPjFIIeNQVQAU3y1u2vh1jB7l390xWbn4nRaGaZC/L4PP4/9GreOA1nLJH5c753GpDRsF1+tub+TBOzl1u3/YIzdP0xDm8KjakX36BDfy6tuzumeG+QxYNY8yeHO3jFW+MRQ40wNrTIWSjoKHqLvLBifOwvvDsEqZViTiHI99vlH5WzL0zqNPaPSfd9PSPTtGBMp/EIDdYmS7UgEhqv+mUb6bjMuCWP3UJKKrJZRTk7ES+lcf8uKcZdw5pC0lf1T2XeTujElceZ0iAwIbA4bsG4Ch2Qckq70XXfBGTVCThH6/BNRF73esoU3WZn1nvG6DrOHJOG9ds7aCE1HIsjZU1hCjuxNY446r+8XG4LkkygnEOdYlC/hsgwq/bbVN8NfRwa1D3fD9e83DBBn4w8dkjDWS7NLdOiY+SnyU8QbgmN2/eTrQaISFGokqp3i+eMo0k+X09CXVpnwop6xSaSH43b5DbYO/e0HbVmxyVzyoXpHlZQ05CNj8oYms84JPXioC3oXShPa6Y2OkIrZiRAP+Opt15aZ93Xg24ljRvRkfzgzf/MsLx2HFjbOjd1IXcK9Ej2b5hoLEByqtfn2A tLQ5+6yP msPw8TNT3rcCExRjfiZND8o7CISR270yo+CkbmbEBDLkZVURenQ687Rz6yQys2wSV6kTemp9KonUDyaVWI9iMoQVSlVHBuXc7wkM4qL8eLrVzF9XeXf1WtlowI2+hD5WsweyFJqAzNKdO2Kpr1xE+wu3ev6ppK6/3DC0pNNXnqKUgjtftfealKLNbIC9R7eZHi5PPIJHjgCSSEbjjFMEhrGNxmVskdaidpvVhMVYIEKMmmxsYLGfeZjJxc7muYBuE0BaWjQhCwfC6nSh++slJwgluhlz7bLEMi5nFcFDsr+ruaa8OBxG++sdBELWzRkHdSm9k1wU+GFkxpqCg5C4yFsHjTg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/18/2025 12:27 AM, Fuad Tabba wrote: > From: Ackerley Tng > > Modify kvm_mmu_max_mapping_level() to consult guest_memfd for memory > regions backed by it when computing the maximum mapping level, > especially during huge page recovery. IMHO, we need integrate the consultation of guest_memfd into __kvm_mmu_max_mapping_level, not kvm_mmu_max_mapping_level(). __kvm_mmu_max_mapping_level() (called by kvm_mmu_hugepage_adjust()) is the function KVM X86 uses to determine the final mapping level, fault->goal_level.