From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BDCEC369AB for ; Tue, 15 Apr 2025 10:18:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8671E280104; Tue, 15 Apr 2025 06:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7E70D2800E6; Tue, 15 Apr 2025 06:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EB37280104; Tue, 15 Apr 2025 06:18:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 31C782800E6 for ; Tue, 15 Apr 2025 06:18:24 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DDB7D8117B for ; Tue, 15 Apr 2025 10:18:23 +0000 (UTC) X-FDA: 83335878486.23.E3E8822 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf14.hostedemail.com (Postfix) with ESMTP id 814CE10000C for ; Tue, 15 Apr 2025 10:18:21 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="Fc/SvuTZ"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf14.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744712301; a=rsa-sha256; cv=none; b=NuVWs/nD++ojgPiKyv564nItZFfJi8EsmMsoZD79k2y7CNrh1Bktl4ZG6EbkAR6PzryCVm ADYiEbZSnUPmvu4NK7C1C3E2hzS7rmKhmitc3Y2b+MGzmpBeJFNMfTiEVAAuX2o4fockwk JCD08ZL7E2EjkPr+GxIKLxnjjhftEhA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744712301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3LVa0ZKJJaKrq0qfnKBbXJhH7QV71WBJP8iqEjBxH5w=; b=DSHkj9dnO4vEHxW3jYhmtXWW4gMe1pyRsGG5DZy/79vWRgDYmbgmbDihC96HFuYGHHLQp3 MSdB3qT76CzgB5Mw4Qo9KZAnXBR/WFtYFtxDQJhulsYc7S7tySIEzBFFru18Z11U8CeffM Z1YMd6zWS/JuPx1sQ/RctYYg3cFKVWY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="Fc/SvuTZ"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf14.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53F9EDPx013055; Tue, 15 Apr 2025 10:18:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=3LVa0Z KJJaKrq0qfnKBbXJhH7QV71WBJP8iqEjBxH5w=; b=Fc/SvuTZe0LfQWItM5a4dU Dc/eSB+iE3hUjHVmqNYg3QmJBOto4j/Y2PzMchhBbHWvzTq7IXy07l4n3joUlaId otR6Se1HUcm4IP6N7Xn7IRI2UQnH7HSR/n3yOPs/2Z2qCxQdw0X9q1z45QLQ+KvO o/7VrdfJxY4oMPLErJznyfaGcjONJyhSUG2HhH1/Y2ku9kzO+bw02uvTTW8TkKjc k5+cHmeeU43JWX2aEru8zacnKhxQBpNz3oKBeWIdSeLXkJDf/Gn0Z5/C8glDbXCo 3MpxX2zwyj1E9efNR+UVAdtBRecqcLLSVN49ggAv52f4Z/PLEmewU8w5uSi4H1Ug == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4610tpdn0q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Apr 2025 10:18:16 +0000 (GMT) Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 53FA5ws1028759; Tue, 15 Apr 2025 10:18:15 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4610tpdn0n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Apr 2025 10:18:15 +0000 (GMT) Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53F7qP67010438; Tue, 15 Apr 2025 10:18:15 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 4604qk2c6k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 15 Apr 2025 10:18:14 +0000 Received: from smtpav03.dal12v.mail.ibm.com (smtpav03.dal12v.mail.ibm.com [10.241.53.102]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53FAIEOG11010586 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 15 Apr 2025 10:18:14 GMT Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 811A858056; Tue, 15 Apr 2025 10:18:14 +0000 (GMT) Received: from smtpav03.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 61AE55803F; Tue, 15 Apr 2025 10:18:11 +0000 (GMT) Received: from [9.124.211.75] (unknown [9.124.211.75]) by smtpav03.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 15 Apr 2025 10:18:11 +0000 (GMT) Message-ID: <9b1c3acc-6d7e-46a2-9d47-b41933bd40ac@linux.ibm.com> Date: Tue, 15 Apr 2025 15:48:09 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: Restore default nr_hugepages value during cleanup in hugetlb_reparenting_test.sh To: Dev Jain , Anshuman Khandual , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan Cc: Ritesh Harjani , longman@redhat.com, Li Wang References: <20250410100748.2310-1-donettom@linux.ibm.com> <098f5acc-f367-4188-acbd-2c91c52d57f4@arm.com> <7aa6ff41-6ec4-4750-8a0f-f43fe2c1b549@arm.com> Content-Language: en-US From: Donet Tom In-Reply-To: <7aa6ff41-6ec4-4750-8a0f-f43fe2c1b549@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: dnJ19TPjEKJwIfsmbJk6c5-J9-NCLlq2 X-Proofpoint-ORIG-GUID: BkXQ_8l_ohRoPOTSZ9tmNvE3a4pqUq-Q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-15_04,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 clxscore=1015 mlxlogscore=823 adultscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 suspectscore=0 mlxscore=0 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504150070 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 814CE10000C X-Stat-Signature: amoqp37zp5yiaweaod7x9xdthse3585o X-Rspam-User: X-HE-Tag: 1744712301-285652 X-HE-Meta: U2FsdGVkX1/BHHmHg2cn4chawxMx2RgWFKg0ZzGRsUm5s5bpUCYQsRHqGgNvETDoDkIfUsuZTDz0nxcqBJAVeHn18BPaDTdi+tpVjcd/D/Sy6KX3v1pA3q2qIc2Old7c9Ngg3+c2nrqm2LnlgerUfvYTgoVuODmm+5Ie90IpUtmBd5hgiUUkq+Gyt3uctVPPXfU+gPc9mFR/odmEmMTVZCGVLugk0eaLOc1LKTd4HhEODIi7ArMof7ODACR8YTydOYwSloifU3gzQCyGhlBzXrEL7GL84XZUlFxd8/BXzYinBUDjQZtiI/GtN0bHerkOWEX6/1Cx9/IzL3oTXq2Da+aXuCoP5Q4Higw7gUO9Wf+yH/iEvK44BP+ccZHBnZST5YUj7dmw0SyJ/soIFMTDTIKbxsZ+/T4MWbbAUrc5Fa4hf5/cOEVTbUDtYT8ngv5EFiHMDC+peQ923HiH4D0tkSVNkHeLE/EfIJwhcYlQg5heKiTU4tRv/7y5si8FP7LxRQHOXAnyptNhSVlJXZ4GVQ//J1NfEh7khEmuoiE1d/hfgC87S5lzAxfLTuUe+u2r9K/QXfQRaVz3ocUPYU2fOuOZWzHXdeI6ardxFTP1L13QiJKvV40BCQbsKQJaE3UcbaJsXPgxl195dQqiR154Oj10VYIOq+84AIuh3/0RCCpdcGHSyhmiMKxPHbvjT7ZsDhRxdjoXLu8d1t3GJSHPixVrL/Qn00+WtENoWGEJ2hF80Th5JUv6JpwtZ3FJCQZGN9d0VC0nBEmXeKKY5OUywF0so+9X8J3WeintXQssM1JmKy5ZwfL7m2rmURjCxoDi8h6djWN5JGgToTpez3rbEcGQDkzoFlYTPstStJSI4SwzDz4EftyDXcUyCMLl0IAU6cp54zsmL498ux72tKzuLuFzey/2gfJO7+oXR2/v8hiXdtITnJ7SkquqB66/L6YiX5gDAEF7668R2/PAu7C Yp8Rlhl5 O1xdxMM1o4w4/6HAvy94jjMIChJhj1sop+3USzQB9AAnrSLGqFGEuZ9yjy9PIMnZ1CynEtfDjdQxXRFQ/sISjzQ5PyXfQP+Rz23i6M5+8XPKW4lNFX+uqShg39DfluQjNNtPzm98Z3iIjpDw7zzgrybDH+T2Pw8hUmraOoYe96s1iC9cqDs2Q5uOmy8M72JoGcaVahDSbyj7TaoquhQfgAqyv6cGbGxOk9sLy3902/0DHsVA4uYRAuLNFZoD7qG/rx6LJPDOdVYQLcLqTb7a5u/Df4bEedGOSTWzvw1M9E2pw7ELAQjfRgqwJgDm1+vV5o0dk+pVRcr/Al7058X+o3dS2iILr6U2UocT9ZWyb8f31JcH/1Vlp7SlfFjmCzBVhz99/XtA+DJnHgtpNHwgKOmTIV/jguKsXWgMXiaoo2I55CfcQTIhvQ9yQTfVWBrGU5QTUBtAvNy+hTu9eMcrwkZzVHmGxT3QOoKwdmPMzqMfyB3jkiUecJBL1gQnRS3qJf4Y+UMYn47ZJ4XM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/15/25 1:00 PM, Dev Jain wrote: > > > On 15/04/25 12:28 pm, Anshuman Khandual wrote: >> >> >> On 4/10/25 15:37, Donet Tom wrote: >>> During cleanup, the value of /proc/sys/vm/nr_hugepages is currently >>> being set to 0. At the end of the test, if all tests pass, the >>> original nr_hugepages value is restored. However, if any test fails, >>> it remains set to 0. >>> >>> With this patch, we ensure that the original nr_hugepages value is >>> restored during cleanup, regardless of whether the test passes or >>> fails. >>> >>> Fixes: 29750f71a9b4 ("hugetlb_cgroup: add hugetlb_cgroup reservation >>> tests") >> Although this change makes sense as an improvement or a cleanup but >> not sure if this also deserves a Fixes: tag as well. > > IMHO it deserves a Fixes tag, the tests should always cleanly exit > without changing system state. It may or may not cause an actual > problem, so let's be proactive : ) > Yes, I was thinking the same. > >> >>> Signed-off-by: Donet Tom >>> --- >>>   tools/testing/selftests/mm/hugetlb_reparenting_test.sh | 2 +- >>>   1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> index 11f9bbe7dc22..114875a2b018 100755 >>> --- a/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> +++ b/tools/testing/selftests/mm/hugetlb_reparenting_test.sh >>> @@ -56,7 +56,7 @@ function cleanup() { >>>     rmdir "$CGROUP_ROOT"/a/b 2>/dev/null >>>     rmdir "$CGROUP_ROOT"/a 2>/dev/null >>>     rmdir "$CGROUP_ROOT"/test1 2>/dev/null >>> -  echo 0 >/proc/sys/vm/nr_hugepages >>> +  echo $nr_hugepgs >/proc/sys/vm/nr_hugepages >>>     set -e >>>   } >> > >