From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DC28C433EF for ; Thu, 5 May 2022 00:26:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D8306B0071; Wed, 4 May 2022 20:26:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 580D36B0073; Wed, 4 May 2022 20:26:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3FBA96B0074; Wed, 4 May 2022 20:26:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3329C6B0071 for ; Wed, 4 May 2022 20:26:01 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EE3012C41A for ; Thu, 5 May 2022 00:26:00 +0000 (UTC) X-FDA: 79429796880.06.0F741A4 Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by imf19.hostedemail.com (Postfix) with ESMTP id 27FE91A0090 for ; Thu, 5 May 2022 00:25:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651710359; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x+VFB+RbqDxtdPfXH5fs43HvbZapK8JlXZrJfass0jo=; b=HK6iq2kpLGHyiuw3wbjoNJxan7Sv0WFKRkfKvm8hSta3XWJx1H31/WvCVWDAWfoqt+vE9E nQP/zzXLdsnPg3Jyxh1Lxs2WPbOvO/kye4h43nYKr9jWHry6CCegtfnJqjw3h8IDatt35q E/WS/ZOdlQiQIaY1yMMvCC42tYJtGjY= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-vbUEOEffMFaws4s1wxMiiQ-1; Wed, 04 May 2022 20:25:58 -0400 X-MC-Unique: vbUEOEffMFaws4s1wxMiiQ-1 Received: by mail-qv1-f72.google.com with SMTP id ke27-20020a056214301b00b0045a82079370so2025657qvb.20 for ; Wed, 04 May 2022 17:25:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=x+VFB+RbqDxtdPfXH5fs43HvbZapK8JlXZrJfass0jo=; b=0zEBz7/4u4+9Z8qdo7l5nq1aq35/B6d30OHyeG7Ax25YtfN6eBGDWGKIuo/qtYj8XA KBstGS2esc9uxy3JmZ3psR/rOYbfpL1Rxdw33HJ1eYIwA7MEsiafxNNdYrHWVdHqmGC+ f8NmVwDj1oFIxcKz2mU2aVKt9L7b/vJBrMtFengpek4J0yX44AXwVn/qE0erzrgYvvXT 44M0s2ioGBOK3JcypXpVVqv3ZoOuFwA2u7KVEMH7QoC/Vp1eYxLJ7Bc8vcgGzmjcVfyR /YE6eoxjHSTuMQfbWPqdIYcJbZ5GBqqCRqP+SWrpDWBZymClKMDPdW3B5CRAr2Xk9wXx DzYA== X-Gm-Message-State: AOAM5319VLOGBDyM40hFXmT4MqglXZFm9gS3qdTKifWfQr5HDSKxw6mc FlR+Ly72V5DwEAPwS9+ZZ1lINxX9osxJoGr+OiXqAxzeXtJvKC14dc2CZb9OEKBafwo66/4KzJN uCk3IOfne9wg= X-Received: by 2002:a05:620a:45a5:b0:6a0:455:b829 with SMTP id bp37-20020a05620a45a500b006a00455b829mr7166829qkb.450.1651710358150; Wed, 04 May 2022 17:25:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDVIxSAgnbeoc2yDLtyhSKIPinnZELTTVOPCTW8YB9dKfNNvKXWcHNIVe6LME42AGiK4No6A== X-Received: by 2002:a05:620a:45a5:b0:6a0:455:b829 with SMTP id bp37-20020a05620a45a500b006a00455b829mr7166816qkb.450.1651710357920; Wed, 04 May 2022 17:25:57 -0700 (PDT) Received: from ?IPV6:2600:1700:5610:6e80::41? ([2600:1700:5610:6e80::41]) by smtp.gmail.com with ESMTPSA id n1-20020ac81e01000000b002f39b99f679sm18727qtl.19.2022.05.04.17.25.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 May 2022 17:25:57 -0700 (PDT) Message-ID: <9b00397e-f0fd-18c2-8268-c071257443cd@redhat.com> Date: Wed, 4 May 2022 20:25:56 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] selftests: vm: Makefile: rename TARGETS to VMTARGETS To: Joel Savitz , linux-kernel@vger.kernel.org Cc: Andrew Morton , Shuah Khan , Sandipan Das , Dave Hansen , linux-mm@kvack.org, linux-kselftest@vger.kernel.org References: <20220504214032.1283777-1-jsavitz@redhat.com> From: Nico Pache In-Reply-To: <20220504214032.1283777-1-jsavitz@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HK6iq2kp; spf=none (imf19.hostedemail.com: domain of npache@redhat.com has no SPF policy when checking 170.10.133.74) smtp.mailfrom=npache@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspam-User: X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 27FE91A0090 X-Stat-Signature: 5cezcgthmtywkuebastkxk6njmsfkatn X-HE-Tag: 1651710353-825910 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5/4/22 17:40, Joel Savitz wrote: > The tools/testing/selftests/vm/Makefile uses the variable TARGETS > internally to generate a list of platform-specific binary build targets > suffixed with _{32,64}. When building the selftests using its own > Makefile directly, such as via the following command run in a kernel > tree: > > # make -C tools/testing/selftests install TARGETS="vm" > > One receives an error such as the following: > > make: Entering directory '/root/linux/tools/testing/selftests' > make --no-builtin-rules ARCH=x86 -C ../../.. headers_install > make[1]: Entering directory '/root/linux' > INSTALL ./usr/include > make[1]: Leaving directory '/root/linux' > make[1]: Entering directory '/root/linux/tools/testing/selftests/vm' > make[1]: *** No rule to make target 'vm.c', needed by '/root/linux/tools/testing/selftests/vm/vm_64'. Stop. > make[1]: Leaving directory '/root/linux/tools/testing/selftests/vm' > make: *** [Makefile:175: all] Error 2 > make: Leaving directory '/root/linux/tools/testing/selftests' > > The TARGETS variable passed to tools/testing/selftests/Makefile collides > with the TARGETS used in tools/testing/selftests/vm/Makefile, so rename > the latter to VMTARGETS, eliminating the collision with no functional > change. > > Fixes: f21fda8f6453 ("selftests: vm: pkeys: fix multilib builds for > x86") > > Signed-off-by: Joel Savitz Acked-by: Nico Pache