From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3A8C4167B for ; Wed, 6 Dec 2023 20:35:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FE586B0095; Wed, 6 Dec 2023 15:35:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B8EB6B0093; Wed, 6 Dec 2023 15:35:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 828606B0095; Wed, 6 Dec 2023 15:35:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 71E1D6B0092 for ; Wed, 6 Dec 2023 15:35:39 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 43D27A0950 for ; Wed, 6 Dec 2023 20:35:39 +0000 (UTC) X-FDA: 81537549198.04.F699FB3 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by imf02.hostedemail.com (Postfix) with ESMTP id 501C280008 for ; Wed, 6 Dec 2023 20:35:36 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=aY3pPK1t; spf=pass (imf02.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.236.40 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1701894936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yf5A6/Q53LugxL4lu4tYjyI2OkN8idTKGkvO/tsL4bg=; b=kdFMY2l9UgVU/2St5yq7Op4bNLV41wpeqFblxoBHr5Ls19tB5p3vl3Z7pz9WQX0tZ7NQK9 nYj+qmECQtjvv14UNMkgY1fc4PsoqQH6w/nmEE3SK3JDJA2uzgruvMrPXTU6CuvdJd6RDg Jp+MJBlbOSayHzeg7TAsrd+g3hA5tUA= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1701894936; a=rsa-sha256; cv=pass; b=Mc94O0TcdIE3sUsF1OJHk+eYMCraEQbFjR5Te67On3Beo6oWt1PaJJuyX3xjStxBpYuZUS bXsBuuQRhFh6A7D058cfjpAmGrAhBzw5yuR6dmrvxa/mtTk38ED11B5k1CJKol654G0unw Huo+2kxOg/qeKsN3raam8EB9R6nMOko= ARC-Authentication-Results: i=2; imf02.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=aY3pPK1t; spf=pass (imf02.hostedemail.com: domain of Ashish.Kalra@amd.com designates 40.107.236.40 as permitted sender) smtp.mailfrom=Ashish.Kalra@amd.com; dmarc=pass (policy=quarantine) header.from=amd.com; arc=pass ("microsoft.com:s=arcselector9901:i=1") ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oTofi2Jj1mdRyQU7bRZbh5143R+wLEJ/nDfvZMPXHQP11DQR0vcvkC87RlZZcINyHcTkhAjxfvdz4JVBGClyW9nvwQhS4P3DkyLBK5r4XRIlpg7TR2xR6kLiT9t2Rwzr33powKv1QBSNCoOrv1qqq0Vm2RgJnV3WZahdchoX+tU60aQfbBmSciXBnRIJ+100lPUnC/9nM3pY0BM8Qd3xifJpXt5J0mwdPaPo2khnoCEi2fJzDFSSIbfOUYiv3MpIH7uPgnZg+9W1mZyd8KJVFLgIZWOqiQD1iNi1IPCA+6A5uEgrkRCl0/PGElLphXibq9h/sfnh32IHv22Aj2VZXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yf5A6/Q53LugxL4lu4tYjyI2OkN8idTKGkvO/tsL4bg=; b=LCNWyG9Jwdt46G1wMrbB0D7Me8AU4EeIz34bSwGgbUqrKH9nmx2F0pwZRyIYHA3yfOKxgASUAVVSpY8opfA1fd/GULz6axjGsEqQ0RCf0VcIVpvLN+8i25v8uq53tVU0qQEIKT5AYkoFMKzBPRTW8KHhQdnaorpl2xzfsFzIsWWKiONAjxp0KLpnwJwmEkt/3Dx4dAZiCx0aNSp6SKv/WuPdluZ2lXzU7SaNv56Qf+QbVL5l2960QWRijPF/RleXz4OnYVm8CmMt/lTwu+Fq/2lyl2fbR5XpuWTOMq2zHAR6s/TqhPQTgUeUgMjQIZgRTl1wzIvhuGY3/4q5Q/VwKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yf5A6/Q53LugxL4lu4tYjyI2OkN8idTKGkvO/tsL4bg=; b=aY3pPK1tg19SgjLi8YY0xxdZ9WbTV+E5Xj7tmg9NUElZEmgVxyytbkxB7Rqpw+o+XoK8P4RDLo/d05UrAia1Taq+/FmmRT6BTc6XwZXXYWkce8Hcp8bSGUR/ZlvklYGN3KT5CrcxOaOKhapqfV6xkhYATioQBOq8k4IJN1ju+uA= Received: from SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) by PH0PR12MB7908.namprd12.prod.outlook.com (2603:10b6:510:28e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.34; Wed, 6 Dec 2023 20:35:32 +0000 Received: from SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::3341:faaf:5974:f152]) by SN6PR12MB2767.namprd12.prod.outlook.com ([fe80::3341:faaf:5974:f152%7]) with mapi id 15.20.7046.034; Wed, 6 Dec 2023 20:35:32 +0000 Message-ID: <9af9b10f-0ab6-1fe8-eaec-c9f98e14a203@amd.com> Date: Wed, 6 Dec 2023 14:35:28 -0600 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH v10 14/50] crypto: ccp: Add support to initialize the AMD-SP for SEV-SNP Content-Language: en-US To: Borislav Petkov Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh , Jarkko Sakkinen References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-15-michael.roth@amd.com> <20231127095937.GLZWRoiaqGlJMX54Xb@fat_crate.local> <20231206170807.GBZXCqd0z8uu2rlhpn@fat_crate.local> From: "Kalra, Ashish" In-Reply-To: <20231206170807.GBZXCqd0z8uu2rlhpn@fat_crate.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SA9P221CA0024.NAMP221.PROD.OUTLOOK.COM (2603:10b6:806:25::29) To SN6PR12MB2767.namprd12.prod.outlook.com (2603:10b6:805:75::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR12MB2767:EE_|PH0PR12MB7908:EE_ X-MS-Office365-Filtering-Correlation-Id: 758ae55f-f5b6-43cf-43cc-08dbf69ae438 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 666IGnSyk5vqfMUgq8LL2his7GkBHoGqlU3bamZhQFmN7R5r4FdQd6CvNqXhcwmR1/uPAWDogd3ACSu49XFGsNagrd4VX1cuzsi36rJwBck1+LZpAXkB1JkclfdkUTnNXBftaqywEVVT3xprML6n/b9X5F6FgWHOwh8osqrpXv1h6zBom93AUJYIUp6oRsgWA+LFFCcJ9vbRHpqDgbN2OoibXsrCJj1WyWwq6oJOULufiwhx04v1U8R2fIsStlm12iPW/MTtiMcDcMa7g7eiHI/WpzGiYao7mYK0s4P9mo5ULz/h9ni/07y2/gOHgEvjlWa2u0WiQzy4+X3sS9L6zLCGzKPnq2oAxVUJN5mKp7Vw9ML6lLCR+qUg0U4Yl2WA4a/WjNsyvgprda6KjJvM4hbpSZ94J5wZ1O/gi7/+FAnggas3ep1JhDj9GPa811N9CZKdlV2c4hO5103SLBZWfH1t1CCND6o6d2XiidsKWItPA2qrlu9yA6BoDKDiGFiySYFC+nUI1dtgeTf1XgVvRLsclGcuCVhATYMjlYrwdMi5n8SbnoTDwQxtodhcDbdkyQcU1EpSRDKskqRHaraNkPQia6zmqax7O7KMkFNB2NKURpJvfiUjq1QBCNxxSzrKaRhfHoVlVmiweeSKcheLOw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2767.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(366004)(39860400002)(346002)(376002)(230922051799003)(451199024)(1800799012)(186009)(64100799003)(41300700001)(36756003)(7406005)(7416002)(5660300002)(86362001)(2906002)(26005)(2616005)(6512007)(83380400001)(478600001)(53546011)(6506007)(6666004)(6486002)(38100700002)(31686004)(8676002)(8936002)(6916009)(316002)(54906003)(31696002)(4326008)(66556008)(66946007)(66476007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SXMzSTZvYm5iZ0dHYnZkNmlUQmdvVE5nNy9nR2NKMXNmK05Va0dkVUxJRWJ2?= =?utf-8?B?K0NkYUV0T1VKRWZOWnE5QnFDbjhlcDZNWmw2cjZxU2hKVmdla3FuNk9SWXNv?= =?utf-8?B?VGtDQlRmbEZGNGFuR2tVanhHMzBmQ3NyQnZRUGd0Mkh2Q2VhNHdSYXJNQlo5?= =?utf-8?B?bmNvanJnR2VjeXlobmN2UGNLUDBlOTdQbzk5MFRnMFEzTjNiaXhRcG01N2RM?= =?utf-8?B?NEJsMTJZYTdJOTE1Mk8xMS9kcGlMdHJRUUlrU0xsR29tbEgrQzlwcGpOaGE0?= =?utf-8?B?TlBveDlLMTFPajFiSTl5Z1l3RlFEQ1VqR0t3M21adUMzeGRTMVNmSVZ4d3dy?= =?utf-8?B?VG9pdWVEelZhTXo0RDdjQnJ3S2ErY2lGSW1HU0tXa0tKUyt4cUxLK3NETkQx?= =?utf-8?B?UkZZMHRmZVV5VnJvOFo1UW1Qb0NZbUxQZG5Uc0JhQXFHUmtvTkJ6LzRoTkh5?= =?utf-8?B?NXlyU2FsaVlhMFc3akt1a3BhOW5DbktqKzl1QnFLMDBFUFVwSjFFMVVpR24x?= =?utf-8?B?ei9zL0pPb1QwUmFpeUwzSXdBZlBBQU5pT3crWU1LQld1c3JGam5pOGpXWlF3?= =?utf-8?B?bWkxUi9iUVlzRFBzdVZ3THQ3Wm4rWnhLNHN6dmluKzdHWlhaUjhIeTZlSGJo?= =?utf-8?B?V25CRWpaNTNna3dTL3g0UlZseXE4QVhsWjlKeVpvN2FJenJzM3pmT0xlTDBm?= =?utf-8?B?ZktXOXNVNnFUMmN5QlJadnJBeDNlYnpsaHhKdm5wWE90ZkpiMlorZWtXQ1JR?= =?utf-8?B?d1hiUy9NYy9LbmdtL0tXUHg2ekZiNUloS1ZNWldUUXE0MFpvbFlLcjdqOU1j?= =?utf-8?B?SUNvelRicytXTTlNRUYyNUJ6dm9RKy9Sb1pRSFUrc3N3anpNRHc1Z2tMcmdR?= =?utf-8?B?WGU4TlZmc1lhSjRsZnkrS1o5RXZXRmE5SEVRR2c1K3dXZU93cUx6RUpxRFhL?= =?utf-8?B?d1Q1VEhwbFpNMFN2bnBZdE5pUUpSeDRabzRicWNTNE80cTJLM2JYbE5VMmxl?= =?utf-8?B?MFZxTG9zd0VHVHltYVV5WXdDZktTWHVVRG16c2tNdHNISjA5KytYc0RnUllX?= =?utf-8?B?dms1bjArR1lQaDRqaWdiWEZieHltRlJMbEpSNUN5aFlEUmhHQStFd1V2M1BZ?= =?utf-8?B?RXpLdnBYZTl1dVRxYWd2WFdJclN1OXlOcTFXWGh5WC9ERTdGZFl3SmZtbGFz?= =?utf-8?B?OHp0Yk4wK29nMWNOdGhscUV1MW9yWlZETzBqUGF4NGp1dXljUGxIRThhNGVQ?= =?utf-8?B?ckNSVno4TmR3M09VaEJWclcvT05EQk5OdHlhSFZTbXVjVmNZWFlURTQ5dXhQ?= =?utf-8?B?UjdjUXp4cXZuellDa1hSaXZIMzllRXRwejZJT3ZCd3BTN0kxU0ZmZ0E2RUdN?= =?utf-8?B?YTN6dDFnais2ODNMNWRTeSt5aWZveWJIT1dsOWdNY1pCTXd1dTQwODBpeXB2?= =?utf-8?B?bHg2Wkd2SVFUYllRdHhrMnZnWXd3eVZiMFNocnpFTjJjdkZ6M1hJSk0wZUIy?= =?utf-8?B?MTdZbk05b0FZOXpnYnR0NlFYMDM3TGZBanhYRE1sYUF1THVSYThWb3p5UitN?= =?utf-8?B?dmFvMzZmaTdkK3RKZ1VaM3pONVJZZmRVVlVQZlhySjROU05EUU56QW5aa3hj?= =?utf-8?B?czVUZi9OemJneHhWaWM0SnkvQTNsc2M1Tyt1ZDFUeW9zbU9VNWNEa3lHS1ll?= =?utf-8?B?UERudE1mOTNHVEpJS1VURUpKNGdGdFRXWkN4WWEzMC82T2RFdlRSTUIydnRR?= =?utf-8?B?a2ZQRXdNQ1hOV0ZZZ3hzNitadmVCUHNnQkdJWTNiVDhNTmhVL0l1eVFTY0cr?= =?utf-8?B?dkF2OFU5RU15RTB2QTgvMFpKandzRnpuV2hhUEFCL2dvZ0RHcWE4YVVhQ1RV?= =?utf-8?B?MUVuYlhNa2UxbkJGRHpXZDBxUjhSaDk0OEpyZElVN0VDdFNEOTBEZVRHVTNu?= =?utf-8?B?VE0yVEpaYWxSTE9FUUlVdE5LelIyaUg5d2Z1SXFxNG1FUkNnbjJ5NEYwdXJr?= =?utf-8?B?YkM3TWlYeEhRckhESEZWV2ZVMWJmWFpSaWtYL3AxNE1Ka2xGZHp2V3V5SjV3?= =?utf-8?B?TlFyUE4xOTJZRXVLcmtoU1JrNWhNSTNpQ2hDUGRrZFR0VUd4ODVKUlVEd3pa?= =?utf-8?Q?RZrg+6YpoH2S1drzKYe2uRcSS?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 758ae55f-f5b6-43cf-43cc-08dbf69ae438 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2767.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Dec 2023 20:35:31.9005 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nq44Zt4tZmxh+PibsdgkI8ZIVKzkMd1OVk81LX+fe26rfqzn63pn8fzcyhwUtKtYSrjsqkj1rKWXVgMVTcuT1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7908 X-Rspamd-Queue-Id: 501C280008 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 7p6qag4f73shwnnwdbojb8mi5pxed6x3 X-HE-Tag: 1701894936-497986 X-HE-Meta: U2FsdGVkX18PYUM/RgFZjjeAFmQN2Kbhln0P84vxWbaBwX6+pXvYCCZq8jlb3R/dyCpktXS+SgCKjB0g67QPLXruoKp+TzxRq+4UoRfyUSUJ0NKIJyZTOuQIHnw+DhdnppW3xPYF/CGUTZVGogrtWVL0qrGYLJ/VUVVDrIvbVSwUlcpYlyNIbBd6sl05vmyI7MRHaYoc//5+fojfl5WL1aRpCqzb0+ALR98/hX9SGed7i0htBZNgq5Zf+2FZuCA5YS40NGNveKZfswwd54i5lZ4KfL5XTVVavTQK6vv0P+taMdNhIx8ho4Ifd7yjgs/vCmMIp0WIzs2blQ37G4G+iQQEb5CMZd3lo0/frHP7bIbJ+7S0e066yeuMBiz7XlL5YJLpnJAavVqjCOpRN+LiBdIr+WNCR/Wv8Maeic83cuKoNUGX/vbjH3PTWjhLvh/rgnpLRRyVKVUIGmLEXCUq2vMyX/7ufXw1ctGrgDxcSwxinfzUTGgLpCR/wY13H6INLzmk+Jlng4aPnkscFp1vT1ORv49PQQdg8hxFNa5UVd4uUzpiUAZmKYYs0g+EgPud3e8XPfCmQJznR+yZdq+lZ/WLbMLz6c+zTy+AjzGSFlERTuEByAvqiFCGRPEav0fbq9DFnZwBiqT5ysxsLHw50MZluSPEObJqjWXt93MGIEtTLJymUDiMe7MfVyIs6PKxN1NeFqGkcUUQa2tJ0mzSItY5yLtI+jCo85whgvVNDTJu/MHbKsl8NGng2U0cBo1yOlMDJszq48vNhJaW8S07GRDBirKj/XL3fz1RVMPDsB7Cvqojie+0vEzd/MomtBxIYDZ1C6ATr7ibk1sS4+hciInW6Ajiq7VF8jVR8PGNXoiW8mY72oOZvfcaoOKN2vcf36mOE8zad04TmhYrIAsQJ8sVP5mvVBk9kbIDh7Bsw70hO7aBYU+n0KjsCnuRpKB8vnxWrRmp8nT7TgDARxj 9Cgtzpyc k7LI+nQbAbUGBHuyGq8bYBNpSbeAW+Z+RaV/ypwqNLRE7wgRkk4rsiOPuxnjkFaSv0kVE4F25FlMego3O1NVQbdJfW/af4ZDzhklieGPls2DKPKZUU8RZ7M9FBRpR7AD1Xlzg7hMqkql/ZP0lBGcHDVE0/WKDR5i3qkrI+WKVqfsvD2MWuLTeLF6fVfRValmf5QSeXLMACF4YYPc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Boris, On 12/6/2023 11:08 AM, Borislav Petkov wrote: > On Wed, Nov 29, 2023 at 08:13:52PM -0600, Kalra, Ashish wrote: >> It surely seems hard to follow up, so i am anyway going to clean it up by: >> >> Adding the "probe" parameter to sev_platform_init() where the parameter >> being true indicates that we only want to do SNP initialization on probe, >> the same parameter will get passed on to >> __sev_platform_init_locked(). > > That's exactly what you should *not* do - the probe parameter controls > whether > > if (psp_init_on_probe) > __sev_platform_init_locked(error); > > and so on should get executed or not. > Not actually. The main use case for the probe parameter is to control if we want to do legacy SEV/SEV-ES INIT during probe. There is a usage case where we want to delay legacy SEV INIT till an actual SEV/SEV-ES guest is being launched. So essentially the probe parameter controls if we want to execute __sev_do_init_locked() or not. We always want to do SNP INIT at probe time. Thanks, Ashish