From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4827AC021B3 for ; Fri, 21 Feb 2025 19:37:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8AD8428000A; Fri, 21 Feb 2025 14:37:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85D41280004; Fri, 21 Feb 2025 14:37:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74C2928000A; Fri, 21 Feb 2025 14:37:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 58FF9280004 for ; Fri, 21 Feb 2025 14:37:09 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id CE4CB120292 for ; Fri, 21 Feb 2025 19:37:08 +0000 (UTC) X-FDA: 83144960136.27.E35A1F3 Received: from sipsolutions.net (s3.sipsolutions.net [168.119.38.16]) by imf19.hostedemail.com (Postfix) with ESMTP id 07E9F1A000B for ; Fri, 21 Feb 2025 19:37:06 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=mqhySQt9; spf=pass (imf19.hostedemail.com: domain of johannes@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=johannes@sipsolutions.net; dmarc=pass (policy=none) header.from=sipsolutions.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740166627; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zDxTSXduPQXA4xHKPlyHXnfxQxWR7o6zkvl4FTCCsPY=; b=ZJg+WSwBtI0Qc9JLaT/nGmKxVjUb9eCSrfBf6liXvHvR2KlGF4rxLSrx0S+oCB2yyZ9PPy JPJxnY4WgAcrIEoKsqxHpjDPSWq0UPfFExaRV1rLAtyKcv6MXSwLsYtcADyClV0diMqV25 47vQ+PctBmJlFwKtbMBjTyfy4p6XrKk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740166627; a=rsa-sha256; cv=none; b=fH+LaQryZo+SsC3Co6bw7qyzvR4FcwtDd+jM8iTJTPmt4O+TB5Iyg3qtt9l/mZCY5XqNSg 0uR4eXbLxkNfaQIesMXAzkJMHYwzddt7Hx3M0mhPT6o9hvu1XBSoYwhRUMyLqiWCnaNJOH DCC2JJlFpqJZuHgTlF97YAffIxcNAqQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=sipsolutions.net header.s=mail header.b=mqhySQt9; spf=pass (imf19.hostedemail.com: domain of johannes@sipsolutions.net designates 168.119.38.16 as permitted sender) smtp.mailfrom=johannes@sipsolutions.net; dmarc=pass (policy=none) header.from=sipsolutions.net DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sipsolutions.net; s=mail; h=MIME-Version:Content-Transfer-Encoding: Content-Type:References:In-Reply-To:Date:Cc:To:From:Subject:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-To: Resent-Cc:Resent-Message-ID; bh=zDxTSXduPQXA4xHKPlyHXnfxQxWR7o6zkvl4FTCCsPY=; t=1740166627; x=1741376227; b=mqhySQt9v+EiX6DWUVUYJNx8vTeGnqpWaUuFix+tjlT7iv6 6vCE43mFBisw2NLJFOvUIyvpaAe4P3rvKr2E5a5yUxE4dkBxNGbZm9ef1E37g+rhNutOboEjC/nXP +ooP+oY0EYZvYvevxg5fbM92/0aAKzVnSdHdMe7ejlP0wZSkLRoI76blJny3Ejl0VKLg6Hr5XPOjQ KiC2t4EklGJo2kccsq6kF6hIiWtgmEBmrYb1wEOuQyZYRZ2f/D+BqEDlvym1D1kZuX0I82ICO3cE1 asbTY7E87RhNjPiKLpFPtDZ+6DJwj380V6f7yCZYvtcldTFcmCqPQOElQ2l5Z1+w==; Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.98) (envelope-from ) id 1tlYp2-00000005Y57-49wJ; Fri, 21 Feb 2025 20:36:29 +0100 Message-ID: <9af9413b7ab41c6b2db5f862d0fa50e9de279d67.camel@sipsolutions.net> Subject: Re: [PATCH *-next 00/18] Remove weird and needless 'return' for void APIs From: Johannes Berg To: Stephen Hemminger , Zijun Hu Cc: Greg Kroah-Hartman , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Thomas Gleixner , Herbert Xu , "David S. Miller" , "Rafael J. Wysocki" , Danilo Krummrich , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jamal Hadi Salim , Cong Wang , Jiri Pirko , Jason Gunthorpe , Leon Romanovsky , Linus Walleij , Bartosz Golaszewski , Lee Jones , Thomas Graf , Christoph Hellwig , Marek Szyprowski , Robin Murphy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Zijun Hu , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-rdma@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org, iommu@lists.linux.dev, linux-mtd@lists.infradead.org Date: Fri, 21 Feb 2025 20:36:26 +0100 In-Reply-To: <20250221110042.2ec3c276@hermes.local> References: <20250221-rmv_return-v1-0-cc8dff275827@quicinc.com> <20250221110042.2ec3c276@hermes.local> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.3 (3.54.3-1.fc41) MIME-Version: 1.0 X-malware-bazaar: not-scanned X-Rspam-User: X-Rspamd-Queue-Id: 07E9F1A000B X-Rspamd-Server: rspam07 X-Stat-Signature: 8nnu6y1rrmsxc5no39qcj77rq7p1oc1r X-HE-Tag: 1740166626-440018 X-HE-Meta: U2FsdGVkX1+BxySHr9Mjecpyy37sXwHGIZk2BX6hIhi4c8UIhXv+ffsP6Y0KfO1fKgAoNOp6vTdSpDSrk0pmrTEGrrMUWbBHqM5PYqrT55omjLHMq9C4qFo0Qo/ByeSzVCOGs4sh0WtvMQ1Yw49Oa0sT0p08ndUwt8Ovyrutt1OUGmgWAaWIKVjPuNiI7CgziCCge2aorZ4v0KQcjbNR/1sSpdYm5uvWrCt4OuCLVUlSLzZjlZ5fhSGJ3zVPb/dDn7GrTVctbeO7cM7RvtnL/FiHDDJK/xYXA56M4i0mwO6OzCWOyAjz/ZRQDWN9tdx4FRHuXw57QKjR3xlQnQ06Kgcnnvz1fEzEhHFizi8k/Dqie3u17sDoQPfAcQVBAxtA1N6D6xDXInah/g2ym0ccg0/ucPIu03O168SZ6RgkNt6v58OqBm0cE7cIkfZ6tC5sSwbB/ctAMiI/9WIdRdSvj0mHlW11nLovcTaQ10FXsK+VFr9x/O09NmewtpTsxkdIiRxbi2FPLn9FH3+ITbM6j+n8Gp77QO8k7ZAgTqe7SeBg4dTGxIbTbIrCGIFBhQ1qAfokBUUuSoq1Ts1wds3F9NrY9Lqh9f/5AWF0dhIEQZ1DGbDRIwdzaQkLKtkcAL8DteZxwjdYHAEEoRBQ/hutglRlMGxlFeqzP5/APkDecAhpr9Jq1IGxFsbLncG+Sg/td1UxPyLxHd9/CyodbZbVlVVCwsXKbQrYjWiDyepJbTAtwG0j9aDLnLyFDkPZAZJ24S51hD0rVmiPpLvWQgW0k35D5xWzqfG4s+AEDNWp50f/Kp9V1nC/R+YUpUhK8YFoUMmE+dAEu1oHT+bwpG89yWjesG+86hY4M8JGeOLLZIFFELnUSZ1D8Q4OhGxaVUPOkKT0X67dzwOEfvTvY9jzbzilx1SLNOUTaM16RxtGGQMeS+DMfu6WbhhE/CnxEzQJaGBb8XXAunkBFVs2CQd al6GRKT8 pV0bMwVQfatYAaanmqsz4MSzoOd2nd5d+mmry2aSduKPqs/JS0bLO76hu7Hyf8hwAzrixe/vKhvKGCzDCxjjoLS7mrK4B5gpaqcRa8WI7e1u3Og7l460PrpPPCFP7ZqHhKoZo8Vb0VXbueIsvzFPObX/9B1Zdlzs8GfEbwmpVUU5oiPxGyOs6V7xJ9hPW+SKJSsCnM6RaYJ5YyTRcvEAvSQpgQmAVogl6UuNlIkQDwZnewj7gq1+OcDwl1LJRqGqtkeL7+iiB0odrtEPtFWP04M7OcHMFMrqtpksQNNJC1r52DhiKwnsSSXI2hw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-21 at 11:00 -0800, Stephen Hemminger wrote: >=20 > Is this something that could be done with a coccinelle script? >=20 Almost enough to do this: @@ identifier fn; expression E; @@ void fn(...) { ... -return E; } It takes a long time to run though, and does some wrong things as well: if the return is in the middle of the function, it still matches and removes it erroneously. johannes