From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AF7DC83038 for ; Tue, 1 Jul 2025 12:36:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 93A676B0088; Tue, 1 Jul 2025 08:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 912D76B00A6; Tue, 1 Jul 2025 08:36:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8006C6B00A9; Tue, 1 Jul 2025 08:36:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6F2EC6B0088 for ; Tue, 1 Jul 2025 08:36:27 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4817CC0400 for ; Tue, 1 Jul 2025 12:36:27 +0000 (UTC) X-FDA: 83615644014.15.C2C5A56 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf29.hostedemail.com (Postfix) with ESMTP id ACDDE12000E for ; Tue, 1 Jul 2025 12:36:24 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eOsvUrpJ; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751373384; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BWUS58/xuFehV84IBP/7jugiRMD3VIiL2+WOvgSmr/U=; b=7/9VEJr1Shh20T56SElklABcJ/A7jnmbOvJT5S/Opa6rwhniRN8Vw2us4NgLEiapYeZtvd b8SLfxZANu/lSC/IV1J6zqP9PA4/v1U+y0+YAqzKE3Z1C0ibjJw2pcNoJLk3T2YphN4zRv eBSIS/6qQL46NPGoUsgkeuvjxHo+1FM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=eOsvUrpJ; spf=pass (imf29.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751373384; a=rsa-sha256; cv=none; b=csnjrgirSuh/GaOvgnZ1jeVmer+1DJOx2ZynQSS6LvQ/tyx5/Ii5RVfBQvDbn/oazcUTU8 kdz+R9ilgQ9zaanL8sB2EwmXsUtg3Eorf6lUsa7DXqxNqagfrzTCC33yYWtCdKrFyYG7Ii hFI3usQQqOkObUUVvTcPdr/j1LAEBNg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1751373384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BWUS58/xuFehV84IBP/7jugiRMD3VIiL2+WOvgSmr/U=; b=eOsvUrpJ0LOALtwLN0WKD0VCHfgjZuKZDMRrr3VNyIeZz9lNb9PT1kY6KBkExBHb9PlTsS kxfvU9XEbT87u5GwdNoCuosF7MSLTuLeDFTfhfG6qDKBOKqghg5QasveGGUHEne5Ry6Tvo cE5NwaBY1GJ5AMXNXYv5L5qsufDvEcU= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-183-j-Wrdcf8M-Sk79vfUBC7eQ-1; Tue, 01 Jul 2025 08:36:22 -0400 X-MC-Unique: j-Wrdcf8M-Sk79vfUBC7eQ-1 X-Mimecast-MFC-AGG-ID: j-Wrdcf8M-Sk79vfUBC7eQ_1751373382 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3a6df0c67a6so2189843f8f.3 for ; Tue, 01 Jul 2025 05:36:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751373382; x=1751978182; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BWUS58/xuFehV84IBP/7jugiRMD3VIiL2+WOvgSmr/U=; b=mAUtU4cgbFciSHa+JxkdDFarpk558Hzg0Oh+V7KgQ8S3jVSeFuUZigauYwab2/9pCz etFCmI6vjw46emUJbp+ZVVDnI0Lo+jUlWLj+NR9tN+lo1J5w74G8aFDDJqus/dip4C0w 2WAqbK7YfLIRCU4lZX6RR10FlkTpXQrtdlOp0skifjKPkWoBYPQ+pPzurTPODlifUKGL Q5khfF2LcuXMOHGZehmIb/HOD5JkYqBrfNbhrb74b6NjokumVPGOqNWzHptSZ0D7Ov8q CyW3sRGy0b9WhvzOjEBkOk/M27tlX1WgAg84c011BuL46pz7Li5JzNq+xsjLs2N72+Va EaRw== X-Forwarded-Encrypted: i=1; AJvYcCWTWcDQAKgDqc5qRVBA6nBwUO+P7ywe1jcQt7o5XYAQs+ZlnZ+Vsj+HvDWoWENjNq1DXD9zoLCw5w==@kvack.org X-Gm-Message-State: AOJu0YwXzcDErGGL83kwRwc3r2PIGOdo5aJ/W/2RXt1Kb68RY2cmXxkM R7NH5ptOFY+3rpdkGXPMDXsbr7rq49uNtlowEzGwqKGQTHfR071LqG66boCgRMYNgeP6TQ9SPqj jYLsZ5J2852zkByBl4/IHdzl7/k/a2OF54mjOxO4HvvI35EIWwrWA X-Gm-Gg: ASbGncvLH8GfLT+oq8EWvLEOdg17O2D8pvgSPfeDx1IROlZHcmPSfZMZrohhIM/dYBy nsXWboBTZJckzligv6Y2IWM61MsMaA07t3TPHoM4tR+lPGal/6TA+QjAxhF915f9SJA4zjnaTlj iUQ2BBWh+snv9gAB1i3Dq/iYGhcxm/MSKqcLBLXFfDgGSGnwa1i7tCa47DwUb9VJPgU5GQfiR4R c762BLDUA3cnx+mwUwYL3oNiLxugyLRbWlNvBvgYYaHepX9iFTJ6Fc7dBkFyuWYkjevyYYrq6xy T5RCNbLZgtVhpOYd4ok0fQvR/FV/f+tLlC/II5AlslHkJiH0bSG9IOafXwK/9X/jk9Lxz1wGDuH hMnE5/eoLXzD4K6s1mh7Tg1QeupHwqCN2+yZ87/4nkKD848szig== X-Received: by 2002:adf:a21a:0:b0:3a5:88cf:479e with SMTP id ffacd0b85a97d-3a8fe79c8e3mr10444945f8f.48.1751373381319; Tue, 01 Jul 2025 05:36:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqIR1BDJyK8ZRp8F0lL2pM8FI7W8fcFCGvncPeyeTD2kfxRgbkByPh+KE/B8iSSRVeA4M/aQ== X-Received: by 2002:adf:a21a:0:b0:3a5:88cf:479e with SMTP id ffacd0b85a97d-3a8fe79c8e3mr10444867f8f.48.1751373380689; Tue, 01 Jul 2025 05:36:20 -0700 (PDT) Received: from ?IPV6:2003:d8:2f18:7500:202e:b0f1:76d6:f9af? (p200300d82f187500202eb0f176d6f9af.dip0.t-ipconnect.de. [2003:d8:2f18:7500:202e:b0f1:76d6:f9af]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a87e947431sm13174236f8f.0.2025.07.01.05.36.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jul 2025 05:36:20 -0700 (PDT) Message-ID: <9af55241-8348-46a1-8f72-5ad7e61bcd84@redhat.com> Date: Tue, 1 Jul 2025 14:36:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 18/29] mm: remove __folio_test_movable() To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux.dev, linux-fsdevel@vger.kernel.org, Andrew Morton , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Jerrin Shaji George , Arnd Bergmann , Greg Kroah-Hartman , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Alexander Viro , Christian Brauner , Jan Kara , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , "Matthew Wilcox (Oracle)" , Minchan Kim , Sergey Senozhatsky , Brendan Jackman , Johannes Weiner , Jason Gunthorpe , John Hubbard , Peter Xu , Xu Xin , Chengming Zhou , Miaohe Lin , Naoya Horiguchi , Oscar Salvador , Rik van Riel , Harry Yoo , Qi Zheng , Shakeel Butt References: <20250630130011.330477-1-david@redhat.com> <20250630130011.330477-19-david@redhat.com> <6e067746-9d18-4d04-a60a-536d5fee6b87@lucifer.local> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <6e067746-9d18-4d04-a60a-536d5fee6b87@lucifer.local> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Xyu4qlT3Ta-fxvXFrPrX7kfe9OmfG7oOg7Io60yvBuY_1751373382 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: t4nmjhz3hmd9jjfkdudqsc4wad5k6yrr X-Rspamd-Queue-Id: ACDDE12000E X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751373384-135570 X-HE-Meta: U2FsdGVkX18990GAoLWcIfSQ425rNzHSX2T+xsMCDhmiuS0B7NLNbyHDIcebnPu4ERyOAh3APTd1HVsmb78i9GA49dxMDoVxwbIVunHq7fsmUPyqgtAP3iLKGwEFApfadHYjzNh3/DBiwe3rd/5NAhjSmF/OzF2zu4obJgHrsl0wD6M7mZE/KOY9bibSOGL2E9n9OyOWcYulrbQvxaIB6njtqNiHdN6UenPaqzGyQ1U6gZ1+5xgWFGTwzb99tyYYU7qPc2xiSlvHE5Si4yonK4hfuL4U7QFABi90s2QjTIRQfPhHATOoAyZMn2LVAMKcD4PfCLu+xhkzvJtoq6YwBgD7f6UV+/wFB2R0VuCNBAd4Lvm6RpMRSe7ali9lgUhyRNtwK90p5jOsyr0AD/HW4zF+UgOQc9WKz3BDPFuCn9+X5JldusUq+kvTRLZNYsKeyXU1lUuHT9KExB9A92LVcNvSfTssU6Ja4esjKM8bv3fBsh74TyIaS5hDJTip7cqDU8vWR1w0VqPFNnqvOpSOfN3KfKQLqMKCz2wMBVSHaBy/+jsAZ85LDiShAu2EqMQ/zoXGMq/lSjR0VTz22wFMautgYooCi6ISFkgEeOJzyI9vM0HpIqhRUQRAfrD4nc0aGe0151PYtuvzdzFdFm/6MM6C/z0UPWdNI+IZ/qqF30nPkRMnwizT2YWPuOJDn2GRy34QYih/Qc/5+8RCSZoCNCqJj5ZtS/ChwcbIwjDWynNdmY58kkxckr/Wot2/J4x9AeEpTv0BAUjum+LGkpeJRz+tBDllsTMR0H2KpGTPFHN/nbBEtCf1sbbyVYQg6H9KnyUtHGtNKhk8EwcJAOncd2mmsMjdY9KRSS5rK3ruMr9IB7XXufQO7dB4X5ld09+vQaMukYFY4lGGA0EBXEO4+cKyZyd+KU0A2wp4lW5PWCFmEQCwkwBJQ38AHgNlPGe7eOVHW7VAuI8MD9N/qO/ /bYZ1zo0 QBU8lsu72BxogcCWlgpp7h3yczm+euaojao/YGfrJqzVN/8EdeFEaB1wMVi3lTBx/GA4cv7xO8JcxwdE/01nkQi1SFD/9sPaAnWAQMTBcUrVUJ/jz1cQ1BsMXG6pB7501+L6CW0BEGKiBbs8SdTUyEME4h9xl6r6giPgEUJL2yUFMSADI0pSTDMlrWpW4nx129BCfUeduOPoaPGjvUx6LBoSxz0IVNpqXTE9LhmEeRS1xjbRM364oI+KdwKBcSP/nvVUuECTxcMBTCV/P72TXZqtM+KCbpN5ytRzAM9HU6f1qGWZdvNGFqG2mNsPatkuQiAgrGnYohpA4rm0qcO+sKDD3vebHeUcpJWxmQTBPP1RczW4Bejmn35PAuwQg3gCXc0hIOWKRTi7+1vi6Li4mh4ry/9E3TrsUPxI36bZL/yPK1vo+AEd0pIom3y7FECP4k+gBsz0A9R/bSvKDlC++EibqKOs6A/Qua7YTG+pWKfEA64UtNUgZNrkbpDqQzvutYMmgEjcguMLrwG82+0Mnzs9qg6T3sYryYP1J1eXQoiqI8cBDNSfm8Pnv8RrvG/K2rgWzdfdhxwd/NUoporC7Mr/EbeBuTU+Kl5VKhtU0crKSuYI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: >> --- >> include/linux/page-flags.h | 6 ------ >> mm/migrate.c | 43 ++++++++++++-------------------------- >> mm/vmscan.c | 6 ++++-- >> 3 files changed, 17 insertions(+), 38 deletions(-) >> >> diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h >> index c67163b73c5ec..4c27ebb689e3c 100644 >> --- a/include/linux/page-flags.h >> +++ b/include/linux/page-flags.h >> @@ -744,12 +744,6 @@ static __always_inline bool PageAnon(const struct page *page) >> return folio_test_anon(page_folio(page)); >> } >> >> -static __always_inline bool __folio_test_movable(const struct folio *folio) >> -{ >> - return ((unsigned long)folio->mapping & PAGE_MAPPING_FLAGS) == >> - PAGE_MAPPING_MOVABLE; >> -} >> - > > Woah, wait, does this mean we can remove PAGE_MAPPING_MOVABLE?? Jup :) > > Nice! > >> static __always_inline bool page_has_movable_ops(const struct page *page) >> { >> return ((unsigned long)page->mapping & PAGE_MAPPING_FLAGS) == >> diff --git a/mm/migrate.c b/mm/migrate.c >> index 587af35b7390d..15d3c1031530c 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -219,12 +219,7 @@ void putback_movable_pages(struct list_head *l) >> continue; >> } >> list_del(&folio->lru); >> - /* >> - * We isolated non-lru movable folio so here we can use >> - * __folio_test_movable because LRU folio's mapping cannot >> - * have PAGE_MAPPING_MOVABLE. >> - */ > > So hate these references to 'LRU' as in meaning 'pages that could be on the > LRU'. Yeah, it's a historical thing. But for anything we isolated, it had to be an LRU folio (PageLRU) because that's how we were even able to isolate it ... from the LRU. [...] >> diff --git a/mm/vmscan.c b/mm/vmscan.c >> index 098bcc821fc74..103dfc729a823 100644 >> --- a/mm/vmscan.c >> +++ b/mm/vmscan.c >> @@ -1658,9 +1658,11 @@ unsigned int reclaim_clean_pages_from_list(struct zone *zone, >> unsigned int noreclaim_flag; >> >> list_for_each_entry_safe(folio, next, folio_list, lru) { >> + /* TODO: these pages should not even appear in this list. */ >> + if (page_has_movable_ops(&folio->page)) > > VM_WARN_ON_ONCE()? Well, no, it can currently still happen. But really, movable_ops pages are not folios that could ever be reclaimed that way. So the TODO highlights that movable_ops pages should never even be put in a list (page->lru will go away). -- Cheers, David / dhildenb