From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31EEDC433FE for ; Mon, 28 Nov 2022 17:01:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEFA56B0075; Mon, 28 Nov 2022 12:01:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9F636B0074; Mon, 28 Nov 2022 12:01:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 966E26B0075; Mon, 28 Nov 2022 12:01:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 87B456B0072 for ; Mon, 28 Nov 2022 12:01:02 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 4F5D61C6656 for ; Mon, 28 Nov 2022 17:01:02 +0000 (UTC) X-FDA: 80183465964.09.D87B0D5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id 0071880066 for ; Mon, 28 Nov 2022 17:00:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1669654854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=niIYnEoa6K6pf1uBHi1CqtcM+got95SLckIarkh2eow=; b=CDHOsm94HoOv1uFu4BADCLUQ0ZXaTtVCjndvl4GeGlhnMFnPv1CUj9MqUvUgiBr/y5aP2Q 26ZrH3wsGhYMnnID9lB7YG/gEgLH7RlDJ2dLFHK34vmwTODapIZmNYId8jxG0av4Ei5P+P ZL9/UKF4hRTEhkU8p06JLQhKPBWsqMY= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-394-u62VqqC-MI6pGTT6bfk7JQ-1; Mon, 28 Nov 2022 12:00:53 -0500 X-MC-Unique: u62VqqC-MI6pGTT6bfk7JQ-1 Received: by mail-wr1-f69.google.com with SMTP id l9-20020adfa389000000b00241f907e102so2146239wrb.8 for ; Mon, 28 Nov 2022 09:00:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=niIYnEoa6K6pf1uBHi1CqtcM+got95SLckIarkh2eow=; b=SjRPrwjLn7fkuRLXps2UP0kIXO7D2FFhs63fW909GmXZ3UAVTDoCmkqXQdbe+z1s1n rWefMYyeTZ3FtImERldMfu+J1y+SFVpZgZcmdV7Wlvdk4xN5ABlFgp/NZggvksazEjsa vgiIVYDIkuFjbdmjZ7TaE2CSxIOXr8xjDbbWaISnTIfGk03YDTzxW9et9xc7oKPyhNkt Eiccb6oL1Ndtkv/8g3YEWk4xrIDb+igDHUwWSbrEKK36FQIn74fp6qG3AknyqZmZtmTk OKHrPCpSiLEikIcn8KZV97oFN3PtHMr6UqIQXEe0cQsjGK4CWSopw2pRcdv0/TIvDuN6 Xziw== X-Gm-Message-State: ANoB5pngTIPCx4iOHyIJZ9vFoKcGRCsdR+eLHMDV7MQfkhQ66TN8cJz0 IbtfbG15xuNnphTua8dlbIPOXLRiYeeQIKId5fHMmXqVZbyhTOq/IZUePruzy/Z3tSnGWtRA7rx QxCi6/w/Mcl4= X-Received: by 2002:a5d:55c9:0:b0:242:1057:40b8 with SMTP id i9-20020a5d55c9000000b00242105740b8mr6057977wrw.182.1669654851583; Mon, 28 Nov 2022 09:00:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf5P6EXV8vknZ/VB0z9CvB+AAHtH91yCE36sEEDpxvAlBEOmBeNr9B+bXhdcWZP3VqcmuW4adQ== X-Received: by 2002:a5d:55c9:0:b0:242:1057:40b8 with SMTP id i9-20020a5d55c9000000b00242105740b8mr6057946wrw.182.1669654851304; Mon, 28 Nov 2022 09:00:51 -0800 (PST) Received: from ?IPV6:2003:cb:c702:9000:3d6:e434:f8b4:80cf? (p200300cbc702900003d6e434f8b480cf.dip0.t-ipconnect.de. [2003:cb:c702:9000:3d6:e434:f8b4:80cf]) by smtp.gmail.com with ESMTPSA id az26-20020a05600c601a00b003d01b84e9b2sm15850167wmb.27.2022.11.28.09.00.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Nov 2022 09:00:50 -0800 (PST) Message-ID: <9ae67ddb-d2b0-57bb-a181-d35a7af51c67@redhat.com> Date: Mon, 28 Nov 2022 18:00:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v3 2/3] mm/khugepaged: Fix GUP-fast interaction by sending IPI To: Jann Horn Cc: security@kernel.org, Andrew Morton , Yang Shi , Peter Xu , John Hubbard , linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20221125213714.4115729-1-jannh@google.com> <20221125213714.4115729-2-jannh@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669654855; a=rsa-sha256; cv=none; b=o9ApsuG5lhhanNTf9eQWdkSDQckxchW77p2vPGK/Yuaqk1OG220x9fP0Do3lqBwN9U8CrY j1wJ9Bfow3APHjitXGWSB3NGZSI2gd+8c6mFJ9qqrGd1tMErQunoj8Cq8rhUvgGh/098rZ nKwVjYAjz8/VfQdoax/WEOe9iAn6Ipc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDHOsm94; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669654855; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=niIYnEoa6K6pf1uBHi1CqtcM+got95SLckIarkh2eow=; b=EO4/V2Hu42oVJJLJTQfB7/SK8FvYqeJyVmbHfEmUpUlERK0TjJNJlVyPcel9/5cDcxtAO6 nYHL2VO6JwD79fDg/u9MQ+d8OiLF7bBUCG3wAMX9LDKhzQdS+8ouPxkuTjuyHN7HsXt3NH niJCahyJfPf4+YVxgAuvDYOPr+rLkMI= X-Rspamd-Queue-Id: 0071880066 X-Rspam-User: Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=CDHOsm94; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf02.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam09 X-Stat-Signature: kh7eruo3wyirq7hcmrjuawqqpb8n74kz X-HE-Tag: 1669654854-67686 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 28.11.22 17:58, Jann Horn wrote: > On Mon, Nov 28, 2022 at 2:46 PM David Hildenbrand wrote: >> On 25.11.22 22:37, Jann Horn wrote: >>> Since commit 70cbc3cc78a99 ("mm: gup: fix the fast GUP race against THP >>> collapse"), the lockless_pages_from_mm() fastpath rechecks the pmd_t to >>> ensure that the page table was not removed by khugepaged in between. >>> >>> However, lockless_pages_from_mm() still requires that the page table is not >>> concurrently freed. >> >> That's an interesting point. For anon THPs, the page table won't get >> immediately freed, but instead will be deposited in the "pgtable list" >> stored alongside the THP. >> >> From there, it might get withdrawn (pgtable_trans_huge_withdraw()) and >> >> a) Reused as a page table when splitting the THP. That should be fine, >> no garbage in it, simply a page table again. > > Depends on the definition of "fine" - it will be a page table again, > but deposited page tables are not associated with a specific address, > so it might be reused at a different address. If GUP-fast on address A > races with a page table from address A being deposited and reused at > address B, and then GUP-fast returns something from address B, that's > not exactly great either. The "PMD changed" check should catch that. We only care about not dereferencing something that's garbage and not a page/folio if I remember the previous discussions on that correctly. Anyhow, feel free to add my Acked-by: David Hildenbrand -- Thanks, David / dhildenb