linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Harry Yoo <harry.yoo@oracle.com>, kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org
Subject: Re: [vbabka-slab:slab/for-7.0/obj_metadata 9/10] Warning: mm/slub.c:7013 function parameter 'objp' not described in 'ksize'
Date: Wed, 14 Jan 2026 10:48:01 +0100	[thread overview]
Message-ID: <9adb16d4-ca80-45b2-8026-135cbf0f00e5@suse.cz> (raw)
In-Reply-To: <aWbxLWF0R5rIvRb5@hyeyoo>

On 1/14/26 02:28, Harry Yoo wrote:
> On Wed, Jan 14, 2026 at 07:00:18AM +0800, kernel test robot wrote:
>> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vbabka/slab.git
>> head:   a4e5702b7bb846cf50d2917cadf2289c25720812
>> commit: 1e8eb4117f27366855b192104098330a2f290f26 [9/10] mm/slab: move [__]ksize and slab_ksize() to mm/slub.c
>> config: x86_64-rhel-9.4-bpf (https://download.01.org/0day-ci/archive/20260114/202601140605.GNpnpgLF-lkp@intel.com/config
>> compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260114/202601140605.GNpnpgLF-lkp@intel.com/reproduce
>> 
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202601140605.GNpnpgLF-lkp@intel.com/
>> 
>> All warnings (new ones prefixed by >>):
>> 
>> >> Warning: mm/slub.c:7013 function parameter 'objp' not described in 'ksize'
>> >> Warning: mm/slub.c:7013 function parameter 'objp' not described in 'ksize'
> 
> We moved the comment from __ksize() to ksize(),
> but didn't rename @object to @objp.

Haha actually I moved... sorry.

> Could you please fix it locally, Vlastimil?

Done, thanks!

> 
> diff --git a/mm/slub.c b/mm/slub.c
> index d3aa805f3e05..373ee58b8b9e 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -7070,7 +7070,7 @@ static size_t __ksize(const void *object)
> 
>  /**
>   * ksize -- Report full size of underlying allocation
> - * @object: pointer to the object
> + * @objp: pointer to the object
>   *
>   * This should only be used internally to query the true size of allocations.
>   * It is not meant to be a way to discover the usable size of an allocation
> @@ -7078,7 +7078,7 @@ static size_t __ksize(const void *object)
>   * the originally requested allocation size may trigger KASAN, UBSAN_BOUNDS,
>   * and/or FORTIFY_SOURCE.
>   *
> - * Return: size of the actual memory used by @object in bytes
> + * Return: size of the actual memory used by @objp in bytes
>   */
>  size_t ksize(const void *objp)
>  {
> 



      reply	other threads:[~2026-01-14  9:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-13 23:00 kernel test robot
2026-01-14  1:28 ` Harry Yoo
2026-01-14  9:48   ` Vlastimil Babka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9adb16d4-ca80-45b2-8026-135cbf0f00e5@suse.cz \
    --to=vbabka@suse.cz \
    --cc=harry.yoo@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox