From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52FE8C678D5 for ; Wed, 8 Mar 2023 10:58:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F8D76B0072; Wed, 8 Mar 2023 05:58:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A95A6B0074; Wed, 8 Mar 2023 05:58:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 770786B0075; Wed, 8 Mar 2023 05:58:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 662536B0072 for ; Wed, 8 Mar 2023 05:58:53 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 28F011603DA for ; Wed, 8 Mar 2023 10:58:53 +0000 (UTC) X-FDA: 80545433346.16.84C78E7 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf13.hostedemail.com (Postfix) with ESMTP id 3CCAA20009 for ; Wed, 8 Mar 2023 10:58:49 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d8LpWLDx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nZkEe64m; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678273130; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LCAfw6gZ22BA3KCRgOa8h5RexNoS/fKKCQLrt+0R00c=; b=Ft2rm5Tbl0aOQTd/NQB/XbobZoapbMZkRkyEZnJnHGRtPeI720WIE3OZhGndZNjIdzYO/L igL6YvuK0B8MtTy92cJQn0FJx4CY60mS1j7hePhondfxu7gK5ZbiW4XvvbF/QkmKRKMAOQ QdvXNpmdL+wxFFVfBRdEWLs/TZfBWv0= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=d8LpWLDx; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=nZkEe64m; spf=pass (imf13.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678273130; a=rsa-sha256; cv=none; b=190Veweyg5oX3fBfoClRpaFTFETdY2ZnQq3yQ4VD+CYtScLtnRpMhJ3wEAPtop9mE/XcNh HaPyM3rGwoi5YRGIOQ387n1zmjeaQqhKfNQmPeJW0Qi6r5Qcnust6xNt1FeuPfWVlxocCx 6EDntnCLKEe76Jj0jkQDPfpvRfgB958= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DEBFC1FE3D; Wed, 8 Mar 2023 10:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1678273128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LCAfw6gZ22BA3KCRgOa8h5RexNoS/fKKCQLrt+0R00c=; b=d8LpWLDxMvAE42tUD5tt3BxLqadEeewL3CK1u5qY1fz7pCs+DdaHLMcbT4SKWNWi5IMqpw uMKSJ+O63xUj23/VHsGHSj+NGRIgaUeq2TWJfHZnlD3ondKQwRXAMfx3z6rRw9H+wxBIMc NJo/UL3PrgXUdp4RRKjg7sBAftecnYE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1678273128; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LCAfw6gZ22BA3KCRgOa8h5RexNoS/fKKCQLrt+0R00c=; b=nZkEe64msf7Ncek7aYtUlKTfM3Nk5KTip3ddKJBrHqmlodyDIwpU5d7F8KKU2oevYwEj12 3+bk564SEhgdzbDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B4B191348D; Wed, 8 Mar 2023 10:58:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NDPuKmhqCGQQbwAAMHmgww (envelope-from ); Wed, 08 Mar 2023 10:58:48 +0000 Message-ID: <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> Date: Wed, 8 Mar 2023 11:59:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate() Content-Language: en-US To: "Liam R. Howlett" , Danilo Krummrich , linux-mm@kvack.org, linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org References: <20230302011035.4928-1-dakr@redhat.com> <20230302015242.xi3y53okc4skmonn@revolver> Cc: Christoph Hellwig From: Vlastimil Babka In-Reply-To: <20230302015242.xi3y53okc4skmonn@revolver> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: htpja71kp33w83d6oe3uqrakjokh4ydk X-Rspam-User: X-Rspamd-Queue-Id: 3CCAA20009 X-Rspamd-Server: rspam06 X-HE-Tag: 1678273129-871388 X-HE-Meta: U2FsdGVkX1+xxEjyyOyytBEYdBlPLnIZP8Se/ikHSN1sjSSMk6iRJFqD4+ZsrsoVj4P06Kg5g/ou7yKxTgfwZ0YVALYFBrkoxNXSiLVfx6Ni3zlLDk5uKIbqu7RSxg5xSO8a2jZ2vOpXnrNBCxdJvV6cZpuNGEM7Q2KPaa/9pG7VMI3dMaDP8eBUjCS3szYyBKTUkjFXmFLPSuhQyiqoKAbCgK9oD21P0XtS378q3Aa0ZAUYyPb2JhVSBqBN4FN+CCcLNBb9uGowNQf2BaueGwK7FxeWHmBqFNfa9IkgeL0c4GXBvAShg3pRfZ3VUjSdCAS2R8YESt995MNGkfbQFp4MdD38d1rLOf6x8P9+XQJv1TyAxKzVT8LjP684JJQb2CUqPVkJt2PBv8FPRMtXZH7+Zdgdnbm48M6eBT5TSiGFUGT1rEjuanIZDS2bU1Pp49wZUMMt+dm+6zZgpH55Zimr9Hci5XJKKjI7cs3qMJL3kc0dCRQ/D/N+cZG+3gIny+Au/a5SRpHnELaXnDabvAPe5L7Hqs+1EgXHRaFzFv/oOH1bdp4BxLx5kD/56+piPHRTsiHIFivURzU7pwQMlZoHOU+oQaUsuFPwge26PtkgDx3ZMFrb0hXOxz7F+A33ecJttVtM1Wq5ctBruhI+4NUBtp9lpYUvb63Mc/H+wcqcQkd03CXONRJLzLckk5Z1SRQIN6dHNrT5vUrLtuPMDeGQ5EhDF8q935WXIV9M2qbwBnJIMfGOcZ5yzqGkKpawn2nkKM96phVCh79ggzYu0oK4O9DII2sduf+Sy6gAjpPgnS8GI5xPP/nOgo37ujZ+6xujOrnddPBe/dw9/6+rxyurw4onVSyRwd/CEURLCI2Y20GjGsBtngtuTZOFp7ThnChrKgy60YL3uRcakvb/I3jF+G9V/VLwICtOT688az1BIJ4KC8v/Q3nui4FNQzsPD3ZtMJAj0EMcfPbezQv jH7YTGNz 0iJC5kD4eFrXplcXEKPookRhZ+SUpAOCPb5i7Z0orBNhWbUYr+4XvQIJ8pxDx4/vChOEjaNV7Z5EK3hBZwvJGQds1TEmgsShXrAGMZh3+l/HPbpyCRjPnJpVjXePR/07GHAJmWSpD2UP7PLFhZFtfgzdlrKoN5vPCIf5JG5SfvgSmKvd1q+9Az3NrZe9JpC3YMsb/+Jtx+FncU+gyaDnA92lVfnmu72tWN4bCmIQQIIlyA0082aWxnV11HAOvKIrP3Nth7++tyY3J6V/BMD8xK7s83qX2yBHjN1qo0EiX5PUNy2DCyp5ra5nFPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/2/23 02:52, Liam R. Howlett wrote: > Thanks for the patch. This should indeed be exported. > > Reviewed-by: Liam R. Howlett What uses it? Don't we export only things used by in-kernel modules? > * Danilo Krummrich [230301 20:10]: >> Fix missing EXPORT_SYMBOL_GPL() statement for mas_preallocate(). >> >> Signed-off-by: Danilo Krummrich >> --- >> lib/maple_tree.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/maple_tree.c b/lib/maple_tree.c >> index 26e2045d3cda..3bfb8a6f3f6d 100644 >> --- a/lib/maple_tree.c >> +++ b/lib/maple_tree.c >> @@ -5733,6 +5733,7 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp) >> mas_reset(mas); >> return ret; >> } >> +EXPORT_SYMBOL_GPL(mas_preallocate); >> >> /* >> * mas_destroy() - destroy a maple state. >> -- >> 2.39.2 >> >