From: Vlastimil Babka <vbabka@suse.cz>
To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
Danilo Krummrich <dakr@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
maple-tree@lists.infradead.org
Cc: Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] maple_tree: export symbol mas_preallocate()
Date: Wed, 8 Mar 2023 11:59:08 +0100 [thread overview]
Message-ID: <9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz> (raw)
In-Reply-To: <20230302015242.xi3y53okc4skmonn@revolver>
On 3/2/23 02:52, Liam R. Howlett wrote:
> Thanks for the patch. This should indeed be exported.
>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
What uses it? Don't we export only things used by in-kernel modules?
> * Danilo Krummrich <dakr@redhat.com> [230301 20:10]:
>> Fix missing EXPORT_SYMBOL_GPL() statement for mas_preallocate().
>>
>> Signed-off-by: Danilo Krummrich <dakr@redhat.com>
>> ---
>> lib/maple_tree.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
>> index 26e2045d3cda..3bfb8a6f3f6d 100644
>> --- a/lib/maple_tree.c
>> +++ b/lib/maple_tree.c
>> @@ -5733,6 +5733,7 @@ int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp)
>> mas_reset(mas);
>> return ret;
>> }
>> +EXPORT_SYMBOL_GPL(mas_preallocate);
>>
>> /*
>> * mas_destroy() - destroy a maple state.
>> --
>> 2.39.2
>>
>
next prev parent reply other threads:[~2023-03-08 10:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 1:10 Danilo Krummrich
2023-03-02 1:52 ` Liam R. Howlett
2023-03-08 10:59 ` Vlastimil Babka [this message]
2023-03-08 14:34 ` Danilo Krummrich
2023-03-08 14:43 ` Christoph Hellwig
2023-03-08 15:18 ` Danilo Krummrich
2023-03-08 15:29 ` Christoph Hellwig
2023-03-08 17:43 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9abef101-3a9b-0bdd-7139-ced7d5e28ebe@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@Oracle.com \
--cc=dakr@redhat.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox