From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8744C61DA4 for ; Tue, 31 Jan 2023 01:12:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D79516B0074; Mon, 30 Jan 2023 20:12:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D29686B0075; Mon, 30 Jan 2023 20:12:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7B816B0078; Mon, 30 Jan 2023 20:12:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A62036B0074 for ; Mon, 30 Jan 2023 20:12:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 706041C606B for ; Tue, 31 Jan 2023 01:12:13 +0000 (UTC) X-FDA: 80413318146.02.013B45D Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by imf13.hostedemail.com (Postfix) with ESMTP id F227F20012 for ; Tue, 31 Jan 2023 01:12:09 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hpQJO5vg; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf13.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675127530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hseK4SQYbQxcvZvWT8eN3JOwpOBD7hMcufxQjX3fMUs=; b=mLJCKI/plKG2Cal3sAmPynL9qKlOXZwu4G3GIgXPB+Wghyww7+duyt317J/kSfQwbn0RQS p20RJPOc53RdGMbrFXizXXwpccKJ/g0SnUnKnqLG4v1i9P+euLLTX6CewKKC0dZ1eKEPpw 1uIGfXjmHAzLvWsSAzWcHQTP6CoceM8= ARC-Authentication-Results: i=2; imf13.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=hpQJO5vg; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); spf=pass (imf13.hostedemail.com: domain of fengwei.yin@intel.com designates 134.134.136.24 as permitted sender) smtp.mailfrom=fengwei.yin@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675127530; a=rsa-sha256; cv=fail; b=Pa1f4TXGgtTrWgEob3tFp804R97LaWt8HnhqbZefKvRzSzqx/QcTG+1D4LTjZP+j0IM6A5 QLeigm0VCBLE2cMSlvK7TeQQBPoyeIhsF4EBO/s+wd+7W3h8F7UAzAWx5enwYgguINUOV8 2syayRJfrJLzCUHX5NVMP/uMB8zLj08= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675127530; x=1706663530; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=T1MLUeTCfDM0NAqWwwaYHf7f4N5Vsl/bPKbtqheLk0g=; b=hpQJO5vgHBGwHUnMZMh+C11eRaaS3cY+hBsjMeh6KGd8w5fKpmCW4hBF pYLWkA5On5kxwO8m3E7E7nomzGHbFUuOjsPQDf/uKQaO7Y7VXavsVdoc4 SL30IlKRat6QsAA4xWmOctUtSRR2BJdbZ+QSAsI66pd8J3tnSINsUGOYn ghOYmT0wuDJEmmN0BRVBo7A/FWq53/3wUChM8wniR4H+ox6++3TzZQ3t7 CMeUdgAKrqZxQixWWB5LHDCmJYUYiRnL7MyHsvW3oJAYwSRqPcJsQcI38 eUSjQU4kvMsi2TTeTcPHF0CiSUhKVvWUS9ImtS2QopGcxrQlM7PyZ/tdj Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="328993444" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="328993444" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Jan 2023 17:12:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10606"; a="694773737" X-IronPort-AV: E=Sophos;i="5.97,259,1669104000"; d="scan'208";a="694773737" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga008.jf.intel.com with ESMTP; 30 Jan 2023 17:12:05 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 30 Jan 2023 17:12:05 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 30 Jan 2023 17:12:05 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 30 Jan 2023 17:12:05 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mJ81pVGWhquF4mocK/j83AgZQQ0O/wWZFjRkkcmjX33Xb+lDLfyLlH9vHApV6nooDBHvuNWIqYTgwI+SSjjznMvVhGuDP/znHd/DXJifVX9SMmMEeCw0ftUKkwURz8A4EnxfV5awkkQ3ICsuThSF0pXINRSJS+l41swikzW44pWXrxlgyBmjbgnoTK6xrSBiaH2wzWfhY9j5y4U0sdyIQm2cKXqulAw1hHC6TzOdUbDW7vCe+7zvNBsT75PpJ4GPZw9gmM4/9BEzL/BvYayn3sWasBFpxrdjOscSS9Dfy29Lk9Kl+Vyk841NCZu4AXyuxpGCho47J1xAOoAtfPkFpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hseK4SQYbQxcvZvWT8eN3JOwpOBD7hMcufxQjX3fMUs=; b=QuZWrCW2vXceo3vJ9nLpC8LogeBJy1tRowRLmnU20Fx0b+VObQXFV9PNQEh7E9/YvpHad63dNGrk5uM0iskLuXFRTqWmCW5X/WbJSi6sMQRVTKyajlbrtQCWxjGp4fc+Wm1GHm7w68GP4KWm0u68ozvw5cLRpzl1X6l4bRHI5ZsNMOX7cZT94eu0WL5HH2z8Z8XzxBomXYQLSWjk5I8WxlS7MtkLwhL+PO37hZMR9FPyfUd1ni1Qlutuh28JizFO84htzeDqwQvsjRcgrVdRApKj8jzB1OgxZNLlyxAevNTT84L4jOYcq/5DkiXFLhnlklYAf/O4XECChCfoHFY63A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) by CO1PR11MB4883.namprd11.prod.outlook.com (2603:10b6:303:9b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.38; Tue, 31 Jan 2023 01:12:03 +0000 Received: from SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::9771:dcdf:cdf8:17bf]) by SJ0PR11MB4831.namprd11.prod.outlook.com ([fe80::9771:dcdf:cdf8:17bf%9]) with mapi id 15.20.6043.036; Tue, 31 Jan 2023 01:12:03 +0000 Message-ID: <9aa5c3e5-1742-b739-08a3-fab609ec7be1@intel.com> Date: Tue, 31 Jan 2023 09:11:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.6.1 Subject: Re: [RFC PATCH 5/5] filemap: batched update mm counter,rmap when map file folio Content-Language: en-US To: Matthew Wilcox CC: , , , , References: <20230130125504.2509710-1-fengwei.yin@intel.com> <20230130125504.2509710-6-fengwei.yin@intel.com> From: "Yin, Fengwei" In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SG2PR01CA0159.apcprd01.prod.exchangelabs.com (2603:1096:4:28::15) To SJ0PR11MB4831.namprd11.prod.outlook.com (2603:10b6:a03:2d2::20) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB4831:EE_|CO1PR11MB4883:EE_ X-MS-Office365-Filtering-Correlation-Id: e39e10f8-258c-4e58-c8ba-08db0328294a X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G0rOLTW3+oHDaqDkRQiG7jBa3qGkgT3hbMNEtF1pTlBTna4UIBKfjjJSorESINSDyb5PJqBSMtxZ+UA7grau4cOK6pGcyCx2TJtiPgdNuzEZG+AcF690qlDKJLEAA36QBpjvEHXFLdty3KhrUtoSxJtsqPuukGXF21mW6Mak6oWyd6PvuFYCDM6L829M31SfzpkZG7VKWcfWpSX4BI27uvMJrANPooiEmO7SRB8oe4MqVOjp/YUZ+MYyTknp6tRoDaua6iDFwHKpgXZth01aVlzrZFe3iRMm+B5R3QMniV5yu52JBqmdCZ+XhDd5RhLDFyrdI2xsbgt1S+eTpC3iOiPKGUEmf29Bw/6Ms2bnOd9WW8DSDEg7xij72cRzTQD2xuEB7EisNmYRxDflJ7MaUH9i2ioTz7/+jjDopZ03bniZrrEMmTgYPwHIYzbTMxWi2yzYvCR4rp/dn9iBL8jheY3669Y6fbYQse/1l42QqFGTxGnB8G7j/QTP/DhfD6blgHWDxmr4IR383zG90GzbAdzp5PXJd/zqTq7JlQ5ddGpYGDRc13q/UtVT1M6e1V8nGikTFz3Kqfm1tlKChqDJu2uH9F98ADlyhFwICxw8kLptJpIPP5VQXiWQIj2GonLyqGwFBmv1tLjJGrfCDzATyakvj44mL1KVsItZJwSjniVXrks5kYVK9u4lhwBrHKEsPMikFFpGCgqae8rWHptuQZOmzypboNc9E04uIqBYT4g= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR11MB4831.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(376002)(39860400002)(136003)(346002)(396003)(451199018)(66476007)(6916009)(66556008)(6486002)(31686004)(66946007)(8936002)(4326008)(41300700001)(8676002)(478600001)(82960400001)(86362001)(316002)(2906002)(2616005)(31696002)(38100700002)(26005)(36756003)(6666004)(107886003)(5660300002)(53546011)(6506007)(6512007)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dzdFREppcDVYcFZMa2RMKzRlZ05HQ01uZTBnUVNCYjhreTVOM0xjaXoyNHFq?= =?utf-8?B?QW9mV042dmZMWk50cUFpZDZMYjA3MnVZbW9QbDhQZ0c3ZGY3eFRQVHIzYWdG?= =?utf-8?B?V2Z3MjlWQXBYYU43OFZaaTFZOWJPRkNFLzZpaUZoc2RQbmhUQjVsRXBEYmdK?= =?utf-8?B?QjgydXN2eVJBdXoxRVZTU0U0dWFGWGlGOHhVUkl6SDcyU2JmOUlINGUxcU5H?= =?utf-8?B?SFZuWjQ2aVczcVdyZW5wN0xnQ0xobTExUExodmlRODRkL1pRd1A0dFpYSlRQ?= =?utf-8?B?K0JzdnE3blRsNlJVUXhHWGtEaGpBbGFzZW92a2l3MTRiRnpMUFZRUTM3aStZ?= =?utf-8?B?anJSSFZRZGNpUEJBSnZOT3lpNTZueDdXZVpsL0hkNjlpdE5tOTRFTndWb2hB?= =?utf-8?B?WlFIK0lMYVZ5cFNOYmVwS3BqSGp6UUtTUEVYeHRuQTFhbndTejJoNTBBOHA1?= =?utf-8?B?cVdNNEt6NlVRODFDdzc1T1ZDWVpQbStQQVc5dzdzd21TM3YybzFhOXEycXpB?= =?utf-8?B?dWZWTzJydURRV1IrOEdoRytWMmpSbDZHMGFFTkZSQVljQmhqa2oxUlBaQldm?= =?utf-8?B?TFExUE1sOGdvQ3BJb21GRXIzYXgwbC9GNFplZnhwL0xxdGw0bHZaVXZ3dmJB?= =?utf-8?B?RXQ1RHVnVWRoSm1TOWJvQkZCeExWZlp3TjR5cis0MnZ6N3dWVGUrci9TUThl?= =?utf-8?B?STV0TXZDY3pHWjdUemJCWEdwanNSUFhuREc0R1o4NDFrK3g0Nm4rZ1N1VG95?= =?utf-8?B?UTZvSWg0QisrQ0ovbUp0dlRDZVYwazhFQkRmL2l0eFo0dkZyM29tSUpFQjRr?= =?utf-8?B?OGpSczRWaUZuMHJ5WXpMWk1wNzJCUkw0cXZMZWx5WGliR21VdUNZVmVLbkVK?= =?utf-8?B?U0ppY1drTTN2YU1IL2IrL0w4RkNSMEgvSGU0aEtLT1JQb2xIUzZ3Ry9wM2Ra?= =?utf-8?B?L3ptOUxlcnFDRzlyZGN0NXh1N2lZT3Z2Z0tONEtVWTRPa2o5UWVZaWFQL3Zj?= =?utf-8?B?RlBDM2J0SDRmVWFxMnJpKzEyRjJNK1J4Y2szY2lCOExXRUVvNWViRjdBRmRV?= =?utf-8?B?OStsYm1kNzNaL005eGRXM1RyWHNrZnU2ek1VaFJBVCtvWXpIWm0xTVQxQWpH?= =?utf-8?B?MmlYSU1XMXc3OWVuK0x2d3BVWkZpc1IvZi81Qk9ZYmNUcER0Nm9zZCtJVEVO?= =?utf-8?B?aU14NnQ5eDRFdTU1Nnl0eE50OTdIQXBuNXMwdFFjWHJNaVRLZjhYMThncStB?= =?utf-8?B?aGhLVUZicWVHR2N2MlUwYXlKRUt0WUNBM0g5UmE4SkVyb29RWG91cTQrNGg4?= =?utf-8?B?dWNSbzdGQ2xidEJJaUo2Z01nek1rZDVCbXBFVzZuMU5ZT0Jma0F0NFF2UTZk?= =?utf-8?B?Q1d5cVNpTnNKbkRGRHQvWTcrdmZ4cmlCRmNaMGJsMDlOZmR2VDRTN1B4aEU0?= =?utf-8?B?MTV1ekVsUUsyTTBnLzZhYnk5b0ZVVzB4dWxnSjYxN0lETG5FVG1DdElHUlA3?= =?utf-8?B?ZU1ZN0ovZE9McmViNnNlZnBhOHU5RldwVG1uWlJWNWdXbG1rTFVCQ0dnbjdz?= =?utf-8?B?R1U1OGIvZXZ2UlpaUmQyZnVWT2xGL1k3Y2tZemFEdWdUQUROdkhWVnR2STlH?= =?utf-8?B?bndwenJnOFBPTy8wb0RwMUlPZlhQTFNhOURycmJVdU91TVBWblNIbkFVTVBx?= =?utf-8?B?QVQxak9ud1NBaFpscjdVU2c1SnhTTmR3OGJvemhXWHhac2pxQmI2akZDRlJR?= =?utf-8?B?RUEzRHg3SXc1Wmovb0ozc1d5RkY3UHdZeThmSlRDaDBYZTBJSmZiUTh4bTVw?= =?utf-8?B?Tkd1ZjFjNTNqSnJrYnc3cDU5UVV4MitRbmlXUmt5K0hCMUtDanJ2ZnhFRjdy?= =?utf-8?B?VDRxakFwOXhXR2UrM2srdDRBL1ZWREg0K3B4aklzNXZLSitYWi9GUEh1R0tw?= =?utf-8?B?VWVHZWdZcXZJYXFrdklzeFYxYjhmTHI4ODI2R3BoS05rSTUrb1ZWVm1GTm1O?= =?utf-8?B?cG5SU3RMUHBJeGpZanNmN0c1SjNVTC94TnFnd2lNYTE0WXk2Yjc4SEFkUTY1?= =?utf-8?B?blg3ZXR4UThRT21XSHdINkFla3RISkpwdHdZV2FQTU5yajJ2cDZjazdqNFQ0?= =?utf-8?B?amIzVDliVUp1bXFYdmR4aC9TVk03azFGbDlZL3lFeFd1bnpRQnY0dDlxTmlm?= =?utf-8?B?U3c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: e39e10f8-258c-4e58-c8ba-08db0328294a X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4831.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Jan 2023 01:12:03.1132 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: iFCGM3DUKo/Mw5Q67ud8ANvQhZOBIdRFrZpgN5b6tZcryc7JPkRqvcfzhMqE2otJfhLTd+dfIUNDmD5flEf/mg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4883 X-OriginatorOrg: intel.com X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: e5uphth4oxmgnc5i1fi3eacgf73p6pdn X-Rspamd-Queue-Id: F227F20012 X-HE-Tag: 1675127529-857661 X-HE-Meta: U2FsdGVkX1/hB4JoQ5EQrmGt0Udgt9Y38tPE7hkP+lRZ/oxIQlzKmqG9I/EIoNCsUhF4rXMLvc1eJvUVzGnh4pD/duxXoV6yMdF8yr3tWY4cV9Se0BwadY/tLHaCjJQ81PumKp3CYV20tn7rm3Xc8f94tBDpd0DbySYmYu6+wjlWLDn736bF7cZIF9BgDdQfAJJyWGEo9RXTHVRNLIoP6OOg7t+5Jnk18dziuzzE0vJKr4xDVOaDKqI446p/8udR9BdrJXXmGcJsA3yzxVO2N929IC5uEVcskXhBlYIYkASuWKzablQ/XwcyoP/WIbANe/63QLv0Do+pMA7lwFsfEzfe3U9gQ5ZugxlRMExg64ETT45CbDRkaVYnCRlbkIQYZZ5fAkFvHKTJzEYGz5Tz7doznF2nmRX1cq/Si7yHLzjt5+LbjAoNBR+yJRQDa19NpU1R2vK8dZ1J8NXsu1mmr6ITDcJH6HMkLkIspST6zmIn7k6pF+NuScFigmFhngX2uIzpMNFrUnDgzTzGJHCTOsgIS9LRXFIdeToFS9xhfxPLlqXR1WUJhEpZTvFduBP3yP885CEPTGaDjyObQO1gi0wSidHMRuan841U/x5myuRXj/Vv3aw7MPhMboyjOk8V+VaBJxF8ymJBi47cf7rmgTTZuLHOiPgFsSUx1yn/leeERssxefXHKSCq9UgNILCpOSkgS7LK9xhr3yXx2gqBS2ExAAYa0UMkeMpQMrP/kokYAxG18iQKrHmgdVStRUxLuZBe6qM3BcEGgD7bnJmFM5yX3R4kJODKt3QPImu1eaVDxgU7U2m4gWG8pLPKW+DdNYd8QJi3zO4Yk9XheWDWNxq6UVxO63WWrQSVqhLWcS742e2EthObNnYlsEGZi4Hj5p8etoFzqi61tzGcQEQCLIvp0QULPr2qs6VKeyFrwfQFwYGAbg3fKCBePRw46AmD42YdSvZ+Bmb1ZPu+LG5 BtdVslbp b0ux4LOY52Zika6GOsrt+/Jrpx08B3SmOtPTXevFj6vncOt1sU5V6kUvhFv8/lePwvLMaonH5IOlFTBlNS6joqf/XdR2OnQf4NoRL/razBAhh3hXnja+3nSCsG34WHzNmwNz4K7+tfI9Gsz3E/h79qOPdDzu9QHDtTanvG5RFPiN9st/sO5N36+SSjFIGjtXlexeqN5nQF4sJQGtrKg2t0Za6MCGe3rWVWkGrbuCE/SsDmpPzyXkp7ZBEN5hSwdIMtCcsxNiuiuGucbdkci85ZM4eXUmsoARr/zY5P+jL3hQZw28= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 1/30/2023 10:14 PM, Matthew Wilcox wrote: > On Mon, Jan 30, 2023 at 08:55:04PM +0800, Yin Fengwei wrote: >> +++ b/mm/filemap.c >> @@ -3360,28 +3360,52 @@ static vm_fault_t filemap_map_folio_range(struct vm_fault *vmf, >> struct vm_area_struct *vma = vmf->vma; >> struct file *file = vma->vm_file; >> unsigned int mmap_miss = READ_ONCE(file->f_ra.mmap_miss); >> - int ref_count = 0, count = 0; >> + int ref_count = 0, count = 0, maplen = 0; >> + struct page *pg = page; > > OK, having read it through, I think you're making your life a lot harder > by keeping page pointers at all. I'd pass xas.xa_index - folio->index > from filemap_map_pages() as a parameter called something like 'first'. I use page pointer here because I saw other changes you made kept the page pointer as parameter. And tried to align with that. > >> do { >> - if (PageHWPoison(page)) >> + if (PageHWPoison(page)) { >> + if (maplen) { >> + page_add_file_rmap_range(folio, pg, maplen, >> + vma, false); >> + add_mm_counter(vma->vm_mm, >> + mm_counter_file(pg), maplen); > > Again you've made your life harder ;-) Try something like this: Yes. This is much better. > > void do_set_pte(struct vm_fault *vmf, struct page *page, unsigned long addr) > { > do_set_pte_range(vmf, page, addr, 1); > } > > ... and then here, you can do: > > if (maplen) > do_set_pte_range(vmf, page - maplen - 1, > base_addr, maplen); > base_addr += (maplen + 1) * PAGE_SIZE > maplen = 0; > continue; Thanks a lot for all your comments. I will address all your comments in next version. Regards Yin, Fengwei >