From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95BD1C5475B for ; Tue, 20 Feb 2024 16:28:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D1956B007B; Tue, 20 Feb 2024 11:28:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 182796B007E; Tue, 20 Feb 2024 11:28:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 022676B0080; Tue, 20 Feb 2024 11:28:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E52FE6B007B for ; Tue, 20 Feb 2024 11:28:30 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 552B1160745 for ; Tue, 20 Feb 2024 16:28:30 +0000 (UTC) X-FDA: 81812715180.30.99B3AA7 Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [81.169.146.167]) by imf14.hostedemail.com (Postfix) with ESMTP id B1E7410000A for ; Tue, 20 Feb 2024 16:28:27 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=hartkopp.net header.s=strato-dkim-0002 header.b=dV1G+xSW; dkim=pass header.d=hartkopp.net header.s=strato-dkim-0003 header.b=MTearm4t; arc=pass ("strato.com:s=strato-dkim-0002:i=1"); spf=pass (imf14.hostedemail.com: domain of socketcan@hartkopp.net designates 81.169.146.167 as permitted sender) smtp.mailfrom=socketcan@hartkopp.net; dmarc=pass (policy=reject) header.from=hartkopp.net ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708446508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xc85nduGOgJ1ntImtZqeF0SSc77OQIEvmm0jwvVa6cU=; b=yaY7XpB+WU2+qnc2iidA5mbNfoq44EXS+/7LEnIPfoJLPOJP1FOadQEAp77nG59YmInJV+ UOxAw1Abm6prdTRD9PDpQ6XGFG4evwKDmri9nf/y23Du/YQYtbjbhmWlPhUAwiw/oSsTmp KT19E1Mu8yO1XsIuLlwFM+OpBpdP9q0= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1708446508; a=rsa-sha256; cv=pass; b=7xdJWcDYRA4ILbOhc5rMcnCSXrxD+ZRxKc3TYWxA5u69vi05pwrQLOJmYAS1SReGJQ+BNM hMCvqr/aRekdYDmqYd84sX4gMzhPXowUm0/ea2tIl760nXrCeegMGbl06qm2jKUa0vf7IN 0Qa0Hjj4VoieHmMh7oBqHRIupKZYlRc= ARC-Authentication-Results: i=2; imf14.hostedemail.com; dkim=pass header.d=hartkopp.net header.s=strato-dkim-0002 header.b=dV1G+xSW; dkim=pass header.d=hartkopp.net header.s=strato-dkim-0003 header.b=MTearm4t; arc=pass ("strato.com:s=strato-dkim-0002:i=1"); spf=pass (imf14.hostedemail.com: domain of socketcan@hartkopp.net designates 81.169.146.167 as permitted sender) smtp.mailfrom=socketcan@hartkopp.net; dmarc=pass (policy=reject) header.from=hartkopp.net ARC-Seal: i=1; a=rsa-sha256; t=1708446504; cv=none; d=strato.com; s=strato-dkim-0002; b=EK6NIu1NIJIeE2JwZYUHU2ft9fAIPY77VfvKcp6BvzCA5Nn29nwVYlsVf95tOf6Tep xC66Dn5RifW1zHv9pNN8ZLWUNnDHQxdvr5hq1tKmCzUO7EjsymNQe7IwfDcz340Olsb0 xBbCnJ/ZRyQ2rmx0hfW8M5r/RZ3nMdXWpNKktMJa/VcBEljJhY4SJPJHsy6W/2lw3ep7 39VuGd+Jb3jHxvnNGuCl12HZ6FrrrlH/7pTp5vio6s85A8rr1IwsIP9hQUL2tNXtQUw+ W57Nb5xhXYVc7porhTGaXalAGaI9q5nGK3Ro96ntUEWfULtqm/Ezy3huYGqSIK6DyWLk /BLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1708446504; s=strato-dkim-0002; d=strato.com; h=In-Reply-To:From:References:To:Subject:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=Xc85nduGOgJ1ntImtZqeF0SSc77OQIEvmm0jwvVa6cU=; b=VrzYpAf5RrDvwZhxur2dOzdtCSUJDIixjTR1Z6GzA2FJo/XeKUtcDsaNIMLAxQ1sgn ajx6sWDSpflH9PKwNBF9jmgKN+inDns5d4GgOLt8JPjr+WEuau1AjQhgPy/UpS4fzcMu RgwXif4pJctEzbqVpfcqwe6KNoXFivF2TNNJZ3R7EkE24pE08uAQgcSqJ4pIOziK5hsf uuOcXEt3dTsUDIOai4VpMpbw9DL+sWyJyJGZVMFxJl4iaZ2zHbSzmeJksbTA3aIhyxPk DxQtaDWlDygUR9JNgzlwaxGF0NjA+6vhIQIqTLuVG7NqXiD9qdPJvRB0OI9omUKRVAcf 0Osg== ARC-Authentication-Results: i=1; strato.com; arc=none; dkim=none X-RZG-CLASS-ID: mo01 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1708446504; s=strato-dkim-0002; d=hartkopp.net; h=In-Reply-To:From:References:To:Subject:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=Xc85nduGOgJ1ntImtZqeF0SSc77OQIEvmm0jwvVa6cU=; b=dV1G+xSWBk96Hf/98BZsIyIBYNXyGetyivnkylvuwuuf++a1ygKZ+ewMnrm9vqTeGc ABMFMQWys1VjG77g0oSLfaafWdNl98jJWxpYBM9hKXPRDHyyF62lojTcKs7mIhd3FnY/ YBAcJeCXj5F4NYWjmdqMlS3ZQJB4CnUFttfrxjeMMU+97912hDQCk5yhsZOqOEo8Mi0j JsLnbkzpqS4ZX4T5jtkFWI8WY+yLOjw0+cAZQz6yVnKDVoqoD29Mw9uy7M0GZJA5rvYk s7CFGtQ+lo08qR95tU+6R+K3cwJvXJlheBHC57Xnx+XuBGFhdEr5r6SW1XVatPEzY7ln XQVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1708446504; s=strato-dkim-0003; d=hartkopp.net; h=In-Reply-To:From:References:To:Subject:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=Xc85nduGOgJ1ntImtZqeF0SSc77OQIEvmm0jwvVa6cU=; b=MTearm4tUl+3nkaXgSKDg57scvgRf8l0ObBLozZl6J4zA8xPyteU6WaeKRfd9XhXg1 uUQToEr+qXXy87EC/dBg== X-RZG-AUTH: ":P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrDxb8mjG14FZxedJy6qgO1qCHSa1GLptZHusl129OHEdFq0USEbDdAnQ==" Received: from [IPV6:2a00:6020:4a8e:5000::90c] by smtp.strato.de (RZmta 49.11.2 AUTH) with ESMTPSA id K49f9c01KGSOBGx (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Tue, 20 Feb 2024 17:28:24 +0100 (CET) Message-ID: <9a98f3f1-6a39-4b05-b100-93be1361fd76@hartkopp.net> Date: Tue, 20 Feb 2024 17:28:17 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [mm?] [hardening?] BUG: bad usercopy in raw_getsockopt To: syzbot , akpm@linux-foundation.org, gustavoars@kernel.org, keescook@chromium.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <00000000000038b6700611d207b3@google.com> Content-Language: en-US From: Oliver Hartkopp In-Reply-To: <00000000000038b6700611d207b3@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: yd3qiswnsma7i3xhpmnfbiy78tai1dnb X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B1E7410000A X-Rspam-User: X-HE-Tag: 1708446507-40275 X-HE-Meta: U2FsdGVkX18d1giYVU943l5bSQusoIGdJ+S6y7fAmfobx97HzpmYFzpxPbhE7NnMD+5kOVqsiKVMeKrjVB9C51uO+LILfzAgcgPygDHKXu/XkwbVrFY7EzqhBwfHbINyRnuT36Phh1EKkrdb1nj6ykNU3D6Muo64/XAxFLymMei+Rvcxmsoho5MSvL+vQMBWq2ivuwN7LNlnalMCBOFbzVbPRbGzjr9eIfrWVSNmV4LjWdnL+P+hG6HgXnzEBefyR0NyRRMduc1IdIHZavXYVU3s5khskBjMXJVDQmUOdzNFY5+FXmzpebziXiu+b8qEt30dNISCmA7z1/bxbOkXJ8mfZ/g1/nT/Z7xn6sLIAwP/nr0BR1dYOzIMQId8QpmiNUlhXJGSrnWxJrLvMrxU2G3eqosqW8l9fKLOwvr+xqSB7iXPdLFPnWKjQPmAeh6yYs1SdUwVBpeuu6yhxzPLtlBPN0RGL4qJlOLmOmuwBwQXj72zqvUsdcwNOX5txzcJAX4npGe+9u0pez9TC2LvtgR556ARJI7l/lhNv6keHMcw0ApeqjlLHPBuxnu2dKC+a15AmwqmVzhrxHeWHXOhvzHE39Hy4FhsugogXSmPrYQOHsUBXrLK1OJtBe+QCGjewTndHlGxytKcEb9p4tBYhJDNch4jUE0qr+wbqg7ZFpx25y+nlSH9IdVv9HqcNfQtsAQ+GiiqVi1y2YcUQDed7kUUJ4+l3btYUs83T4yF673JGP1EYGoyU3iz8Dmgyja1ZmWZLT7X2WQXIuiCz+AURDnkB7VEBtLCdKYi/TneAWzFDzYQKtPZ+lRRQoJe0OrOARKeRJHZb7ff65VEk0i+d+0a0aIEc++jbIwOfqUk1EkhZ6BoTob3T34jG8XUtVwLuO6oFpWpqP6y45gX5ChnBgYvRKUGjKhah+ve3FlLzq0apqJK5SfFhTt1jdq/8FmfnYd37pLNcrd2gMbUP6s cxNGuqjS X5olaMeM+diGSlFB2suAGA4I5t7yflZkDSzebhoyD3V58vaOgbJ7r1M7IC5xUUBg9zcUNztIWPKECykrQeWG9v9nt/kmbQR9WuCHUnR+MLn6Gxy3pfBbK5GYQm10P0SDNikJAN5dtuFFX9j9c37h7GyhptcPBD3zV8OM2jXlhfmUkEmd32PDUwrCYrOyAtgvA3zUKlZk2GtvqEwVp5gaONVy4FDQ5ZPQfrVclq5crG/kxJYaKcIXOIghuMNgAIgFv/LeKLdHOCdV3bdYZrABp2tYuVpnokY1b75BsRrIy+OPJYTITinJwf1ryNqNKBDTeCZboWudeqA14GEzcR9am8VwRx24M2dD9rlBHSW36F691VDjc9nQ5SX16iMV++pIGZCnyXqj33AJOi7km/0WMudSAse/ViEHk3GVAi3qhwC0PdGTEZV7EnEX+YTL4HauZiENT X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: The issue has already been fixed with the next commit in net-next: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=c8fba5d6df5e476aa791db4f1f014dad2bb5e904 Sorry for the effort - but really good to see, that the problem has been catched automatically. Good job! Best regards, Oliver On 2024-02-20 16:40, syzbot wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit: 74293ea1c4db net: sysfs: Do not create sysfs for non BQL d.. > git tree: net-next > console+strace: https://syzkaller.appspot.com/x/log.txt?x=13dcc4b4180000 > kernel config: https://syzkaller.appspot.com/x/.config?x=970c7b6c80a096da > dashboard link: https://syzkaller.appspot.com/bug?extid=0c35af046fa98c893c84 > compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=10f38cf8180000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=136d41c2180000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/9bca2f6e074e/disk-74293ea1.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/611a08387d8f/vmlinux-74293ea1.xz > kernel image: https://storage.googleapis.com/syzbot-assets/78c388071345/bzImage-74293ea1.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+0c35af046fa98c893c84@syzkaller.appspotmail.com > > usercopy: Kernel memory exposure attempt detected from null address (offset 0, size 4)! > ------------[ cut here ]------------ > kernel BUG at mm/usercopy.c:102! > invalid opcode: 0000 [#1] PREEMPT SMP KASAN PTI > CPU: 1 PID: 5070 Comm: syz-executor201 Not tainted 6.8.0-rc4-syzkaller-01053-g74293ea1c4db #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/25/2024 > RIP: 0010:usercopy_abort+0x84/0x90 mm/usercopy.c:102 > Code: 49 89 ce 48 c7 c3 40 db b7 8b 48 0f 44 de 48 c7 c7 e0 d9 b7 8b 4c 89 de 48 89 c1 41 52 41 56 53 e8 01 c5 60 09 48 83 c4 18 90 <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 90 90 90 90 90 90 90 90 90 90 > RSP: 0018:ffffc90003a3fc50 EFLAGS: 00010296 > RAX: 0000000000000057 RBX: ffffffff8bb7db20 RCX: b071ef5fcc834300 > RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000 > RBP: ffffffffffffffff R08: ffffffff81753e6c R09: 1ffff92000747f28 > R10: dffffc0000000000 R11: fffff52000747f29 R12: 0000000000000001 > R13: 0000000000000004 R14: 0000000000000000 R15: 0000000000000000 > FS: 0000555555f8e380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000020001480 CR3: 000000001f404000 CR4: 00000000003506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > __check_object_size+0x601/0xa00 > check_object_size include/linux/thread_info.h:215 [inline] > check_copy_size include/linux/thread_info.h:251 [inline] > copy_to_user include/linux/uaccess.h:190 [inline] > raw_getsockopt+0x37a/0x490 net/can/raw.c:852 > do_sock_getsockopt+0x373/0x850 net/socket.c:2373 > __sys_getsockopt+0x270/0x330 net/socket.c:2402 > __do_sys_getsockopt net/socket.c:2412 [inline] > __se_sys_getsockopt net/socket.c:2409 [inline] > __x64_sys_getsockopt+0xb5/0xd0 net/socket.c:2409 > do_syscall_64+0xf9/0x240 > entry_SYSCALL_64_after_hwframe+0x6f/0x77 > RIP: 0033:0x7f21bfe782a9 > Code: 48 83 c4 28 c3 e8 37 17 00 00 0f 1f 80 00 00 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007ffcdfc8f038 EFLAGS: 00000246 ORIG_RAX: 0000000000000037 > RAX: ffffffffffffffda RBX: 00007ffcdfc8f208 RCX: 00007f21bfe782a9 > RDX: 0000000000000008 RSI: 0000000000000065 RDI: 0000000000000003 > RBP: 00007f21bfeeb610 R08: 0000000020001480 R09: 00007ffcdfc8f208 > R10: 0000000020001440 R11: 0000000000000246 R12: 0000000000000001 > R13: 00007ffcdfc8f1f8 R14: 0000000000000001 R15: 0000000000000001 > > Modules linked in: > ---[ end trace 0000000000000000 ]--- > RIP: 0010:usercopy_abort+0x84/0x90 mm/usercopy.c:102 > Code: 49 89 ce 48 c7 c3 40 db b7 8b 48 0f 44 de 48 c7 c7 e0 d9 b7 8b 4c 89 de 48 89 c1 41 52 41 56 53 e8 01 c5 60 09 48 83 c4 18 90 <0f> 0b 66 2e 0f 1f 84 00 00 00 00 00 90 90 90 90 90 90 90 90 90 90 > RSP: 0018:ffffc90003a3fc50 EFLAGS: 00010296 > RAX: 0000000000000057 RBX: ffffffff8bb7db20 RCX: b071ef5fcc834300 > RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000 > RBP: ffffffffffffffff R08: ffffffff81753e6c R09: 1ffff92000747f28 > R10: dffffc0000000000 R11: fffff52000747f29 R12: 0000000000000001 > R13: 0000000000000004 R14: 0000000000000000 R15: 0000000000000000 > FS: 0000555555f8e380(0000) GS:ffff8880b9500000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000000020001480 CR3: 000000001f404000 CR4: 00000000003506f0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. > > If the report is already addressed, let syzbot know by replying with: > #syz fix: exact-commit-title > > If you want syzbot to run the reproducer, reply with: > #syz test: git://repo/address.git branch-or-commit-hash > If you attach or paste a git patch, syzbot will apply it before testing. > > If you want to overwrite report's subsystems, reply with: > #syz set subsystems: new-subsystem > (See the list of subsystem names on the web dashboard) > > If the report is a duplicate of another one, reply with: > #syz dup: exact-subject-of-another-report > > If you want to undo deduplication, reply with: > #syz undup >