From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by an-out-0708.google.com with SMTP id d33so155405and for ; Thu, 02 Aug 2007 16:26:42 -0700 (PDT) Message-ID: <9a8748490708021626s58f0f7cew54932e523800e982@mail.gmail.com> Date: Fri, 3 Aug 2007 01:26:42 +0200 From: "Jesper Juhl" Subject: Re: [PATCH] Fix two potential mem leaks in MPT Fusion (mpt_attach()) In-Reply-To: <20070802161730.1d5bb55b.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200708020155.33690.jesper.juhl@gmail.com> <20070801172653.1fd44e99.akpm@linux-foundation.org> <9a8748490708020120w4bbfe6d1n6f6986aec507316@mail.gmail.com> <200708030053.45297.jesper.juhl@gmail.com> <20070802160406.5c5b5ff6.akpm@linux-foundation.org> <9a8748490708021610k31a86c17y58fb631a36dfdb6a@mail.gmail.com> <20070802161730.1d5bb55b.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org Return-Path: To: Andrew Morton Cc: Linux Kernel Mailing List , James Bottomley , Christoph Lameter , Pekka Enberg , linux-mm@kvack.org, Ingo Molnar , Matt Mackall List-ID: On 03/08/07, Andrew Morton wrote: > On Fri, 3 Aug 2007 01:10:02 +0200 > "Jesper Juhl" wrote: > > > > > So, where do we go from here? > > > > > > Where I said ;) Add a new __GFP_ flag which suppresses the warning, add > > > that flag to known-to-be-OK callsites, such as mempool_alloc(). > > > > > Ok, I'll try to play around with this some more, try to filter out > > false positives and see what I'm left with (if anything - I'm pretty > > limited hardware-wise, so I can only test a small subset of drivers, > > archs etc) - I'll keep you informed, but expect a few days to pass > > before I have any news... > > Make it a once-off thing for now, so the warning will disable itself after > it has triggered once. That will prevent the debug feature from making > anyone's kernel unusable. > Ok, I'll do that :-) Just be a little patient. I'm doing this in my spare time and I do have a real job/life to attend to, so I'll be playing with this in the little free time I have over the next couple of days. I'll get something done, but don't expect it until a few days have passed :-) -- Jesper Juhl Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org